From patchwork Sat Sep 24 13:11:33 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carl Eugen Hoyos X-Patchwork-Id: 700 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.140.66 with SMTP id o63csp1068169vsd; Sat, 24 Sep 2016 06:18:33 -0700 (PDT) X-Received: by 10.194.236.42 with SMTP id ur10mr10996018wjc.211.1474723113060; Sat, 24 Sep 2016 06:18:33 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id s1si11635281wjm.218.2016.09.24.06.18.31; Sat, 24 Sep 2016 06:18:33 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 85B44689D85; Sat, 24 Sep 2016 16:18:13 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-vk0-f41.google.com (mail-vk0-f41.google.com [209.85.213.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 95D2D689A68 for ; Sat, 24 Sep 2016 16:18:06 +0300 (EEST) Received: by mail-vk0-f41.google.com with SMTP id v205so11125490vke.1 for ; Sat, 24 Sep 2016 06:18:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=ym9Y0LhXrDBaf52aX1DBmoa83xEoAH8cAcB6z6RhPj4=; b=Ac8Rd6NxFGyFa/+JIx3VeitOBt7+xVaVnOzDuEOpevTLgAXY+GiM8skDVJ4AdkiyJo /86UTYBqekKPyvMyQc0jjOYSRdI06IzbBJ+vXJYX52ERH/AoZqbmmO86TSdaz53EhGsS Xnxy8rX3jNIYVMKLxysK3g52YTIYo1XDbexbHARQFjG9PrVZsjGVWhofwEc+T+JztrXR NwdrzENFduVaOYpNLMnRj9wttrHP1YhNfTxQzgFIfk845r+y1iZjtrqaMc/1bCkGr8/4 qQRq9QgWYUaSbysUjobXYf6kPsQrRs2lxCkYVTiQnmXWQQV625SmLFI5m2YFd6b6lGTT HnxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=ym9Y0LhXrDBaf52aX1DBmoa83xEoAH8cAcB6z6RhPj4=; b=aLyTdgEQpH8L5PqS2NDvzBcU8ybWLyguyI6/JiYDfdTTgtzKLPOxsPZG8oFE5mJC+s 9/2KFMuuWhBXaRR/HwRhaSOiT7Zf40DLKV5fuuXguwKpy6Do77K4DNjSfaqymnQCGJeY fHMKHlDDu+BIHGaVl2PEP7Qqo8dCT7iCq1SaYHhjBbPpgepojNZE4g8gJaaS7beV3VHP g0WSLtVblhkTPOxugNaP7ecnMxOP18bUUv+rfTdd59iGRfTZrLlWIQboJrEitLJsP6qS 04VDs/dgWZjPrbEz7T+kKSWWGJFzTjCRxLGqv0a0z3SKHAe8CHNS4kPDfXBcPQ90vmuu o2rw== X-Gm-Message-State: AA6/9RlAVqEmUy93fq0G7n2QHUktzS9jb6Vl/CYGjcubFIZAoYcAY8GbPcS+GX9ArPYlmThQ9p3h94wcgw0d1w== X-Received: by 10.31.207.133 with SMTP id f127mr2140762vkg.114.1474722693761; Sat, 24 Sep 2016 06:11:33 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.2.11 with HTTP; Sat, 24 Sep 2016 06:11:33 -0700 (PDT) In-Reply-To: References: <201609240000.35942.cehoyos@ag.or.at> From: Carl Eugen Hoyos Date: Sat, 24 Sep 2016 15:11:33 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH/RFC]lavf/aacdec: Do not auto-detect a single frame X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Hi! 2016-09-24 14:58 GMT+02:00 Ronald S. Bultje : > > On Fri, Sep 23, 2016 at 6:00 PM, Carl Eugen Hoyos wrote: >> >> I use this patch locally for some time. It fixes >> many misdetections, a similar patch was applied to >> loas detection three years ago. >> An alternative would be to return "1" for two frames. > > > Is there any point in detecting two AAC frames? I mean, we're > talking about a split second audio... True, but I believe if it is the beginning of the file, a positive score should be returned, so new patch attached. Thank you, Carl Eugen From ab91c039600b4518dc34a61d42176b1d68b814a1 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sat, 24 Sep 2016 15:09:27 +0200 Subject: [PATCH] lavf/aacdec: Do not autodetect a single frame inside the file. --- libavformat/aacdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/aacdec.c b/libavformat/aacdec.c index aa23756..fecb1e3 100644 --- a/libavformat/aacdec.c +++ b/libavformat/aacdec.c @@ -70,7 +70,7 @@ static int adts_aac_probe(AVProbeData *p) return AVPROBE_SCORE_EXTENSION; else if (max_frames >= 3) return AVPROBE_SCORE_EXTENSION / 2; - else if (max_frames >= 1) + else if (first_frames >= 1) return 1; else return 0; -- 1.7.10.4