From patchwork Wed Sep 25 12:11:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carl Eugen Hoyos X-Patchwork-Id: 15285 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id E2A99448181 for ; Wed, 25 Sep 2019 15:11:44 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C64D5689CC8; Wed, 25 Sep 2019 15:11:44 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 03263680988 for ; Wed, 25 Sep 2019 15:11:37 +0300 (EEST) Received: by mail-io1-f54.google.com with SMTP id c6so13090298ioo.13 for ; Wed, 25 Sep 2019 05:11:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=LdY4IuStm7OJq8es8L78IVmxU3hRuXqHKRKiAh4my6E=; b=SLZ3wHhT5lMFRl09znnfBlHOgMdv9gqQL4+SzNC6sSVQ07v7+M2RCA4H8ZSQ5DI2Fc hhUihjVeCCrLjanrklBWbJIIT6BmQj8B0ZxXw/YUQsJRWhRuNIK88QJaH0Yh9TiLLOu4 UAquz/2nKJVHN6j7iOIfOE5uGbLv3lXn4NtcJ8g108p2RRRJuzpxq/WjTi9phfQbMMUc D4ad2rFoqv2KoXCi8QbclEWlaxn78kZ4tzj7b1XtZBLY5YNTLtZYm1tJ8ReFNB+Um3lr ugWp72PwsIQq5Ey23cDfpQqp/w8zl+cnqI/mA+xL5dKkBRdKhyppARhRY59TG02+L8Hm rAPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=LdY4IuStm7OJq8es8L78IVmxU3hRuXqHKRKiAh4my6E=; b=IslwLaE1SEbi951IIcIsRqg6ivL6Y0GljJSGDDJvXzzPHUAMFOPa3nHjaQdCMfSRUn eT2qfN811c7yF8efyt22dvCu8KC2PxJkrP8UyPp0n/oe0LEU3alExFR35gSO3lH9/3ny GCoAcEl3d2fhSnpkhNOXzeLhg080YZnqCDyQAUFtZ84LolvlwcS9i7Or2gKymJyfPnEm tjn5wOBtxRgvqMjX9G9OIEYf2BFwpXQj0VXR+44evA1ODqoiPx29F4Q1k1mRy+Dvg6Y9 bxQUsnCpwRHKTJ1HQ5Sth45l4JIi5G1EftBlXIz8dO/2bzte4+9fHbjJzZI1CfwmhL5O Vrsw== X-Gm-Message-State: APjAAAVYb0jDrh0uImiXkoe21zntc0Ld2ZCeJKd8up8VsVYP07jLHDvq IQ0NNz3jOh/LNf8U5w+MfmwbVV+KssS0B+yN2oZ/yA== X-Google-Smtp-Source: APXvYqwlsAbZ5IMIT4RSVZQD7ScEaPfQwFZJFEMz2E8E5wAQvtRuT1/n6G5PWknczR9bfiGXrCg9wg8RqTHwMHcGjkU= X-Received: by 2002:a6b:2c02:: with SMTP id s2mr9585694ios.54.1569413496372; Wed, 25 Sep 2019 05:11:36 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Carl Eugen Hoyos Date: Wed, 25 Sep 2019 14:11:25 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH]lavf/avio: Print https warning also for avio_find_protocol_name() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Am Mi., 25. Sept. 2019 um 11:35 Uhr schrieb Carl Eugen Hoyos : > > Hi! > > Attached patch helps users fixing ticket #8197. > > Please comment, Carl Eugen From 92a62e4f56f4820d79529060636e0382b33b376b Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Wed, 25 Sep 2019 11:32:57 +0200 Subject: [PATCH] lavf/avio: Print https warning also for avio_find_protocol_name(). Helps to fix ticket #8197. --- libavformat/avio.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavformat/avio.c b/libavformat/avio.c index 663789ec02..c1bad312cd 100644 --- a/libavformat/avio.c +++ b/libavformat/avio.c @@ -283,6 +283,9 @@ static const struct URLProtocol *url_find_protocol(const char *filename) } } av_freep(&protocols); + if (av_strstart(filename, "https:", NULL) || av_strstart(filename, "tls:", NULL)) + av_log(NULL, AV_LOG_WARNING, "https protocol not found, recompile FFmpeg with " + "openssl, gnutls or securetransport enabled.\n"); return NULL; } @@ -297,10 +300,6 @@ int ffurl_alloc(URLContext **puc, const char *filename, int flags, return url_alloc_for_protocol(puc, p, filename, flags, int_cb); *puc = NULL; - if (av_strstart(filename, "https:", NULL) || av_strstart(filename, "tls:", NULL)) - av_log(NULL, AV_LOG_WARNING, "https protocol not found, recompile FFmpeg with " - "openssl, gnutls " - "or securetransport enabled.\n"); return AVERROR_PROTOCOL_NOT_FOUND; } -- 2.23.0