From patchwork Mon Mar 30 22:19:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carl Eugen Hoyos X-Patchwork-Id: 18524 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 2447F44B00E for ; Tue, 31 Mar 2020 01:19:58 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0275E68B0C7; Tue, 31 Mar 2020 01:19:58 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 29D1068AF03 for ; Tue, 31 Mar 2020 01:19:51 +0300 (EEST) Received: by mail-io1-f47.google.com with SMTP id x9so13169754iom.10 for ; Mon, 30 Mar 2020 15:19:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=T13bv1A2HT+Telg2GnzrnkOD9MYXkKoi2MiUk/6lzvw=; b=PtHkKHBU+Aa1DFWRn5gSj8VCqL/spUWG9/C4kx5EV08F4NHiHxtSC6slvFuZQmGyg8 GLltFgxt7hJ+jQKE5rd6oltaUTpHJVNg7x4v4BPPoGPSpTFwyK3KkfhJ5ucnTzNZBxJr E0WsfZszI+K8UCq4dB9V8HM/YYfTkKw8WHLRftZJWrhAoRYBfDocD4rrR68HJQiuC903 UP/SJPejd9Bpu+BowkwD+sTUOCSWK0w6ochT7s2xN8AEM5wtrjZ9z0f+nYfSIjKEewo9 mZvhVgnbKSOy0E8e6+TUkugTsXDXZF2Z5aqEicfBmR8LxKK4GTrsKuvCiwjBRawO/Lya uudg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=T13bv1A2HT+Telg2GnzrnkOD9MYXkKoi2MiUk/6lzvw=; b=N2iwY4zz+7GdqycN50SB+baw/fMiD6mdKh0ixDO+kA4eTdf9AL3eSAcJQ3Av4uo767 ehYlxTJ6X4tGMvh7V/83Z+zv35H3eNdmph9tihpKetzLXen13ALQz+fePtbD0a3cUghH py3G+ifhXBiiPhE3eLm2pWpjh8VzdM/hdkebG1ZMsSiXplRbRr8gS4mzB8m7xowWsqMO OuqHgNlIvmNqMuoThBAhQSeH3HV67FRIsITPJz53+d0Dqbsdx3bR68+MCt/j0MPapzZp d/xTME/ZypwcSRJ5vtQncr1AcZSRyprPR8Zx5qk2PlQGi+q74ZqBXgB6r8QpWC1B6glu yf9Q== X-Gm-Message-State: ANhLgQ2AbTE8xVHXZLiZx0wKhjE90r/yzGQxMjBKcM5iz9qeJWG9W6jZ KZVTyenkkRqOctySg5dvGL+xJgLb4yqKwS7r9orcFw== X-Google-Smtp-Source: ADFU+vsrl1jGACwsd9Hf20UV9MXVefgfdO7Z510tqEP929l0+CcQX/U/2BdWQWi6YEvtQ3jtlXzuZ087zuZfG24oPi0= X-Received: by 2002:a05:6602:210f:: with SMTP id x15mr13081268iox.34.1585606789377; Mon, 30 Mar 2020 15:19:49 -0700 (PDT) MIME-Version: 1.0 From: Carl Eugen Hoyos Date: Tue, 31 Mar 2020 00:19:38 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH]lavf/movenc: Do not write empty av1C boxes X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Hi! Attached patch avoids writing an mp4 file that cannot be read by FFmpeg (only be vlc) in some use cases. Please comment, Carl Eugen From 42b5e30f3bf13620a41ed92181f7b0358873e764 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Tue, 31 Mar 2020 00:17:44 +0200 Subject: [PATCH] lavf/movenc: Do not write an empty av1C box. --- libavformat/movenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 1c178fc4bc..8cdd406335 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -2098,7 +2098,7 @@ static int mov_write_video_tag(AVFormatContext *s, AVIOContext *pb, MOVMuxContex mov_write_uuid_tag_ipod(pb); } else if (track->par->codec_id == AV_CODEC_ID_VP9) { mov_write_vpcc_tag(mov->fc, pb, track); - } else if (track->par->codec_id == AV_CODEC_ID_AV1) { + } else if (track->par->codec_id == AV_CODEC_ID_AV1 && track->vos_len > 0) { mov_write_av1c_tag(pb, track); } else if (track->par->codec_id == AV_CODEC_ID_VC1 && track->vos_len > 0) mov_write_dvc1_tag(pb, track); -- 2.24.1