From patchwork Wed Sep 20 11:55:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vittorio Giovara X-Patchwork-Id: 5206 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.36.26 with SMTP id f26csp657910jaa; Wed, 20 Sep 2017 05:04:14 -0700 (PDT) X-Received: by 10.223.166.99 with SMTP id k90mr3944559wrc.183.1505909054539; Wed, 20 Sep 2017 05:04:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1505909054; cv=none; d=google.com; s=arc-20160816; b=AWuhLYyprz/3sqHLW3P9w4AYDsGuGiKWuX7s/I7nSSksPGty1C0mzb7/UNOrdiz9ZA I7bw0/y5+94LSFATD87DTAKfzn7KIcmztarl5jSSfcyP9Y59QxNxkSlmfPYed23/+ash VxVSN+Wd+WLWralCxmkQZZQ43/BncmMGwGwr5WrNRuW9yPhzMLX6iTiMtFtHSy7rqd19 UvYaEL2YkKXIwSQNAUtbODikh2QpSWh54Igx23YaK+Z77qLGOg2Bns9G5OCVeVdNh+fF xhSZc86Qv3zKOm5xvf6fuBmew7QgAN4OniQ4BpDhn3T898hHslPvBdTqp6eUhQTLhMeA fgdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:to:message-id:date:from:mime-version :dkim-signature:delivered-to:arc-authentication-results; bh=sUt0oomYZkrdm5o3QLvEUDMNZ9zDw0howR8N5JF6xyQ=; b=zGP70Dv7i3nLfaNEoxUWwD14NzpEbD5HOzzuXqhHNvoR/OeyvkkoTS4cJfn80AuEwU 98kPp0yXndKxhhM/lmPnjG1zARfIjq+NebX6Dg8AI5t3+mHBzmfbDFEpT2VOWXX/oVWE oTilSD6MvczS63RCE/h1PTRYPvl94lDsg1+T+bRCdTdrJIsHwtmGyTyfCubA+Z0YZLnv 2G7lZPeeikbVH+o56UImFpsri2yjebqSQyvCujX4G/9WpRaNh0jT9ffYszSa97DM9o+C 0GY1lGEpLyGMjWCSdC6/WJgFocHRvkVJgPsqVR+++yO4+PIF7W5LwQ70+or76ONkJwir kR0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=IKoEc6/k; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id x78si1336537wmd.24.2017.09.20.05.04.13; Wed, 20 Sep 2017 05:04:14 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=IKoEc6/k; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 010B76883AE; Wed, 20 Sep 2017 15:04:04 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-io0-f193.google.com (mail-io0-f193.google.com [209.85.223.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7FBBE68835F for ; Wed, 20 Sep 2017 15:03:57 +0300 (EEST) Received: by mail-io0-f193.google.com with SMTP id d16so1882430ioj.2 for ; Wed, 20 Sep 2017 05:04:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=aZuT1gVfdNCSMGBMXSJOiEDe1XYFDzpLCTL6KwTqlY4=; b=IKoEc6/kW1bqxk9CXt4D5iLSdEto5Q6ALh9bLFsiDR0KhHELMs9QPXVZLQPVQpAAjk zGnrG9ze5OkVc0Yr5nWCvE64B3mjDL/Oj8qrTWl6O+zoq3pfQmYZXWnaq/XD7dlLASjY EHnjxHlRxfQb3Mgv6izVsF1Njqigfk+XPR90nJblwxNWik+8EOVOB0x0qAa9rXgDYruQ b6bs+mO1n0aJeJxOQdEPheMJG8G55uS8WwbFa+Ofhkh8hPN6j0GFjUjr6s911MuO0Vp+ lfrj+rqGoZLaefIFfrQnzYM3fV4JemNj6bJUL86LM4Qi4aS/L2GpJfp9zo/YBZtiB4o3 nGMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=aZuT1gVfdNCSMGBMXSJOiEDe1XYFDzpLCTL6KwTqlY4=; b=CKMDMTKSQAhhDRf7Quq6gYxw7k/eZTPGdlgh7Vevm2ZUSREQHDiY1s71pr/heJesT2 ds98GpLL2l+7xczYLYmqRR7SnfVKG30GTQBIKtlda416BUaXXChjcunIxy7Qg034xctg ViRYqGSwrf+U6WCV7u3cjxJJATQaYwNBmUmZfBMhxrOaJzeoj6K/mO202xIyZWNTss09 X2ETy8gg6Q4gPhLec88JWwVKoDhGmcqgEXgHFkfrwepLwikdeYk6GQVWv3zNzP49re8X jjSteN8WlqLztHpheamUW0q+3l19HXs7dcdpw/JSIykRVKiYOPRbBEJnxxUdqI5i6CPK +JIg== X-Gm-Message-State: AHPjjUgCMTrNXSyKwoyDgWHbNFwFeOPeczvzOsPxCJ14n+UQ6+l5Rlxv uCq/TG6D8U45SSKGHCo5EVvHmTB99NaN+IZGJpUU9w== X-Google-Smtp-Source: AOwi7QD6X8VYpRAVdYEgIaGEjU1/DNv5Ar4T5Zy7PIQaBvHChXLP4f01smVWpWcXUPIYR74MTVlQUftyGOiWPDrbvJo= X-Received: by 10.107.23.135 with SMTP id 129mr6361127iox.279.1505908545633; Wed, 20 Sep 2017 04:55:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.157.66 with HTTP; Wed, 20 Sep 2017 04:55:45 -0700 (PDT) From: Vittorio Giovara Date: Wed, 20 Sep 2017 13:55:45 +0200 Message-ID: To: ffmpeg-devel@ffmpeg.org X-Content-Filtered-By: Mailman/MimeDel 2.1.20 Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavu: add a gamma field to AVMasteringDisplayMetadata X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" In my opinion we should not add new fields to structures that map 1:1 to something defined elsewhere (with the exception of booleans). I think this should be a separate side data and type, ie AVGammaResponse, that can of course reside in the same header. diff --git a/libavutil/mastering_display_metadata.h b/libavutil/mastering_display_metadata.h index 847b0b62c6..3de58bf468 100644 --- a/libavutil/mastering_display_metadata.h +++ b/libavutil/mastering_display_metadata.h @@ -66,6 +66,16 @@ typedef struct AVMasteringDisplayMetadata { */ int has_luminance; + /** + * The power-law response exponent needed to compensate for nonlinearity. + */ + AVRational gamma; + + /** + * Flag indicating whether the gamma has been set. + */ + int has_gamma; + } AVMasteringDisplayMetadata;