From patchwork Wed Feb 21 00:25:14 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Flehner Heen X-Patchwork-Id: 7685 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.150.33 with SMTP id c30csp179043jai; Tue, 20 Feb 2018 16:31:35 -0800 (PST) X-Google-Smtp-Source: AH8x227SnlPNNtLMPV1KeGsW8dbSN89v1Rd9LHiZY0kBAiuQyEsNnYgGu8N/DjbUv01Sv88cjOni X-Received: by 10.223.186.83 with SMTP id t19mr1195057wrg.252.1519173095013; Tue, 20 Feb 2018 16:31:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519173094; cv=none; d=google.com; s=arc-20160816; b=tRCfc21UA40rmoRNpvfqYsI/nCte838ng4S787wAGC0UI96VIAqaISJZnkiGrGMlns YMyi0dW4Ez/znlouodT8glJqHETvlh+YgWf/nvJX+3TKTMFiIeVXAAku2YMo1xUg4gqV pNSAaHV6VbvZRVJGngglm1eQeoVKD2q2AjNGnzCv8feoRW3HpLXoQe0wMjFhFv6t3CUo 54LJNZZXhGEWA21mGki6MCVBGOBMNFqq0ylQn7rwsOmj6mFf+QTAwM0trpiSVCnCO4l+ DoL8yOhj2yqnkIzoZFFLjXjjEK9fFMOj26EBx1spo0OVwQxNUr3bmcuWEBFMPb8OuROJ M1zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:to :message-id:date:from:mime-version:dkim-signature:delivered-to :arc-authentication-results; bh=7n7CMl6ZOGaDye7pMzlRl3tCo1STpeGa3aw33vANY24=; b=hKKGb7kAGs3WPdgggZwV+r7UhkkqFtP4pY3Ls+rrXTSBy3tJ5DO0uZrnlx+ZqksqgV L8t/i3DSiJANvBEXVoYhd7ch0zQ0JIhqXmSmAkuEMi9SKPeq+s2EcqrHQ0VVJvjVmaeB A36XH2FHaVI9IwJFGX6KPm2zNt3H0sfxEaN2f9IHmhHuAQi+cXSMGuvvFaOdlSctniCF j3ROAi1OiHY5qNd6dCa3Pxz66Q5BFZH9HQEOwjNu+OGAo5O9j6HJE6Mk7iTWNZ/evOaN 5cJtGqfKC1ymLKrGfxWE/6XRKeYQeXMO4VIM6HKj8ecwozIfaG2wvMLLxCC+0yn5tQjR ouGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=TBWy9gHl; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id y71si8517142wrb.47.2018.02.20.16.31.34; Tue, 20 Feb 2018 16:31:34 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=TBWy9gHl; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E14E668A342; Wed, 21 Feb 2018 02:31:31 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wr0-f176.google.com (mail-wr0-f176.google.com [209.85.128.176]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CE90868A2D0 for ; Wed, 21 Feb 2018 02:31:25 +0200 (EET) Received: by mail-wr0-f176.google.com with SMTP id u15so19376270wrg.3 for ; Tue, 20 Feb 2018 16:31:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=KM/TMUuQNqIoDFy+D60IEY6IR3X9SM1wP7uHzn4AJNE=; b=TBWy9gHlsVXFXFMQTws1W07jt9vIUCoglNZGvlE3LbVhzXnEcxbZzXnDFCF2agYjV1 BFR9PLs+xaIF1grdgBEMUHFuK6ycuEpRm5ncHJeHlnBo0aEIpG7au37do9qaf/Cna3F5 YWKd5g3VMMosaQcDxgXmEFv5Vimg9bNRNpOnm8vQr7MIbz2nUmefpddle1txnR5XPV+Y DybqGUlCaPkh6l0SoPfZ2geFVozw2Y5JK7XAhDvWnbyX0KgTZwN31Fqoz2NF0jigY97J ppIYnALF0qMM6lOyGIEwztHKSvpEluLVVaPa0wUYhRF962tF7Ugi/JB7/VPVhG3h329X qsiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=KM/TMUuQNqIoDFy+D60IEY6IR3X9SM1wP7uHzn4AJNE=; b=kJT6mA8QdkMVO54eboaVnAYa8prf9fFn0DCWqwXr3V6t/ICFbFSLM3JGz+DFFXIo19 pKqdAHZOf9P3uvAN3iwnaX+srOOT1+CgjPLpy+8IYe2NEeDKjQ4qqjakDMAzSRr8BdtI g/GiC+RiSjxWfq89SNFigL24nLIxKhtar1alfEOZODC2y4l+oxzFpoH+ikraRmVd31Ft Y3tEaTwHVlzbelkas0vwu4NfbfzjXD+aV9xgKgucXlGp52JuXwOtf1RzX9bRFfQ5qi8g 0gqlFXNyP2Y8fomhCCb4vg/VSUdXW1SIMYLlwuL7zbBPpRAciRgYAFjpIyRw7XHKlgDG 6yfg== X-Gm-Message-State: APf1xPCPjrgAIK6EDxuxVyXs2AWMJMUMUSTm7vTQe9zvaDsrPOqkqSTT JWF1JfgEEE08WQ/o0qI9nnywiQ0HU8cRNHqEQ0GbyA== X-Received: by 10.80.189.139 with SMTP id y11mr2519408edh.122.1519172734907; Tue, 20 Feb 2018 16:25:34 -0800 (PST) MIME-Version: 1.0 Received: by 10.80.174.67 with HTTP; Tue, 20 Feb 2018 16:25:14 -0800 (PST) From: Daniel Flehner Heen Date: Wed, 21 Feb 2018 01:25:14 +0100 Message-ID: To: ffmpeg-devel@ffmpeg.org X-Content-Filtered-By: Mailman/MimeDel 2.1.20 Subject: [FFmpeg-devel] [PATCH] Added support for version field flag 0x04 in OpenEXR files X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Hi! First time poster so please excuse any mistakes made. I've tried submitting a patch through git send-email but got issues authentication through gmail. Attached is a patch file created with git format-patch. Commit message: Added support for version field flag 0x04 in OpenEXR files regarding long names in attributes. Should have no impact on decoding of images. Also added a bit more verbose logging of OpenEXR 2.x flags not yet supported. From 0a8c7b74ef6ad39c7ce4a2eaa8327dd4a1f9d851 Mon Sep 17 00:00:00 2001 From: Daniel Flehner Heen Date: Tue, 20 Feb 2018 23:36:29 +0100 Subject: [PATCH] Added support for version field flag 0x04 in OpenEXR files Added support for version field flag 0x04 in OpenEXR files regarding long names in attributes. Should have no impact on decoding of images. Also added a bit more verbose logging of OpenEXR 2.x flags not yet supported. --- libavcodec/exr.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/libavcodec/exr.c b/libavcodec/exr.c index 47f59bd..238ee4a 100644 --- a/libavcodec/exr.c +++ b/libavcodec/exr.c @@ -1354,7 +1354,15 @@ static int decode_header(EXRContext *s, AVFrame *frame) s->is_tile = 0; else if (flags & 0x02) s->is_tile = 1; - else{ + else if (flags & 0x04) + av_log(s->avctx, AV_LOG_DEBUG, "Long attribute names flag detected %d.\n", flags); + else if (flags & 0x08) { + avpriv_report_missing_feature(s->avctx, "OpenEXR 2.x deep format flag %d", flags); + return AVERROR_PATCHWELCOME; + } else if (flags & 0x10) { + avpriv_report_missing_feature(s->avctx, "OpenEXR 2.x multipart flag %d", flags); + return AVERROR_PATCHWELCOME; + } else { avpriv_report_missing_feature(s->avctx, "flags %d", flags); return AVERROR_PATCHWELCOME; } -- 2.7.4