| Message ID | CADxeRwmEovoK9BvGqLndn9u4XvRBgAfURgk56PdFxdi+nEMObA@mail.gmail.com |
|---|---|
| State | Accepted |
| Commit | 2b9f92fcc5486361b63c4fab5a24c222dc8969ef |
| Headers | show |
2017.02.12. 2:36 keltezéssel, Steven Liu írta: > 2017-02-12 5:31 GMT+08:00 Bodecs Bela <bodecsb@vivanet.hu>: > >> Dear All, >> >> hls-encoder currently does not provide stream level metadata to mpegts >> muxer. This patch also fixes track #3848 bug. >> >> Please review this bug fix. Thank you in advance. >> >> >> best regards, >> >> Bela Bodecs >> >> >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> > > hls-encoder currenlty does not provide stream level metadata to mpegts > muxer. This patch fixes track #3848 bug. > > Signed-off-by: Bela Bodecs <bodecsb@vivanet.hu> > --- > libavformat/hlsenc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index bd1e684..a58ded9 100644 > --- a/libavformat/hlsenc.c > +++ b/libavformat/hlsenc.c > @@ -446,6 +446,7 @@ static int hls_mux_init(AVFormatContext *s) > avcodec_parameters_copy(st->codecpar, s->streams[i]->codecpar); > st->sample_aspect_ratio = s->streams[i]->sample_aspect_ratio; > st->time_base = s->streams[i]->time_base; > + av_dict_copy(&st->metadata, s->streams[i]->metadata, 0); > } > hls->start_pos = 0; > hls->new_start = 1; Should I change the status of the track ticket or is there somebody who is the maintainer of trac? bb
2017-02-12 17:17 GMT+08:00 Bodecs Bela <bodecsb@vivanet.hu>: > > > 2017.02.12. 2:36 keltezéssel, Steven Liu írta: > >> 2017-02-12 5:31 GMT+08:00 Bodecs Bela <bodecsb@vivanet.hu>: >> >> Dear All, >>> >>> hls-encoder currently does not provide stream level metadata to mpegts >>> muxer. This patch also fixes track #3848 bug. >>> >>> Please review this bug fix. Thank you in advance. >>> >>> >>> best regards, >>> >>> Bela Bodecs >>> >>> >>> _______________________________________________ >>> ffmpeg-devel mailing list >>> ffmpeg-devel@ffmpeg.org >>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel >>> >>> >>> >> hls-encoder currenlty does not provide stream level metadata to mpegts >> muxer. This patch fixes track #3848 bug. >> >> Signed-off-by: Bela Bodecs <bodecsb@vivanet.hu> >> --- >> libavformat/hlsenc.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c >> index bd1e684..a58ded9 100644 >> --- a/libavformat/hlsenc.c >> +++ b/libavformat/hlsenc.c >> @@ -446,6 +446,7 @@ static int hls_mux_init(AVFormatContext *s) >> avcodec_parameters_copy(st->codecpar, s->streams[i]->codecpar); >> st->sample_aspect_ratio = s->streams[i]->sample_aspect_ratio; >> st->time_base = s->streams[i]->time_base; >> + av_dict_copy(&st->metadata, s->streams[i]->metadata, 0); >> } >> hls->start_pos = 0; >> hls->new_start = 1; >> > > Should I change the status of the track ticket or is there somebody who is > the maintainer of trac? I saw the ticket has been passed three years, you can close it with check Hi Carl, Can the tickets close with check? > > > bb > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel >
2017-02-12 10:24 GMT+01:00 Steven Liu <lingjiujianke@gmail.com>: > 2017-02-12 17:17 GMT+08:00 Bodecs Bela <bodecsb@vivanet.hu>: >> Should I change the status of the track ticket or is there >> somebody who is the maintainer of trac? We do not track patch status there (if this was your question), closing the ticket should happen once the patch gets committed. > I saw the ticket has been passed three years, you can close it with check > > Hi Carl, > Can the tickets close with check? As soon as you push the change. Carl Eugen
2017-02-12 9:36 GMT+08:00 Steven Liu <lingjiujianke@gmail.com>: > > > 2017-02-12 5:31 GMT+08:00 Bodecs Bela <bodecsb@vivanet.hu>: > >> Dear All, >> >> hls-encoder currently does not provide stream level metadata to mpegts >> muxer. This patch also fixes track #3848 bug. >> >> Please review this bug fix. Thank you in advance. >> >> >> best regards, >> >> Bela Bodecs >> >> >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> > > > hls-encoder currenlty does not provide stream level metadata to mpegts > muxer. This patch fixes track #3848 bug. > > Signed-off-by: Bela Bodecs <bodecsb@vivanet.hu> > --- > libavformat/hlsenc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index bd1e684..a58ded9 100644 > --- a/libavformat/hlsenc.c > +++ b/libavformat/hlsenc.c > @@ -446,6 +446,7 @@ static int hls_mux_init(AVFormatContext *s) > avcodec_parameters_copy(st->codecpar, s->streams[i]->codecpar); > st->sample_aspect_ratio = s->streams[i]->sample_aspect_ratio; > st->time_base = s->streams[i]->time_base; > + av_dict_copy(&st->metadata, s->streams[i]->metadata, 0); > } > hls->start_pos = 0; > hls->new_start = 1; > -- > 2.5.3.windows.1 > > > > > LGTM > > > > > > Thanks > applied! Thanks
diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index bd1e684..a58ded9 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -446,6 +446,7 @@ static int hls_mux_init(AVFormatContext *s) avcodec_parameters_copy(st->codecpar, s->streams[i]->codecpar); st->sample_aspect_ratio = s->streams[i]->sample_aspect_ratio; st->time_base = s->streams[i]->time_base; + av_dict_copy(&st->metadata, s->streams[i]->metadata, 0); } hls->start_pos = 0; hls->new_start = 1;