From patchwork Thu Dec 31 02:19:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Musketa X-Patchwork-Id: 24726 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id AA52F449970 for ; Thu, 31 Dec 2020 04:45:00 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 840E268A55B; Thu, 31 Dec 2020 04:45:00 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2C84468A323 for ; Thu, 31 Dec 2020 04:44:54 +0200 (EET) Received: by mail-wr1-f42.google.com with SMTP id 91so19031866wrj.7 for ; Wed, 30 Dec 2020 18:44:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=3SikllZiQVZ9ts178fDdcCx2FBs54YLvngcUN7YHUIs=; b=KbzsK5R901xDZq0HztM4mWW08zncSc42reCZ9ORb6KLZesvP0IFH1fpN6eTXGlqDvz 0HZjUNQAAq2imjmmxk2yvzsFxtpLGRJFI1TPB5u4jVsKsVJP1P/Ff3uZLzdgIURI94+0 J5BAp646tZEaiW+6R+3asI7i5z9VW9enkAkKry2j1KsDG6SPNi2/4o6MO7T4GVbTxF7q pS2aJJDHFoJ8hDCs4GTmbzi+8H7TqUWMhrIwjjOrkWudNKArr962AdzTO8sYMamKGxdV /PgeryZ6QZlZoHC+xgdwgEpAhf2wvGDLyPBFMwyy2mpRmII2pUpix1wbGQmKk/7VZK41 f0NA== X-Gm-Message-State: AOAM531Fz+c2JmwxcD+zVY5Sq+LXEzqYvRyRFNZ6jakhOouRkQvPMPL+ WSWq4fMNU/XyB9f28V+f44LiUSybaMtEGg== X-Google-Smtp-Source: ABdhPJzrrWY8eQqaZSVHHzUAu/3pIG2jZf2Sy1TXwR+fWlyvRN08ZVPPUQwvuYJP0ZLU8GCSvXvGjA== X-Received: by 2002:a17:906:b0d2:: with SMTP id bk18mr49818730ejb.508.1609381211860; Wed, 30 Dec 2020 18:20:11 -0800 (PST) Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com. [209.85.218.54]) by smtp.gmail.com with ESMTPSA id a2sm12525476ejt.46.2020.12.30.18.20.11 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Dec 2020 18:20:11 -0800 (PST) Received: by mail-ej1-f54.google.com with SMTP id jx16so23938802ejb.10 for ; Wed, 30 Dec 2020 18:20:11 -0800 (PST) X-Received: by 2002:a17:906:f1c8:: with SMTP id gx8mr52480950ejb.524.1609381211099; Wed, 30 Dec 2020 18:20:11 -0800 (PST) MIME-Version: 1.0 From: Daniel Musketa Date: Thu, 31 Dec 2020 03:19:59 +0100 X-Gmail-Original-Message-ID: Message-ID: To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] Contribution: remove commented lines from filtergraph X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Hello everyone, I was heavily using the -filter_script option lately and was missing a way to put comments into the filtergraph file. So here’s a proposal to add that functionality. Happy new year! Subject: [PATCH 2/2] document the behaviour of -filter_script to ignore commented lines --- doc/ffmpeg.texi | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index 62015d7565..b97002b9d3 100644 --- a/doc/ffmpeg.texi +++ b/doc/ffmpeg.texi @@ -663,6 +663,8 @@ This option is similar to @option{-filter}, the only difference is that its argument is the name of the file from which a filtergraph description is to be read. +Lines beginning with "#" in the filtergraph description will be ignored. + @item -filter_threads @var{nb_threads} (@emph{global}) Defines how many threads are used to process a filter pipeline. Each pipeline will produce a thread pool with this many threads available for parallel processing. @@ -1678,6 +1680,8 @@ This option is similar to @option{-filter_complex}, the only difference is that its argument is the name of the file from which a complex filtergraph description is to be read. +Lines beginning with "#" in the filtergraph description will be ignored. + @item -accurate_seek (@emph{input}) This option enables or disables accurate seeking in input files with the @option{-ss} option. It is enabled by default, so seeking is accurate when