From patchwork Tue Feb 13 00:55:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: flow gg X-Patchwork-Id: 46228 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:9002:b0:19e:cdac:8cce with SMTP id d2csp1005558pzc; Mon, 12 Feb 2024 16:56:06 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCVPs8g4iM7QgFhFv2WGz5nSYuBWnOl4lbtzcQ33tDqXa54/sii7hqzSZevZvTus1VRRJVNt6t8ERq8Wl3tN4AsZn7YECpOaqXl9Zw== X-Google-Smtp-Source: AGHT+IGXfxj/JNtD2yvx9eaFkODxZVMLHhXh4rjQJOo91WHghCwMpyHQaoSs0fQg7lumo/XkrsYZ X-Received: by 2002:a17:906:a858:b0:a3c:fe37:611e with SMTP id dx24-20020a170906a85800b00a3cfe37611emr175708ejb.18.1707785765997; Mon, 12 Feb 2024 16:56:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1707785765; cv=none; d=google.com; s=arc-20160816; b=YRsQc6kVxPqsJmG+dHp07eLV+ouTfc+YNSYOoUeLnxbZmCmuZgfRijhX5Glo3JjpsY EaYBwYgTllM3tuCAfDO1ctdwOEspajUy5nbIpfHimiZwQmNXxYRod+SrKegNeH3sN3dZ GllYaHFuSVVPx7pQfa7pl85hft4fAAF6tmSDMvnBGjsHZXmvVe/fFD9BlYLowQ6vtgdg Xa2Up0WHmUo7MUNmFagpMIzqs68tOvut6MNwwENTgLOpKefinRR56DzkZaOf0Zuk0wbd lV5Ml10UqykT28k5hOw60FhiZm5JBnUfGJInU2sWOGgT+OP4/aCu3PprBaFja1ozdwKT xK+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:to :message-id:date:from:mime-version:dkim-signature:delivered-to; bh=WCjbnVMs/h8wBRAdWj3O26vzZNd4Sp1/UdftNsqFtNA=; fh=i1yDSVPZx7j7zOumZ5VVRDhPd5JDDYUhUMLCDBwMqqU=; b=isCKWbY1ARJ+aYmK0Cu7T/CrTS8nRCpPg02/KuAQHTltxzR5ETdAdAjFMIlgZGyZZY HFvOe4sZhI9gXipt2Yk4zYn9/f98+PIyhcAwbLYWi4mxW4e5k5T8axoKGIcGSeHAJ4tl A9+8nnxv9pqwOyZo/wbXtfaUBEi5ZJJ/Pur3sXx5p+htKjXOVjnj4steAs2l96Yc3UIG 2g49cIamFKFK76/mb71920hen++9ywmxHXdE+4hWNB1/Tu2xQXBo3ZGmO8KvPiubOdPc aphALN/mJM4yfAryZ1sTSWETCLk0KG9pOb0bUwy8I8ICwoafI8WGoh5d8to+wo20J3jV 3t+A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=dDCD1aLS; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com X-Forwarded-Encrypted: i=1; AJvYcCVHuCAiZZEaxJWKgAEF8CtUIs86OFs+Ee3tjkRUPeVKgl+8yaSF/uy7m4Y+pwAk3csV3QJg7NzsZtQm6tqrNtViNvg2zsWlM2YrgvGUklez952zDZyAIGUwK0J5RmACZ0h67Dxce1oS4/ruIjcat97lXmoZh7FIvlUV+CJBtTGybJi/my/+ORh/xP5dw72QIpfybY0efKNfPuwQ574zpuKiMg9HDZ0KtCtdwe9yl3ygAD4MkTl4bXuQz1FoIyaUq599LXUHrvu8rIyeUI2MDCtjfK5+B2WlOQiECL4IYmABljPbeHMfejGAVtj899iYUjNwCuBhNKjkU/bU8bMcCRHR4kt9jjArR046RbQtytUZzCZw+Vh9MKHt9jDXJoDX12z+flUpFOQiZIhqa9itUaJV8zndStLXns9bHrn/Wp/a6LBvZEmDSOwcoOYayrQ9GQ+eyep4n0lPMbaShvVl2BA5cr6aW37bpHhWQY7EqqVlSd2Hi9+TROaNquerq2kf/UFvvvtgpNqgHZUN7kpZdmLEe/bxQxWabQu1Y31AYOYvCtgVrwyurKPNWqJXyr8nYMRxbTdWhpzkW2iMAfwUmDP3OXczHc0ergAReW6KMzJfPuFq7CWJU5cFEZ/YUJ1qdCw8kSerZEdK8saBHZFypINiU4mMQT+ojW69Drlw/pD36v4l4uUZDbVsOiCwqS9bRKi2MtKCp9qQN26afzZGy3EPLo8/nKThyhH8iPxjy6Z1qsrWWSyhQnrApOfHXGXJDREUm/TeV7DSJkeWjWwd9TgBAnzZiFlS9R2Thk+FhUj6pSAlUnRJiQlV16/50TCCk62pVqMl+n/obd9Tqe8SBEdT0e4CSlmv6Gj0PIp33UQF5w3KqmjuBcus5+dDb/4V9TpVP5VcOKc17wlN3wEqjStsR3vwJOhT8t9IYP/kqEGG3SxQHDeMXnK1Rl17NHhz58nxiS z7ddwV+NMM0amZwyPJm+dBBb2kt2upjEmHlLf6eadpEHMkh/HCVYRTpximMPxwdLIcNuSb3kQ1+ZamOSXQrlYjLf6hZiHAZ5Z6t19HP2iKEGzYmZS81SXq1IGVJ7LvclkSlReeHAnbNfBs/RihVhZZcaBnA4rahbQN8y0UsWwbKGzH6UTLCR/JbYgwBuPR7YK5dH5Dkj5QghOWFXKVW2ENmr3b2/fIV7FrImxaxgnnpvbz3vuiLVWdf4g6gqwh0jnzzv09gbdtqMd8GQ3ZW5CKJowzjPfcmW+fQhUOKryy692wAjDdM5WOiNzPMTt/9zKrC2r4o2gb3q5jkc5VlwzA8jHFw+v/nJo0rVYDikLjraZU62xcV6PLqKPYSBRadclM9qZAo9bmmQpsa5InZXfiPn7FZr4Ma8+ceMvI4ACFrTA1cL1cwMWRCtANLSrg8McPEx4HF4OxO1GLAldDMORgilnJ1ogswB99AWwWlBNq+5XvzVQNb42mw8A6YQdJd/ebrG9wdu6E5Lm0xj/RgbGCMBa42dR/O9WwJhjScsZ1VIhHivtkTp3Y1Ai4SG6n5aLUDIkb8dlMFP6Cpi+ova7oJxpT4OFDflhZQ8/I Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id i7-20020a170906a28700b00a3cb39307c2si740137ejz.483.2024.02.12.16.56.04; Mon, 12 Feb 2024 16:56:05 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=dDCD1aLS; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4F1DB68D10E; Tue, 13 Feb 2024 02:56:01 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9587D68CBBD for ; Tue, 13 Feb 2024 02:55:53 +0200 (EET) Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-6869e87c8d8so17165606d6.2 for ; Mon, 12 Feb 2024 16:55:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707785752; x=1708390552; darn=ffmpeg.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=1w3FpDePQa6Qsdcs0NmWfpbPKsY5rarDNiH1Jx8mw7A=; b=dDCD1aLS+2HUH1am+HFGfDwXbdgmFlrE+wOk7BOcIfb7aJAnvNXOR9Ck8u4hnLpjVN V4UFwFsaWUXIJasZZEgA/LY1l5ZMSlI7W0cNTPQTcZZuXkHFavRpGRFd362oTLYYv+rS lOXadOwkQwtPDrNFXOhFNRz5fVA6a0tYuEziOmPxJiEz3oR9u/r5t31Lfm7rnx7DJl4e f9rtZXTKI2r3Q4GgNL35TPp8v38Xmcme82BTleHW+KM5Uhho1Q2B2I0EdjiSgV0UCj++ wM3sSzVESSjNjJ2ZNiEk1agBo1RqxTClARmMo0oKsNEr3WGvcMscuPhzDwZ8GA6nZe3G pOBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707785752; x=1708390552; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=1w3FpDePQa6Qsdcs0NmWfpbPKsY5rarDNiH1Jx8mw7A=; b=NeFG1alj1tXVv95df6ob4pygDeo9QOeZ2ga2wfqY/D5uGz6b88Zkd10QSDNnohxG5m gj1tTi3hkrynJH6dseknYimKgFBprwBtiRfal2q1zDIsi8+T5kSDVO5HFLJHmen2bAAO 7vD1I3jjkaKohPB28NX/BSRaa9RoRXxSbOXzJ8XbRs1qrhSi+oyqhA1A4APxuhbhECBr 9hOlO/7IDHe38OJ18DaIZ/dDr/UfKpVmAv0h7poqnsFQR/1fgPBBQKobuxwJotgnb6WV p+YuwSMVrqn8+M3oTrgxzcetKcbHw/CUCAit7ismDu3FPgqYXwaEu9R170JDWAG3i5Vc 868A== X-Gm-Message-State: AOJu0YwqfqD1+C5rNjPa75iawYW7AF6j5sEGtusymXInu3hxnRWfrANA QOc8htjRqWlwiyudN4d7BpU49Rh+eLKb+JR0OCAzIRwic+dvAsgOHmPCT4CQ4hAqZU4BA8aZyou HND4pLHeFYPN2QaMJU5lcXVDHfkeWyKxe9y0= X-Received: by 2002:a0c:cb0e:0:b0:686:9fff:6561 with SMTP id o14-20020a0ccb0e000000b006869fff6561mr6945023qvk.19.1707785751841; Mon, 12 Feb 2024 16:55:51 -0800 (PST) MIME-Version: 1.0 From: flow gg Date: Tue, 13 Feb 2024 08:55:40 +0800 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [FFmpeg-devel] [PATCH] x86: Remove MMX assembly rv34_inv_transform_dc in rv34dsp X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: rFVgnEnEeD4P checkasm in [FFmpeg-devel] [PATCH 1/4] checkasm/rv34dsp: add rv34_inv_transform_dc test From 1aa51d60def8d4313c1b11a50528662ec832530e Mon Sep 17 00:00:00 2001 From: sunyuechi Date: Tue, 13 Feb 2024 08:41:20 +0800 Subject: [PATCH] x86: Remove MMX assembly rv34_inv_transform_dc in rv34dsp This asm will cause checkasm to fail. --- libavcodec/x86/rv34dsp.asm | 12 ------------ libavcodec/x86/rv34dsp_init.c | 2 -- 2 files changed, 14 deletions(-) diff --git a/libavcodec/x86/rv34dsp.asm b/libavcodec/x86/rv34dsp.asm index f29bfd715c..82704843e6 100644 --- a/libavcodec/x86/rv34dsp.asm +++ b/libavcodec/x86/rv34dsp.asm @@ -44,18 +44,6 @@ SECTION .text sar %1, 10 %endmacro -INIT_MMX mmxext -cglobal rv34_idct_dc_noround, 1, 2, 0 - movsx r1, word [r0] - IDCT_DC_NOROUND r1 - movd m0, r1d - pshufw m0, m0, 0 - movq [r0+ 0], m0 - movq [r0+ 8], m0 - movq [r0+16], m0 - movq [r0+24], m0 - RET - ; Load coeffs and perform row transform ; Output: coeffs in mm[0467], rounder in mm5 %macro ROW_TRANSFORM 1 diff --git a/libavcodec/x86/rv34dsp_init.c b/libavcodec/x86/rv34dsp_init.c index caa5c2d653..b865201cd2 100644 --- a/libavcodec/x86/rv34dsp_init.c +++ b/libavcodec/x86/rv34dsp_init.c @@ -25,7 +25,6 @@ #include "libavcodec/rv34dsp.h" void ff_rv34_idct_dc_mmxext(int16_t *block); -void ff_rv34_idct_dc_noround_mmxext(int16_t *block); void ff_rv34_idct_dc_add_sse2(uint8_t *dst, ptrdiff_t stride, int dc); void ff_rv34_idct_dc_add_sse4(uint8_t *dst, ptrdiff_t stride, int dc); void ff_rv34_idct_add_mmxext(uint8_t *dst, ptrdiff_t stride, int16_t *block); @@ -35,7 +34,6 @@ av_cold void ff_rv34dsp_init_x86(RV34DSPContext* c) int cpu_flags = av_get_cpu_flags(); if (EXTERNAL_MMXEXT(cpu_flags)) { - c->rv34_inv_transform_dc = ff_rv34_idct_dc_noround_mmxext; c->rv34_idct_add = ff_rv34_idct_add_mmxext; } if (EXTERNAL_SSE2(cpu_flags)) -- 2.43.1