diff mbox series

[FFmpeg-devel] Subject: [PATCH 1/3] lvac/dnxhdenc: add ff_dnxhdenc_init

Message ID CAEa-L+vyHJp6eZMiCGv5PL+kL8dZHP8Oqq0x5nwwOusc5gDu7A@mail.gmail.com
State New
Headers show
Series [FFmpeg-devel] Subject: [PATCH 1/3] lvac/dnxhdenc: add ff_dnxhdenc_init | expand

Checks

Context Check Description
andriy/commit_msg_x86 warning Please wrap lines in the body of the commit message between 60 and 72 characters.
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

flow gg Dec. 20, 2023, 8:39 a.m. UTC

Comments

Anton Khirnov Dec. 20, 2023, 9:51 a.m. UTC | #1 
Quoting flow gg (2023-12-20 09:39:57)
> 
> 
> From 3f8adabeac408ada6048a1e2ac472534f970364e Mon Sep 17 00:00:00 2001
> From: sunyuechi <sunyuechi@iscas.ac.cn>
> Date: Wed, 20 Dec 2023 16:17:32 +0800
> Subject: [PATCH 1/3] lvac/dnxhdenc: add ff_dnxhdenc_init

typo in 'lavc'

> 
> This is for clarity and use in testing, consistent with other parts of the code.
> ---
>  libavcodec/dnxhdenc.c | 6 ++++++
>  libavcodec/dnxhdenc.h | 1 +
>  2 files changed, 7 insertions(+)
> 
> diff --git a/libavcodec/dnxhdenc.c b/libavcodec/dnxhdenc.c
> index f52a2e9918..1ac8116f53 100644
> --- a/libavcodec/dnxhdenc.c
> +++ b/libavcodec/dnxhdenc.c
> @@ -1377,3 +1377,9 @@ const FFCodec ff_dnxhd_encoder = {
>      .p.profiles     = NULL_IF_CONFIG_SMALL(ff_dnxhd_profiles),
>      .caps_internal  = FF_CODEC_CAP_INIT_CLEANUP,
>  };
> +
> +void ff_dnxhdenc_init(DNXHDEncContext *ctx) {

Brace should be on its own line

> +#if ARCH_X86
> +    ff_dnxhdenc_init_x86(ctx);
> +#endif
> +}
> diff --git a/libavcodec/dnxhdenc.h b/libavcodec/dnxhdenc.h
> index e581312ce4..95aea83d28 100644
> --- a/libavcodec/dnxhdenc.h
> +++ b/libavcodec/dnxhdenc.h
> @@ -111,6 +111,7 @@ typedef struct DNXHDEncContext {
>                                 const uint8_t *pixels, ptrdiff_t line_size);
>  } DNXHDEncContext;
>  
> +void ff_dnxhdenc_init(DNXHDEncContext *ctx);

Shouldn't it actually replace the existing ff_dnxhdenc_init_x86() call
in dnxhdenc.c?
flow gg Dec. 20, 2023, 10:12 a.m. UTC | #2 
> typo in 'lavc'

fixed.

> Brace should be on its own line

fixed

> Shouldn't it actually replace the existing ff_dnxhdenc_init_x86() call
in dnxhdenc.c?

Sorry, I missed this part, it's fixed in this reply

Anton Khirnov <anton@khirnov.net> 于2023年12月20日周三 17:51写道：

> Quoting flow gg (2023-12-20 09:39:57)
> >
> >
> > From 3f8adabeac408ada6048a1e2ac472534f970364e Mon Sep 17 00:00:00 2001
> > From: sunyuechi <sunyuechi@iscas.ac.cn>
> > Date: Wed, 20 Dec 2023 16:17:32 +0800
> > Subject: [PATCH 1/3] lvac/dnxhdenc: add ff_dnxhdenc_init
>
> typo in 'lavc'
>
> >
> > This is for clarity and use in testing, consistent with other parts of
> the code.
> > ---
> >  libavcodec/dnxhdenc.c | 6 ++++++
> >  libavcodec/dnxhdenc.h | 1 +
> >  2 files changed, 7 insertions(+)
> >
> > diff --git a/libavcodec/dnxhdenc.c b/libavcodec/dnxhdenc.c
> > index f52a2e9918..1ac8116f53 100644
> > --- a/libavcodec/dnxhdenc.c
> > +++ b/libavcodec/dnxhdenc.c
> > @@ -1377,3 +1377,9 @@ const FFCodec ff_dnxhd_encoder = {
> >      .p.profiles     = NULL_IF_CONFIG_SMALL(ff_dnxhd_profiles),
> >      .caps_internal  = FF_CODEC_CAP_INIT_CLEANUP,
> >  };
> > +
> > +void ff_dnxhdenc_init(DNXHDEncContext *ctx) {
>
> Brace should be on its own line
>
> > +#if ARCH_X86
> > +    ff_dnxhdenc_init_x86(ctx);
> > +#endif
> > +}
> > diff --git a/libavcodec/dnxhdenc.h b/libavcodec/dnxhdenc.h
> > index e581312ce4..95aea83d28 100644
> > --- a/libavcodec/dnxhdenc.h
> > +++ b/libavcodec/dnxhdenc.h
> > @@ -111,6 +111,7 @@ typedef struct DNXHDEncContext {
> >                                 const uint8_t *pixels, ptrdiff_t
> line_size);
> >  } DNXHDEncContext;
> >
> > +void ff_dnxhdenc_init(DNXHDEncContext *ctx);
>
> Shouldn't it actually replace the existing ff_dnxhdenc_init_x86() call
> in dnxhdenc.c?
>
> --
> Anton Khirnov
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
diff mbox series

Patch

From 3f8adabeac408ada6048a1e2ac472534f970364e Mon Sep 17 00:00:00 2001
From: sunyuechi <sunyuechi@iscas.ac.cn>
Date: Wed, 20 Dec 2023 16:17:32 +0800
Subject: [PATCH 1/3] lvac/dnxhdenc: add ff_dnxhdenc_init

This is for clarity and use in testing, consistent with other parts of the code.
---
 libavcodec/dnxhdenc.c | 6 ++++++
 libavcodec/dnxhdenc.h | 1 +
 2 files changed, 7 insertions(+)

diff --git a/libavcodec/dnxhdenc.c b/libavcodec/dnxhdenc.c
index f52a2e9918..1ac8116f53 100644
--- a/libavcodec/dnxhdenc.c
+++ b/libavcodec/dnxhdenc.c
@@ -1377,3 +1377,9 @@  const FFCodec ff_dnxhd_encoder = {
     .p.profiles     = NULL_IF_CONFIG_SMALL(ff_dnxhd_profiles),
     .caps_internal  = FF_CODEC_CAP_INIT_CLEANUP,
 };
+
+void ff_dnxhdenc_init(DNXHDEncContext *ctx) {
+#if ARCH_X86
+    ff_dnxhdenc_init_x86(ctx);
+#endif
+}
diff --git a/libavcodec/dnxhdenc.h b/libavcodec/dnxhdenc.h
index e581312ce4..95aea83d28 100644
--- a/libavcodec/dnxhdenc.h
+++ b/libavcodec/dnxhdenc.h
@@ -111,6 +111,7 @@  typedef struct DNXHDEncContext {
                                const uint8_t *pixels, ptrdiff_t line_size);
 } DNXHDEncContext;
 
+void ff_dnxhdenc_init(DNXHDEncContext *ctx);
 void ff_dnxhdenc_init_x86(DNXHDEncContext *ctx);
 
 #endif /* AVCODEC_DNXHDENC_H */
-- 
2.43.0