From patchwork Sun Nov 24 22:36:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Jan_Ekstr=C3=B6m?= X-Patchwork-Id: 16403 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id D3F4544A1B5 for ; Mon, 25 Nov 2019 00:45:05 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AF3BC68AC67; Mon, 25 Nov 2019 00:45:05 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-oi1-f196.google.com (mail-oi1-f196.google.com [209.85.167.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1233868AB4A for ; Mon, 25 Nov 2019 00:44:59 +0200 (EET) Received: by mail-oi1-f196.google.com with SMTP id d22so11403881oic.7 for ; Sun, 24 Nov 2019 14:44:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=Ssoyzhwn09wTCklCG4/i5sXGAAB52XZF5qGaKyINdHM=; b=OJ1e33Lh5bO4nENF0mURxPugvf5HXnRuiKBX2W4ww/8zu8izuoOWIuzV/Lp1YXTnx1 EotLzbcyUn1zzWCbfqx1lyquLUeZAO2QBjUUjQFXo+3wslYFY17mMY2eQ3tOEnjJGTsa B7FCnD/PY1gfOTQIOKV065HVuTGgl2dgiljPr1lXiZyYv/r1qIiTe1UdgUr/ILum4+n2 qPQeLdF56nfayK7zSsiPQ7QWMmM3MDilkFtYuATuxvatkYDBbde+4yqTCICVd3fkP0zc Rb8FHkObfqPcQjacf+YrGPFB6Cx5tl8T3OnUXB5nEhG56PPTmD75JTyITbD5qJaP7iBG ByAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=Ssoyzhwn09wTCklCG4/i5sXGAAB52XZF5qGaKyINdHM=; b=BdvPFvy2KEihKVukwvJb7BN8xF+s3rK9D6n8/HrKimlt8nsUyD5RyZzeZ0hxW46Qrh mvvUzvlmY0hs1O/PHA1KTC64UMWGWrTTdQXtDY4kHCsWCShfwpmgFj5sZzjtvSwonaZh fiOF3iyKZBKZLjLZ63BK5dSdh9njMt7a6VrirGjsnhkt7NQ6NylLhOCunXATKMhtqo2I HGIeBC8oK/dhp+MSw4RvLH20Jq3P6BxClekqTl4EmaVOhyiz8d3bYnZNFyeQHOmg/plN SYvqk3vek1jUSQQyIVSCTPYtHs+TqrW2v85gT0xMaQVEHvbLckyY9eZ3JGl7THGY073v U1pg== X-Gm-Message-State: APjAAAUvQNKN2kdxXPjhKgnO9W0hVS3ryjbj2DL0WI8DJc3LUMUILBQo k+GQjwgvp0g1pjYaIAbbvnrZdPIiXyuV5D9apk1SK7s5 X-Google-Smtp-Source: APXvYqxqumTC/6THmAYgDG3dQrTo6cXZCksum/4JnF/FwYwUsdK4mU0gdvxpSRsol77wg9dxibiFEwmSl/FXl9QLV9g= X-Received: by 2002:a54:408e:: with SMTP id i14mr19739129oii.61.1574635003420; Sun, 24 Nov 2019 14:36:43 -0800 (PST) MIME-Version: 1.0 References: <20191120092543.5071-1-lq@chinaffmpeg.org> In-Reply-To: <20191120092543.5071-1-lq@chinaffmpeg.org> From: =?UTF-8?B?SmFuIEVrc3Ryw7Zt?= Date: Mon, 25 Nov 2019 00:36:31 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: set strict_std_compliance from the parent AVFormatContext X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Hi, On Wed, Nov 20, 2019 at 11:26 AM Steven Liu wrote: > > fix ticket: 8388 > > Signed-off-by: Steven Liu > --- Too bad meta things that end up creating internal contexts end up messy like this. Generally same idea as with bad42e9b40920f079b27e5bd4103d9293046b2ed , so other than the following nit regarding extraneous white space on the newly added line, LGTM. Possibly also utilize similar wording as the other commit, but I have no heavy opinion on that :) . > libavformat/hlsenc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index 013e91ad88..24c102f570 100644 > --- a/libavformat/hlsenc.c > +++ b/libavformat/hlsenc.c > @@ -782,6 +782,7 @@ static int hls_mux_init(AVFormatContext *s, VariantStream *vs) > oc->opaque = s->opaque; > oc->io_open = s->io_open; > oc->io_close = s->io_close; > + oc->strict_std_compliance = s->strict_std_compliance; Adds extraneous white space. A single space before the equals sign goes just fine here since this is the longest line in the set. I'd just do the following to be honest: if (vs->vtt_oformat) { Best regards, Jan diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 013e91ad88..519d489956 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -776,12 +776,13 @@ static int hls_mux_init(AVFormatContext *s, VariantStream *vs) if (!oc->url) return AVERROR(ENOMEM); - oc->oformat = vs->oformat; - oc->interrupt_callback = s->interrupt_callback; - oc->max_delay = s->max_delay; - oc->opaque = s->opaque; - oc->io_open = s->io_open; - oc->io_close = s->io_close; + oc->oformat = vs->oformat; + oc->interrupt_callback = s->interrupt_callback; + oc->max_delay = s->max_delay; + oc->opaque = s->opaque; + oc->io_open = s->io_open; + oc->io_close = s->io_close; + oc->strict_std_compliance = s->strict_std_compliance; av_dict_copy(&oc->metadata, s->metadata, 0);