From patchwork Sat Jul 28 16:10:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Jan_Ekstr=C3=B6m?= X-Patchwork-Id: 9834 Delivered-To: ffmpegpatchwork@gmail.com Received: by 2002:a02:104:0:0:0:0:0 with SMTP id c4-v6csp2062614jad; Sat, 28 Jul 2018 09:10:57 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfzmRyhqV+1TjNrkgbRMxiXXYBpd5F/S/BfkTvzEbgigBgyyyiCqZDWSyC96s73hdEtQFje X-Received: by 2002:adf:82f0:: with SMTP id 103-v6mr9592303wrc.131.1532794257807; Sat, 28 Jul 2018 09:10:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532794257; cv=none; d=google.com; s=arc-20160816; b=Mr6zRsmNuwc+aYaJpsyieVVI89unn591T7uGNwuGnBHa9Tw69SDOnKw93ylnu3LGm1 C3Nb8aEZxIbJjGOos32R2dcJi/ZSVoH2U6sr92lbZUAEoXVFMC1dQbew4LN48HZ99Q3f pgq066YSr1i3v3qUqFNzNzYvjv5EYeTBl4aT+Y4QW7nRe5rXY15l6fjuszhKd/ui6dHD V3/MBqRNBzWVvVAzX3CIVm55GUP7tPfk+CxTotScWaUH++R3EYl8UrR1Gi9vdpT8kTj+ VO69Of2pl/GOLXwy7kHcX1LKQSxgcqWC89MwWGwmSAR+FgU8vKUQ69bVtmM87KzH8ZCn 5XjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:to:message-id:date:from:references:in-reply-to :mime-version:dkim-signature:delivered-to:arc-authentication-results; bh=By5Xjgd1+2WfL9V2b4UNbGIRhTSJp+s78dwg2Q9+oiQ=; b=QvKhve+bhxPKXssr49lKoZBlw1M6MlKFtQQNvg13TEHeIJmxY1xvztBjwggMmrTeip g5mTK273QKBBLpjGKweF4aW4vBmmZN0tC6ybPkkhUcoAcuJv5yesKbbsUBy9y4qxauAN cDp/LE3vdmfOj5wxKHj+VoN4okhrlNzfXIYusXSM1m0eZCWRK1kzSH2sxYsn4aPLhmmw 0oVPkAswmBq2KGjufNHBeXM2/yPW+8+ieUPLJs8/i3oWUu8PtOMNBdW5i3ZaiGs+g7e7 OFtS6LoCue7XYDMAEiWH0rhQL1gYlrIvRbcRZLxBnk8DHUlW3U8s2mzEdad4t9ND40/P 1ESQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=c4vf7lCl; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id u13-v6si6228586wrq.429.2018.07.28.09.10.56; Sat, 28 Jul 2018 09:10:57 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=c4vf7lCl; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7F67A689CB4; Sat, 28 Jul 2018 19:10:39 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2A257689B55 for ; Sat, 28 Jul 2018 19:10:33 +0300 (EEST) Received: by mail-lj1-f176.google.com with SMTP id j19-v6so6952894ljc.7 for ; Sat, 28 Jul 2018 09:10:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=1KWskI3vttX16C00HDMpKswY8Ncw4bWNnqggPccAiCs=; b=c4vf7lCl33lsoyw6ZZKoaaH+3exJsYuCHUkjGHrwrbXMWuRJoriBxClqP9PpLbQ+Q5 qAKRKSO7+bLQswnsW/dLiOsbikXclL7M11PH2lxVethcl4kv1Yt3FY1W4i3ONZtRXIhG B8aeTaPZ9VEu5ehJGGU6BYOVxcosLc+lmecbb2tWRl+RF4jajknw2vcukLFXUXXGlBIE hn+Rq8rvk0xNfQjyIkCzGDY/HCfgyPQR9deD/FE7Ks+K3gzsbHvG76moqLZ6iOgfA8IX 9BjnUQp/aN37pU8oshayQzAcbs2g97nDQ8RpqNACxeIxm+VUNy4CY3aqegPDuq61XE7r Aiug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=1KWskI3vttX16C00HDMpKswY8Ncw4bWNnqggPccAiCs=; b=S2ka6cWpK4ogvqqxtlfOdBXjP+d4w6jveKrEQu1eQI3f9uxV4bS+uint6KNBt9zNro 7jv9BiPyxApHNPRWxrQf8k0aWgH/AIAgPBSNW3FnTLxd3DM5l7VGupNL8Afblp2DuFTa iugFEc0v+0lD5jVFWtdtxLTJDgazRYCetUNNPryIEjJNUq1O/PRDpYakz9KkJ4g4N+bs 6Zj3rbNyu3baoLPNWVbO7XnBcgHtcXkm67xiLAGP9UoLM//4C69mM99EYSCtPVHJ8WOF yd4Nf5eAqW005+3bR0Fu/NHfapOMH9tMpCYOxPvbVCxEhkg0xou2c+w5qle2Rms/8xk8 jEGQ== X-Gm-Message-State: AOUpUlHQ4Iw6sqy3JJLEwkTrnW5PYKb6TAqp2+b8Mqw7wY03wKQSkhfi m/TvqOkMySHLnp4saQruDdJk8V1ijeCnNZj1j9R3vkO5 X-Received: by 2002:a2e:4d9d:: with SMTP id c29-v6mr7743218ljd.132.1532794248059; Sat, 28 Jul 2018 09:10:48 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a2e:8603:0:0:0:0:0 with HTTP; Sat, 28 Jul 2018 09:10:47 -0700 (PDT) In-Reply-To: <20180726223031.GF19650@michaelspb> References: <20180725235138.27380-1-jeebjp@gmail.com> <20180726223031.GF19650@michaelspb> From: =?UTF-8?B?SmFuIEVrc3Ryw7Zt?= Date: Sat, 28 Jul 2018 19:10:47 +0300 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avformat/movenc: implicitly enable negative CTS offsets for ismv X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On Fri, Jul 27, 2018 at 1:30 AM, Michael Niedermayer wrote: > breaks fate > fate-lavf-ismv seems to be all about the version identifier (0 is for uintXX CTS offsets, and 1 is for intXX CTS offsets). F.ex. with the first file: Will send a new patch with that test updated. Jan diff --git a/old_1st.log b/new_1st.log index f188075577..5100ff6710 100644 --- a/old_1st.log +++ b/new_1st.log @@ -267,7 +267,7 @@ [trun: Track Fragment Run Box] position = 851 size = 120 - version = 0 + version = 1 flags = 0x000305 data-offset-present first-sample-flags-present @@ -350,7 +350,7 @@ [trun: Track Fragment Run Box] position = 143053 size = 120 - version = 0 + version = 1 flags = 0x000305 data-offset-present first-sample-flags-present @@ -433,7 +433,7 @@ [trun: Track Fragment Run Box] position = 284519 size = 32 - version = 0 + version = 1 flags = 0x000305 data-offset-present first-sample-flags-present