From patchwork Sun Feb 10 01:47:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Jan_Ekstr=C3=B6m?= X-Patchwork-Id: 12016 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id A2F6344861C for ; Sun, 10 Feb 2019 03:47:54 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7EB6168A7ED; Sun, 10 Feb 2019 03:47:54 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 94F9268A57B for ; Sun, 10 Feb 2019 03:47:47 +0200 (EET) Received: by mail-lf1-f68.google.com with SMTP id v7so946518lfd.2 for ; Sat, 09 Feb 2019 17:47:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-transfer-encoding; bh=CthujMgtn8meQEMXvQKuENyYhWHsxVfosddPffPayhQ=; b=nYt7xnoXse4euLR/ZT3ViF0OWlbid2ca60cg5dA4dw7qDnSvrYWHlSt1kjhtWhD8wa fpH1BdNhNCvm9O3Y705J1QMLUr3EXThbSaIYWh4tUCJREN0jy2o/TzNuDBdMYvUXi/lQ FgA0iENwkrR+dPlsl1Q15WAQa6n+JIUKTWOCunUADAEzktCr12W1R0yurusLVJNSYb6Z whDR6oVueai4Fh2rKL3mjUH8h6ZITGLPjkqBW7KpBkcByQTWbx0rIEcyWS2wCMoyupOx b/UOHexjYgrEvENCdAAVkrlAcIhsPuFcy2yBDX+1Q0xgjQV5k9nwJrCqX39HYXx9yFTq UeJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:content-transfer-encoding; bh=CthujMgtn8meQEMXvQKuENyYhWHsxVfosddPffPayhQ=; b=WArZzZ5X+8L5M8AZ4/mElHrpdheJgK2M9bSUQAWapn9kTQ2it4d7+sTrqBYouMn0vd +L8MmMhVYaZ/SA9eE602UtTOZfjOwiUURXFXb/qcm3ydNtmLEm6LvSzi5OB9BggzvcBs G0QWbozW0LPB+CfVVFC17mDMF1rfeRazzqwh+ZhaZVb9j7uJn5NFDjTRQk4jK+zOKcSh 3GMVnQSdGUmbmluD+4A3/0r8D4u7mxspA1hEt5eXqBnzY+Ky7bB7YWpNmIj16WW+9om9 1Dy/63KZ8Y6GeKNOk6Cwysl17Uo9kqCryCl2mKQww1wluFAI5PyR/XEa0WV0+4z94oBl LgOA== X-Gm-Message-State: AHQUAuYcqROYQOEOc1naXq25/DJWF26NphmAjL4qtmfSpbXWEA9K+gJw 52TC8hwDNj3PrCFC5czy4e3eH1BAdshIUIWiMJVZBOnX X-Google-Smtp-Source: AHgI3IbcqW3fjbEsoPzjo5V32C7YNnFkTWgHO0YkMHDLj8KCbDflB7vFK2t2CH/Ko149P8W7ngLeMoo0X1UgANyReJ8= X-Received: by 2002:a19:a98f:: with SMTP id s137mr18867463lfe.18.1549763266415; Sat, 09 Feb 2019 17:47:46 -0800 (PST) MIME-Version: 1.0 References: <20190202133136.28596-2-jeebjp@gmail.com> <20190203193840.31535-1-jeebjp@gmail.com> In-Reply-To: <20190203193840.31535-1-jeebjp@gmail.com> From: =?UTF-8?B?SmFuIEVrc3Ryw7Zt?= Date: Sun, 10 Feb 2019 03:47:36 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 1/2 v3] add libaribb24 ARIB STD-B24 caption decoder X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Noticed some minor issues while doing my final check-up of the patch set, which I fixed locally. Checked that the configure checks still failed if you tried to enable libaribb24 without version3, and that if the version of the library is old enough, it would fail without gpl being enabled. On Sun, Feb 3, 2019 at 9:38 PM Jan Ekström wrote: > @@ -1684,6 +1685,7 @@ EXTERNAL_LIBRARY_NONFREE_LIST=" > EXTERNAL_LIBRARY_VERSION3_LIST=" > gmp > liblensfun > + libaribb24 > libopencore_amrnb > libopencore_amrwb > libvmaf Moved libaribb24 above liblensfun to be in alphabetical order. Wonder why I missed this originally. > @@ -1707,6 +1709,7 @@ EXTERNAL_LIBRARY_LIST=" > jni > ladspa > libaom > + libaribb24 > libass > libbluray > libbs2b Hadn't noticed that EXTERNAL_LIBRARY_VERSION3_LIST was included in this list at first, removed the duplicate entry. All in all the changes are as follows : Jan diff --git a/configure b/configure index cb852c6289..fe45fd2290 100755 --- a/configure +++ b/configure @@ -1684,8 +1684,8 @@ EXTERNAL_LIBRARY_NONFREE_LIST=" EXTERNAL_LIBRARY_VERSION3_LIST=" gmp - liblensfun libaribb24 + liblensfun libopencore_amrnb libopencore_amrwb libvmaf @@ -1709,7 +1709,6 @@ EXTERNAL_LIBRARY_LIST=" jni ladspa libaom - libaribb24 libass libbluray libbs2b