From patchwork Wed Oct 4 10:45:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: pon pon X-Patchwork-Id: 5409 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.161.76 with SMTP id m12csp700328jah; Wed, 4 Oct 2017 03:46:00 -0700 (PDT) X-Received: by 10.28.45.9 with SMTP id t9mr16193516wmt.94.1507113960106; Wed, 04 Oct 2017 03:46:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1507113960; cv=none; d=google.com; s=arc-20160816; b=TjuWgwbi7eiEom6WRl7/S81M5viXzcwtu42t8IYZvT5RqdYqwdPTyA9VKa00W81vpb KGcEX5dUWR8d68wAkcdmQKRaje8kiNuLql8yuK/gscr9rJb41bgpZWZm0y7rwZsA0G6O 2eBAxvpjiGDZ0gUhzHvWU12JkUKMD6NJr4dGslQnmUnejTfDHG4KLwuoprDJZbhImUQx 2V3HkDcUG1p7CdUVGZ0EuVW6uDrJ3F4kMT0AFMWcoesIERDaveDrGdRbOk25jKbLI4wF xonivMSMJfN6b2ctTPaUPmuZAcTtB5TcKTZCHa8plmTgwPaH73aVyE7VJ1MeDUf3COQi C1xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:to:message-id:date:from:references:in-reply-to :mime-version:dkim-signature:delivered-to:arc-authentication-results; bh=eQwvCbEU9gOg+rmYZnSjQUQ3s6GlylzYViPdr3KLt1w=; b=lQWqPdUqF9ckz/qw+idMKiMdWRsV72Wv9nj4yCM6qf6KNIJCtAhSiX5P1+zh8v75mQ akZ8amIdImN1b56o67FMRHUl9H/Q+ztdFN/gZhy7GuyZHD/xW6hXrzWLIC7P1sJ9aLkd 0IWOcV532wmSaMp2ETf9iPNiCB5QWFjiU4IpmvKIfa+6R9WWh/mdOQJs6FLh8EgbQVxn jCMskSDNXS4Lu6d+tHOqH986Waj0zsuK7d4u6JbKgbwSKCNbWEjfVhBOdtK6svG6ujs0 ZmxUA3xzRxpKO7M0hJvqVob9GWbSaGm5ICfLLfKdC6WSpoAShvAfEOzWNFKeNC/TRlo3 dSkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=belcrTZu; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id q18si12593816wre.148.2017.10.04.03.45.59; Wed, 04 Oct 2017 03:46:00 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=belcrTZu; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 036CD68A261; Wed, 4 Oct 2017 13:45:43 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-it0-f49.google.com (mail-it0-f49.google.com [209.85.214.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 654D368A25D for ; Wed, 4 Oct 2017 13:45:37 +0300 (EEST) Received: by mail-it0-f49.google.com with SMTP id w1so5599070itd.0 for ; Wed, 04 Oct 2017 03:45:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=VCcKl8MMka1kylYjsHaYa/hQomoK8TZOyhk5CtRATP4=; b=belcrTZuFhqWYPmdJ0sb9i/1yH0YlwgiyYN4vAOkdVuqNQ7S/gPbViB/Y5jXIvuoHz MdDC+3WDfwCAAfRcOaH2HPHK001FGKHsSlbTDjLYl/N76Tu02HtgQEbG43DjEv/V98sH Vu/TfdgT4UPcJN/lJkvjOw6HRDSzKRHs1i6POT2uvB8QdEsRIR5e+rqkXx8sfJMBLROC pwiIYsg+U4IThlrHVnMtZNV9v3mKPZ2m0nGR7psZwMfH1thY7yhf5iuk2frG+0hICqfJ SK16iugmjCOZNE+80jTHNtRVOylLiYCelqmiFNLm0uSoGPBBAw+9G3BGArdJDiYkcEB2 QLlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=VCcKl8MMka1kylYjsHaYa/hQomoK8TZOyhk5CtRATP4=; b=NUlpY8G/GD80lZPXx6Ra4qXH4+YAZrJrl1hTwqtz9tXljbq9A8/y0Y3Hu0kQyG8Ara ZrozUvo6YCP57RUAKOpaFYFgOJ1W1/Bo8ZUb8TYqcdiqG1zL50dTEHQdPXaiZ/dUKaI3 sMKD7TCN1bz2PF0AlzypeX0RIEBtVXg+wHoI/EiJ+PZStBh309abcYRi22hTSGlEofnm rU/nW+r+dmZTYUAHuB23s0XEz6ruDXSXayO2OQlqna7m8Cji9XoSDrm+XNnW9uoXvb7G jlDs1HL/srJQCym5SvLOn8jGIr+ZoiFpno00tsE9pvmmJoDQLn9JYVA4TjVIsm/UEiPo 9HwA== X-Gm-Message-State: AMCzsaWFg+9yZgOiiYFGHMd92zUDNUYTIRVM/wC5u/O3mcTNfrHlShu7 A/IkJgyuds8k5UW6hhao8VlP2rLl5GgI6ml1JeJ+sw== X-Google-Smtp-Source: AOwi7QD+2eykclIr440ezDlZfU7GQFfZKBXD3ZKi0Z/TR8el4TKxKnQK8BEWqQDbEqRb7zhliQN3gVln8aRCvxj/ZLI= X-Received: by 10.36.213.69 with SMTP id a66mr21577410itg.89.1507113951036; Wed, 04 Oct 2017 03:45:51 -0700 (PDT) MIME-Version: 1.0 Received: by 10.2.147.172 with HTTP; Wed, 4 Oct 2017 03:45:50 -0700 (PDT) In-Reply-To: <20171004064256.GG388@golem.pkh.me> References: <20171004064256.GG388@golem.pkh.me> From: pon pon Date: Wed, 4 Oct 2017 19:45:50 +0900 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.20 Subject: Re: [FFmpeg-devel] [PATCH] Videotoolbox encoder: Enable Videotoolbox encoder X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Thank you for pointing out. >i t doesn't belong in this list. Doesn't this mean videotoolbox_encoder belongs to EXTERNAL_AUTODETECT_LIBRARY_LIST, also? If so, I think the integrated modifications of videotoolbox"enc".c and videotoolbox.c are need. This is because videotoolboxenc.c doesn't include videotoolbox.h. independent each other? Your idea is correct. Videotoolbox has decoder , encoder, videofilters. Moreover, its work switches between soft- and hard-ware. But, My understanding of hw accelation policy of ffmpeg isn't enough and this is beyond my ability. For example, ./configure --disable-decoder=h264_videotoolbox and ffmpeg -c:v h264_videotoolbox -i input output don't work. On the other hand, qsv isn't so. As a temporal handling to autodetect, the previous patch or can be used. ffmpeg -i input -c:v h264_videotoolbox output, ./configure --disable-encoder=h264_videotoolbox, and ./configure --disable-videotoolbox well work in my tests. Of course, this depends on the policy of ffmpeg. I like ffmpeg. Thank you. ponpon 2017-10-04 15:42 GMT+09:00 Clément Bœsch : > On Wed, Oct 04, 2017 at 09:55:04AM +0900, pon pon wrote: > > I reported that Videotoolbox encoder isn't enabled since commit > > 9ef5a2f5f30bdc4ac86275ae4b4708ab4681b21 > > 9ef5a2f5f30bdc4ac86275ae4b4708ab4681b21d> > > in ticket 6702. > > This is a simple patch correcting it. > > > > diff --git a/configure b/configure > > index ae0eddac6c..8922303c89 100755 > > --- a/configure > > +++ b/configure > > @@ -1652,6 +1652,7 @@ HWACCEL_AUTODETECT_LIBRARY_LIST=" > > vda > > vdpau > > videotoolbox > > + videotoolbox_encoder > > v4l2_m2m > > xvmc > > " > > > > "videotoolbox_encoder" is not an autodetected library, it's a component > depending on videotoolbox, so i t doesn't belong in this list. > > Please see http://ffmpeg.org/pipermail/ffmpeg-devel/2017-September/ > 217075.html > > If you can test it I'll apply it. > > -- > Clément B. > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > diff --git a/configure b/configure index 0d86c4cb2a..d3886b6d41 100755 --- a/configure +++ b/configure @@ -1542,6 +1542,7 @@ EXTERNAL_AUTODETECT_LIBRARY_LIST=" sdl2 securetransport sndio + videotoolbox_encoder xlib zlib "