diff mbox series

[FFmpeg-devel] crash fixed: live stream.

Message ID CAGsMwNA53LfuPmnAvGiAX9waOysvhcyAcsQi7MFcrvCGszyFwg@mail.gmail.com
State New
Headers show
Series [FFmpeg-devel] crash fixed: live stream.
Related show

Checks

Context Check Description
andriy/ffmpeg-patchwork pending
andriy/ffmpeg-patchwork warning Failed to apply patch

Commit Message

mostafa namazi Feb. 18, 2020, 3:22 p.m. UTC
---
 libavformat/hls.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

                 ret = av_read_frame(pls->ctx, &pls->pkt);

Comments

Andriy Gelman Feb. 18, 2020, 9:03 p.m. UTC | #1
On Tue, 18. Feb 18:52, Mostafa Namazi fard wrote:
> ---
>  libavformat/hls.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/hls.c b/libavformat/hls.c
> index 1f58e745a7..97b1a1db52 100644
> --- a/libavformat/hls.c
> +++ b/libavformat/hls.c
> @@ -2110,7 +2110,7 @@ static int hls_read_packet(AVFormatContext *s,
> AVPacket *pkt)
>          /* Make sure we've got one buffered packet from each open playlist
>           * stream */
>          if (pls->needed && !pls->pkt.data) {
> -            while (1) {
> +            while (pls->ctx) {
>                  int64_t ts_diff;
>                  AVRational tb;
>                  ret = av_read_frame(pls->ctx, &pls->pkt);

Hello Mostafa, 

It looks that your inlined version doesn't apply with git am. If
you simply paste in the patch, your email client may corrupt it.

I recommend to use git send-email which handles the formatting.

If you have a gmail account and want to use it with git send-email, then follow
the steps at the end of this page (in the examples section) 
http://web.mit.edu/git/www/git-send-email.html

Thanks,
Patchwork Feb. 18, 2020, 11 p.m. UTC | #2
Hello, 

Thank you for submitting a patch to ffmpeg-devel.
 
An error occurred during an automated build/fate test. Please review the following link for more details:
https://patchwork.ffmpeg.org/project/ffmpeg/patch/20200218224926.23103-1-andriy.gelman@gmail.com/

Thank you, 
ffmpeg-devel
mostafa namazi Feb. 19, 2020, 4:30 a.m. UTC | #3
Hello Andriyyou can see my patch in below link. please review that. thanks.
[FFmpeg-devel] new patch - Patchwork

| 
| 
|  | 
[FFmpeg-devel] new patch - Patchwork


 |

 |

 |



    On Wednesday, February 19, 2020, 1:01:21 AM GMT+3:30, Andriy Gelman <andriy.gelman@gmail.com> wrote:  
 
 On Tue, 18. Feb 18:52, Mostafa Namazi fard wrote:
> ---
>  libavformat/hls.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/hls.c b/libavformat/hls.c
> index 1f58e745a7..97b1a1db52 100644
> --- a/libavformat/hls.c
> +++ b/libavformat/hls.c
> @@ -2110,7 +2110,7 @@ static int hls_read_packet(AVFormatContext *s,
> AVPacket *pkt)
>          /* Make sure we've got one buffered packet from each open playlist
>          * stream */
>          if (pls->needed && !pls->pkt.data) {
> -            while (1) {
> +            while (pls->ctx) {
>                  int64_t ts_diff;
>                  AVRational tb;
>                  ret = av_read_frame(pls->ctx, &pls->pkt);

Hello Mostafa, 

It looks that your inlined version doesn't apply with git am. If
you simply paste in the patch, your email client may corrupt it.

I recommend to use git send-email which handles the formatting.

If you have a gmail account and want to use it with git send-email, then follow
the steps at the end of this page (in the examples section) 
http://web.mit.edu/git/www/git-send-email.html

Thanks,
Andriy Gelman Feb. 19, 2020, 2:19 p.m. UTC | #4
On Wed, 19. Feb 04:30, mostafa namazi wrote:
>  Hello Andriyyou can see my patch in below link. please review that. thanks.
> [FFmpeg-devel] new patch - Patchwork
> 

If you had a crash, you should probably open a ticket on 
https://trac.ffmpeg.org/

Thanks,
diff mbox series

Patch

diff --git a/libavformat/hls.c b/libavformat/hls.c
index 1f58e745a7..97b1a1db52 100644
--- a/libavformat/hls.c
+++ b/libavformat/hls.c
@@ -2110,7 +2110,7 @@  static int hls_read_packet(AVFormatContext *s,
AVPacket *pkt)
         /* Make sure we've got one buffered packet from each open playlist
          * stream */
         if (pls->needed && !pls->pkt.data) {
-            while (1) {
+            while (pls->ctx) {
                 int64_t ts_diff;
                 AVRational tb;