From patchwork Wed May 30 16:48:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Liberato X-Patchwork-Id: 9165 Delivered-To: ffmpegpatchwork@gmail.com Received: by 2002:a02:11c:0:0:0:0:0 with SMTP id c28-v6csp4557690jad; Wed, 30 May 2018 09:49:02 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLL6P19ubMccDeLchqdo+Au/zL7Z9P/jDpbJml7uPgHABLEPXkYUy0kekFz7UdmVfJxc9Wm X-Received: by 2002:a1c:3282:: with SMTP id y124-v6mr2062764wmy.33.1527698942536; Wed, 30 May 2018 09:49:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527698942; cv=none; d=google.com; s=arc-20160816; b=yGA/G7LbzwIQAPgDTeB+SO7rPuR7vHhi6+A+3dMbI/Qv3fwnwUCw14KXEzSA8V6Xqw NAXd7E6yZZdboQK2lHPJ/iwzsGz3NDBfDfAEbgzS7hKWwKk/4YjQEXhbHk8gPXVcBIjm i/YJUovts+X+aiTve3XUqbrDMurUEkRtBqf96dRDGaHsoFaIsz62vIXallXpig5VWIi8 xpayEh5/WkAqw9yZ38swEGKfkAXnWNNiAumxLK1BX9amDGRbYB/EdsoEQkrwpMRrbjCe HGyY8Ldpfzfv5rKwkRHyheCS3Dct4IIVSQe4Jf+kr+Z5AC0HB98Us6sj6DZCLdC6Fmhc AJAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:to :message-id:date:from:mime-version:dkim-signature:delivered-to :arc-authentication-results; bh=ZXk7dASx+rNr/EtciJqvW564WzWB4rWi6s+GQWc94xY=; b=GkL5YlYeqNnWyv2Qs3NFlzJP9cBsovoRcvKJQoMW02jSQuryS8OSBRFBRXSOgpGUOm uRslLad1RFSbcqC8wze+6bn8y1KG0cdcBmt7NRWdpLYjOu7EDQLdXVVtlkFWnxU6yfig 7xm8BFbvhzHYEowms00j4PhQkR4I4UNvTYnOuGusB+C3MS4uIW2VqTNIbx0/BpfgJ+uw 8QEeQOrWrcb/9fnyMJIhUUH+Ld+piUozEvM3RyOQgNjyzyRUhbsDz4NCi0tLxqPmtTKt tS21xL89LR7Hiio5E+5vaQ1MVDwPvz9Zm6vzcjarqU8U6+Cbi9ju6ZFKlA2+LrovG5Ua jDfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@chromium.org header.s=google header.b=cFWIcIka; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 83-v6si9633976wmb.84.2018.05.30.09.49.02; Wed, 30 May 2018 09:49:02 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@chromium.org header.s=google header.b=cFWIcIka; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3E76168A3FB; Wed, 30 May 2018 19:48:16 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qk0-f175.google.com (mail-qk0-f175.google.com [209.85.220.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id ECAF968A396 for ; Wed, 30 May 2018 19:48:08 +0300 (EEST) Received: by mail-qk0-f175.google.com with SMTP id j80-v6so13166077qke.9 for ; Wed, 30 May 2018 09:48:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:from:date:message-id:subject:to; bh=E/DJxZB6BASCgaGYMKYkbcsEYxg29wLwaXeEsYhraDk=; b=cFWIcIkaDsUTmkf6Of3VNZxVF7Oy7ZyQOROmKejzl/8LphNMEuh69TPkFTESG2HQ3s OCxLnqxfMgaGgvMCMlJNl2+3aXSsTKBsz2DTz4Qbd6vdsRgrtq/RfgbSy2byRw1qTmUp W1GaCbkFTF292AVOkF2OjvKOklBZoWe/UaNYk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=E/DJxZB6BASCgaGYMKYkbcsEYxg29wLwaXeEsYhraDk=; b=aLNNoGEA2iRczPD0e/97pi1QdH+GEin3d1HrTEXlDOnaDH/LGkvrjwd2vdDplNx3B9 pz8hqebDUfCV1lBesctH6BChk7yYs9U3j7y1i7VbztRtM6oQiDOC/IBt1EA6/87hZRoJ otiZXCvwKx1YRQ2bcVr+D0zz62vJoHYjhwUp2CnsIytlfmuAnEMWneTAJbfXGcNBK2j6 giM6Eg5zKGtS/9Wkhf1rjVkMc+e9B8KMNu1hX+9NjB81eLzU4y94vSsoay95cHL+Ny6y wf/PIajkVKYDNLUZoaK+2UFkEO9Zj69Vy7aJ1synaQ0dxaev55dSSkZl+VX75odwSxx4 k4kw== X-Gm-Message-State: APt69E3fVCeJFpYDUbsVuig//5wooVS0hCYUX4x4Zqsnn+tSG8hvFRYD qXEeAOl9phFnjjWhB3nD2FCCfqV1iKV0cYavg5PVihBjNoI= X-Received: by 2002:a37:1399:: with SMTP id 25-v6mr2986102qkt.83.1527698931960; Wed, 30 May 2018 09:48:51 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:aed:2f82:0:0:0:0:0 with HTTP; Wed, 30 May 2018 09:48:51 -0700 (PDT) From: Frank Liberato Date: Wed, 30 May 2018 09:48:51 -0700 Message-ID: To: ffmpeg-devel@ffmpeg.org X-Content-Filtered-By: Mailman/MimeDel 2.1.20 Subject: [FFmpeg-devel] Patch: Replace quotes for inline asm detection. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Please find attached a one line patch: > Commit 8c893aa3cd5 removed quotes that were required to detect > inline asm in clank: > > check_insn armv5te qadd r0, r0, r0 > .../test.c:1:34: error: expected string literal in 'asm' > void foo(void){ __asm__ volatile(qadd r0, r0, r0); } > > The correct code is: > > void foo(void){ __asm__ volatile("qadd r0, r0, r0"); } Thanks Frank From 58c96127b6f1510b956b2280049d1c3778e3cab4 Mon Sep 17 00:00:00 2001 From: "liberato@chromium.org" Date: Tue, 29 May 2018 11:35:04 -0700 Subject: [PATCH] Replace quotes for inline asm detection. Commit 8c893aa3cd5 removed quotes that were required to detect inline asm in clank: check_insn armv5te qadd r0, r0, r0 .../test.c:1:34: error: expected string literal in 'asm' void foo(void){ __asm__ volatile(qadd r0, r0, r0); } The correct code is: void foo(void){ __asm__ volatile("qadd r0, r0, r0"); } --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 22eeca22a5..4dbee8d349 100755 --- a/configure +++ b/configure @@ -1040,7 +1040,7 @@ EOF check_insn(){ log check_insn "$@" - check_inline_asm ${1}_inline "$2" + check_inline_asm ${1}_inline "\"$2\"" check_as ${1}_external "$2" } -- 2.17.0.921.gf22659ad46-goog