| Message ID | CAHVN4mh6NgUHsFtG-XOJq302nDpZA+AeSi+1kG2O8PFypHoPBQ@mail.gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
Hi! 2016-08-29 8:17 GMT+02:00 Matt Oliver <protogonoi@gmail.com>: > The fifo muxer works without pthreads due to the existing pthread > wrappers already available within ffmpeg for other platforms. How did you test this? (How can I test?) Carl Eugen
On Mon, Aug 29, 2016 at 8:17 AM, Matt Oliver <protogonoi@gmail.com> wrote: > The fifo muxer works without pthreads due to the existing pthread wrappers > already available within ffmpeg for other platforms. > It should probably still depend on "threads" at least, assuming the thread-wrapper we have provides enough threading features for the muxer. - Hendrik
On 29 August 2016 at 16:43, Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote: > Hi! > > 2016-08-29 8:17 GMT+02:00 Matt Oliver <protogonoi@gmail.com>: > > The fifo muxer works without pthreads due to the existing pthread > > wrappers already available within ffmpeg for other platforms. > > It should probably still depend on "threads" at least, assuming the > thread-wrapper we have provides enough threading features for the > muxer. > You are correct updated patch is attached. > How did you test this? > (How can I test?) > There is a FATE test already added for the fifo muxer. I used that to test for mingw and msvc.
Hi! 2016-08-29 9:00 GMT+02:00 Matt Oliver <protogonoi@gmail.com>: > On 29 August 2016 at 16:43, Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote: > >> How did you test this? >> (How can I test?) > > There is a FATE test already added for the fifo muxer. I used that to test > for mingw and msvc. What I meant is: If I remove pthreads from my system, fifo compilation fails, which imo implies that the patch is wrong. But I may miss something. Carl Eugen
On Mon, Aug 29, 2016 at 9:28 AM, Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote: > Hi! > > 2016-08-29 9:00 GMT+02:00 Matt Oliver <protogonoi@gmail.com>: >> On 29 August 2016 at 16:43, Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote: >> >>> How did you test this? >>> (How can I test?) >> >> There is a FATE test already added for the fifo muxer. I used that to test >> for mingw and msvc. > > What I meant is: > If I remove pthreads from my system, fifo compilation fails, which imo > implies that the patch is wrong. > But I may miss something. > Obviously it requires some sort of thread implementation, but that doesn't necessarily have to be pthreads, it could be w32threads. - Hendrik
On 29 August 2016 at 17:28, Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote: > Hi! > > 2016-08-29 9:00 GMT+02:00 Matt Oliver <protogonoi@gmail.com>: > > On 29 August 2016 at 16:43, Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote: > > > >> How did you test this? > >> (How can I test?) > > > > There is a FATE test already added for the fifo muxer. I used that to > test > > for mingw and msvc. > > What I meant is: > If I remove pthreads from my system, fifo compilation fails, which imo > implies that the patch is wrong. > But I may miss something. > The second version is the correct one. You need w32threads/os2threads enabled if not using pthreads.
2016-08-29 10:04 GMT+02:00 Matt Oliver <protogonoi@gmail.com>: > > The second version is the correct one. You need > w32threads/os2threads enabled if not using pthreads. Thank you! Carl Eugen
diff --git a/configure b/configure index 5c11040..e225b7d 100755 --- a/configure +++ b/configure @@ -2834,7 +2834,6 @@ dv_muxer_select="dvprofile" dxa_demuxer_select="riffdec" eac3_demuxer_select="ac3_parser" f4v_muxer_select="mov_muxer" -fifo_muxer_deps="pthreads" flac_demuxer_select="flac_parser" hds_muxer_select="flv_muxer" hls_muxer_select="mpegts_muxer"