diff mbox series

[FFmpeg-devel] doc/filters: added possible values to @item win_func

Message ID CAJp+Fr0izJd02FJu9_Ox0UTEAWVLOd2tUQsotxT6=n6kYcV4eg@mail.gmail.com
State New
Headers show
Series [FFmpeg-devel] doc/filters: added possible values to @item win_func | expand

Checks

Context Check Description
andriy/configurex86 warning Failed to apply patch
andriy/configureppc warning Failed to apply patch

Commit Message

Arif Driessen Sept. 28, 2021, 8:35 a.m. UTC 
Hello all, excited about my first patch! Documented the possible window
functions for `afftfilt`. Needs review/signing-off.

---
 doc/filters.texi | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

 Set window overlap. If set to 1, the recommended overlap for selected

Comments

Gyan Doshi Sept. 28, 2021, 12:41 p.m. UTC | #1 
On 2021-09-28 02:05 pm, Arif Driessen wrote:
> Hello all, excited about my first patch! Documented the possible window
> functions for `afftfilt`. Needs review/signing-off.

These should be formatted like they are in the surround filter for the 
option with the same name.

>
> ---
>   doc/filters.texi | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/doc/filters.texi b/doc/filters.texi
> index 0b7e21f7f8..0a04165f11 100644
> --- a/doc/filters.texi
> +++ b/doc/filters.texi
> @@ -1325,7 +1325,11 @@ Set window size. Allowed range is from 16 to 131072.
>   Default is @code{4096}
>
>   @item win_func
> -Set window function. Default is @code{hann}.
> +Set window function. Possible values are: @code{rect} @code{bartlett}
> @code{hamming}
> +@code{blackman} @code{welch} @code{flattop} @code{bharris} @code{bnuttall}
> +@code{bhann} @code{sine} @code{nuttall} @code{lanczos} @code{gauss}
> +@code{tukey} @code{dolph} @code{cauchy} @code{parzen} @code{poisson}
> +@code{bohman}. Default is @code{hann}.
>
>   @item overlap
>   Set window overlap. If set to 1, the recommended overlap for selected

Regards,
Gyan
Arif Driessen Sept. 28, 2021, 1:59 p.m. UTC | #2 
> These should be formatted like they are in the surround filter for the
option with the same name.

Good catch! Looking around, I see there are other filters too with a
win_func option. When I next get a moment (either later today or more
likely tomorrow) I'll double check with the code,
and add documentation for those too. if that sounds good to you.

Regards,
Arif Driessen

On Tue, Sep 28, 2021 at 2:42 PM Gyan Doshi <ffmpeg@gyani.pro> wrote:

>
>
> On 2021-09-28 02:05 pm, Arif Driessen wrote:
> > Hello all, excited about my first patch! Documented the possible window
> > functions for `afftfilt`. Needs review/signing-off.
>
> These should be formatted like they are in the surround filter for the
> option with the same name.
>
> >
> > ---
> >   doc/filters.texi | 6 +++++-
> >   1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/doc/filters.texi b/doc/filters.texi
> > index 0b7e21f7f8..0a04165f11 100644
> > --- a/doc/filters.texi
> > +++ b/doc/filters.texi
> > @@ -1325,7 +1325,11 @@ Set window size. Allowed range is from 16 to
> 131072.
> >   Default is @code{4096}
> >
> >   @item win_func
> > -Set window function. Default is @code{hann}.
> > +Set window function. Possible values are: @code{rect} @code{bartlett}
> > @code{hamming}
> > +@code{blackman} @code{welch} @code{flattop} @code{bharris}
> @code{bnuttall}
> > +@code{bhann} @code{sine} @code{nuttall} @code{lanczos} @code{gauss}
> > +@code{tukey} @code{dolph} @code{cauchy} @code{parzen} @code{poisson}
> > +@code{bohman}. Default is @code{hann}.
> >
> >   @item overlap
> >   Set window overlap. If set to 1, the recommended overlap for selected
>
> Regards,
> Gyan
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
Gyan Doshi Sept. 28, 2021, 2:56 p.m. UTC | #3 
On 2021-09-28 07:29 pm, Arif Driessen wrote:
>> These should be formatted like they are in the surround filter for the
> option with the same name.
>
> Good catch! Looking around, I see there are other filters too with a
> win_func option. When I next get a moment (either later today or more
> likely tomorrow) I'll double check with the code,
> and add documentation for those too. if that sounds good to you.
Sure. But let's start with this one.

Regards,
Gyan
Arif Driessen Sept. 29, 2021, 10:51 a.m. UTC | #4 
Here's your patch for `afftfilt` win_func. (copied from the surround
filter, but checked against the code to ensure it's correct). If you like
it, I'll do it for all the win_funcs.

---
 doc/filters.texi | 27 ++++++++++++++++++++++++++-
 1 file changed, 26 insertions(+), 1 deletion(-)

diff --git a/doc/filters.texi b/doc/filters.texi
index 568c2995bc..60403a628e 100644
--- a/doc/filters.texi
+++ b/doc/filters.texi
@@ -1325,7 +1325,32 @@ Set window size. Allowed range is from 16 to 131072.
 Default is @code{4096}

 @item win_func
-Set window function. Default is @code{hann}.
+Set window function.
+
+It accepts the following values:
+@table @samp
+@item rect
+@item bartlett
+@item hann, hanning
+@item hamming
+@item blackman
+@item welch
+@item flattop
+@item bharris
+@item bnuttall
+@item bhann
+@item sine
+@item nuttall
+@item lanczos
+@item gauss
+@item tukey
+@item dolph
+@item cauchy
+@item parzen
+@item poisson
+@item bohman
+@end table
+Default is @code{hann}.

 @item overlap
 Set window overlap. If set to 1, the recommended overlap for selected
Paul B Mahol Sept. 29, 2021, 10:58 a.m. UTC | #5 
On Wed, Sep 29, 2021 at 12:51 PM Arif Driessen <arifd86@gmail.com> wrote:

> Here's your patch for `afftfilt` win_func. (copied from the surround
> filter, but checked against the code to ensure it's correct). If you like
> it, I'll do it for all the win_funcs.
>

Better add separate section, and than link to it with each filter docs,
instead copy paste lines 100 times.

>
> ---
>  doc/filters.texi | 27 ++++++++++++++++++++++++++-
>  1 file changed, 26 insertions(+), 1 deletion(-)
>
> diff --git a/doc/filters.texi b/doc/filters.texi
> index 568c2995bc..60403a628e 100644
> --- a/doc/filters.texi
> +++ b/doc/filters.texi
> @@ -1325,7 +1325,32 @@ Set window size. Allowed range is from 16 to 131072.
>  Default is @code{4096}
>
>  @item win_func
> -Set window function. Default is @code{hann}.
> +Set window function.
> +
> +It accepts the following values:
> +@table @samp
> +@item rect
> +@item bartlett
> +@item hann, hanning
> +@item hamming
> +@item blackman
> +@item welch
> +@item flattop
> +@item bharris
> +@item bnuttall
> +@item bhann
> +@item sine
> +@item nuttall
> +@item lanczos
> +@item gauss
> +@item tukey
> +@item dolph
> +@item cauchy
> +@item parzen
> +@item poisson
> +@item bohman
> +@end table
> +Default is @code{hann}.
>
>  @item overlap
>  Set window overlap. If set to 1, the recommended overlap for selected
> --
> 2.30.2
>
>
>
> On Tue, Sep 28, 2021 at 4:56 PM Gyan Doshi <ffmpeg@gyani.pro> wrote:
>
> >
> >
> > On 2021-09-28 07:29 pm, Arif Driessen wrote:
> > >> These should be formatted like they are in the surround filter for the
> > > option with the same name.
> > >
> > > Good catch! Looking around, I see there are other filters too with a
> > > win_func option. When I next get a moment (either later today or more
> > > likely tomorrow) I'll double check with the code,
> > > and add documentation for those too. if that sounds good to you.
> > Sure. But let's start with this one.
> >
> > Regards,
> > Gyan
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> >
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
Arif Driessen Sept. 29, 2021, 5:52 p.m. UTC | #6 
> Better add separate section, and than link to it with each filter docs,
instead copy paste lines 100 times.

If we do add a separate section, I'm not sure where to put it. Perhaps
under "@chapter See Also"?

I thought about something like a "@chapter Common Filter Options", but this
makes it sound like they are common to all filters.
Paul B Mahol Sept. 29, 2021, 6:17 p.m. UTC | #7 
On Wed, Sep 29, 2021 at 7:52 PM Arif Driessen <arifd86@gmail.com> wrote:

> > Better add separate section, and than link to it with each filter docs,
> instead copy paste lines 100 times.
>
> If we do add a separate section, I'm not sure where to put it. Perhaps
> under "@chapter See Also"?
>
> I thought about something like a "@chapter Common Filter Options", but this
> makes it sound like they are common to all filters.
>

Name it various windowing functions, as it may be used for both video and
audio.


> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
Arif Driessen Sept. 30, 2021, 8:49 a.m. UTC | #8 
Okay. But is it a @chapter Various Windowing Functions (placed at the end
just before @chapter See Also and @chapter Authors) or a @section Various
Windowing Functions, that has to live under some chapter? (...Which?)

On Wed, Sep 29, 2021 at 8:17 PM Paul B Mahol <onemda@gmail.com> wrote:

> On Wed, Sep 29, 2021 at 7:52 PM Arif Driessen <arifd86@gmail.com> wrote:
>
> > > Better add separate section, and than link to it with each filter docs,
> > instead copy paste lines 100 times.
> >
> > If we do add a separate section, I'm not sure where to put it. Perhaps
> > under "@chapter See Also"?
> >
> > I thought about something like a "@chapter Common Filter Options", but
> this
> > makes it sound like they are common to all filters.
> >
>
> Name it various windowing functions, as it may be used for both video and
> audio.
>
>
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> >
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
Gyan Doshi Sept. 30, 2021, 8:53 a.m. UTC | #9 
On 2021-09-30 02:19 pm, Arif Driessen wrote:
> Okay. But is it a @chapter Various Windowing Functions (placed at the end
> just before @chapter See Also and @chapter Authors) or a @section Various
> Windowing Functions, that has to live under some chapter? (...Which?)

Just keep the current patch for now. I'll push and then consolidate.

>
> On Wed, Sep 29, 2021 at 8:17 PM Paul B Mahol <onemda@gmail.com> wrote:
>
>> On Wed, Sep 29, 2021 at 7:52 PM Arif Driessen <arifd86@gmail.com> wrote:
>>
>>>> Better add separate section, and than link to it with each filter docs,
>>> instead copy paste lines 100 times.
>>>
>>> If we do add a separate section, I'm not sure where to put it. Perhaps
>>> under "@chapter See Also"?
>>>
>>> I thought about something like a "@chapter Common Filter Options", but
>> this
>>> makes it sound like they are common to all filters.
>>>
>> Name it various windowing functions, as it may be used for both video and
>> audio.
>>
>>
>>> _______________________________________________
>>> ffmpeg-devel mailing list
>>> ffmpeg-devel@ffmpeg.org
>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>>
>>> To unsubscribe, visit link above, or email
>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Gyan Doshi Sept. 30, 2021, 10:50 a.m. UTC | #10 
On 2021-09-30 02:23 pm, Gyan Doshi wrote:
>
> On 2021-09-30 02:19 pm, Arif Driessen wrote:
>> Okay. But is it a @chapter Various Windowing Functions (placed at the 
>> end
>> just before @chapter See Also and @chapter Authors) or a @section 
>> Various
>> Windowing Functions, that has to live under some chapter? (...Which?)
>
> Just keep the current patch for now. I'll push and then consolidate.

Pushed as 3ee45027536c8a085b02844dd7469c9122bdc9ef

Gyan
Paul B Mahol Sept. 30, 2021, 10:50 a.m. UTC | #11 
On Thu, Sep 30, 2021 at 10:53 AM Gyan Doshi <ffmpeg@gyani.pro> wrote:

>
> On 2021-09-30 02:19 pm, Arif Driessen wrote:
> > Okay. But is it a @chapter Various Windowing Functions (placed at the end
> > just before @chapter See Also and @chapter Authors) or a @section Various
> > Windowing Functions, that has to live under some chapter? (...Which?)
>
> Just keep the current patch for now. I'll push and then consolidate.
>

Please revert your commit, I haven't approved your changes that duplicates
lines unneceassary.


>
> >
> > On Wed, Sep 29, 2021 at 8:17 PM Paul B Mahol <onemda@gmail.com> wrote:
> >
> >> On Wed, Sep 29, 2021 at 7:52 PM Arif Driessen <arifd86@gmail.com>
> wrote:
> >>
> >>>> Better add separate section, and than link to it with each filter
> docs,
> >>> instead copy paste lines 100 times.
> >>>
> >>> If we do add a separate section, I'm not sure where to put it. Perhaps
> >>> under "@chapter See Also"?
> >>>
> >>> I thought about something like a "@chapter Common Filter Options", but
> >> this
> >>> makes it sound like they are common to all filters.
> >>>
> >> Name it various windowing functions, as it may be used for both video
> and
> >> audio.
> >>
> >>
> >>> _______________________________________________
> >>> ffmpeg-devel mailing list
> >>> ffmpeg-devel@ffmpeg.org
> >>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >>>
> >>> To unsubscribe, visit link above, or email
> >>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> >>>
> >> _______________________________________________
> >> ffmpeg-devel mailing list
> >> ffmpeg-devel@ffmpeg.org
> >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >>
> >> To unsubscribe, visit link above, or email
> >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> >>
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
Gyan Doshi Sept. 30, 2021, 10:51 a.m. UTC | #12 
On 2021-09-30 04:20 pm, Paul B Mahol wrote:
> On Thu, Sep 30, 2021 at 10:53 AM Gyan Doshi <ffmpeg@gyani.pro> wrote:
>
>> On 2021-09-30 02:19 pm, Arif Driessen wrote:
>>> Okay. But is it a @chapter Various Windowing Functions (placed at the end
>>> just before @chapter See Also and @chapter Authors) or a @section Various
>>> Windowing Functions, that has to live under some chapter? (...Which?)
>> Just keep the current patch for now. I'll push and then consolidate.
>>
> Please revert your commit, I haven't approved your changes that duplicates
> lines unneceassary.
You don't maintain docs, I do.

Regards,
Gyan
Paul B Mahol Sept. 30, 2021, 10:58 a.m. UTC | #13 
On Thu, Sep 30, 2021 at 12:51 PM Gyan Doshi <ffmpeg@gyani.pro> wrote:

>
>
> On 2021-09-30 04:20 pm, Paul B Mahol wrote:
> > On Thu, Sep 30, 2021 at 10:53 AM Gyan Doshi <ffmpeg@gyani.pro> wrote:
> >
> >> On 2021-09-30 02:19 pm, Arif Driessen wrote:
> >>> Okay. But is it a @chapter Various Windowing Functions (placed at the
> end
> >>> just before @chapter See Also and @chapter Authors) or a @section
> Various
> >>> Windowing Functions, that has to live under some chapter? (...Which?)
> >> Just keep the current patch for now. I'll push and then consolidate.
> >>
> > Please revert your commit, I haven't approved your changes that
> duplicates
> > lines unneceassary.
> You don't maintain docs, I do.
>

You are self proclaimed maintainer only.
If you do not fix docs soon i will do it instead of you, with above commit
reverted.


>
> Regards,
> Gyan
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
Gyan Doshi Sept. 30, 2021, 11:03 a.m. UTC | #14 
On 2021-09-30 04:28 pm, Paul B Mahol wrote:
> On Thu, Sep 30, 2021 at 12:51 PM Gyan Doshi <ffmpeg@gyani.pro> wrote:
>
>>
>> On 2021-09-30 04:20 pm, Paul B Mahol wrote:
>>> On Thu, Sep 30, 2021 at 10:53 AM Gyan Doshi <ffmpeg@gyani.pro> wrote:
>>>
>>>> On 2021-09-30 02:19 pm, Arif Driessen wrote:
>>>>> Okay. But is it a @chapter Various Windowing Functions (placed at the
>> end
>>>>> just before @chapter See Also and @chapter Authors) or a @section
>> Various
>>>>> Windowing Functions, that has to live under some chapter? (...Which?)
>>>> Just keep the current patch for now. I'll push and then consolidate.
>>>>
>>> Please revert your commit, I haven't approved your changes that
>> duplicates
>>> lines unneceassary.
>> You don't maintain docs, I do.
>>
> You are self proclaimed maintainer only.
> If you do not fix docs soon i will do it instead of you, with above commit
> reverted.

Check the MAINTAINERS file.

Like I said earlier, I'll make a separate section soon.

Regards,
Gyan
Paul B Mahol Oct. 2, 2021, 9:55 p.m. UTC | #15 
On Thu, Sep 30, 2021 at 1:04 PM Gyan Doshi <ffmpeg@gyani.pro> wrote:

>
>
> On 2021-09-30 04:28 pm, Paul B Mahol wrote:
> > On Thu, Sep 30, 2021 at 12:51 PM Gyan Doshi <ffmpeg@gyani.pro> wrote:
> >
> >>
> >> On 2021-09-30 04:20 pm, Paul B Mahol wrote:
> >>> On Thu, Sep 30, 2021 at 10:53 AM Gyan Doshi <ffmpeg@gyani.pro> wrote:
> >>>
> >>>> On 2021-09-30 02:19 pm, Arif Driessen wrote:
> >>>>> Okay. But is it a @chapter Various Windowing Functions (placed at the
> >> end
> >>>>> just before @chapter See Also and @chapter Authors) or a @section
> >> Various
> >>>>> Windowing Functions, that has to live under some chapter? (...Which?)
> >>>> Just keep the current patch for now. I'll push and then consolidate.
> >>>>
> >>> Please revert your commit, I haven't approved your changes that
> >> duplicates
> >>> lines unneceassary.
> >> You don't maintain docs, I do.
> >>
> > You are self proclaimed maintainer only.
> > If you do not fix docs soon i will do it instead of you, with above
> commit
> > reverted.
>
> Check the MAINTAINERS file.
>

That file is seriously obsolete.


> Like I said earlier, I'll make a separate section soon.
>

Time it ticking.



>
> Regards,
> Gyan
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
Paul B Mahol Oct. 14, 2021, 7:05 p.m. UTC | #16 
will revert in next 96 hours.
Gyan Doshi Oct. 15, 2021, 4:11 a.m. UTC | #17 
On 2021-10-15 12:35 am, Paul B Mahol wrote:
> will revert in next 96 hours.

Devote time to something productive.

In any case, not all filters have identical lists. spectrumsynth 
supports limited functions. many don't recognize the string 'hann'. The 
defaults also vary.
Harmonize those first before we save 150 odd lines out of 28000 in 
filters.texi

Regards,
Gyan
Paul B Mahol Oct. 15, 2021, 8:11 a.m. UTC | #18 
On Fri, Oct 15, 2021 at 6:12 AM Gyan Doshi <ffmpeg@gyani.pro> wrote:

>
>
> On 2021-10-15 12:35 am, Paul B Mahol wrote:
> > will revert in next 96 hours.
>
> Devote time to something productive.
>

Great words you do not follow at all.


>
> In any case, not all filters have identical lists. spectrumsynth
> supports limited functions. many don't recognize the string 'hann'. The
> defaults also vary.
> Harmonize those first before we save 150 odd lines out of 28000 in
> filters.texi
>
> Regards,
> Gyan
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
diff mbox series

Patch

diff --git a/doc/filters.texi b/doc/filters.texi
index 0b7e21f7f8..0a04165f11 100644
--- a/doc/filters.texi
+++ b/doc/filters.texi
@@ -1325,7 +1325,11 @@  Set window size. Allowed range is from 16 to 131072.
 Default is @code{4096}

 @item win_func
-Set window function. Default is @code{hann}.
+Set window function. Possible values are: @code{rect} @code{bartlett}
@code{hamming}
+@code{blackman} @code{welch} @code{flattop} @code{bharris} @code{bnuttall}
+@code{bhann} @code{sine} @code{nuttall} @code{lanczos} @code{gauss}
+@code{tukey} @code{dolph} @code{cauchy} @code{parzen} @code{poisson}
+@code{bohman}. Default is @code{hann}.

 @item overlap