| Message ID | CAJp+Fr1f6PaRovks0VioVdqHf0tn-2brm=4Q0Oz6E2rgrpU3EQ@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel] README.md: fix typo | expand |
| Context | Check | Description |
|---|---|---|
| andriy/configurex86 | warning | Failed to apply patch |
| andriy/configureppc | warning | Failed to apply patch |
On 7 Oct 2021, at 12:40, Arif Driessen wrote: > Hi, > > I think this is a typo... > > --- > README.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/README.md b/README.md > index 447347c700..f54299d340 100644 > --- a/README.md > +++ b/README.md > @@ -9,7 +9,7 @@ such as audio, video, subtitles and related metadata. > * `libavcodec` provides implementation of a wider range of codecs. > * `libavformat` implements streaming protocols, container formats and > basic I/O access. > * `libavutil` includes hashers, decompressors and miscellaneous > utility > functions. > -* `libavfilter` provides a mean to alter decoded Audio and Video > through > chain of filters. > +* `libavfilter` provides a means to alter decoded Audio and Video > through > chain of filters. I think it's missing an article too: 'provides a means to alter decoded Audio and Video through a chain of filters' might be better here, alternatively: 'provides a means to alter decoded Audio and Video through a filtergraph'. > * `libavdevice` provides an abstraction to access capture and > playback > devices. > * `libswresample` implements audio mixing and resampling routines. > * `libswscale` implements color conversion and scaling routines.
> I think it's missing an article too: 'provides a means to alter decoded > Audio and Video through a chain of filters' might be better here, > alternatively: 'provides a means to alter decoded Audio and Video > through a filtergraph'. Yes, I did consider that, the problem was 'means' was critical to understanding (and not misunderstand 'mean' to mean something else), while the missing article wasn't critical, and at the same time I didn't want to presume i knew absolutely certain what 'chain of filters' means and that it needs an article. Filtergraph, however, is also consistent with the rest of the documentation and thus, to me, is preferred. Please take a look again, a couple more fixes: --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 447347c700..e5649236bf 100644 --- a/README.md +++ b/README.md @@ -6,10 +6,10 @@ such as audio, video, subtitles and related metadata. ## Libraries -* `libavcodec` provides implementation of a wider range of codecs. +* `libavcodec` provides an implementation of a wide range of codecs. * `libavformat` implements streaming protocols, container formats and basic I/O access. * `libavutil` includes hashers, decompressors and miscellaneous utility functions. -* `libavfilter` provides a mean to alter decoded Audio and Video through chain of filters. +* `libavfilter` provides a means to alter decoded Audio and Video through a filtergraph. * `libavdevice` provides an abstraction to access capture and playback devices. * `libswresample` implements audio mixing and resampling routines. * `libswscale` implements color conversion and scaling routines.
On 2021-10-07 04:10 pm, Arif Driessen wrote: > Hi, > > I think this is a typo... The patch is corrupt. But it's ok I'll apply it. Thanks, Gyan
On 2021-10-08 09:34 am, Gyan Doshi wrote: > > > On 2021-10-07 04:10 pm, Arif Driessen wrote: >> Hi, >> >> I think this is a typo... > > The patch is corrupt. But it's ok I'll apply it. Pushed as f79be02be0abb7f4264fdc8467639eea7cd23d62 Regards, Gyan
diff --git a/README.md b/README.md index 447347c700..f54299d340 100644 --- a/README.md +++ b/README.md @@ -9,7 +9,7 @@ such as audio, video, subtitles and related metadata. * `libavcodec` provides implementation of a wider range of codecs. * `libavformat` implements streaming protocols, container formats and basic I/O access. * `libavutil` includes hashers, decompressors and miscellaneous utility functions. -* `libavfilter` provides a mean to alter decoded Audio and Video through chain of filters. +* `libavfilter` provides a means to alter decoded Audio and Video through