From patchwork Thu Oct 13 01:53:30 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Muhammad Faiz X-Patchwork-Id: 983 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.140.66 with SMTP id o63csp89483vsd; Wed, 12 Oct 2016 18:53:43 -0700 (PDT) X-Received: by 10.28.129.9 with SMTP id c9mr202428wmd.54.1476323622947; Wed, 12 Oct 2016 18:53:42 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id w1si14221452wjv.42.2016.10.12.18.53.41; Wed, 12 Oct 2016 18:53:42 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7F2F7689BC8; Thu, 13 Oct 2016 04:53:38 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qt0-f182.google.com (mail-qt0-f182.google.com [209.85.216.182]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E0CCC6898B0 for ; Thu, 13 Oct 2016 04:53:31 +0300 (EEST) Received: by mail-qt0-f182.google.com with SMTP id f6so31590224qtd.2 for ; Wed, 12 Oct 2016 18:53:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=vVoDrBKbKzy3L0/OmTXZuftGQdtN+w9oCeKlZ5Jpzcw=; b=mH9yFhV2P1pAMpED00mrRr69FjpDGg5mGEdX8Gq3kryaMnB9O75nWLHatlvPOOGMsB 83MRXg2r/vtLEWzm8mwvBd9UUCQ8QUp7jZ/hOBm5jFcTwYiZwQUgUL5zzMqGaueLmBi/ fpZN7YEYb68uEXA7KBHwp+G+HkZQ249GpqcVwgG4pzvIunKvXzvnCeG4bW+DOK7tArFR 0faGR7K3oYD/1LUvFj3XHikKEw29A+ovtRPes5gBF1Ziqtt4fjMP2Kr3kbjYGBWN9MSi Uz2GzCnkPDR35KhUYw1mp8WDijb5XetU3RiMb7t0lCDLZbPi3G0ZMLHcCUddsel+bOvt 07IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=vVoDrBKbKzy3L0/OmTXZuftGQdtN+w9oCeKlZ5Jpzcw=; b=X33QL66g3wTnylAR+/7OjAJQCbmljlbMFED5k2mOANZv7MajNoq124XRmT5P0n2Daw SWVbdX8SQy5FlMTtNDktXpr9C8NSbHUb3d+0v4ITdjiO61Au7knaIV+E+D6eMXYkE80V VJ9cTefoQX1a25mMmj63Hb3QKl60LAJrEVUSCEwZxL9wPGdnfbrpBLMLEaBtbDQiKUtc aRfAp5orAFQLPHN0Fo+WQSXV2P2CHpu8s4h9g52CkdeHAjPJ2TpufJufTQXUMVFOj/41 e+e67I1bN/8biy9k+maLIo+WDo2xBsYZihZTp0jZRzQaZoJ5n/BzB0pEza8LL2aUTjb5 3zPA== X-Gm-Message-State: AA6/9RnloT6FFMv4AoV2xe/dzBALEqp7ewxO9DNPqk+uemyP2O1gWoEQOpffA1CqyE4a4SCVU2kORkSXupy46g== X-Received: by 10.200.43.233 with SMTP id n38mr3829342qtn.139.1476323611097; Wed, 12 Oct 2016 18:53:31 -0700 (PDT) MIME-Version: 1.0 Received: by 10.200.42.101 with HTTP; Wed, 12 Oct 2016 18:53:30 -0700 (PDT) In-Reply-To: <20161013011912.GN4602@nb4> References: <1476310478-2129-1-git-send-email-mfcc64@gmail.com> <20161013011912.GN4602@nb4> From: Muhammad Faiz Date: Thu, 13 Oct 2016 08:53:30 +0700 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] fate: add test for firequalizer filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On Thu, Oct 13, 2016 at 8:19 AM, Michael Niedermayer wrote: > On Thu, Oct 13, 2016 at 05:14:38AM +0700, Muhammad Faiz wrote: >> Signed-off-by: Muhammad Faiz >> --- >> tests/fate/filter-audio.mak | 10 ++++++++++ >> tests/filtergraphs/firequalizer | 27 +++++++++++++++++++++++++++ >> 2 files changed, 37 insertions(+) >> create mode 100644 tests/filtergraphs/firequalizer > > works on mingw liunx x86 32/64 > but fails on qemu arm > TEST filter-firequalizer > stddev: 0.68 PSNR: 99.68 MAXDIFF: 1 bytes: 1058400/ 1097208 > stddev: |0.68 - 0| >= 0.01 > Test filter-firequalizer failed. Look at tests/data/fate/filter-firequalizer.err for details. > make: *** [fate-filter-firequalizer] Error 1 > new patch with oneoff test patch attached thx From e25da07363c2126ac4642794f905678e95bf14a4 Mon Sep 17 00:00:00 2001 From: Muhammad Faiz Date: Thu, 13 Oct 2016 08:43:50 +0700 Subject: [PATCH] fate: add test for firequalizer filter Signed-off-by: Muhammad Faiz --- tests/fate/filter-audio.mak | 9 +++++++++ tests/filtergraphs/firequalizer | 27 +++++++++++++++++++++++++++ 2 files changed, 36 insertions(+) create mode 100644 tests/filtergraphs/firequalizer diff --git a/tests/fate/filter-audio.mak b/tests/fate/filter-audio.mak index 809bf4e..9c6f7cd 100644 --- a/tests/fate/filter-audio.mak +++ b/tests/fate/filter-audio.mak @@ -114,6 +114,15 @@ fate-filter-extrastereo: tests/data/asynth-44100-2.wav fate-filter-extrastereo: SRC = $(TARGET_PATH)/tests/data/asynth-44100-2.wav fate-filter-extrastereo: CMD = framecrc -i $(SRC) -aframes 20 -af extrastereo=m=2 +FATE_AFILTER-$(call FILTERDEMDECENCMUX, FIREQUALIZER ATRIM VOLUME, WAV, PCM_S16LE, PCM_S16LE, WAV) += fate-filter-firequalizer +fate-filter-firequalizer: tests/data/asynth-44100-2.wav +fate-filter-firequalizer: tests/data/filtergraphs/firequalizer +fate-filter-firequalizer: REF = tests/data/asynth-44100-2.wav +fate-filter-firequalizer: CMD = ffmpeg -i $(TARGET_PATH)/tests/data/asynth-44100-2.wav -filter_script $(TARGET_PATH)/tests/data/filtergraphs/firequalizer -f wav -acodec pcm_s16le - +fate-filter-firequalizer: CMP = oneoff +fate-filter-firequalizer: CMP_UNIT = s16 +fate-filter-firequalizer: SIZE_TOLERANCE = 1058400 - 1097208 + FATE_AFILTER_SAMPLES-$(call FILTERDEMDECENCMUX, SILENCEREMOVE, WAV, PCM_S16LE, PCM_S16LE, WAV) += fate-filter-silenceremove fate-filter-silenceremove: SRC = $(TARGET_SAMPLES)/audio-reference/divertimenti_2ch_96kHz_s24.wav fate-filter-silenceremove: CMD = framecrc -i $(SRC) -aframes 30 -af silenceremove=0:0:0:-1:0:-90dB diff --git a/tests/filtergraphs/firequalizer b/tests/filtergraphs/firequalizer new file mode 100644 index 0000000..ee432e2 --- /dev/null +++ b/tests/filtergraphs/firequalizer @@ -0,0 +1,27 @@ +firequalizer = + gain = 'sin(0.001*f) - 1': + delay = 0.05, + +firequalizer = + gain = 'if (ch, -0.7 * sin(0.001*f), -0.2 * sin(0.001*f)) - 1': + delay = 0.1: + fixed = on: + multi = on: + zero_phase = on: + wfunc = nuttall, + +firequalizer = + gain = 'if (ch, -0.3 * sin(0.001*f), -0.8 * sin(0.001*f)) - 1': + delay = 0.05: + multi = on, + +firequalizer = + gain_entry = 'entry(1000, 0); entry(5000, 0.1); entry(10000, 0.2)', + +firequalizer = + gain_entry = 'entry(1000, 0.2); entry(5000, 0.1); entry(10000, 0)', + +volume = 2.8dB, + +atrim = + start = 0.12 -- 2.5.0