From patchwork Fri Jun 2 12:59:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Kucera X-Patchwork-Id: 3794 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.10.2 with SMTP id 2csp182695vsk; Fri, 2 Jun 2017 05:59:23 -0700 (PDT) X-Received: by 10.28.4.203 with SMTP id 194mr3043630wme.118.1496408363078; Fri, 02 Jun 2017 05:59:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1496408363; cv=none; d=google.com; s=arc-20160816; b=s8C7L2CedQ0U1dMIoeFTvGfWxDyu/fpZ6+HT/3LF7ejkLQlC2Ree7ERLIPq9w0x7Qj g88xltUoJUUdaBbHq/xAZsuBpsX2VVvUceP+3Sci4S/0aUSTW/02yphIJ3rkbz8cgE12 xMKnsFxgKDzZIvoH/7ZKRjF8QkKF2/Dfaj7yG+f5/mWItSI8EzwBsZBb/jgobKMH0QeZ NGVD7bXkLLv61F8D4kyX4JlEbOORMDLsK6a65opk/nDLjXNaYrKg4ZHVihaW24TygWS0 v3AtVUSqo+YYL5Dhim6eDje6FystE4n97TpdkBGC6mZTezTjGc+MNE5stzjDRAoXhVei ncBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:to:message-id:date:from:references:in-reply-to :mime-version:dkim-signature:delivered-to:arc-authentication-results; bh=wW2Ba289TKj1tKyqYotgqRNK5mQNQ34ciPtd04lOQsI=; b=tSb/xHsIIYOpYddRveMQJQaxeDYooTZjehjEKvTQoWqXFJCNRXLSytEonFpN29Rrq0 4X63bYHMWeGGSajG4JxIxma3tK65CT+jK9wDrlOU+hI3K6aQQEk5X59LPFCx/GCjfOwA DAI2misuCAVOjBjrvzNMQnFN7kC0OEidjvDZrWbnuC/eXZZDTBvXsr2R0ALbB3vhWfOp NXYx6vuoyt/b30OxpMcq/uED3Hb+RpMoKQd7nSRemWHn/YkZJVyjGZyapfJvfBZms18y zV6Q0xoqrR2zzgXTW+rony0gp0KgEm1E9roqDtIkTLBZkORLk6Zdl3TUgH3QdMFSmYrs b8dg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id d81si2712992wmi.122.2017.06.02.05.59.22; Fri, 02 Jun 2017 05:59:23 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D856C689B4A; Fri, 2 Jun 2017 15:59:13 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2CA1B689980 for ; Fri, 2 Jun 2017 15:59:07 +0300 (EEST) Received: by mail-wm0-f54.google.com with SMTP id b84so25173663wmh.0 for ; Fri, 02 Jun 2017 05:59:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=XH0qm8iFMATKk5Fp2y3Uwf1NhZtE6VIw1BQLj60PSSA=; b=ZpT6rQt1dv5rkYOSPeZl1X3BnSgzeFNChTdOjHMO+zyIN1/qkDaC5FUSxX0VCWB5EY usTtIrZJIRnG0GX9gSwNFPT/OGpVdgQfjfTS1xKBE+TLkReIVwu8ZEkN/1qnTTD4PhFi WH7+WT8rWw6ekw5YKFiZSKtI3ipBLk52COR4wh9il2b44pYDofJhD27uWv10u7LZNL9q F9gaI1q06dh4bcrCZfN7654weVvTcQp7Q7GaQy0pG16aU2EWIXLC1THXB/FSIogPkF5Y IQO6V8LcdZH+/VTPhrzB7eJYDv3LqD8ATGqzvXMCHUHh56Ty2ZrhYHc8nNr5J2wHr5ZQ cvrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=XH0qm8iFMATKk5Fp2y3Uwf1NhZtE6VIw1BQLj60PSSA=; b=kkQQWc47XO03yOlKhYGKAjpJH8XaCMSj21obfOlLRUbS3nOehR4YMGW3LZRbkRCaeR lbyOe0zBHE+QB2XGfWfPQASsrmbDjhxmvRQG4HuaM3NlGKt4lAWIeCt8Llg+PxgcoTT0 5PCKh6J8ROwzodMViYEuSHyJpqnhzfHvPYaB2zVhrvL1516cFY/vDpNySpQvMakJ+tFC PQU9z7jO2LZFdZaBgJYKk2VIzE8FZ35tv5DB0QeC+H+RpQHL6uV2TMxYZP+t/rMD9evX S2xGhlgbV8jEcdgVlI70fo/1yGrL3JPKXRY/JhZ+RFjzqQABVA69gzfbIQD0HSYayf7X YlFw== X-Gm-Message-State: AODbwcAAv1NHsdiFuyajRvw0zt6rrjuivXtbkgSpVsnEar+8NQviz9EE XVK6Yv21GrKyWnGxtB/tmWOUbYCp5dVp X-Received: by 10.28.51.73 with SMTP id z70mr2704165wmz.65.1496408352102; Fri, 02 Jun 2017 05:59:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.161.138 with HTTP; Fri, 2 Jun 2017 05:59:11 -0700 (PDT) In-Reply-To: <20170602013142.GP4759@nb4> References: <20170601111213.31981-1-daniel.kucera@gmail.com> <20170602013142.GP4759@nb4> From: =?UTF-8?Q?Daniel_Ku=C4=8Dera?= Date: Fri, 2 Jun 2017 14:59:11 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" 2017-06-02 3:31 GMT+02:00 Michael Niedermayer : > On Thu, Jun 01, 2017 at 01:12:13PM +0200, Daniel Kucera wrote: >> Signed-off-by: Daniel Kucera >> --- >> libavformat/aviobuf.c | 18 ++++++++++-------- >> 1 file changed, 10 insertions(+), 8 deletions(-) > > breaks fate (infinte loops) > example fate-swr-resample-s32p-2626-8000 > Thanks Michael. Now I'm trying to pass fate. I've fixed some problems but don't have an idea why it won't pass following test. Does anyone have idea? TEST seek-cache-pipe ./tests/fate-run.sh fate-seek-cache-pipe "fate-suite/" "" "/home/danman/FFmpeg" 'cat fate-suite//gapless/gapless.mp3 | run libavformat/tests/seek cache:pipe:0 -read_ahead_limit -1' '' './tests/ref/seek/cache-pipe' '' '3' '' '' '' '' '' '' '' '' '' /home/danman/FFmpeg/libavformat/tests/seek cache:pipe:0 -read_ahead_limit -1 ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: 1451 size: 417 ret: 0 st: 0 flags:1 ts: 2.835837 -ret: 0 st: 0 flags:1 dts: 2.821224 pts: 2.821224 pos: 46590 size: 418 +ret: 0 st: 0 flags:1 dts: 1.933061 pts: 1.933061 pos: 32380 size: 388 ret: 0 st:-1 flags:0 ts: 1.730004 ret: 0 st: 0 flags:1 dts: 1.750204 pts: 1.750204 pos: 29454 size: 418 ret: 0 st:-1 flags:1 ts: 0.624171 @@ -28,7 +26,7 @@ ret: 0 st: 0 flags:0 ts:-0.481662 ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: 1451 size: 417 ret: 0 st: 0 flags:1 ts: 2.412505 -ret: 0 st: 0 flags:1 dts: 2.403265 pts: 2.403265 pos: 39903 size: 418 +ret: 0 st: 0 flags:1 dts: 1.933061 pts: 1.933061 pos: 32380 size: 388 ret: 0 st:-1 flags:0 ts: 1.306672 ret: 0 st: 0 flags:1 dts: 1.332245 pts: 1.332245 pos: 22766 size: 418 ret: 0 st:-1 flags:1 ts: 0.200839 @@ -36,12 +34,11 @@ ret: 0 st: 0 flags:0 ts:-0.904994 ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: 1451 size: 417 ret: 0 st: 0 flags:1 ts: 1.989173 -ret: 0 st: 0 flags:1 dts: 1.985306 pts: 1.985306 pos: 33215 size: 418 +ret: 0 st: 0 flags:1 dts: 1.933061 pts: 1.933061 pos: 32380 size: 388 ret: 0 st:-1 flags:0 ts: 0.883340 ret: 0 st: 0 flags:1 dts: 0.888163 pts: 0.888163 pos: 15661 size: 418 ret:-1 st:-1 flags:1 ts:-0.222493 -ret: 0 st: 0 flags:0 ts: 2.671674 -ret: 0 st: 0 flags:1 dts: 2.690612 pts: 2.690612 pos: 44500 size: 418 +ret:-1 st: 0 flags:0 ts: 2.671674 ret: 0 st: 0 flags:1 ts: 1.565841 ret: 0 st: 0 flags:1 dts: 1.541224 pts: 1.541224 pos: 26110 size: 418 ret: 0 st:-1 flags:0 ts: 0.460008 Test seek-cache-pipe failed. Look at tests/data/fate/seek-cache-pipe.err for details. [cache @ 0x56224fd448e0] Inner protocol failed to seekback end : -38 [cache @ 0x56224fd448e0] Inner protocol failed to seekback end : -38 [mp3 @ 0x56224fd44040] invalid concatenated file detected - using bitrate for duration [cache @ 0x56224fd448e0] Inner protocol failed to seekback end : -38 [cache @ 0x56224fd448e0] Inner protocol failed to seekback end : -38 [cache @ 0x56224fd448e0] Inner protocol failed to seekback end : -38 [cache @ 0x56224fd448e0] Statistics, cache hits:0 cache misses:8 tests/Makefile:221: recipe for target 'fate-seek-cache-pipe' failed make: *** [fate-seek-cache-pipe] Error 1 Thank you. S pozdravom / Best regards Daniel Kucera. --- ./tests/ref/seek/cache-pipe 2017-05-23 17:02:08.517401755 +0200 +++ tests/data/fate/seek-cache-pipe 2017-06-02 14:30:41.555138153 +0200 @@ -6,21 +6,19 @@ ret: 0 st: 0 flags:0 ts: 0.788334 ret: 0 st: 0 flags:1 dts: 0.809796 pts: 0.809796 pos: 14407 size: 418 ret:-1 st: 0 flags:1 ts:-0.317499 -ret: 0 st:-1 flags:0 ts: 2.576668 -ret: 0 st: 0 flags:1 dts: 2.586122 pts: 2.586122 pos: 42828 size: 418 +ret:-1 st:-1 flags:0 ts: 2.576668 ret: 0 st:-1 flags:1 ts: 1.470835 ret: 0 st: 0 flags:1 dts: 1.462857 pts: 1.462857 pos: 24856 size: 418 ret: 0 st: 0 flags:0 ts: 0.365002 ret: 0 st: 0 flags:1 dts: 0.365714 pts: 0.365714 pos: 7302 size: 418 ret:-1 st: 0 flags:1 ts:-0.740831 -ret: 0 st:-1 flags:0 ts: 2.153336 -ret: 0 st: 0 flags:1 dts: 2.168163 pts: 2.168163 pos: 36141 size: 418 +ret:-1 st:-1 flags:0 ts: 2.153336 ret: 0 st:-1 flags:1 ts: 1.047503 ret: 0 st: 0 flags:1 dts: 1.044898 pts: 1.044898 pos: 18169 size: 418 ret: 0 st: 0 flags:0 ts:-0.058330