From patchwork Fri Jan 26 07:03:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: rshaffer@tunein.com X-Patchwork-Id: 7419 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.156.27 with SMTP id q27csp336339jak; Thu, 25 Jan 2018 23:09:59 -0800 (PST) X-Google-Smtp-Source: AH8x226TkqhrLslJs6aRnw6CkO5Mb1W/6rlJfpQgFw/PuaKMCszZBhIxu54QXOB3Ulbi5WtnTNcg X-Received: by 10.223.131.166 with SMTP id 35mr10294645wre.221.1516950599706; Thu, 25 Jan 2018 23:09:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516950599; cv=none; d=google.com; s=arc-20160816; b=F09W598Ycf4lDuBaVJgZilSeejbSHqg88geyjutFij++hJX6yiw8kfi9H1JpJeGxcx WlqtMu0hf+/D8DczB+tbJES64gWA485G9tUwzB+dIsEY+Z60u1yECrOAmFMkv5kPUclW GUNTx+EtTKWLmfD82BBUhgX6e2G//+k4WMtp2SgA4iP2WMagkxaCyxdO2285WCCyrDEJ gRUcUpXW9K9jzuZoY94kTRyi7NTAK96ROnUSk2bvplJPYNQkh6C29mMBG9FOFrlxLip4 NJwmWVzEXJvryeuwg6OHoebIJn0TAIES0uJHBKBFc1K0oyP6B+6b1NiD9zn2dl2tO7vp CAMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:to :message-id:date:from:mime-version:dkim-signature:delivered-to :arc-authentication-results; bh=bM2RRqPFWU+QzKqpmUEgnq+JHequokSZrO0XDMW+siw=; b=sSuQ/DtacoXUZybFbPbbHAlKv8FaFH3sRWSpmymyFkRHc93tU3TWKYKLFCHbWLYJrp afEK++Wxw8C6JS2fZNymPMX7sUAH3EsVINnittyooAdTKtavRkFeFo08TIEzt+oX27Ly GhQDCdGx2pMMuY7RCELnIDUhUmIxzv/t0FzFsW/lkVlQuMoofAib2wyfaKDrmV7DFv3Q EOSN592EKp/Xr3gw95IOq50Tdrd0qTTUWhlju9NSruI5oeImcgkgxxvXOuy+3K4kY9Lt HW1XHDOZ5ARs1hDs7etCpwvIHWG4fjwv/AVAh793uM9aAEV7DQwTIw63rAhmXfcICGIb h4Pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@tunein-com.20150623.gappssmtp.com header.s=20150623 header.b=vWjjicXE; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id f13si2029773wmc.15.2018.01.25.23.09.58; Thu, 25 Jan 2018 23:09:59 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@tunein-com.20150623.gappssmtp.com header.s=20150623 header.b=vWjjicXE; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B7C5D689834; Fri, 26 Jan 2018 09:09:53 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qt0-f175.google.com (mail-qt0-f175.google.com [209.85.216.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1B7336883DC for ; Fri, 26 Jan 2018 09:09:47 +0200 (EET) Received: by mail-qt0-f175.google.com with SMTP id z10so25520485qti.5 for ; Thu, 25 Jan 2018 23:09:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tunein-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=uZOe+j3poXXSNTqnTxWrnnSPHq+6tWEiDNdqUAtN+FA=; b=vWjjicXEQrzO5SzQchIrs+08fEEZ6t/Lj1NO+sY1fOvOQ5Q67RqMiREKViOJxZZhjU o4yZC9Lg4X90mkaB3/hidy/lLcfuQkcgjoRKcNQ7aOsd1ceYT862DtnSe6VEixuuXu7q bcxtr/dVWlc8eWwtK2DQy6QBGVfAT60KfLhNZ6hmAJXk0YRiLapmSNtRK+oOPKHUrTq1 gfEznPvORkgpZ1iKGhfE7S45lLnFaFbKIFyl/vzLhu5LLMM/Hn4DL1McUex59YTMGxkn 9aeGQNv5RkAXuCIFf+/SY/n0kaIf/RgcqCYwXYAt/zeVjk89HV42BxJ/oGLHY7Gse/Eb swSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=uZOe+j3poXXSNTqnTxWrnnSPHq+6tWEiDNdqUAtN+FA=; b=EgX7+fy9jmQNCEN+nBP8fMaNM/m2OFX2WbTOsosIOV9vRogsVIfKi4C0Rm5wIp4pPZ o0vDiHP1u5Yxyu3J+WdxBfELZ2ybaVa9WbzApRpG7L8Wtu5JNp6f5UG2ltFFlDukgEc6 e/sZc24FmP0F3WM8PMSXghVgfHOIFrdWtv0XHq744W+i1riLTANfa1UdikyAdk353uf1 L5RLmxr2oOIxBhw+d83crbdbO1PW5eM9gj/GD2Cokijr2+1HFovJAKmXEzHENXLvnTkI UWNnbnv5iBwFxotSyqaJqGqeGS5+qFBAW14oQxskGW4t5+1l+WaQYta6D84cBCgVxdrA nQhA== X-Gm-Message-State: AKwxytdYIC6e1+K2VHQhL19sDk+WMTi/O2zCLiYoDEQe/DGGWAYDCToP abzcnHkhmBBMlArQWqfzBLKgTot4dGdjIFvHytbC5UNdixg= X-Received: by 10.233.230.67 with SMTP id x3mr7974199qkl.202.1516950193830; Thu, 25 Jan 2018 23:03:13 -0800 (PST) MIME-Version: 1.0 Received: by 10.200.3.174 with HTTP; Thu, 25 Jan 2018 23:03:13 -0800 (PST) From: Richard Shaffer Date: Thu, 25 Jan 2018 23:03:13 -0800 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] fate: add id3v2 test X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From f7398407c1f5822e1536ce03d46c885b2ad00c38 Mon Sep 17 00:00:00 2001 From: Richard Shaffer Date: Thu, 25 Jan 2018 19:54:59 -0800 Subject: [PATCH] fate: add id3v2 test Adds basic unit test for parsing ID3v2 tags. --- This follows the suggestion to use the ffprobe utility instead of a test program. The required test sample is attached. -Richard tests/Makefile | 1 + tests/fate-run.sh | 4 ++++ tests/fate/id3v2.mak | 6 ++++++ tests/ref/fate/id3v2-read | 5 +++++ 4 files changed, 16 insertions(+) create mode 100644 tests/fate/id3v2.mak create mode 100644 tests/ref/fate/id3v2-read diff --git a/tests/Makefile b/tests/Makefile index 14b9601378..327e3f4420 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -130,6 +130,7 @@ include $(SRC_PATH)/tests/fate/gapless.mak include $(SRC_PATH)/tests/fate/gif.mak include $(SRC_PATH)/tests/fate/h264.mak include $(SRC_PATH)/tests/fate/hevc.mak +include $(SRC_PATH)/tests/fate/id3v2.mak include $(SRC_PATH)/tests/fate/image.mak include $(SRC_PATH)/tests/fate/indeo.mak include $(SRC_PATH)/tests/fate/libavcodec.mak diff --git a/tests/fate-run.sh b/tests/fate-run.sh index 05f4ca5e20..82862b7ef4 100755 --- a/tests/fate-run.sh +++ b/tests/fate-run.sh @@ -88,6 +88,10 @@ probefmt(){ run ffprobe${PROGSUF} -show_entries format=format_name -print_format default=nw=1:nk=1 -v 0 "$@" } +probetags(){ + run ffprobe${PROGSUF} -show_entries format_tags -v 0 "$@" +} + runlocal(){ test "${V:-0}" -gt 0 && echo ${base}/"$@" ${base} >&3 ${base}/"$@" ${base} diff --git a/tests/fate/id3v2.mak b/tests/fate/id3v2.mak new file mode 100644 index 0000000000..af60ee12b5 --- /dev/null +++ b/tests/fate/id3v2.mak @@ -0,0 +1,6 @@ +ID3V2_TEST_FILE=tests/data/id3v2-test.mp3 + +FATE_SAMPLES_ID3V2-$(CONFIG_MP3_DEMUXER) += fate-id3v2-read +fate-id3v2-read: CMD = probetags $(TARGET_SAMPLES)/id3v2/id3v2-test.mp3 + +FATE_SAMPLES_FFPROBE += $(FATE_SAMPLES_ID3V2-yes) \ No newline at end of file diff --git a/tests/ref/fate/id3v2-read b/tests/ref/fate/id3v2-read new file mode 100644 index 0000000000..965c8695e8 --- /dev/null +++ b/tests/ref/fate/id3v2-read @@ -0,0 +1,5 @@ +[FORMAT] +TAG:title=id3v2-test +TAG:id3v2_priv.testowner=testdata +TAG:id3v2_priv.testowner2=\x00\x01\x02 +[/FORMAT]