From patchwork Wed Apr 19 15:07:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alessandro Bono X-Patchwork-Id: 41249 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:4645:b0:e3:3194:9d20 with SMTP id eb5csp557286pzb; Wed, 19 Apr 2023 08:08:21 -0700 (PDT) X-Google-Smtp-Source: AKy350YggVs1pFNHikg/AbHHs1xntAJ9YfaNHcQVy7Dl6TUrloPuoENp3SFTpEff713YPNFasjrN X-Received: by 2002:a05:6402:254c:b0:4ea:a9b0:a518 with SMTP id l12-20020a056402254c00b004eaa9b0a518mr2904511edb.17.1681916900984; Wed, 19 Apr 2023 08:08:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681916900; cv=none; d=google.com; s=arc-20160816; b=CSeFMhXxImvU34amXtmVC5Ks9vDQIWJvJz/TRS8tEcxXBbq07GGn4H5HiLjeS/Nk3B SKeSQppzOTSBBl3v1+8GRmYG240O7IJHM12FWRupALJ8wlvrbWp1r6fBQc02ESHafSd/ bd0yFxlqdCuaiajSBYyGan9dTj6d6GLGhioDOwkncwjCL5UcvGYlzso1bZGGbc5zZ85F jh32lXPv/SQB9bm2sgAn0p/bbD8dedSoAcvND3u70nLIKryRGlmw8cj/DrsGBIkHYBMD zlufM7C46T0XuZIwOJexJxhQmaFVcaVmps20dvSjHqyzajqiCiwNGs33LgI6y5PwiYja Dd0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:to :message-id:date:from:mime-version:dkim-signature:delivered-to; bh=4gunX0nEzvNFDx7b/G5vv2XHS9a/EQol1woz2lShb+o=; b=cYX2eXOwenMdil3KzJPKKuKAMMGmPRMi8XbQSjW6iYcPpflb89x3/gzRgY1fe6LfZp nAjilpDAQRbIkGJIq69y5TM8Q/nIxA34w8EOvISvJEk7aPPho8JN8lLHbIO4VsMs78HE pULIWU4Xai0MVY3ksATb0iQxiSsrjaoW19E6I/2JunpoujD1ks9+CRDQfAYC1M52eiOj qpRfLSr+wTeTXRGOnWTtw9LxqvoOkuakooSouCLOiqT6wSYEDTD3efXczxISGBQeJSQb xlGAQFeQyROoDXAKvDYvOGplPWqmrM3d95HiyMw/SRR8AHL7urteptxULrE5hR15Rlin orBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20221208 header.b="KNcq3/Mr"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id bt2-20020a0564020a4200b005050661fdfcsi14856908edb.451.2023.04.19.08.08.18; Wed, 19 Apr 2023 08:08:20 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20221208 header.b="KNcq3/Mr"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8324468BE34; Wed, 19 Apr 2023 18:08:16 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-oo1-f51.google.com (mail-oo1-f51.google.com [209.85.161.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7FD4368BE34 for ; Wed, 19 Apr 2023 18:08:09 +0300 (EEST) Received: by mail-oo1-f51.google.com with SMTP id 006d021491bc7-541b69a8355so657474eaf.2 for ; Wed, 19 Apr 2023 08:08:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681916887; x=1684508887; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=tIRCCOMtXpmVGBw/Rlq9Jzk//dvRAwpcRevd+day+tM=; b=KNcq3/MrYsqOoTRrAlQt8ldqZH6/kWO/MIJzAbolf5usE88aMp1JNkm14gI4YCv4xW n//Rf6exrKhYoTP+Dhd0++WDXtMrySxXdN1IHqMoBQ7XJ6d3Z3GiZVC9h5lN91j0hjLG lYd5J2/nhrUYevFL2WOORmqweKD66Vf3EVXWEXhsCdbJT2t0kdlVO4LBxWNYNgnaAxvT 2zLb5Z3BmA3G0uHzONpuAsgOLYjvRwpa6eMBHRdZjaicJp9r9dLtU9T2lT518kC3BQYt BWrNoZZPFnBApeLhwvvgWXeEkOFIYNL+hGO8H8UqnGsIEjcrLSHZVyd/tNAGwSoklLjA KjpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681916887; x=1684508887; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=tIRCCOMtXpmVGBw/Rlq9Jzk//dvRAwpcRevd+day+tM=; b=I75Pdnt2e3iKQ0Hj5nxIxjrgdfAW5jpkZ+bSi96xt0H92DLKiyfAr5qwW2JfiYi3f8 2clyH4GtuJgiWJ05RaZX7Tm+w9ZTwax+VUnkBuIj5IDah2v7Kshlzk6Li5uuukp9hzqT fqp1n7X0RVMIaNek2FjTlKcwL460x613XaVofSu2VyFUZHTO46N0T7utROEEDyJbAPq9 iPmSu7XiJ7guaxaMMpGTvCnshSKESgrHEUxfTBy+6ucJrjotvm+xlS8G751ILr4e83zd 7M52oBxzSrxM/BKUuei41U5hALMcM/5Iwkj1BKetB0nU9M+5ic+TQ3xTvpPbaP8Epy8J qsFA== X-Gm-Message-State: AAQBX9cLq4rh366GPvi18QuzMMxt7BuqzMSvSD5ZyZFGRDSFhOH/szor 0oi3fwmUa/XQMX5ASMnhYIyQJqyK6Wx6yiQw2M5qD6T/bMTFxA== X-Received: by 2002:aca:efc4:0:b0:38c:6afd:931c with SMTP id n187-20020acaefc4000000b0038c6afd931cmr1297435oih.8.1681916887634; Wed, 19 Apr 2023 08:08:07 -0700 (PDT) MIME-Version: 1.0 From: Alessandro Bono Date: Wed, 19 Apr 2023 17:07:56 +0200 Message-ID: To: ffmpeg-devel@ffmpeg.org X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [FFmpeg-devel] [PATCH] 0001-libavutil-tx-Check-also-for-ARCH_X86.patch X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: VGJkm9tbDm2B Fallout from 9787005846893c1d1c01cb8ac71abed91980b218. While it doesn't make sense to pass --enable-x86asm option in a arm64 build, this is the only place where we don't check also for ARCH_X86 when we check for HAVE_X86ASM in code that is not x86-specific. As a consequence we get: ``` Undefined symbols for architecture arm64: "_ff_tx_codelet_list_float_x86", referenced from: _codelet_list in tx.o ld: symbol(s) not found for architecture arm64 clang: error: linker command failed with exit code 1 (use -v to see invocation) ``` From c20c9ee960d23e5ca234e142f98f9a5c56243546 Mon Sep 17 00:00:00 2001 From: Alessandro Bono Date: Tue, 18 Apr 2023 17:16:36 +0200 Subject: [PATCH] libavutil/tx: Check also for ARCH_X86 Fallout from 9787005846893c1d1c01cb8ac71abed91980b218. While it doesn't make sense to pass --enable-x86asm option in a arm64 build, this is the only place where we don't check also for ARCH_X86 when we check for HAVE_X86ASM in code that is not x86-specific. As a consequence we get: ``` Undefined symbols for architecture arm64: "_ff_tx_codelet_list_float_x86", referenced from: _codelet_list in tx.o ld: symbol(s) not found for architecture arm64 clang: error: linker command failed with exit code 1 (use -v to see invocation) ``` --- libavutil/tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/tx.c b/libavutil/tx.c index e25abf998f..fb9d9f477a 100644 --- a/libavutil/tx.c +++ b/libavutil/tx.c @@ -341,7 +341,7 @@ static const FFTXCodelet * const * const codelet_list[] = { ff_tx_codelet_list_double_c, ff_tx_codelet_list_int32_c, ff_tx_null_list, -#if HAVE_X86ASM +#if ARCH_X86 && HAVE_X86ASM ff_tx_codelet_list_float_x86, #endif #if ARCH_AARCH64 -- 2.34.1