From patchwork Sat Oct 10 17:25:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Zivkovic, Milos" X-Patchwork-Id: 22835 Delivered-To: andriy.gelman@gmail.com Received: by 2002:a05:6902:1005:0:0:0:0 with SMTP id w5csp192883ybt; Sat, 10 Oct 2020 10:25:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyjxOYvNmKNspIYfa+oHST7TjTXYbh0sCgcxA09FBp8Ib03QYDR7uyq/zmgRDGhYY9b+2Ev X-Received: by 2002:adf:a31c:: with SMTP id c28mr22071658wrb.351.1602350746312; Sat, 10 Oct 2020 10:25:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602350746; cv=none; d=google.com; s=arc-20160816; b=UB+8EvOto97/yFmiz8tWrBWH9lUQD2UnasIlwEa5Q3M8rqINq9eH7NsuMYrZ6UgxX4 lF+uTMlFRYjWXuOgyB2zqRRzGAYRPmExH8KreAKjR+ghpmXxJ1o/aGbsdp9Jd+43FNZZ ZJ0dRsdpenXhUWgHx2g3CcsSohzLDuykQ9m+OFHTCe+ymV4dQn2fbu9+Byn66DitBWsR xpkOHz65T+sXtB8TxKlr1LT3UrKoslEu89RzolNFNEklVP2l70yyCqSKldn0DFZwExs4 iIobmveYsEqAuJolxI4vhexqj8YhloODcMiJMi1o8MzybQZ5tJofCld/P8ue2wBp2c82 Hnpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:to :message-id:date:from:mime-version:dkim-signature:delivered-to; bh=WONXEQyyYkZGQbxsX9/0wLFZjCrjnZFgTm16zXS2f4g=; b=JqOoSia1tmi7ArAANn7Sz/NlCQp+TPCbhISbp2jCzPii3leJfZaA7R8ElZPbMZ0gNH IDk7CjbQbE+3uNk8usgGK3MpK8ih+0BTGPd1YxBxf5pp4+zWTnCwCil+Wi7bZoDZ+wzC M0fWLXRk65/rjHwSJE30Lpi7p2XXyl7RoZtNKkwaDTLfXnrO4LnprVGh68PqJ8OTqg/h 5PB7gxHfgaIdDdsvjV5qll7aVFJlrayBizUWPBz63HdfYceY0nbM+Z4kRsqKJAqraUy4 LXg+54rKC1a73RdSJiP9IGA/rOJ+wQPo8FAh4z+ZeW+mU4jjVjPFCkxzkYBoonuU2RaV d1/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@teralogics-com.20150623.gappssmtp.com header.s=20150623 header.b=DRz0qhoS; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id q22si10599528wmq.150.2020.10.10.10.25.45; Sat, 10 Oct 2020 10:25:46 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@teralogics-com.20150623.gappssmtp.com header.s=20150623 header.b=DRz0qhoS; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 03DDC68B9C0; Sat, 10 Oct 2020 20:25:41 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com [209.85.210.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1AF5D68B9C0 for ; Sat, 10 Oct 2020 20:25:33 +0300 (EEST) Received: by mail-ot1-f52.google.com with SMTP id d28so11995752ote.1 for ; Sat, 10 Oct 2020 10:25:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=teralogics-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=uhusdQcUE1e3O3mqdeyH4vTlBL5peyUqKuGIwAW2LGk=; b=DRz0qhoStOa3zEi9evr8pyLAGun2odJt2p2XQ05IAIeHxXLrFFXhFMc+aCDWU5F8QK 9ojWwIybxvAafnoYKa+eJFTz7m3/wv1cuCBtATYGZztNhJPxIs9MU9ZssyC4/crw83y/ Xr9BCuvuZeDsfKuqCV3AY4Dt3cgth/tp2yvX3ZYcgkxG9ZXgrYhT+b3H3LoKRoaGV/ov opXeUB5eNIjT+ujtEJ4ELpTFQdHUA9AJCE8az5Lu3IpXBp7LnordiWFrwR9Kc2dawdad TyjJJAC8uIETiaI3olHMj7UNydYoCjQpx5mzYqEol9XWfVZ9E01GT7R+Iu8GqAYu92FB l1sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=uhusdQcUE1e3O3mqdeyH4vTlBL5peyUqKuGIwAW2LGk=; b=PYAqa4sY+XtUHGGdJSq8ZXtSGi1UM8mAlj0GnCPqrf0HlXzW3AiYx3Icw49bmWbvH5 3zPAlrZGlarZE5sktOradPScaFr9a6M09MhYGaifkHll9y7pBuO2NDNRTN7jBaR1AYUy j+nX9nxHYrPd/ijPMls8C2OJ16Xt41yqIFoa/GxZrZZx/CeheGtblfKuvNKqz4ZTSHpk yvulRFtAg4GOVdyMHjviQYppYD+FCV+Kqxfp86ddNND0rSwWtWzWSt61ObYoL6S5uNAo 7tKSjwVOPsWI5DKOfzPorPAgVSpdT4vXMFOQVIk/F5RmTodTMzztgdcAbCxKdaSljo47 /Csg== X-Gm-Message-State: AOAM530BDmbpseXbSSoxwcIkNJl2u6wMo3Fc53WeJhuvNugGX1utC5I/ X91iI97oNRq6cVY8zEC1MMXKSIBmjaqg993srp6qkQJPYzcO X-Received: by 2002:a05:6830:22f1:: with SMTP id t17mr11799544otc.239.1602350732175; Sat, 10 Oct 2020 10:25:32 -0700 (PDT) MIME-Version: 1.0 From: "Zivkovic, Milos" Date: Sat, 10 Oct 2020 19:25:19 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] avcodec/qsvenc: clear mfx frame type in submit_frame X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: gBdT7JeBj9XR Hello, I've attached a patch that clears the mfxEncodeCtrl::FrameType field. Since QSVFrames are reused, this field can affect not only the frame it was supposed to affect, but also the subsequent ones. It would be enough to force a keyframe only once and that QSVFrame will have the FrameType field set until the end of times. Once that QSVFrame gets reused the output frame will also be a keyframe, even though that might not have been requested. Subject: [PATCH] avcodec/qsvenc: clear mfx frame type in submit_frame Signed-off-by: Milos Zivkovic --- libavcodec/qsvenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index 1ed8f5d..f1b8994 100644 --- a/libavcodec/qsvenc.c +++ b/libavcodec/qsvenc.c @@ -1371,6 +1371,7 @@ static int submit_frame(QSVEncContext *q, const AVFrame *frame, } qf->surface.Data.TimeStamp = av_rescale_q(frame->pts, q->avctx->time_base, (AVRational){1, 90000}); + qf->enc_ctrl.FrameType = MFX_FRAMETYPE_UNKNOWN; *new_frame = qf;