From patchwork Mon Jul 10 22:04:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran O Leary X-Patchwork-Id: 4292 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.1.76 with SMTP id 73csp4129446vsb; Mon, 10 Jul 2017 15:04:45 -0700 (PDT) X-Received: by 10.223.155.222 with SMTP id e30mr9093462wrc.55.1499724285797; Mon, 10 Jul 2017 15:04:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1499724285; cv=none; d=google.com; s=arc-20160816; b=FQMvE9uizr96OGhP+UhFd4Zt9rU/xbAAkC3vofAriW06UZREbPW0auTzaxWm6SzONN aU9Duruhw0ZhFriuvjjvVcqJnTj5vB2XkQC9BeggPCr1um/UnvvrCXEYOVkwxjL9fPr2 /BWcVf0v3tDctoR3msznhcf+OrOHp8o9cLquqRHWr340ZTnYgcTCzA6lWTgLIqkYDG1X yLlXXg+EUleCFWDslGclSE3XGtMwRLULs1qotP5P54z4GUw6HqZdRe01tTZ9QJHUHcDH sqMOMoCIwHwrI6G0x6stDpA4PC0f459MEJi73Bs00waISd/Z7tja8HXZKWRukpYxOKbH ML2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:to :message-id:date:from:mime-version:dkim-signature:delivered-to :arc-authentication-results; bh=4eK955jg4txiSeAXHgZYvuCa1t95+HpSUaeJdmUxmKo=; b=TjRUQhcWwvrFgs6PfhFYDCjQ0n6W9v4+oA9XAoDi1nBv5p69V8apHQf4ovKmqGgUzI mVeTPMlAkcdlUhNFGP6XjPKHaCccaidV+dFfV4UJBgKo6UaXkAbG5z457hVbIw6WzI+l ZiTviaPpKLPs92AomiBFIq8rXNKmQzFe05AJjhfTuUg5ZvP1m7ycenP9tyq8MbBGhd2b dcc1omMQmA3WJw3kwz7MQAip0SBESy90wI5n/odeAWaYO+RvVXe3aoLUA5yqIRImHgU8 QzYTTegYpD29wmwSco+4oSZ5dUGvzDsvzK3Ig0iXr3P40ilGfiuNVYMgztpsoNWRvaHb CQFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.b=Azjbpw/g; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id z18si8813643wrc.253.2017.07.10.15.04.45; Mon, 10 Jul 2017 15:04:45 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.b=Azjbpw/g; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5C31B689E31; Tue, 11 Jul 2017 01:04:38 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qk0-f175.google.com (mail-qk0-f175.google.com [209.85.220.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 79491689E17 for ; Tue, 11 Jul 2017 01:04:31 +0300 (EEST) Received: by mail-qk0-f175.google.com with SMTP id d78so85851099qkb.1 for ; Mon, 10 Jul 2017 15:04:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=btpbw8lVSVcJGCiJCTahCaapX8Tu/L45/yBgFX7a/hY=; b=Azjbpw/g4c6d4CfTa2zOC1/ZnEm42OnH0gsi9uSQcVIum1pYb1d11uxTVk1NIpCxP/ FMWZAUeCx7ll6s9OlNKsuWfAPGpHUPtUiZRlJdokcD6eKELcdJx397UrN4U0MPq8Tycj 1UuBrGE2mJANWlaXJVEHOx6lZHiDtUw0hoJA8bCuqsiigyWoRgnHct0HZZ5QOvPAt0Sa 2BQQh/SdmlVhvGoJCMuFPrS3GDIOJmV91yVIoadowYsCyPAyX70Q+RDsrziyPs7lj4lP 0DleXgveJKmjp6V0ukZxRZL8ZwgLYTU1FZnzSuAzIbO5OUWZDN3YjuQtG+tiqh1GzbrK qUqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=btpbw8lVSVcJGCiJCTahCaapX8Tu/L45/yBgFX7a/hY=; b=GF1n5z3a6HMIhPAH9I2IQFggKTvZFKR6ctgSGdkuF28+QcLvQNHIOu7mVk1n3N0GQL rCpwhLnRobVQYzOvDucayxaFGai3/xehVJmMInEZgr3TU8wIW9daCfZDQW5n8PzqT3Fv 3SZUQ5IeGkO+PfmE7EAdr5XcgVls7y2m9V0KDBeLimEvP1T82rCnngcvVWiklCtm04KZ ZED6kk0d9j4dS2wPqB74PTEilviVu20j0pB+8KuzP3g57JOIaNuHGq9x3TcWV0rmBXxy TJESthhY5vn6Zi4yFOBSGCPA0G4lsqVBwg8d7Jn83vdKFL4NMkEm3sJx8SqCiNsLKKPa oYJw== X-Gm-Message-State: AIVw1138a4fkJLs2I5XwZ7CuWxRNA3kbIim0jiYASW4URyK+9tmU6YWo YOO19WMYDc0oshz0t0UfykjayLtjSRt3+BU= X-Received: by 10.55.95.129 with SMTP id t123mr6588624qkb.119.1499724274308; Mon, 10 Jul 2017 15:04:34 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.201.80 with HTTP; Mon, 10 Jul 2017 15:04:33 -0700 (PDT) From: Kieran O Leary Date: Mon, 10 Jul 2017 23:04:33 +0100 Message-ID: To: FFmpeg development discussions and patches , aegoreev@gmail.com X-Content-Filtered-By: Mailman/MimeDel 2.1.20 Subject: [FFmpeg-devel] [PATCH] movenc:adds keywords metadata X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Hi, A user mentioned in ffmpeg-user ( http://ffmpeg.org/pipermail/ffmpeg-user/2017-July/036571.html) that they couldn't write the 'keywords' metadata tag. I tested this patch and it appears to add the metadata value when using MOV and MP4 as output. I'm sure I've messed something up so please let me know if I can improve this. Patch is attached and posted here too: From c474a7f5095fc1a84c4bd2d811546a821f6420f6 Mon Sep 17 00:00:00 2001 From: Kieran O'Leary Date: Mon, 10 Jul 2017 22:54:56 +0100 Subject: [PATCH] movenc:adds keywords metadata --- libavformat/movenc.c | 2 ++ 1 file changed, 2 insertions(+) mov_write_int8_metadata (s, pb, "stik", "media_type",1); @@ -3543,6 +3544,7 @@ static int mov_write_udta_tag(AVIOContext *pb, MOVMuxContext *mov, mov_write_string_metadata(s, pb_buf, "\251mak", "make", 0); mov_write_string_metadata(s, pb_buf, "\251mod", "model", 0); mov_write_string_metadata(s, pb_buf, "\251xyz", "location", 0); + mov_write_string_metadata(s, pb_buf, "\251key", "keywords", 0); mov_write_raw_metadata_tag(s, pb_buf, "XMP_", "xmp"); } else { /* iTunes meta data */ From c474a7f5095fc1a84c4bd2d811546a821f6420f6 Mon Sep 17 00:00:00 2001 From: Kieran O'Leary Date: Mon, 10 Jul 2017 22:54:56 +0100 Subject: [PATCH] movenc:adds keywords metadata --- libavformat/movenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 88f2f2c..3989ac1 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -3321,6 +3321,7 @@ static int mov_write_ilst_tag(AVIOContext *pb, MOVMuxContext *mov, mov_write_string_metadata(s, pb, "tvsh", "show" , 1); mov_write_string_metadata(s, pb, "tven", "episode_id",1); mov_write_string_metadata(s, pb, "tvnn", "network" , 1); + mov_write_string_metadata(s, pb, "keyw", "keywords" , 1); mov_write_int8_metadata (s, pb, "tves", "episode_sort",4); mov_write_int8_metadata (s, pb, "tvsn", "season_number",4); mov_write_int8_metadata (s, pb, "stik", "media_type",1); @@ -3543,6 +3544,7 @@ static int mov_write_udta_tag(AVIOContext *pb, MOVMuxContext *mov, mov_write_string_metadata(s, pb_buf, "\251mak", "make", 0); mov_write_string_metadata(s, pb_buf, "\251mod", "model", 0); mov_write_string_metadata(s, pb_buf, "\251xyz", "location", 0); + mov_write_string_metadata(s, pb_buf, "\251key", "keywords", 0); mov_write_raw_metadata_tag(s, pb_buf, "XMP_", "xmp"); } else { /* iTunes meta data */ -- 2.7.4