From patchwork Fri Dec 8 19:35:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacob Trimble X-Patchwork-Id: 6617 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.161.94 with SMTP id m30csp938182jah; Fri, 8 Dec 2017 11:35:17 -0800 (PST) X-Google-Smtp-Source: AGs4zMYZbEXXkbY9NTQC91x8VP2/od7ZmyvJ1NmRhnuWMsFOaRh6KR0AtQfK1V3kfGTm5NwNLJV4 X-Received: by 10.28.220.215 with SMTP id t206mr4699990wmg.75.1512761717707; Fri, 08 Dec 2017 11:35:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1512761717; cv=none; d=google.com; s=arc-20160816; b=KSkOFf3WC0xcPHK3T9mqTcz+nnWXXS0OsmiDDHZh1DvtsBqlbpFf0HvWS6eBjoMKan pgxI7BXeFEf/M709gGk9C8vIGKHPRWxgNgTXosQimEnFdhE1YmcCckh500uz4fYpEwnh 3DGFw6OgJZst4OlEYMdC0m3ZLC3fvU/H+2tmPgQ7zBG9MPjnXEapwUm0k6yJE3RXqMDn hqX56Jb+5WHUH+wbABXTUCgpWVKqXC1OCh5Bj7s5ZcQMl7r7lQhDISgOm1U9js7W2H9M CEudkeGKKbBIeF8lAvkDwRhudRkcN2LOSqvMVD5Vw1tILn8zp0ZSvY8NVFI0OMkeJayr j2eQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:to :message-id:date:from:references:in-reply-to:mime-version :dkim-signature:delivered-to:arc-authentication-results; bh=lnzfDtCL/xQR58nx70gJiETgKjKGWu+wq1OgmDAzijk=; b=ZC6kpmKuGamXC0ywXxM78lgV6GSa65BuaNcEkLoY1bZcWqlYNLe30esXG1sfjnXij8 3lZvg362Pyl+YwGK4vM6ucmypQGIUzh/YzfvzcdcsdhvK9Jo4IJkjNhoXaoWG/AK6PZy ZrQpKicOnnow5xyJzqQwcu2aQy1Vwpym+Z2foTy4H6UeDBlj8EUjc5PYDA9EP3bjvsHb E7Tj8SzNHAMMQKULrkMfO3oTuTW8YcsdbjtQeHEXrZ8jJ/0VoCN611e3I7zZ2EKVyH57 b4Vh0t+wZKARZuASYuP6h/SOpYLIKX8LB4iq3b6AD72V8jZYLROCsbwlG8V28WeBiG5t 9paw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@google.com header.s=20161025 header.b=qlRGlZFW; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id t13si6470165wrg.337.2017.12.08.11.35.16; Fri, 08 Dec 2017 11:35:17 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@google.com header.s=20161025 header.b=qlRGlZFW; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6F869680A6A; Fri, 8 Dec 2017 21:35:09 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-ua0-f172.google.com (mail-ua0-f172.google.com [209.85.217.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2592F68A42D for ; Fri, 8 Dec 2017 21:35:03 +0200 (EET) Received: by mail-ua0-f172.google.com with SMTP id p33so8189810uag.9 for ; Fri, 08 Dec 2017 11:35:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=f7PTrOwVtl2mWWr1houaoEfcKRDAwPASu5Lvg64UrJY=; b=qlRGlZFWnj0BtAoGHgKiqgpQzhm0HufVsTSSLnCUoGSUsAtO5tlK+1bZHNcvOBidXE j+9S37nicgfEhxMOBt7GfQaOmIIScsiPZ1hT6CfQtJpfjcqwOcd114MsnHKbcIis82TK 5XMvL+3rI0oatdTtZ0Dj9oDz5s12RwevH9Mc7JX8TihCtljdZlN7ti257cE8bqrqnT+P 0D5I6uu+f7fzoRhWh4uGtbpA+bTqE+8jR6ejSwdLgWoVEI6BjHI6YgI8wB9DetkmsJa6 Hco1xEvya5w5Sa3zJ+zhPlmnf98d2+LtbhCvDj6OsOzb/AHnjFb/TPCOCXpzF1Z0Z160 YEuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=f7PTrOwVtl2mWWr1houaoEfcKRDAwPASu5Lvg64UrJY=; b=qKiz2k+j60ZhmJXcryHKXgffA86PBDevXQQgHTMINm1wzqjv41PigLo3hhEJV49njT pPwRzb/keIaWhn9V4P0YRp/c1gvDRtm9/G6VEKhWB4ZN2Oiow1Tu45dGamDYsUQV+8LW s+fSymmmDbM1RKUl/NzStFT3q/0QHJLc/NNO2vqrGJ9wTLKzfwnYkmi8Z3YDWjNfQdJ4 ZBTm14+n8srH5YgE+WPY76CmEeUXMlS0/MTgX1M8wtS3nGY3neNNxm1p+KZ2hre60dCP gt0OHNsOKCj8W8ah8YzGGoxwWjXCEBu3KKt6A9Zc1UMiKxFkb7DsX9U8TRSLVpIaXi31 iPDA== X-Gm-Message-State: AKGB3mJLuHwQEdu43WuqyG4MYB0Tm1OkKGf29XODINAYd3XNFGWfZl/x yZJgbb9lJES6AyBkOP5gydVtBmCgdqxqtSllE+4dpzjM X-Received: by 10.159.57.195 with SMTP id p3mr19479471uag.39.1512761707696; Fri, 08 Dec 2017 11:35:07 -0800 (PST) MIME-Version: 1.0 Received: by 10.103.214.138 with HTTP; Fri, 8 Dec 2017 11:35:06 -0800 (PST) In-Reply-To: <20171208183910.GI4636@nb4> References: <20171207193013.90747-1-modmaker@google.com> <20171208183910.GI4636@nb4> From: Jacob Trimble Date: Fri, 8 Dec 2017 11:35:06 -0800 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avcodec/Makefile: Fix opus parser dependency. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On Fri, Dec 8, 2017 at 10:39 AM, Michael Niedermayer wrote: > On Thu, Dec 07, 2017 at 11:30:13AM -0800, Jacob Trimble wrote: >> The opus.c file uses variables that are defined in opustab.c. The >> opus parser needs to include that file to avoid linker errors when >> not including the opus encoder/decoder. > > please list the symbols needed or the error message in the commmit > message, so the reader knows about which symbols this is > > thx Done From 8519e5192bc3dbbc5aa49204321419b6e5a8bf4b Mon Sep 17 00:00:00 2001 From: Jacob Trimble Date: Thu, 7 Dec 2017 11:05:46 -0800 Subject: [PATCH] avcodec/Makefile: Fix opus parser dependency. The opus.c file uses ff_celt_freq_range and ff_celt_freq_bands which are defined in opustab.c. The opus parser needs to include that file to avoid linker errors when not including the opus encoder/decoder. Signed-off-by: Jacob Trimble --- libavcodec/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index ab7893f560..ca72138c02 100644 --- a/libavcodec/Makefile +++ b/libavcodec/Makefile @@ -1005,7 +1005,7 @@ OBJS-$(CONFIG_PNG_PARSER) += png_parser.o OBJS-$(CONFIG_MPEGAUDIO_PARSER) += mpegaudio_parser.o OBJS-$(CONFIG_MPEGVIDEO_PARSER) += mpegvideo_parser.o \ mpeg12.o mpeg12data.o -OBJS-$(CONFIG_OPUS_PARSER) += opus_parser.o opus.o vorbis_data.o +OBJS-$(CONFIG_OPUS_PARSER) += opus_parser.o opus.o opustab.o vorbis_data.o OBJS-$(CONFIG_PNG_PARSER) += png_parser.o OBJS-$(CONFIG_PNM_PARSER) += pnm_parser.o pnm.o OBJS-$(CONFIG_RV30_PARSER) += rv34_parser.o -- 2.15.1.424.g9478a66081-goog