From patchwork Fri Jun 30 21:56:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dale Curtis X-Patchwork-Id: 4167 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.1.76 with SMTP id 73csp6271451vsb; Fri, 30 Jun 2017 15:02:50 -0700 (PDT) X-Received: by 10.223.148.66 with SMTP id 60mr28745538wrq.75.1498860170906; Fri, 30 Jun 2017 15:02:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1498860170; cv=none; d=google.com; s=arc-20160816; b=kY+cA+3wDDx+XBINDAV2aCHm/Gu//AoNMNvF2Kd+BAs8T82tFal+aY4wmc9r+8nCsm +n+WYAMl41pNDTSmZU8hC7FK6+GH41+EK9/X3FqxS9BXjfQzwSyUQaNA43uPKb5w/x3I ochaxThuB3T+IiybXWdSCujhdecW0A/JZIheselQXEHX6WDW4FJAJ7IhUsVhGQThs+ef dnuNJJmj0819dVpflc0pMRk16ijOCpdVppRdku61jDllTSzlGg/fZ9uiz+0zYdpoFo67 phAt+NPZmfMK+TZF1ujr8TlzUbsXtGVBAUwaTvrkFjmHZc574MOeCQqC5Pk0t6kVL6iS bg6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:to:message-id:date:from:references :in-reply-to:mime-version:dkim-signature:dkim-signature:delivered-to :arc-authentication-results; bh=ED6Q3vSupt7kbj2Kq/Tn/VT6U1DT3VNWE15p6FBPgIg=; b=pcoRlxzsTMcWLnL/iQKtfUoQEHpu053EKNCJvBf78AEBeIHlO4UAx+fS8QlkOBuiC7 Ua7gbYrPalZa0sZxPyFoFNKWC5sM2W0NNF6PZX9p5e4ZnA1YtwXsYg2JLGK2HanDJHBr W/KrTgUsjh7Op4y6T1uWw37KuEZrqjCz0rTv9OC/Q2b0R88UrT+nu/8TiKCqYhYTCKye h0+ekhyPUJw5wsUIYdsz+8BhoA1oA6Dtagp2TUbqiTyh/SaILLm/WKwgN67Q1iHzFdlm spdyDFuKlEID7dOnvX/Q45ZgrwPlp/KkJuDV7hJw3BlDHUyS+3acvs+8LV6uiRcwAGjN 5E6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@google.com header.b=sfy66EbC; dkim=neutral (body hash did not verify) header.i=@chromium.org header.b=YREc9L/v; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id g11si7275756wrb.350.2017.06.30.15.02.48; Fri, 30 Jun 2017 15:02:50 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@google.com header.b=sfy66EbC; dkim=neutral (body hash did not verify) header.i=@chromium.org header.b=YREc9L/v; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 70F10689F99; Sat, 1 Jul 2017 01:02:44 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 97B08689E75 for ; Sat, 1 Jul 2017 01:02:37 +0300 (EEST) Received: by mail-wm0-f53.google.com with SMTP id w126so120841987wme.0 for ; Fri, 30 Jun 2017 15:02:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=uMtzoLnsSyB+xouVcw/lRz7Mv3lNi8h2llqFfjDb0/0=; b=sfy66EbC2JIsoah5ckiZ7JJrnhVAFe8zpNCGhj1BXgsAJKXd73llvVrCe4bXWb/3Hm bu9C+XE58L5ovqhwmGLf79ASMiHqjszrc02PlxMGnFdAn2WoX1YZQhmXHlLDvzaqCCH1 V8GMUC1L29jFEaZDNjUgfJJNDflsaSjGVB70Xdf5uqsanRLCwJUH4xPuYKRgwoh0w8Rd Vo/CKQrEN9lme+JrgzsakZDI5crmrCxzjss9juCxsn27ufnwYh4kNf20Q7qsYShUhTQ2 uwBHDHCAdtVyvcLSmRDuYl8TNsmEVWz3/dbkSozxJOwssMrMWDpFlFEAB//vXF6EGdv2 +4Ww== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=uMtzoLnsSyB+xouVcw/lRz7Mv3lNi8h2llqFfjDb0/0=; b=YREc9L/vP4xEIRSIK3JbVlrm+OY0cda9NHd6YvrBEtUNkLVvCxxB67faXqZgXTZ5BY ji+IIA7ag2AzSfS7c59jVstif/qCVjP9FgnYNjSNyDlOC/Gv3IRADeJNIi2CXFE4/yBC bfBzNGFtlrbv5XFaQxPI4Sv3Gx9E+2Qe2r/Lc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=uMtzoLnsSyB+xouVcw/lRz7Mv3lNi8h2llqFfjDb0/0=; b=JZEWt8lUBxPEhWOids3meUc5iYT3azCOhc1zTFZwFW9u+ft/ZYwkl7A4/qjHqdEAOP yQ0BTyeefqhK0GDibCS3zpcXSDOOpt61zbjkUYlBJu7zeZm+TNuBIAaSsVR67bDHJC2d akg3w4pC4Hr4Luz96IZLXavkN3i0uzV3H4OcebVeOvQfg0QuO46ZYXwqKxS06yxmyd+Q 5Z8x8y7bDBsp8egCZRYUgGO+3qogpAuVs9xHmnY1v5Iq3rJ1OoXuAVYromC749ezlWMi yDR2+NE1C7ReH4TSW3Wemh2SqHFMILHHQHnzQ9rlvqzSFu6DS1YOfDQSMtekiN5gJhlK 0vsA== X-Gm-Message-State: AIVw1138cWM9VISM1U2bKQTadtP9OAY/3ppm3S9PFpldwAN6DItqP7AM xFznRmQ/f7gSRllfI2Afir3TvTJR+ONG X-Received: by 10.28.13.145 with SMTP id 139mr7046416wmn.49.1498859785677; Fri, 30 Jun 2017 14:56:25 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.184.136 with HTTP; Fri, 30 Jun 2017 14:56:05 -0700 (PDT) In-Reply-To: <87F93A93-BC23-4611-AEA0-60887D5CB076@gmail.com> References: <1444121423-25972-1-git-send-email-rodger.combs@gmail.com> <20151006161821.GA4540@nb4> <20160115225719.GL13213@nb4> <87F93A93-BC23-4611-AEA0-60887D5CB076@gmail.com> From: Dale Curtis Date: Fri, 30 Jun 2017 14:56:05 -0700 X-Google-Sender-Auth: L_BgMCBxppqBDsNYWX4-uBRXj8o Message-ID: To: Rodger Combs X-Content-Filtered-By: Mailman/MimeDel 2.1.20 Subject: Re: [FFmpeg-devel] [PATCH] lavf/mov: add support for sidx fragment indexes X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Michael Niedermayer , Michael Niedermayer , Dan Sanders , FFmpeg development discussions and patches , Dan Sanders Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Hmm, finally got around to looking into this again and this still isn't fixed. Just seeking a few times in ffplay can trigger this issue with the clip linked in my original message: http://storage.googleapis.com/dalecurtis-shared/buck480p30_na.mp4 ./ffplay -v debug -drp 1 ~/Downloads/buck480p30_na.mp4 [mov,mp4,m4a,3gp,3g2,mj2 @ 0x7fbce00008c0] invalid dts/pts combination 14583000 [mov,mp4,m4a,3gp,3g2,mj2 @ 0x7fbce00008c0] invalid dts/pts combination 14586000 [mov,mp4,m4a,3gp,3g2,mj2 @ 0x7fbce00008c0] found fragment index for track 1 [mov,mp4,m4a,3gp,3g2,mj2 @ 0x7fbce00008c0] found fragment index entry for track 1 and moof_offset 16686198 [mov,mp4,m4a,3gp,3g2,mj2 @ 0x7fbce00008c0] found frag time 14589000, using it for dts [mov,mp4,m4a,3gp,3g2,mj2 @ 0x7fbce00008c0] invalid dts/pts combination 14607000 [mov,mp4,m4a,3gp,3g2,mj2 @ 0x7fbce00008c0] invalid dts/pts combination 14610000 [mov,mp4,m4a,3gp,3g2,mj2 @ 0x7fbce00008c0] invalid dts/pts combination 14622000 [mov,mp4,m4a,3gp,3g2,mj2 @ 0x7fbce00008c0] invalid dts/pts combination 14631000 [mov,mp4,m4a,3gp,3g2,mj2 @ 0x7fbce00008c0] invalid dts/pts combination 14634000 [mov,mp4,m4a,3gp,3g2,mj2 @ 0x7fbce00008c0] invalid dts/pts combination 14643000 Disabled sidx processing resolves this issue: - dale On Fri, Feb 12, 2016 at 2:21 AM, Rodger Combs wrote: > This issue is fixed by this patch, but I'm unsure of possible implications > on other files. It passes FATE, at least. > > diff --git a/libavformat/mov.c b/libavformat/mov.c > index 149e3b4..c5e0a1e 100644 > --- a/libavformat/mov.c > +++ b/libavformat/mov.c > @@ -3609,7 +3609,7 @@ static int mov_read_trun(MOVContext *c, AVIOContext > *pb, MOVAtom atom) > } > av_log(c->fc, AV_LOG_DEBUG, "calculated into dts > %"PRId64"\n", dts); > } else { > - dts = frag->time; > + dts = frag->time - sc->time_offset; > av_log(c->fc, AV_LOG_DEBUG, "found frag time %"PRId64 > ", using it for dts\n", dts); > } > > > > On Jan 15, 2016, at 16:57, Michael Niedermayer > wrote: > > > > On Fri, Jan 15, 2016 at 10:24:43PM +0000, Dan Sanders wrote: > >> Michael, I wanted to check if you have you looked into this playback > issue, > >> or were planning to? > > > > i didnt look into it, i had thought rodger would look into it as it > > was his patch ... > > > > rodger, did you look into this ? > > > > [...] > > -- > > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > > > Rewriting code that is poorly written but fully understood is good. > > Rewriting code that one doesnt understand is a sign that one is less > smart > > then the original author, trying to rewrite it will not make it better. > > diff --git a/libavformat/mov.c b/libavformat/mov.c index 63f84be782..919475f12f 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -5497,7 +5497,7 @@ static const MOVParseTableEntry mov_default_parse_table[] = { { MKTAG('a','l','a','c'), mov_read_alac }, /* alac specific atom */ { MKTAG('a','v','c','C'), mov_read_glbl }, { MKTAG('p','a','s','p'), mov_read_pasp }, -{ MKTAG('s','i','d','x'), mov_read_sidx }, +// { MKTAG('s','i','d','x'), mov_read_sidx }, Rodger, are you able to still look into this?