From patchwork Thu Jan 5 12:44:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul B Mahol X-Patchwork-Id: 39886 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:bc95:b0:ad:ade2:bfd2 with SMTP id fx21csp349814pzb; Thu, 5 Jan 2023 04:39:23 -0800 (PST) X-Google-Smtp-Source: AMrXdXvCsqVS8dOTsdH0Wj3EzTXHuCxTxMU4BK5jLpxEvdlazSz5cPmG2PtL/+yZ+cYb+tM86jSL X-Received: by 2002:aa7:d60e:0:b0:488:f6a3:2dd6 with SMTP id c14-20020aa7d60e000000b00488f6a32dd6mr25432452edr.41.1672922362912; Thu, 05 Jan 2023 04:39:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672922362; cv=none; d=google.com; s=arc-20160816; b=tW5rjOqMadjemlMeNxpgnOXffTMvmq3Ec1Vuhkt2h+1WCM4RX9ustUfam1hkgYO40r BG8X6QAtda+3OFVlCi+dL0tf8xPMNbQ5+pfUtgWndsTO0qx0F1bfbhjVqMdv1DGrb7ae i5TiTYEGM0UAPU3uvqxxEcONDjtfVgP23ZAmISrFeKy1sEHcFvdsbqI8iLgtYcDAxY0h Jx+hKOKzYV6QjESJhzeDgYd6JaFANE1bLt+XZq95J/QpW3mkWtpKTkSCgq/gdGhjm6+K kg/w9puzFStewU0GLz6xhnC7p6BxGtrNYmbePVSApWmG2lutnjpFCq5495ZChrqZYYND rPAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:to :message-id:date:from:mime-version:dkim-signature:delivered-to; bh=gVuRhXgzkZL6D0+yn05RZNzgrrokgK0LmbiKN5/l56c=; b=p5ec06XlhNdeI7ORkdNtqFrVkS5IbT++NvXWm2We2foaRNCQBPgmCxaMMkLZy7/Ne5 /Vp6gOvbAmEmjOKPQ2U/4XaBDGR+HC1WmVUHCc83ojScthDMeVA71l2UND4y6waKnUnm prWHjma8PD66Z6VqNx7/nK/4AhRcSoWenYmCdE98ze0Z9/fYJafpgY/caw2yXG8zbttk kiXFJg5UJqdOciKJicf+8Br75Pph2ahN+CFhS79akio3n6cSEm13G5vcDY9CbBzC65sF LRa7Nd/nShLDjpAzRS9X7JmvnhlJQ1V1OvcBjp0okRpDMY7VgS/b7Cph4LvH01Y/IB62 gILg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b="Jkh2h7p/"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id cm27-20020a0564020c9b00b00492c006b78esi1403446edb.213.2023.01.05.04.39.22; Thu, 05 Jan 2023 04:39:22 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b="Jkh2h7p/"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 22B9E68BD40; Thu, 5 Jan 2023 14:39:19 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-vk1-f171.google.com (mail-vk1-f171.google.com [209.85.221.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 99D1C68B96D for ; Thu, 5 Jan 2023 14:39:12 +0200 (EET) Received: by mail-vk1-f171.google.com with SMTP id t190so7293562vkb.6 for ; Thu, 05 Jan 2023 04:39:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=UXS9cvPfSiQPNJCSyvhFJxPvzqUStV7zyYaMfbsXCGQ=; b=Jkh2h7p/sE8Np7O0jHOUWztXG4PLmrVH7TirW/ZZMyxt4kTxUJCs+BaFoeTWt8away hqR6T1NbzO849AJ3gJ0mNdg79NPoshQTPsz//dPZlLYBobMbLtyaEmBZcU+rns/yPcIy 6B0/7VvZgikJnXmOVA0IUmYfuTQk1zTpUnsolVtKrjfxO7GoZTMp/xiU5PZRVqEOuwzg IrxSPckuICuHpMEU8pjUh9uW7S5H2FaoGNJL2wCVCjs2oN/raH4GrHgW3yexmZd1EfiO 8bUUCIfNv5uqgEY50it9vEjkIa+cUOCHtAXqxYWKjRxjJqkREINDkob9IyWU3qTkZbU+ 69JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=UXS9cvPfSiQPNJCSyvhFJxPvzqUStV7zyYaMfbsXCGQ=; b=qLTQlx0IsQb0PUsLNSqEOLEO+iYNZ+JasgzHQIKUTDHX967+jlSRk2NFefUhX0xJy5 AleQgBVJcCpZMQ7kTzhKKAfvzSJ1urIAMZQjepYy2lq4ZgIivfpF+OVNzpu0QttxRro4 nbn+dfqRj30ZRXi9jbmEkELBgM76AAdQz/SfCYH5x3MjVs5uzumwbBqAZXAoqzh4u7qp O3JhbJxfytu73Jz5T1H5IwAA35G33KxzfQGbCNv3+4+5cD2la5KFrof3nitpPbKfM7tu tj7ddhPjTf994q6fdFpxEyZtATca9l25/kQiSRq67kIWW3d1yI/Vda6OTFhn+PiGqmvr dpyw== X-Gm-Message-State: AFqh2kqRQpfsYf8NvuPYt5UbM9W8xHFeu8unTWu+VcgC8s0Vhh32e97b jLV4rkeAk3QfvvRrv8m+7g6kFQ2222mLRZH5i4qF9urs X-Received: by 2002:a1f:b294:0:b0:3d5:d2a3:8c22 with SMTP id b142-20020a1fb294000000b003d5d2a38c22mr1381786vkf.39.1672922350864; Thu, 05 Jan 2023 04:39:10 -0800 (PST) MIME-Version: 1.0 From: Paul B Mahol Date: Thu, 5 Jan 2023 13:44:10 +0100 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [FFmpeg-devel] [PATCH] libswresample: avoid s16p internal processing format X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: G1vU3ZfwqgGy Patch attached. From 9c4cd60e2dd41cf98d693c8251f4cfade0807073 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Thu, 5 Jan 2023 13:40:12 +0100 Subject: [PATCH] libswresample/swresample: avoid s16p internal transfer format Instead use float one by default for sample rate conversions. The s16p internal transfer format produces visible and hearable quantization artifacts. Signed-off-by: Paul B Mahol --- libswresample/swresample.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libswresample/swresample.c b/libswresample/swresample.c index 5884f8d533..e6151bc335 100644 --- a/libswresample/swresample.c +++ b/libswresample/swresample.c @@ -318,7 +318,8 @@ av_cold int swr_init(struct SwrContext *s){ if(s->int_sample_fmt == AV_SAMPLE_FMT_NONE){ if( av_get_bytes_per_sample(s-> in_sample_fmt) <= 2 - && av_get_bytes_per_sample(s->out_sample_fmt) <= 2){ + && av_get_bytes_per_sample(s->out_sample_fmt) <= 2 + && s->out_sample_rate==s->in_sample_rate) { s->int_sample_fmt= AV_SAMPLE_FMT_S16P; }else if( av_get_bytes_per_sample(s-> in_sample_fmt) <= 2 && !s->rematrix -- 2.37.2