From patchwork Fri Jul 12 17:19:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marvin Scholz X-Patchwork-Id: 50505 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:612c:2298:b0:482:c625:d099 with SMTP id fp24csp991272vqb; Fri, 12 Jul 2024 11:06:52 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXok4pn6n19VnyL15N+iuxDpDeut0rM0GfCGz7zOQ0MaeraqWYhoHk+nVb+ACBLpFlZZ1t/bz2iaCyWwNUC8a0PWjAPvLnl2rBkLA== X-Google-Smtp-Source: AGHT+IF3CrMH1USVXXzVNH4xRqNBIegAOKuo+LWgaUKiQBiiiySOjgpXAUknrKK/uyN3QAMjKGIK X-Received: by 2002:a05:6512:3d8f:b0:52e:7688:2817 with SMTP id 2adb3069b0e04-52eb9994ab3mr7863324e87.17.1720807612457; Fri, 12 Jul 2024 11:06:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1720807612; cv=none; d=google.com; s=arc-20160816; b=WoR3i9qaTJWeqvBBvG44X3iFaFuKq6SsN1t7xx4retSzs8CwFoBdFJ2mL4lQ301PDg wXPGR58EZ4x6Ii/jj0EHZ8BDrnUo/cDp45vxl9ARgG2x/DmO1GwodBifUwsXau5ZvUJ7 +/p3dDzUwIbZ9PjB6GEAtfP8nLojTpTOeEkfPuJjdCexQn+EFc+eDieP2JWgDgvejiu+ wARQ7iwwQL3pUJPyQR0PTO080hphr+LJohEUf/DvVpNlgyRLb95r9fVy+IxVsSVpAx1l 5CTikQ1ZNaCA+nXMtLjbUtxaw9UHQ8Wb4i7fHnI5JRajZEz7XSKz//fqlg7Jy1V/ZVrT OFTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:date:from:to:message-id:in-reply-to :dkim-signature:delivered-to; bh=CV0cj2TtYghzSKUafoa9fHmgMLbkFDY+QBtbRqSiDdQ=; fh=5IeVwzS1vbVKjIV8MP3mnmnRtZGb8uteQ9r4QD2keV0=; b=uHhTFFB+DcGTPO3dvi6a12zDez5a8d6ecX9GAmu4RdQ2XDxh8HhEF4eU3d9oOCG8LR mvCti1gTZm03HAHp5snZSsIfTmOks9Fa31RXXEw00qorBqtmJm0bElysCAAVrXbh5/eE fW0iWvs/qlnKpic2hw+IcyHaX/NLJtQZ+X5cEzxrm1ucMc3xxqyydPzmh2/++YOhnivu qwrpmitNZwlRSpNtmJY6ghbBNicY/iliiOYh+Xv9nuZ/z9Ur8/rmYp/wNX8gSMZnltSM jeqgqTPGYZf2BkMgikgKkEs9zUBFLzw3wfNT1DvhjFBce/BFDqyMqiGqzx5eX9xdRB5g QfGQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=gfJK7+hZ; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a640c23a62f3a-a780aae15absi429681766b.338.2024.07.12.11.06.51; Fri, 12 Jul 2024 11:06:52 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=gfJK7+hZ; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 885B868DB30; Fri, 12 Jul 2024 20:48:22 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6966F68DAE7 for ; Fri, 12 Jul 2024 20:48:10 +0300 (EEST) Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-58c947a6692so3027791a12.0 for ; Fri, 12 Jul 2024 10:48:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720806489; x=1721411289; darn=ffmpeg.org; h=subject:date:from:to:message-id:in-reply-to:from:to:cc:subject:date :message-id:reply-to; bh=ASUdObaICANV31Nwe4+w7+fkh4Aoci7OwkS7rVUzGEA=; b=gfJK7+hZZvqj4MK7utTJHVT7ZYOnkvRhCKowygGiaqyOrVhJ6RNQppOF1QaNKbqb8q R7kw2Wwgc3WSq775zCoq+L1WHy8SUGKvosu/khOL/OuuVw+GPg/kTjh74/GotwycZz7p NdV0nDhohM9+D4TKZpvmN5vu4sYpy2jh87+xd4Pq35xcXa5v6M37q8zEcQ4reheAoOU7 LDHH/aiLKe+Vk9nT7JEVrgHbD8X7SI7IwUA1O3pBop32ODCcN6IWA0icfGVMpXajlEwh jxUBZwvEotu4VQSJqTsSb4/2d4liw5jqPJ0Hpid+pq2ORFGXCCDKvuRn1tOOQAgEj4iZ dytQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720806489; x=1721411289; h=subject:date:from:to:message-id:in-reply-to:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ASUdObaICANV31Nwe4+w7+fkh4Aoci7OwkS7rVUzGEA=; b=Nc7cb1pHijg7OHZWsWqolERTJIX2bVvJVXV5+gvzWlE/Ca1qtOIaUf/ciJI6QX8LSG a0bwfhLEQIdB7I9SHaBaBWeuX5u7HtaJxew0p/aE7fDZbjNcinJMEludc2yWkRIW/CzL udqpu09+sU7j71Tumm2lb9Z9ntVX2aiTHTwJmKAlygIEXK7rMiy93qq8iwf0BJbXMhSE WKw/wXCAyMur2v2KELS1Ald6ayro25XnE8vhAxRtZqUl8TJc1Ht3JpSWNphrBsapfzuJ 8V6owBIGGZxeUxTyQoVwncPmO4TWd1xr1O6dQDYpxR0Ao8MVoP0AcXz+A7IdOXsAq19w QA/w== X-Gm-Message-State: AOJu0YwmVLO6YW/VV3oscWq5gm9nX3wf1D6ePmbKN6teR2WD0m+fUUiC Qz7o2UzzfBD8R7FRDlq0cBCZQ6kzYLXp4/2wRBN00gm/yB15h7Gvqs1Cnw== X-Received: by 2002:a05:6402:234b:b0:58c:909f:3d46 with SMTP id 4fb4d7f45d1cf-594ba0cbe63mr9903875a12.10.1720806489372; Fri, 12 Jul 2024 10:48:09 -0700 (PDT) Received: from localhost (p200300cccf1e25001072fbc25e6664b9.dip0.t-ipconnect.de. [2003:cc:cf1e:2500:1072:fbc2:5e66:64b9]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-594bd45a1b6sm4753150a12.60.2024.07.12.10.48.08 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Jul 2024 10:48:08 -0700 (PDT) In-Reply-To: Message-Id: To: From: "Marvin Scholz" Date: Fri, 12 Jul 2024 19:19:37 +0200 Subject: [FFmpeg-devel] [PATCH 08/11] avfilter/vf_coreimage: simplify list_filters code X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: iOWKIzVw6Y3g Use fast-enumeration and get rid of unnecessary intermediate variables. --- libavfilter/vf_coreimage.m | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/libavfilter/vf_coreimage.m b/libavfilter/vf_coreimage.m index bfc17764b5..38355414bd 100644 --- a/libavfilter/vf_coreimage.m +++ b/libavfilter/vf_coreimage.m @@ -102,18 +102,13 @@ static void list_filters(CoreImageContext *ctx) filter_categories = [NSArray arrayWithObjects:kCICategoryGenerator, nil]; } - NSArray *filter_names = [CIFilter filterNamesInCategories:filter_categories]; - NSEnumerator *filters = [filter_names objectEnumerator]; - - NSString *filter_name; - while (filter_name = [filters nextObject]) { - CIFilter *filter = [CIFilter filterWithName:filter_name]; - NSDictionary *filter_attribs = [filter attributes]; // - NSArray *filter_inputs = [filter inputKeys]; // + for (NSString *filter_name in [CIFilter filterNamesInCategories:filter_categories]) { + CIFilter *filter = [CIFilter filterWithName:filter_name]; + NSDictionary *filter_attribs = [filter attributes]; av_log(ctx, AV_LOG_INFO, "Filter: %s\n", [filter_name UTF8String]); - for (NSString *input in filter_inputs) { + for (NSString *input in [filter inputKeys]) { NSDictionary *input_attribs = [filter_attribs valueForKey:input]; NSString *input_class = [input_attribs valueForKey:kCIAttributeClass]; if ([input_class isEqualToString:@"NSNumber"]) {