diff mbox series

[FFmpeg-devel] fftools/ffmpeg: remove useless error check

Message ID D3EZFI1S2KAG.3C1IMUZAYF7D5@gmail.com
State Accepted
Headers show
Series [FFmpeg-devel] fftools/ffmpeg: remove useless error check | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished

Commit Message

Marvin Scholz Aug. 13, 2024, 6:06 p.m. UTC 
When ret is checked here, it was never assigned anything, making this
check useless, as highlighted by Coverity.

It seems to be a copy paste mistake given that opt_match_per_stream_str
does not return an error code that could be checked and the previous
value assigned to ret is already checked above. So just remove this
check.

Fixes: CID1616292
---
 fftools/ffmpeg_mux_init.c | 2 --
 1 file changed, 2 deletions(-)


base-commit: e26276d829cc608fc95734969bfcf93c3d90162e

Comments

Anton Khirnov Aug. 14, 2024, 11:59 a.m. UTC | #1 
Quoting Marvin Scholz (2024-08-13 20:06:42)
> When ret is checked here, it was never assigned anything, making this
> check useless, as highlighted by Coverity.
> 
> It seems to be a copy paste mistake given that opt_match_per_stream_str
> does not return an error code that could be checked and the previous
> value assigned to ret is already checked above. So just remove this
> check.
> 
> Fixes: CID1616292
> ---
>  fftools/ffmpeg_mux_init.c | 2 --
>  1 file changed, 2 deletions(-)

LGTM

Thanks,
diff mbox series

Patch

diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c
index e84fa9719f..6aae1add02 100644
--- a/fftools/ffmpeg_mux_init.c
+++ b/fftools/ffmpeg_mux_init.c
@@ -1198,8 +1198,6 @@  static int ost_add(Muxer *mux, const OptionsContext *o, enum AVMediaType type,
             const char *format = "{fidx} {sidx} {n} {t}";
 
             opt_match_per_stream_str(ost, &o->enc_stats_pre_fmt, oc, st, &format);
-            if (ret < 0)
-                goto fail;
 
             ret = enc_stats_init(ost, &ost->enc_stats_pre, 1, enc_stats_pre, format);
             if (ret < 0)