diff mbox

[FFmpeg-devel] libavformat/tls: pass numeric hostnames to tls_connect_cbs()

Message ID DB3PR0202MB34528690741C61ADC4836507ECCF0@DB3PR0202MB3452.eurprd02.prod.outlook.com
State Superseded
Headers show

Commit Message

sfan5 Feb. 20, 2018, 6:40 p.m. UTC 
Hi,

attached patch fixes a small issue with the libtls backend.

reported here: https://github.com/shinchiro/mpv-winbuild-cmake/issues/61

Comments

Carl Eugen Hoyos Feb. 20, 2018, 9:30 p.m. UTC | #1 
2018-02-20 19:40 GMT+01:00 Stefan _ <sfan5@live.de>:

> attached patch fixes a small issue with the libtls backend.

Please mention ticket #7029 if it is related.

Carl Eugen
diff mbox

Patch

From 4bba90874839cf98ac27756c4a3137be4c84c669 Mon Sep 17 00:00:00 2001
From: sfan5 <sfan5@live.de>
Date: Tue, 20 Feb 2018 19:18:13 +0100
Subject: [PATCH] libavformat/tls: pass numeric hostnames to tls_connect_cbs()

Numeric hosts in certificates are not very common, but supported by LibreSSL.
Forward the IP address to make verification work in this case.
---
 libavformat/tls_libtls.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/tls_libtls.c b/libavformat/tls_libtls.c
index 1321f7922..ba83b56ff 100644
--- a/libavformat/tls_libtls.c
+++ b/libavformat/tls_libtls.c
@@ -119,7 +119,7 @@  static int ff_tls_open(URLContext *h, const char *uri, int flags, AVDictionary *
 
     if (!c->listen) {
         ret = tls_connect_cbs(p->ctx, tls_read_callback, tls_write_callback,
-            c->tcp, !c->numerichost ? c->host : NULL);
+            c->tcp, c->host);
     } else {
         struct tls *ctx_new;
         ret = tls_accept_cbs(p->ctx, &ctx_new, tls_read_callback,
-- 
2.16.2