diff mbox

[FFmpeg-devel,PATCHv2] configure: fix pkg-config check for libtls

Message ID DB3PR0202MB34529A268602D6D09D8471D7EC0F0@DB3PR0202MB3452.eurprd02.prod.outlook.com
State New
Headers show

Commit Message

Stefan _ Dec. 19, 2017, 5:13 p.m. UTC
Last patch had a minor issue, fixed version attached.

Comments

James Almer Dec. 19, 2017, 5:28 p.m. UTC | #1
On 12/19/2017 2:13 PM, Stefan _ wrote:
> Last patch had a minor issue, fixed version attached.

Applied.

The fallback check for that matter should be removed. It's pointless
since every supported version of the library ships a .pc file, and it's
pretty much guaranteed to not work with static builds.
Carl Eugen Hoyos Dec. 19, 2017, 11:32 p.m. UTC | #2
2017-12-19 18:28 GMT+01:00 James Almer <jamrial@gmail.com>:
> On 12/19/2017 2:13 PM, Stefan _ wrote:
>> Last patch had a minor issue, fixed version attached.
>
> Applied.
>
> The fallback check for that matter should be removed. It's pointless
> since every supported version of the library ships a .pc file

Which is completely unrelated to the fact that less common
toolchains do not provide pkg-config.

It is sadly impossible now to test on aix, I still believe it
would make sense to support as many systems as possible.

Carl Eugen
Hendrik Leppkes Dec. 19, 2017, 11:41 p.m. UTC | #3
On Wed, Dec 20, 2017 at 12:32 AM, Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote:
> 2017-12-19 18:28 GMT+01:00 James Almer <jamrial@gmail.com>:
>> On 12/19/2017 2:13 PM, Stefan _ wrote:
>>> Last patch had a minor issue, fixed version attached.
>>
>> Applied.
>>
>> The fallback check for that matter should be removed. It's pointless
>> since every supported version of the library ships a .pc file
>
> Which is completely unrelated to the fact that less common
> toolchains do not provide pkg-config.

We should not have to maintain the dependency lists of external
libraries (which can even change when the library changes without us
knowing when the API remains the same), especially when a standard
tool exists to handle this for us. pkg-config was specifically
designed for this.
Changes are that such fallback cases are notoriously broken due to any
mainstream system not ever reaching them, so its best to encourage
everyone to use the mainstream option as well.

>
> It is sadly impossible now to test on aix, I still believe it
> would make sense to support as many systems as possible.
>

There is pkg-config for AIX in third-party repos (which is probably
where you get most AIX stuff, since its otherwise a proprietary OS).

- Hendrik
James Almer Dec. 19, 2017, 11:49 p.m. UTC | #4
On 12/19/2017 8:32 PM, Carl Eugen Hoyos wrote:
> 2017-12-19 18:28 GMT+01:00 James Almer <jamrial@gmail.com>:
>> On 12/19/2017 2:13 PM, Stefan _ wrote:
>>> Last patch had a minor issue, fixed version attached.
>>
>> Applied.
>>
>> The fallback check for that matter should be removed. It's pointless
>> since every supported version of the library ships a .pc file
> 
> Which is completely unrelated to the fact that less common
> toolchains do not provide pkg-config.
> 
> It is sadly impossible now to test on aix, I still believe it
> would make sense to support as many systems as possible.

A quick google search suggest pkg-config can be compiled in AIX, and
that even some pre packaged binaries are available for download.

If you're building ffmpeg, libressl and probably other needed
dependencies for such a system, you can also build pkg-config.

> 
> Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
Carl Eugen Hoyos Dec. 20, 2017, 12:33 a.m. UTC | #5
2017-12-20 0:49 GMT+01:00 James Almer <jamrial@gmail.com>:
> On 12/19/2017 8:32 PM, Carl Eugen Hoyos wrote:
>> 2017-12-19 18:28 GMT+01:00 James Almer <jamrial@gmail.com>:
>>> On 12/19/2017 2:13 PM, Stefan _ wrote:
>>>> Last patch had a minor issue, fixed version attached.
>>>
>>> Applied.
>>>
>>> The fallback check for that matter should be removed. It's pointless
>>> since every supported version of the library ships a .pc file
>>
>> Which is completely unrelated to the fact that less common
>> toolchains do not provide pkg-config.
>>
>> It is sadly impossible now to test on aix, I still believe it
>> would make sense to support as many systems as possible.
>
> A quick google search suggest pkg-config can be compiled in AIX, and
> that even some pre packaged binaries are available for download.

The aix issue - that configure takes two and a half hours now
on a system where compilation takes much less than ten
minutes - is not pkg-config related. It makes running a bisect
a little difficult.

Apart from that, I still believe testing with vanilla toolchains
makes much more sense from a user perspective.

Carl Eugen
diff mbox

Patch

From 6f6bcf77ce2aaf6a84858d34112f61128e779fda Mon Sep 17 00:00:00 2001
From: sfan5 <sfan5@live.de>
Date: Tue, 19 Dec 2017 17:33:26 +0100
Subject: [PATCH] configure: fix pkg-config check for libtls

This was not accounted for during merge and is required due to
the refactor in commit 93ccba96df6340249b0db227d5bc3297010797a4.

Signed-off-by: sfan5 <sfan5@live.de>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 2f7db05faa..c01f414f9a 100755
--- a/configure
+++ b/configure
@@ -5894,7 +5894,7 @@  enabled libssh            && require_pkg_config libssh libssh libssh/sftp.h sftp
 enabled libspeex          && require_pkg_config libspeex speex speex/speex.h speex_decoder_init
 enabled libtesseract      && require_pkg_config libtesseract tesseract tesseract/capi.h TessBaseAPICreate
 enabled libtheora         && require libtheora theora/theoraenc.h th_info_init -ltheoraenc -ltheoradec -logg
-enabled libtls            && { use_pkg_config libtls libtls tls.h tls_configure ||
+enabled libtls            && { check_pkg_config libtls libtls tls.h tls_configure ||
                                require libtls tls.h tls_configure -ltls; }
 enabled libtwolame        && require libtwolame twolame.h twolame_init -ltwolame &&
                              { check_lib libtwolame twolame.h twolame_encode_buffer_float32_interleaved -ltwolame ||
-- 
2.15.1