From patchwork Sun Jun 12 00:29:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 36170 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:6914:b0:82:6b11:2509 with SMTP id q20csp548155pzj; Sat, 11 Jun 2022 17:30:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyJ15eE/SzvpCEoJGWi1Ox7tGpGbOtEwVA0P95ZakROUKqq3BOdSHWAZ9pNifDTa3+ZZxJi X-Received: by 2002:a17:906:6483:b0:712:1bfe:eda2 with SMTP id e3-20020a170906648300b007121bfeeda2mr9983338ejm.306.1654993800334; Sat, 11 Jun 2022 17:30:00 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id et8-20020a056402378800b0042ae7984dafsi3315512edb.46.2022.06.11.17.30.00; Sat, 11 Jun 2022 17:30:00 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b="u85/9f4t"; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0A8F668B546; Sun, 12 Jun 2022 03:29:46 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2021.outbound.protection.outlook.com [40.92.91.21]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7C84668B4B3 for ; Sun, 12 Jun 2022 03:29:39 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KWCJmReg3mpbdj1uPpyp9mv0tprvd14LaHoIo8F+7UsktBjSbJaXcEh0yclwMZD5xxCbDrp+6O8dSHM0GDWyOEHGDtzV4eJbvuChCVTcSRsfKj6eHRRr7VmTfDa6+gulhj1T81ztJZHUKSRALAKV1RrGIAw/D2s3y+MFt+0wUZVrQ3yOLkTfEoxX7XlJIWEdRK1sTsMBU4/HCkF7IcGhRAQxxukXhPPyzpGGuaIyh9kmc3Dztu4CI503iZTNIrkE/KxVl54WbEnRyneVNuygZoOIVqsYi2InTGIPLNEA89v/qPNEVAH2yHvREyxkuoLs1+8uQdVIaFRAjtsNt2Sr2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NAg/uMBT025PreTjGdZlq0N5N57dn4LpOtvL69bwblU=; b=dFlKkwTbIJH3BsttIRO2GwmA0TN+fEoN54uRrdH1zt1971J2RyeGIOTxyELoTpGlbQpeGbRMkkmenxUjExwUkTAwOjaIDmzjUy/A7Tx36/vuQvFw0SPv+YLbFyH7Yrh4PLDnP1T6CanY0xXgBsQx5ol047og7QKWJvn5E6nIiOseBNihMDruR/qV+iYecch560N1juozXkD0n6DrFxZLCiN2EPqtSKpolRc69WAJLS2b3PmLIgK8RyvEoZ6yguNdHtlnjTW6Bitc5PTeNfri2tKvFp+5utMvsGopkrmehidiDYnHE9wr65ZIuBiP/3ifK/BZ/dQCxVOUb6n5Tponmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NAg/uMBT025PreTjGdZlq0N5N57dn4LpOtvL69bwblU=; b=u85/9f4t62qmp0Z5V3k322uBxZ0BQTXyuQ7FYfwsY3ZUbcEqn8FtuL8hr+TUeUwuquJw8N/1cou6dpZVZedffStdffVENE74o/+Pc8UkR1FhMZgeMyUkcrhoquzbNIrw8sZ84jheW53sw/i7sZNSiwZ3jItIQGaS1JXs9Uae2KX0PIJy/JKhdCZFAZKNBrqPgivKLUwRaqb0BmzdpNYb5d+E3vurqM2BpuXrmwZUPEvdCz0fxbWIMhSQKW5cj0DNXQiKWILVX+Jn7yxZ0olRm1I6Qwf7oe0xfZxM6ZGhtXXF/X5tuo5YyBkm1mykRfNVjzSpUUYvErxOYnvppD8OQw== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by AM6PR0102MB3413.eurprd01.prod.exchangelabs.com (2603:10a6:209:22::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.17; Sun, 12 Jun 2022 00:29:29 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c%10]) with mapi id 15.20.5332.016; Sun, 12 Jun 2022 00:29:29 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Sun, 12 Jun 2022 02:29:12 +0200 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: X-TMN: [d6fxsNSolvxiO1otwB7lLlahhuIVUZmI] X-ClientProxiedBy: ZR0P278CA0097.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:23::12) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: <20220612002913.198265-3-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6b9c7d32-cfaa-49db-3710-08da4c0a9cbc X-MS-Exchange-SLBlob-MailProps: gjx25WM8ZNXOgn4wKLTlrzW91FC18xji4U755DiKSIi7tzlof1f7ZaGfDZMwxp5TfF5zgYsO55912XMIzNxzoPt1nIe2xn41oSuu0leRVwYsAWBl39whJlKinqy4rJ8apssJgY8gpbI6ccvppNV1sAq8VnpDUfnFKYASqhKKMHrUuw6l+HsOyvHuZD2jHSz08W7NSwwlJl0DRjtU6yZbZjeiIXbrO8xjbCRQYzMfYlLykZW0ycFLkfBXfOqqLp2ZWPxt23DdwCMNm8y/Dp0fEaLuM5jlvce+P16GuzOhOM1a4USaEojgNgt4GWtSjJfuF3L83zwo2EIO17IgWFFA54iEql5Yd8Gq7+htWjdCC6ivDavT+YmVZxQBlNl5uiTyJeenyTiVSwhUDL83ij+qTLdtDjrmRMNDGUBH815MdTg8SyPikrw89TwhzjC1393wSX3jYyFNFnNYYoVYRjNKT26ij24TD/9zz63qqLjtmfYulSmjO0MZWwftf3BNLUGOoatntOWBFedlq614OKpmVV5qp5GsXsN03FuDEpWczMBFuPzx5nIuVVh032iohzrmybY0U0dubS3sfvDx9q8LlAOuOC6vJHG5E4vwYCgQ3qYw4o1LaxfgaVpFV8Zk6nCudCMPUR2qcyUyhsjpBCKwGzsVMHdpVaYxsbZpL/ezjOLp9L4/cy8RkrKgy/q9U4zMee4ibhdJLU3GiSPpryKGBuBO4heJ02xvjb0zxEKlOQY= X-MS-TrafficTypeDiagnostic: AM6PR0102MB3413:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: T0Nwws8FxJnvIEOjTDMW6LvZnTx3o1Xf5ih93u08RWK4nu04rl4cMPsm+VVwXryxe6fDY0r8MncliAY92c0/qhDH/YKeNiztdwX6PcNf+D9F+ggPqATsZ2nhXWlH+OvOA9Cq5lkyR30C+yQm0PltNcJ4GKbzL88QASPI1UQccOa8M8ssjs7WH6AK/5mbBRIsLB/F43OuT7zO5lwx8swCNKfE4OEN8BzyeNzpMx1cl7IPbJQfHEZ/7C7jjURypnM0e6kX2wYc9iYEEfS0KtIEgjLK/z5HUbv+2o1g+v9rELjZPVD0Hma3I1H629xVHpzgBp+Rt7W4a7Wwiq1RoE580FWCQO/Vu+AEU8XH5KdHZ3mmWx1Nf8ryJWon5m5GkHUnOdEi09rXu9ovm/JUawivUKufNIf5MeUOzrzlhapxWv4sGK6UOQ21Aj34lcg7PwWd3ZSJK1U/5hGG9CuL3/cTTv2dJjvHzxvshM6+RFncIqxbdCSZt5khme8kbo7WLUOYJnm7ybGJwTwY/oLLc7aHOa56gYD9w/VsWGd+mDC1/qfGhz8Pv1KNmeGBX+/wuoKoq+qg8nTn+iDCThj+w1fXxQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: coJEhfiAnZOj3rP64pnxu4c90+5lKRMZEd0Vfdlj4nFdRsXTwoCtVuSQmM7uVJeVmfu9doZAoIN9pGkudvHoNQr99Ql6POG5MegrweOjMt1YPvPDGj+I+TyCFUFPKQ2Bg3248pcCScVXipbl2RIP0GrZ/ndq1KnoxlL5/b/S/cGZL5mbL49LqbVuwQWdDFAVw4RI6XNPRqYIKySHGqbp3Dwt9R3lPA0QKBKNwMpte0kW2WPluju2QmX/D6B4ImSB4gtI3/ifZlZ3sqsXgcucIu94TFY6Pc29WUaCD9bm7IZOcNoSxr+p19vkK5oGgWm5i6t36Pagh01DNnVZGoUpbwAVj4aKD5r62ueKP3Urh5Hh7WVMapMpzC4fteWbttTH25dceWtO/iJAjWgdPY2vm/xBC71BvoPttMR1E11QFWGhyHR/GpnrBJzjSpQRn0EzfpY1cpHAKRVwVly8Z+ZmttqKQSJnc+UzbLSIV/EtWrwWsMlN4AABvuwobJb9Yj31iC67TICugRtp7wZxM3LCxnDNbjUQAfv4FoV+DAPSYa0ZMTjBC0xfxK3oVqB8rmonj7qW9QtyC7G8CDFTgFm97rzaVE3nbnpJl36p/JsEd2o8wFkIN/C3MA39qVEZQpvdXhofBK3Brxsn7hhpYelyQK7xwyqXfNWssEH8xlhBonJ24KNklkcdz3dW6HiQ96eFRZVZdHjPnUK3qYdouu2mas58DTz548Ie5dlOi1/tVIsTpiqEHdT5G6w6RMfOP+r6bWaKbRKOK9+8GNi1btEqOQWidaJiMlQnN8JrOmDaA3AJhZhaBLb9sCmHUhB1UU76s2VbVinVCq4dK4Gj4yQ+RYuCAYcE/tqgTsP94R/KuRa48kaNh1U+FFeBiyZXHQioOPHGoB5RxlRk0J4gofl8ov2WHda7gdl7n6/debBSR6/pDT9Jd76MEKYHb9OkPRPN7wXez55YTwVVEDeaXulg2q8zhKz6rNG0NIZSx+DKpNUcW8GAvRtW2ftbDifGjrzEtfVSS+kD3qG5f1SXkWJJSEJhpRfVXuqy2WSRGpZ0RsapXbv26SUyfeslcEL/vpuRjKCvRPDrpV0oqAMRLtoMO5M7RBKgbRF57o8fEdUSF+6q2sauBihtd4jUdKp5s+nXYn5Zk3UmSAeQmlolATCol9QpFTT+85TkxzhW9ABmBK5SwB+cOCUG5I5u/Lr7fYYuymyx1MLKYtUa92zrto70l8d8942nYAEqmo/TQQlR6LXQ2knxhz9H3ipBWoTZxWGnVHaWF2BAyO7u1ddiAgqcQGCzlh3XMJeZxkOeoFD2Ky7MzaTR5jy/HNV6c+dlueN/547E59mogrFoV78qnfoNMEZFrlNR3ksWeTJSDp+pdLrvroCRgyNGgNFmNS5ogvYiFq3GK9P257j5g1jrV4G0DKe8ljPNj18A6XVRhLQwcIHZtpxZwbc8F6jcDeqJrqR/D1jw/u+RV8hduLK+AybB0g== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b9c7d32-cfaa-49db-3710-08da4c0a9cbc X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2022 00:29:29.2123 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0102MB3413 Subject: [FFmpeg-devel] [PATCH 4/5] swresample/x86/resample: Remove obsolete MMXEXT functions X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: x+oymPpQEzMe x64 always has MMX, MMXEXT, SSE and SSE2 and this means that some functions for MMX, MMXEXT, SSE and 3dnow are always overridden by other functions (unless one e.g. explicitly disables SSE2). So given that the only systems which benefit from the MMXEXT resamplers (which are overridden by SSE2) are truely ancient 32bit x86s they are removed. Signed-off-by: Andreas Rheinhardt --- libswresample/x86/resample.asm | 5 ----- libswresample/x86/resample_init.c | 5 ----- 2 files changed, 10 deletions(-) diff --git a/libswresample/x86/resample.asm b/libswresample/x86/resample.asm index 7107cf9d42..6c3dc28703 100644 --- a/libswresample/x86/resample.asm +++ b/libswresample/x86/resample.asm @@ -594,11 +594,6 @@ INIT_XMM fma4 RESAMPLE_FNS float, 4, 2, s, pf_1 %endif -%if ARCH_X86_32 -INIT_MMX mmxext -RESAMPLE_FNS int16, 2, 1 -%endif - INIT_XMM sse2 RESAMPLE_FNS int16, 2, 1 %if HAVE_XOP_EXTERNAL diff --git a/libswresample/x86/resample_init.c b/libswresample/x86/resample_init.c index 32c080ea4c..d13ccd4833 100644 --- a/libswresample/x86/resample_init.c +++ b/libswresample/x86/resample_init.c @@ -35,7 +35,6 @@ int ff_resample_common_##type##_##opt(ResampleContext *c, void *dst, \ int ff_resample_linear_##type##_##opt(ResampleContext *c, void *dst, \ const void *src, int sz, int upd) -RESAMPLE_FUNCS(int16, mmxext); RESAMPLE_FUNCS(int16, sse2); RESAMPLE_FUNCS(int16, xop); RESAMPLE_FUNCS(float, sse); @@ -52,10 +51,6 @@ av_cold void swri_resample_dsp_x86_init(ResampleContext *c) switch(c->format){ case AV_SAMPLE_FMT_S16P: - if (ARCH_X86_32 && EXTERNAL_MMXEXT(mm_flags)) { - c->dsp.resample_linear = ff_resample_linear_int16_mmxext; - c->dsp.resample_common = ff_resample_common_int16_mmxext; - } if (EXTERNAL_SSE2(mm_flags)) { c->dsp.resample_linear = ff_resample_linear_int16_sse2; c->dsp.resample_common = ff_resample_common_int16_sse2;