From patchwork Tue Aug 9 18:34:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 37200 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:3d0d:b0:8d:a68e:8a0e with SMTP id y13csp426205pzi; Tue, 9 Aug 2022 11:35:40 -0700 (PDT) X-Google-Smtp-Source: AA6agR7qQzvji6w0prbdYtlU10Trgw2AQcIes6qPfCVacHWIM/MB3ufnwYRy+cFxT0Y1B11MwnVP X-Received: by 2002:a17:907:7b8e:b0:731:4e73:89f2 with SMTP id ne14-20020a1709077b8e00b007314e7389f2mr8719324ejc.562.1660070140092; Tue, 09 Aug 2022 11:35:40 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id bi2-20020a170906a24200b0073187f41b15si2147081ejb.224.2022.08.09.11.35.39; Tue, 09 Aug 2022 11:35:40 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=vJjpnsuj; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 98D9268B813; Tue, 9 Aug 2022 21:35:26 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03olkn2104.outbound.protection.outlook.com [40.92.58.104]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0BD3B68B813 for ; Tue, 9 Aug 2022 21:35:19 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LWbR6TQzdtGQCkbGiaWgDDXNvwAf5wvUmsEWNSR1Eu5ZUg7jjZrtJ6Q/iiZkG0WEyP7EcCsxGI2G919Xlb4HbwhVHRzBdl7P0QypHkeoPy09YFjuvGDMCxMRDMkmI0OAfGhq3UCR4AMjAdAysZYF5u/C5BIFbNmlxY4BTnxBomFvu+GbBhPLkDk/MVvUDeHQyRao0cAp65ZHDsH+YkcJDAqHCzo3+Kbz/tGKZDpROiYdoCmJrYgVJ2hDC5NYx+ZBhQQBQaw0zSPKJ03bVnr3hhYgswmIV8d2QmCgYQ7DXR//kb4pM+9PF+mfJfuRV3edRLQGfxd8DJ2KhTv9TgagqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NM6DfaYaCIISBtpbikuR+DlcVdDnEMnDYpX18LtHW0k=; b=P6StpCYnIMsXjSCkoqI44a8Y2K/ifGPB1Ju2SlzRKZSifFH8ZW1UuCgqg8pVgkETzDtSAMI09mBvbfGMocEoncxfGwM5lYIMu93+P0Qw53iUzARngHiRKsGptoB4KwvLbHZ+Ut5B3AY4HuCt43YWsGF4NzjOnTbFM7k0wAbPMDIOpEY+O5p2TTPTvoSTGdWz/LAbrM2yYiBRYKLp3K1AfoOVIwiboJaqwY7IU0Cyf4XQ7BEO5Pfe64OX+7eztu7sYhCVk84nlklGpGQICmz+n3paOb7hlRwJfCKp5iwGiub/7uxlNRxfo0W3tTT43upXHY0a0oS4E5j1TD4N019o5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NM6DfaYaCIISBtpbikuR+DlcVdDnEMnDYpX18LtHW0k=; b=vJjpnsuju4Cw0d+Xkvhe5KZDIaOi2t45MsXESbltO+HKghZfQiSWFItizqsm5zuERdatqrGRIbnVvshvJLjenbU4hHJjZkAmiugoHrgnwA2hiJEqJZDSxK8IkoZ7pMEubD7Tq0OkMuZg3mbNhAa6aSqsgEoW1K/7aaLcXRz8LPZEcm0Qmd9kg6oS/s4Yl7WFBsLjiE7n1U7JG7CeE7cOj1goJy6Ch7PAN/fuyvAoYqVmYGQZ/GSy6uB+I1qXcuQ1yZzdOONZwOH7yVZZaLdNMwQkdfPjL7HVqFzB9v/0wIHGLRCkzBGw7uj2pgLtWSBM8XDK6W5l9yp2dCQCN+aXXw== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by DU2PR01MB8093.eurprd01.prod.exchangelabs.com (2603:10a6:10:276::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.16; Tue, 9 Aug 2022 18:35:12 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::210e:b627:bcc9:8c46]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::210e:b627:bcc9:8c46%11]) with mapi id 15.20.5504.020; Tue, 9 Aug 2022 18:35:12 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Tue, 9 Aug 2022 20:34:49 +0200 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: X-TMN: [ZKtinoEyrOj2YO2ETRg+fo+rTFu7xIp3] X-ClientProxiedBy: ZRAP278CA0011.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:10::21) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: <20220809183453.220687-4-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 453b6e3a-0380-49a8-1755-08da7a35e4e8 X-MS-Exchange-SLBlob-MailProps: gjx25WM8ZNXow4yDQWpczRUJbygObe2vxN6Tvg6lQIkxxnH7ZOHThXGkEMvq/4vtoXSjRaxElWYQROuveQGiS12oamUnTvJs5RfAXNJlU1EBYdFQWdOLDLt1cfcOR6kQTYn97CcNrK3c33Oi+miKMvdpgK7bEF5186UzJVeE2TRKyMElWQYzVTwac3ycvl6a02VPSujBp35y/JAhULz3xBUDvpPtS1SRAZ+ApsTYeHR2urhOubvE9tAjur1UYPs6Xx4MEVm8Xn07NeeB8dxetaorum95Qm9wPadQtSRsAeoLi//OaU0jAwQgdiIghp+/WiI7pqU8TtcMgDzWKShHa1gkNs7xd2104D7p3w4fVIs6ebR9QJRLxbUkJpGdndSHcJcwVYv8MRT/s90sLr/tPsK5MetX+4IMXC6aarKvqnowgFdbzfNnQaNuWAi9O/nbHvI5Im5Uhe2lYWYE5bXwtyLTm6YMW45n7GicWbV0/OYZQUyQnTYGBC6zwRtfXpr1oZmxG2pbTuJDGQW264QrVkHHE6l8moZ5mNNwy3eVkOVgMHTZ9DxJNRDEg+egQEM/hB/yGgv2x8hEe6oGBiXtWxcn/Aamgqq8iMKUTCiw+3li/QsBVt6iz+RfkGUIsrrIDL4p6o5RD8WuYXVFsLqiQf6Ah2Woi09njp3amaMm0mfPsZDsdrXDorDtv3RfTrTfQg24TRnXwgrg+RgepQYLqHLX+A5TT2KoaAPZwipJB8k= X-MS-TrafficTypeDiagnostic: DU2PR01MB8093:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mPUnhS4MS4XbqMilN2Q4BtyCmxepBqQOpPKSD+cwEWNe6V2PO/VyFp+vNAufm7yw/B1gGmfkL2N45hFq9f68FBGNAtXUUTF7f9C0+wvBHCKRXVYLd4IxMt4uiJgNf/6eRWOBdnHFX3UPqcR5Fhme6FkjcJ9V8uMOk2Q8nyBFUcqYtiSv0TXYV6Pzx0AZ1i1CujH8GOLszjfipe/1vTBRYJYw+0A6BmMvviPywUiJ1Eoypm2vT3HCHQ50TVkDWxcCme3UP0VcOMrRtu7QmRSoKPNOlXYujGFmcYFl+BkxH3+W9KCcaGeVESWBqMpFYio3EyNe1J7qtf8hDtS/YN8tbuiFp+y4JAAzLm0KzQ0uZdoOTGjN7nyWImlU4r2NW5EBkI/SRw2Q93nh7SoXOhoQqscJ3mizvhxrfqfKx8gp5BbRGxkahPh6WxEqloCmOJ15dKCzcJjm3mMtmt8PEuUrLFKg+DemEyGZ397wQEhb1bBoCYIxn/XtGCmwYafF2ieOjZFrhcUFwfUfHFlhqzsNEWHhywuCvjz/R4dyLEmcDIz3VdqFv6idrsMTo2i6t/LgkRpIUVGVhjO05px+E6EHnsgE6beelmDhua5ApHWJh/xpqT9UwIqJe0rsoEb1/fOfkCEZypLGJ6OlZ/R6SDQSIA== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: PANL2NGhV3qJxCmFlGJIYXVPOxlibuF6qylAplEpwOzC//KLS24uj1q4eRnXvzrh/Ix25mGxzx5QG/XIgjifGONS7azo6Tx04Qr1RC2JoD3kSw1CJY94Y83Mgp5NekQkWydLmdfILDhrCf01RlBPSV3OOSW50KDvM6RC9ijWvUBS4yZrQ/jMRbuPl/O+dT8ig5R0JcrH4tJtmVYuCy8PKR1osI9K6w2Dyv8kvEqaIqeYdsxwt8wigFmckx4Ky3zdbZaFvmi5zJpOuV7X+XgYSmdCgXN3y8XXm+/9nCZTUTmDSBDCPfCQEOwgIdQEDoQdUY+vVHjTlqsKAw8RoViPXDntlAyaeG8xBU8eOPmxqje0/NVPYHhV7Pz7ue1ijwK09LjzCsiITKZRkJExft2KyNsCF8Z9+PgqL7dJyMWIzQKi5RpLAMqLNexkTO93NU6RyudJoEnaTdWRxy+SNEyD3TtlAUOWpXmIsAkVgiw6BNwW1W1hHw38ZL+vVusQDqkK7FiE3/pCz1QVclrt3RXrK/pmgZHztgCxAojLUw4xoHB8H007vJgOl8hVoEMZSuIvrtUscdMMTm4FvGEB9qLdCjalhrT8LunEy5hGJZGrMwbyzkA0CXFSeLWzfyvy3Dw0vh9Lk4JfDVQt/lFL+OZGFq1PhMWODMr3v4vZPgzBeV8ov10lEU47xLLJJxgTshzHAuSqaHZF/aunQlNddYTd8LzTGIOomjG1xdYZNbFgbe4WRh6NbIGlNbooU8zARjN6HhpyAaM8Z7F+ne+as62KlEYfJM4ZCcP8dpo3l2TvEaBeZZTtx/go+JAtnEE44oxhIHLphrNy+dPnb0Jnx0f+FzMlF4S4qNbVVSejyirmRzjY/9ahadeD/swvfKMsJff7PI1EOyMv4JysaQ+9a9MbSpP9QRx0136i5q8bpDy18J1eoMPw8Wb6tQX42OJe9Nh3dwNzf1z7OW1HnLK8P72QIQEoUKUrsmk+1jnIIZX5K2qH4IdWTwwIQkao3SigiwjvQKJB2mPv5IClE8D7yggb4doCBXRP7gENIcAab8nBNlWciaPgTKQpzeQd9jER1NRLglq/5Eb4dDVk9UjDkcS36XF3ptru8EoGDLCh2wnB2gC6M/FoE7JBRIPcJsVZL0Qi7ICsH0n1f57DMJJ0BGZV3LWh12qCHYgRlwD8WUMvPNURzVknWj6OSDuSuCJI8LtLu4VHNvjYAxsxTfmsNQNWWUsrl0fq4dEPvEDO2763RANhsm5KkcoYlmf4h62uD7S8WhCDMUoQ8MnO2UVSSV4evoYAaKoN93RYLrEVpu8Agns= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 453b6e3a-0380-49a8-1755-08da7a35e4e8 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2022 18:35:12.1117 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR01MB8093 Subject: [FFmpeg-devel] [PATCH 5/9] avutil/buffer: Never poison returned buffers X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 0E8S+hx6ih/0 Poisoning returned buffers is based around the implicit assumption that the contents of said buffers are transient. Yet this is not true for the buffer pools used by the various hardware contexts which store important state in there that needs to be preserved. Furthermore, the current code is also based on the assumption that the complete buffer pointed to by AVBuffer->data coincides with AVBufferRef->data; yet an implementation might store some data of its own before the actual user-visible data (accessible via AVBufferRef) which would be broken by the current code. (This is of course yet more proof that the AVBuffer API is not the right tool for the hardware contexts.) Signed-off-by: Andreas Rheinhardt --- I already sent this patch last October, but didn't apply it due to lack of feedback. Future patches of mine depend upon this and therefore I am sending it again. libavutil/buffer.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavutil/buffer.c b/libavutil/buffer.c index 54590be566..e4562a79b1 100644 --- a/libavutil/buffer.c +++ b/libavutil/buffer.c @@ -341,9 +341,6 @@ static void pool_release_buffer(void *opaque, uint8_t *data) BufferPoolEntry *buf = opaque; AVBufferPool *pool = buf->pool; - if(CONFIG_MEMORY_POISONING) - memset(buf->data, FF_MEMORY_POISON, pool->size); - ff_mutex_lock(&pool->mutex); buf->next = pool->pool; pool->pool = buf;