From patchwork Tue Jul 12 10:27:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 36759 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:6da0:b0:8b:e47:9dbf with SMTP id wl32csp1909341pzb; Tue, 12 Jul 2022 03:29:05 -0700 (PDT) X-Google-Smtp-Source: AGRyM1skWD7NyEmZ3Jw7lVUzwCCC+HAtqdzHqcSNIpKwWbdlW1cwWjXqv75B5U/oVw1E6y9Q2z+X X-Received: by 2002:a17:906:6d91:b0:715:7d4e:84a2 with SMTP id h17-20020a1709066d9100b007157d4e84a2mr22052597ejt.504.1657621745273; Tue, 12 Jul 2022 03:29:05 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id l18-20020a170906795200b0071203baa0desi13856195ejo.260.2022.07.12.03.29.04; Tue, 12 Jul 2022 03:29:05 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b="d/5Q59F9"; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 638ED68009F; Tue, 12 Jul 2022 13:28:39 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-oln040092073026.outbound.protection.outlook.com [40.92.73.26]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A51D168B88C for ; Tue, 12 Jul 2022 13:28:36 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aCeQK2ycWfU0cmxdZqJjWeWkC9Lv/jYEF0V8SUlvdGL58W0cCBH+LngQy5EvjTBwwrgLwhKlo4YYkpD2LX7fKwD9Bv0DMUEbJYnFRBxw4yB+5miM3LyY7um/n2PoE6QBmgAHovcx3kS1W/LhNL7DJ9nQXhaH7LBLeQFygTFROEehMiO9PzIxJ0wJ1bU9c0NMSnDvYYzosApOLjWrZiFhF4fiq7qfcubedH5F8b/cCx0fjuwLCDWGmSG9R5bB9zTl5aGl8UlgiKUD7fA91Hrn2j0P708XSUvJqkXuiod6+oTM1E4/Stqc8L57/rtC6ECTucxqFiLTiCx2m23ZiKDcug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I2kJ7xL1dhAppTtXo9ruvG3Yhic0swg7F8Eiun21ZwI=; b=idUJkNOdjKVHb7rvjc8D9Ric94EDBKICM9HjNNgLiBRNFyuHh81YOiu5QcJv2FU+DAxK0uU1ewP0TL8lDsI9cQr6SwD8u/6e9JlXwZgRwrQVZNjFK/OeNawN0Ex8zToNlRtIa7EZhNL7/EYUDns5kz5DPaB497y/9cfya2OVzsHawLFMoQxVIroYlud4T1U2upved6U7KTV2ZYIibyNVeh4YJ+ZF2L6Q71FId+6vyxtO1xh35QhZE4Q4pw7NeFS2adfFjxNk2Wp8eqmbFxnUZwbDIGCyUJVeO3Ymzs5hi0hLJ2ZxY7w7Hvp8fwF9x018zJhWgD+KnlMwOUIlaXjgEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I2kJ7xL1dhAppTtXo9ruvG3Yhic0swg7F8Eiun21ZwI=; b=d/5Q59F9ZWaeiqsj/pnQJUO9wTLZpoRYj6nCBeLx2XfgNTbWZTxZFCEewIAh6B7gj+E+Ua2ZFNWdWitHVO9kapV0uquFO0MNQBBcFACl+NhkfpysLNF4CX60s/QqKMGPhnuPO/k0Ka5djqgj+rOGpmChxMx/6rVdyLN41baMYdobGLjziL2da1Me81HTcpRhSr2MXxgXIq6BZzXvlwJPwuurLfaeXm0s3yuf9fl9dFxnEoBVZFqkgqV3zXTWHM+GCWtUmFyniym3OqiVJ1E7Q+VvqlvE2S08wlFnOcht52u9CKvg4bVH8W2kTMNWMJ6MHD6D8fxdKuS7ulkY0S4+Bg== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by VI1PR01MB4814.eurprd01.prod.exchangelabs.com (2603:10a6:803:92::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.25; Tue, 12 Jul 2022 10:28:27 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::210e:b627:bcc9:8c46]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::210e:b627:bcc9:8c46%11]) with mapi id 15.20.5417.026; Tue, 12 Jul 2022 10:28:27 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Tue, 12 Jul 2022 12:27:51 +0200 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: X-TMN: [GOWCjiTliw+0bkxGZKarmSHLhQjsaVen] X-ClientProxiedBy: AS9PR07CA0048.eurprd07.prod.outlook.com (2603:10a6:20b:46b::15) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: <20220712102751.3784996-6-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fbf9b38a-eddd-47ab-fdab-08da63f1421c X-MS-Exchange-SLBlob-MailProps: gjx25WM8ZNXMm18b5TlTbUk9d1Jz4Ba7aQyBo7ZvaFBC5hSTb+ta/+jqabwWp3n+ej/6XnSOdqB7e8uwT4T7pgU5sRxM4NpRBohz1JuR9IRXNyVSoOcqgNa3MmkKHOlAtqVF/B24bWVxzG25wyw3B2PK2hj36FshB4i7cgvQYIWy+Lw6lWiTRPH8FeXFArkrQI4JfR5wxwVBOX3qH1FPe7PtiIUIRtHHK+lL45PPLdCqWmxli9dCzNQJkjlMPVKQ0RRAe5UXnvpvXrieNtwxmMLiq9s4xn54xgrB5waPEc2bcSEJodrLWpbTEhmRtfE525JDdVR2v0Abn/uxojx5CPxk+I2LRUMIdh5on8H7Gadvdd8vcE5hNjNH3A6u/xdXCRVD9iUZ4WfuEvF46ZPIFiiyxt/uM5l17m/OoWsO/fGNbxdg9lI870n6CItzPHXOYeI512mvFTAQXZiDXpHh3Z+UGLu9uG6ZatH98FylJzwH0HBnwBUnpzWeWNu/LB507rlbIk7DR4+AwAaBIDCNyrWaNJzzPzJAbAinVQRY9euDf9QnHfvyphgFcasnT7CqcaNzn8POM+ucl2tPJ6xC/9E/numUjgN6DeGNnuvxFxTAKVY1Ec8CjRQO6NM9tspktr+d5jGMAKQnSjuIYllgSSTVjA4g8zxHp6dQU2Hjs9GVwb/NWiyinxJAqhwcmXSIBxHKHnFFTh70MnkSfEqJ/UVfE00IL6C/+HPs2EZjI4s= X-MS-TrafficTypeDiagnostic: VI1PR01MB4814:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KL8F/RaWN+1vAWoAxi5Z6Ochd0hOm+eTP+wqdWtohFWkhMm/NfZMFH/cSf9zeiJ4MgzQEEM++B3ln0AVZp6un3hNxu1KttgRb+lYHf+1K0bV6UEhF32sjPpTgUEqNUkI9PkoTH9dqpVuZz4Us1TeRiXDmivpDM0p45IQNyD5Y7YpLaqXwRyTz6ovqKCZw8o4caZwNhRG7bxjt6mnUOC2PdJEHW3niMnS9nOZNFd3XfUIwtK1LioQVjs2LqdJxirM1eVON33S1f2mbF3+fklSbY74b+3FtOYgyFjr8M5dQ3GAckUgJXChny/RN13v963rWJIWzmdp6TRP7g3v21cRuO1lylvSZXXshqsd0Y+HuCNlunZMyJLhkgOzpS/Zp8O8yt1BQGLwpvLwnnA2oiMbRKC0PhqV1bJHsOHDNP98Wi1fZIQoCJDNYrJUWRxGgPQkU0LzFOKWIlzXoeg9yICCeSLdK4hA+3aFl1wp/2vKNZAD5nYwbaH2jHATQ+r/thhnPARoe9xql0koO3GVwTTwlimq+UpVpOQm+E27fzZGkNjh30USVZQmDd1Dl1XkZZ989iv5/3OcJthJySTr3McFE5/J5gVkOSR4r+u6Wc79UvMm4/sH2TcByERrzzzDGu1ZWWtGu9wLoeYzpDi2T7Z+4Fg5nk0i9Y3ZlsB61OTTD8lAUv91igxpsHTaN0KdMqbIIcn1+jNfTNcZD99VRMzTDg== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Z/+UCrCUSnkIibjdi435ToKk2cxIa8p/zEAzaMYj7uaAU9O8wHNlM+tQfnxilfTXUPaLMHZfT4HP2xQnr51rRGs/T52l/iVwetwnnbIKagMy66q6V292/qAOOZSAlr+cXS9zn2kCMe35V7EYeQC8XbCFljaSkQaqykIjz7X19tzWmuTqChCrdEOjV6saFUGmaF5+QoZhm/attuQxGnj/V89tXKwTr0QvuLC0lr1qGBb+XXJNSnhRwvdwCtwK1kkqWYN1C4otEEKrxtTAbQtYr2xyG+XI3ein4NA9JkZ/NRZ+0uKmQQ2Wc6D/IRgxirbQD4nCh+j/GQgGIxsZFmn/ti6ToK0xe2Ol/fAeyCzBfYfRBHn1TYG04tJnL3VSgKgsT6D2oq1jLY4kuQET04m3yZaT32WpO59t4dJJJJc6OImkjveie0kwHebozqLcSLHP2kcN0TgBt30vGrvCx5Gh/zLvuoRPQjXPVwR6RS6luVrnSD1friuDrO2PaXjn2USAB3KNBLUyhPf0x6IMFr9jD8/a3bV+GLpmz00/oF2uzWkMveZ86XAfj3irw1sOUlOwxasRW208H9pp8h5dUr6NBURnNImttrhPbqBmwh43+fRbcpHJ1rR+0iYyV6CqxWtDQ+7P0Tt9mGsaYsb5P5t4S4FmY549pil4x+y6b2Xral4E0u3FyiOgkQGEQlmQDLm25qwPdO6bLTjzHviRHcgEVGDCY1GiukaSv1cX7TbWfoXNCKpZGRSm/IxztrJJdRBDMIKhygCp9gfqv1vCean8G9oqfHn9hIzXAcGVyXbLwrYnASv6N8GiK0MOi/Z0yfnWtwq/KMF3HjTOjnmriTdLz0o81DdhAGItbmEYsLvRCZMIBuZYxk5d4ZmENKI6nTpKAwSuLOeNVC93a7uDBt9tAzybvQ5PFLtFH28YEnaXt/mem03rD+/G/te+i+sHsyBaV61Wchq6vlwjYOhBLhaJXc0OCqGAB8P2d0a00Bq/5jnJJn41ITbkwur6CQuX4czzMuWzwBLjfJTAfqInWgtM6XXu4zl0iRCILZk1aCTRkjA7Je3lvNNtHFh6HVSXef6XhiNhfFUQjbWEQFnr9wK+iAaGr5FtMv050nrhmlvsKxhYZ8G0mlLm8F3FzyDiH7BhpiIQXr3ilRwwcaZ/EFlpENwrUwC1ftv8oUEOgBFWrcKxw+/ohu2zfLJQTlY+5JE4DqRWGBtmv3yoyPHfi1RjMUOMRp6VBj+IvUtKlpcNZHaeD7U2LXOv8Z/mWDrf4Ie9chnvRbqhI3TuSuXDNLdSAoKez4quaMqdfAX82KGGeWU= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fbf9b38a-eddd-47ab-fdab-08da63f1421c X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 10:28:27.6935 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR01MB4814 Subject: [FFmpeg-devel] [PATCH 7/7] avcodec/iff: Use unsigned to avoid compiler warning X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: kTsreFRCYHwb GCC 12 apparently believes that negative palette sizes are possible (they are not, as this has already been checked during init) and therefore emits a -Wstringop-overflow= for the memcpy. Using unsigned avoids this. (To be honest, there might be a compiler bug involved.) Signed-off-by: Andreas Rheinhardt --- libavcodec/iff.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/iff.c b/libavcodec/iff.c index ad96bd9191..0bc2e3ca21 100644 --- a/libavcodec/iff.c +++ b/libavcodec/iff.c @@ -152,9 +152,10 @@ static av_always_inline uint32_t gray2rgb(const uint32_t x) { static int cmap_read_palette(AVCodecContext *avctx, uint32_t *pal) { IffContext *s = avctx->priv_data; - int count, i; + unsigned count, i; const uint8_t *const palette = avctx->extradata + AV_RB16(avctx->extradata); - int palette_size = avctx->extradata_size - AV_RB16(avctx->extradata); + /* extract_header() already checked that the RHS is >= 0. */ + unsigned palette_size = avctx->extradata_size - AV_RB16(avctx->extradata); if (avctx->bits_per_coded_sample > 8) { av_log(avctx, AV_LOG_ERROR, "bits_per_coded_sample > 8 not supported\n");