From patchwork Mon Nov 29 20:17:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Soft Works X-Patchwork-Id: 31820 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:d206:0:0:0:0:0 with SMTP id q6csp6673848iob; Mon, 29 Nov 2021 12:17:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJyawjFoTwAwan6qX9MYEPRmFx1huCnmE7CQjNZtX7bjA/EVb3SNBsfLcEAH3ZA12+9Nwyt+ X-Received: by 2002:a17:906:7688:: with SMTP id o8mr17435763ejm.291.1638217073088; Mon, 29 Nov 2021 12:17:53 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id qb2si33238134ejc.155.2021.11.29.12.17.52; Mon, 29 Nov 2021 12:17:53 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@hotmail.com header.s=selector1 header.b=ipfkhpm2; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=hotmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D1EF968AE6F; Mon, 29 Nov 2021 22:17:46 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12olkn2090.outbound.protection.outlook.com [40.92.21.90]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 335E968A15F for ; Mon, 29 Nov 2021 22:17:40 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DqxnCJGu+BnIkwlB4T24voPm8khVMMyiA0MC9ru08DpEr8ixxnzbUyW9vWSblqo5mFlCK05+HIpqLT+C8AfAAz1SOeqfIHkrlVUYC1Ca4kudK8R+NoB9VNxQygZdivHgXWhVEMa29LrP/ESjsPJz+TRJlJ6aiphcwgtL+LAGX+i7xtmUhm0fFPmlqD1hIik0U8sii/+8AH5B7yD6eU5N/NU13vzXH+nLrSpssN0aLDXXjXifLghA5zv3SfAUD711fGEG+aUbUwTRtBePnpoeZH9t+s8DER6994CWPSXWLxC0wpvuTvZO5Um5Ttz9IwGZv7/AHJvaukgU+be44RM47w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NUi4vfQ4BAiIKPHql+SoeGFz0RTvXZIl3sVSDbKFH8g=; b=WOqXKkYqjzsrl1VofmMFryFEK11IMy4/hQFRqD8LUStzc3k7Tg7vjzOXo1dQU/Zfsgk1kfenHqVpvj+nlaLTFpslhAK7VfixsIQTa+Qk3MRZ7Rizg+VPwym7fUtaqF3LWHiHU+yLllShsWVxE3vKgOsp56pOnPPCdj1p3Iy7r99QSYBBnBFj4sOzUKYboKq5zHscipHOEd0bBjIc5CJZNG7dFzFJ09mpYARrK4fcTwLrWbXN8Dy27TNshbv9+uiO+zCD2IIbnKY78+9WNobxPh+ExUTObhqqGUNdO0b5KjuNBzT2sTbFGKJyAP/JhT1bBjgRVDqTVVQMsDQ7MZia7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NUi4vfQ4BAiIKPHql+SoeGFz0RTvXZIl3sVSDbKFH8g=; b=ipfkhpm2fWSIPJ0GRbi5cEqLZ15+iT9BZxyAestF9XeKlAqdbmlno8PDqNDCxfrnbim33szkYH3YSs+2Vppc5pme4tRkFjt5JgVukRfddg6SxW2VSxEkLuohNy9zbAtAMBCxAvD8MmPq1OLm+4JIIjR1wrb0ucxbQKwOxsg5pSFsk5PuvmVzitreUlsbIE1CvvAVb+yZvAAokFJFXzwkieLlSZsssZSc9YGGg7jYvlC71fFQznc1fjzbrlmrrtnj2rpe5WNK/NSBO+hRWHGdfcPl0yae99MYqfmYMUBDiRqvduGSe4rbldPnXrHEs7tYGCX8zQqkffzWfXEa26yJJQ== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by DM8P223MB0336.NAMP223.PROD.OUTLOOK.COM (2603:10b6:5:316::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22; Mon, 29 Nov 2021 20:17:36 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::9c8d:fc63:9488:9775]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::9c8d:fc63:9488:9775%5]) with mapi id 15.20.4734.024; Mon, 29 Nov 2021 20:17:36 +0000 From: Soft Works To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [PATCH 2/2] avcodec/dvbsub: Don't dump images to disk based on DEBUG define Thread-Index: AQHX5V4mQncVTgqXD0yqrf6rcm3naw== Date: Mon, 29 Nov 2021 20:17:36 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [hVA3h+vEoRIb6S3ePvUuPWC28w0dIqxO] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0c994b6e-b3fe-4bed-c0fe-08d9b37548a0 x-ms-traffictypediagnostic: DM8P223MB0336: x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6y8BVcf6UrALgQiTRN+nEwx2grY/eLi5GX3jc9gpwyAbjDORrvC/5GIowi3WigSc6yxeR10TUQvVBDvSggA04/HAZws1DkNnKkHfaqmOVMhN5okaOoF4zx2QK2amI/DZ4ir5NdlNx+SoAq33Ysnxr9Ow9F0fkEw/M7Nae9JAZXpngtFiHpvWGvH31Ru6eNhnMUzaT4itC6d7K4ZWFCA1Q1v5AMWdiYTx5bd8jVlCrOKxjzvqhIV+iaj98ouIdQyTuxZoKtvDtS06QxpX8y1/kzCiyl/j2zOD/TTB+CeBnFSF0fBI3HnwcfLp6UFJbn+KMSB1q+V6jMCZWooSL3AWOKST48JeyPKRI6WAQAYtirUgGOXwUrcF8S/u4Ru4Ph4KoIVz7Ht15i/CCvEnfFLxjnToI6XLdvuKpD3y5bv8g0QzFzWiJDruqeiFkGfhbiOktyOVZOUudchtRai3y/lJOzDaIMBQCroX4oyzqRdiHFoy0WMSqnTJZ22Repj1/i9qeq/BsSUAC8B2C73qTNeVQTROiHOeubcF6EZu+Qcaz4IC1bh5z7PjxL5pxFT1TBzIqQGejXq51YGivjw/rQ4eBg== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: EtHa5oWDPvmZIScFtn9h60ENDWxTGZBAQ1JBAVMBQWDlk1OC4RgOC3IKIvCy3ieGXeUhw7+LqfH3n0WbsnmnRlsXin4xr/08PlmTojaYsIfRJBybeBI2ZUbHCKQcQj+RAVeHKRVFfV4UVlQGN5pdvdJmay7uv0/GTCPmmemTMCmU3gMaUT1YV9Qw640j9rC7GIYJtaB5evxJvYFuhPPstk4uRA/rPbLESCWAEp24wABx+Nl27IQ3Cd/0wL+GwG5eb8oRM6XXMWCbG7E9p/Qp+iagMbnJnncpRfwKfQEWg7OVG8UpkNy5DGAKuOKR6DgVdOlIYeqiZL0fgxB/h5430plFV+8GlPzV7mbMcWmmu73mnc08FoDpBfUdRcRosqpeqP4N4SunKcHfWVYBFuXx+/HoXbWCgBU0iDfUiJpCK/q+O2Q5IVgjcC5Vorer1DgSO8UN+Tlt0nWlQ0Hz5103OKXfg1F612aMvq7F0zFz2CUKcNT/piMzo9EKTLitaBRdM4GNIzXorDE5YAGmIvq/McU8tMU4PzqRCbmW04r7GIdk5LraMX74DhfZmNRmevcRS1N+SSZFekUl4vb+tGhOxvir0PZKFRWmrZtZWb99z5EzJv3ijK38bmTAxUdfpc6zM4ri89BUW0OAM65ulcJXV11sJAO88AuJ9x64/dE3OMBX37ceM3ShjSnBdYfIrGzFezERCorNutMQkIXcIVQoIw== MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-3912-16-msonline-outlook-1fc6d.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 0c994b6e-b3fe-4bed-c0fe-08d9b37548a0 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Nov 2021 20:17:36.0377 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8P223MB0336 Subject: [FFmpeg-devel] [PATCH 2/2] avcodec/dvbsub: Don't dump images to disk based on DEBUG define X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: QMHYYJZKygxV It's been a regular annoyance. Introduce a debug-only parameter for this. Signed-off-by: softworkz --- libavcodec/dvbsubdec.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/libavcodec/dvbsubdec.c b/libavcodec/dvbsubdec.c index d192f3251d..e629b315c7 100644 --- a/libavcodec/dvbsubdec.c +++ b/libavcodec/dvbsubdec.c @@ -137,6 +137,9 @@ typedef struct DVBSubContext { DVBSubRegionDisplay *display_list; DVBSubDisplayDefinition *display_definition; +#ifdef DEBUG + int dump_imgs; +#endif } DVBSubContext; @@ -1538,11 +1541,11 @@ static int save_display_set(DVBSubContext *ctx) } - snprintf(filename, sizeof(filename), "dvbs.%d", fileno_index); - - png_save(ctx, filename, pbuf, width, height); - - av_freep(&pbuf); + if (ctx->dump_imgs) { + snprintf(filename, sizeof(filename), "dvbs.%d", fileno_index); + png_save(ctx, filename, pbuf, width, height); + av_freep(&pbuf); + } } fileno_index++; @@ -1736,6 +1739,9 @@ static const AVOption options[] = { {"compute_edt", "compute end of time using pts or timeout", OFFSET(compute_edt), AV_OPT_TYPE_BOOL, {.i64 = 0}, 0, 1, DS}, {"compute_clut", "compute clut when not available(-1) or only once (-2) or always(1) or never(0)", OFFSET(compute_clut), AV_OPT_TYPE_BOOL, {.i64 = -1}, -2, 1, DS}, {"dvb_substream", "", OFFSET(substream), AV_OPT_TYPE_INT, {.i64 = -1}, -1, 63, DS}, +#ifdef DEBUG + { "dump_imgs", "Dump subtitle images to disk", OFFSET(dump_imgs), AV_OPT_TYPE_BOOL, {.i64 = 0}, 0, 1, DS}, +#endif {NULL} }; static const AVClass dvbsubdec_class = {