From patchwork Fri Dec 10 21:37:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Soft Works X-Patchwork-Id: 32275 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:cd86:0:0:0:0:0 with SMTP id d128csp2373686iog; Fri, 10 Dec 2021 13:39:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJxRwSG1uL3faz446j495rqu7tk9wMuBG1yLSNVd90hjoGGaAA6+mtkQZrfW1B9amVXcZfWs X-Received: by 2002:a05:6402:5146:: with SMTP id n6mr42381181edd.126.1639172347134; Fri, 10 Dec 2021 13:39:07 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id d9si5150875ejr.221.2021.12.10.13.39.06; Fri, 10 Dec 2021 13:39:07 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@hotmail.com header.s=selector1 header.b=OR3jhfSL; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=hotmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1719E68AF81; Fri, 10 Dec 2021 23:37:37 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12olkn2011.outbound.protection.outlook.com [40.92.21.11]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 879EA68AF3A for ; Fri, 10 Dec 2021 23:37:34 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NKFko3nfS2B2tbLIrMJ9olofSRJ9yroInOWa0bvInfec1KiIRHH2jiPCCQP98uH/KP4mRR9QQ2wO5hwXkQMXl82MP/tMSOiMWn0cqaZvUb31SDEdZoYAWCxo8OvmAyMTCnJa+5wvCM6/DnqnzLqXqWDHs9zLIQCmwDNmOEIMDDg92MK484IpAEtbl0sM7uVwiVuZYjki/dUC/GYpDuKQPAxMXgMYPWVw1l9erVHeeJ+8rYhPOWKIM4v+csHUCKWIMkLonwn8HAAGvu0ySnZ4enfKWpBKen6J53tUGxawgv3jEeJJ9tI1ke/OrEqDROmuiMzp9IPxBCfUiBLcql3xlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qgJmS0GpwRFmLIz6mjkSSnEW3v7UTXOe8XP6GYa7hBQ=; b=BX0ESGDBr25IabGLIpOpyKWazPhPfJvTbhXjXSwJVYpiJ+858Sq8uq/pn2nuXHmK0vuDuqyB11f7tX9CFlT1an1yDYNu9u/2u0APYq2B1PEqF5PGbjlC0xBB9u/PqHh6IKtsbqa+JjtB84yf6wDqs5UYESWbi+Q4xjtBbvuTgCLLHkWKpUpXXk6dFQQEBzT1MCbWXYTyH3e55QwVm/eQV3cWKdF+IQ9FW/4GQp6rREU5oUfFKVK8JUJPN+wJCp4hiW9DLQnOE/0rFaMBqLlleaPDexyZZ/6z5qIiR/0BhkfVdh2OtKhZocUZmbJ/Rh6Oasao6imZ4fhLHhWoYjjXNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qgJmS0GpwRFmLIz6mjkSSnEW3v7UTXOe8XP6GYa7hBQ=; b=OR3jhfSLnRzGFNpZ9enzjoZNEo5vsISqEOfuALFSpeJA4KxbukmuYrRBce23LGrFDlHNO9LzVs9NVqbJl8rxhCkzUHTT3izLYhqzNkt9xunyKfh+U7w7RaMCZeiQ+0kJAktgTB51zeZLjrs6y/CiG3dORThtMA1xPWO0s4N6eVShza/znWyLWVTh730kynxMKjnU8gNdSNqKGuTqHxUmApKPNpXTiDQHdFOKmM3CHADqXjEdgvs+L4VPe05tohUnu+q2M7ySOnJ6DbJRenbLZ/RfS+k6/dxtAQHKA1520SIeha+ufHoFiI7ia4np8e4QR48niQYK03pm50i3VrAFyA== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by DM8P223MB0397.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.20; Fri, 10 Dec 2021 21:37:33 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::9c8d:fc63:9488:9775]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::9c8d:fc63:9488:9775%7]) with mapi id 15.20.4778.015; Fri, 10 Dec 2021 21:37:33 +0000 From: Soft Works To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [PATCH v23 10/21] avfilter/avfilter: Handle subtitle frames Thread-Index: AQHX7g4k9dFhErHf0UGtxozAko+wIQ== Date: Fri, 10 Dec 2021 21:37:33 +0000 Message-ID: References: <84c6ba3b99bf387e818d59f2161009ead8fb5767.1639172095.git.softworkz@hotmail.com> <0b41271ed30b530c1d55a9b824fc8bbbbd14fe5e.1639172095.git.softworkz@hotmail.com> <9f2875d043147119351f59b6410d718d170574e1.1639172095.git.softworkz@hotmail.com> <62a926e2d86310039653324bdf2a856f09a0fb46.1639172095.git.softworkz@hotmail.com> <75bb9ceffef9e8e2d05ffce8a51c1991d5d3a973.1639172095.git.softworkz@hotmail.com> <554aab35996d92c90ab3b0ecb2c0c6c1278479d6.1639172095.git.softworkz@hotmail.com> In-Reply-To: <554aab35996d92c90ab3b0ecb2c0c6c1278479d6.1639172095.git.softworkz@hotmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [Ph/yrxjC5cTs02uv9PHscSBaKfbtQNFj] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 26af0159-676d-45da-9942-08d9bc25468e x-ms-traffictypediagnostic: DM8P223MB0397:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 38Fe+PBEJhSzhIno+fR8ARMcM5RTlny9Bl7l4AhIbPdEnIkQYGuDZEEA4CDB1JRntY46EhMpu7qYLcZliEaKHjXZmf7kpQh7sL/J221W4htdaFH8WLHFVMqpgqWG0D2Wp14FB7MCvzqaclNdc2gOsLg5Mcv4qe7DzEZdZkDP8oao0w4CcW3XTLzKMULLJOBodlgbVqFNp6QtKU7cmvG3VQeuvhLLSH1SDskHTLG92ScaXr4I0r+2HFOvM0BpoxegPJIo9NyMk0RwFJUFGfUDPMoRpijCgpRD9E5Qmps8Uj14XhKM5RAcZv2n21ME6qT9clk2AoTEu9QpCNQCDJpE1SN5eDWfGLYHdagNzxbDW9PUhu3IfuTxijBTeg1eBXuuZvfjftqpom5YefJ1qOyrL74PXzwCEsRrBhZ4yMpK0YcvAOa2a11oyb0YgJ+j7jq3z6MRw8h6G+mK7qCH9mPPHI4Pe30QdViQKPNZGbaCvwXr1pTaXpI7g8r7EDNhpYujfNJ4oT91Q4Tft72aS75oyfPsWjbCy9QDbqeLxaghML+2WiMXabPh3W4bTiYdXaQ6kii8Z6M0xAqfjA2iwtMWGg== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?q?y0v4tRaH6yubFvLsHJQshFwG4eNe?= =?utf-8?q?Vbzia7PxTk+tZ7x4iHzr271N1MFdqsnOjVC2rT2S6H2cBCpMeMNW+z126AATrZUkj?= =?utf-8?q?DwDvreCRVs86wiGbjNIThzz5wCFeJ2mPie5Iw277f4YSk7IOGd7P16blPIHh810rd?= =?utf-8?q?pQwVsOrottvTPpYu1BnG6/YcHcqspQmiYgVtOr1YPePoAtlE7FnU8NnWJdsw6Eng4?= =?utf-8?q?IarLgAXMrCG1o+/XMHCVhRz1iQwbF52S5YejrFxwBomqC724+LnUdyslGMUBdY/vg?= =?utf-8?q?n+dxa1hB1Yk91kh+b4L5aPGUCEErw5rD3rDnbjOQVZ1JWSalVT9u+nZagc780kQO+?= =?utf-8?q?B/KcsJGOXECLWIl+GZw6cljLPhLbtfSXC9TWNA1weWnXDH3KrarAnjTCgtcazCcvN?= =?utf-8?q?9J1C+5MfSMWqegLTEnCNuXFK+sh+Fefn2i2Mx3jNmFvVkWTV5P9mLQTCWJ6xJNgnF?= =?utf-8?q?pYzVg81kZ0XrouNbUHY/cTfjKCnBPbkVtxIo9qziUQ5zjQ6ABeDKDTDnqUJekn0WA?= =?utf-8?q?JJlRm+RfYOqziNRBZ/pt12fRYpmsmHQCM+M7BAaYKANCYLq7VHXX3tz7pFUzENoc5?= =?utf-8?q?M1+D0L1JVqn6Eg419lySOnwVYETGPce5i/hAXUzOFwpqkptuBU8lp6E4vBD+UmmYS?= =?utf-8?q?irQ0Cu34yAaDHsNSWyC2kCuVUODIamS35ubPJ55Frqbg+cUDxZ6B9u2q0bICFALew?= =?utf-8?q?Hh5CaMobCfVPVRnUD6rn4S6aeCpYfAZBC13d288VCnkiAUyqsuDdJd42Quyth5Fgf?= =?utf-8?q?ih3d7YJj8qNoBJmsk1P6+uQccr8Uw585ZYXJVRx4487jKm478qWYua0LxukwEDMy9?= =?utf-8?q?toibSM+0w4SgjvaBqcPDMiS2q8qlk1LclmZ797yeuJN4YQ0UuwZ46dwH5BlF2oTOE?= =?utf-8?q?q73MhKV5tExx7nsEV45fDdb9Jg7GpkLrBD0P+WrnmWWg=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 26af0159-676d-45da-9942-08d9bc25468e X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Dec 2021 21:37:33.2142 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8P223MB0397 Subject: [FFmpeg-devel] [PATCH v23 10/21] avfilter/avfilter: Handle subtitle frames X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: xE10Tjgu+7Ro Signed-off-by: softworkz --- libavfilter/avfilter.c | 8 +++++--- libavfilter/avfilter.h | 11 +++++++++++ libavfilter/avfiltergraph.c | 5 +++++ libavfilter/formats.c | 22 ++++++++++++++++++++++ libavfilter/formats.h | 3 +++ libavfilter/internal.h | 18 +++++++++++++++--- 6 files changed, 61 insertions(+), 6 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index df5b8f483c..75d5e86539 100644 --- a/libavfilter/avfilter.c +++ b/libavfilter/avfilter.c @@ -56,7 +56,8 @@ static void tlog_ref(void *ctx, AVFrame *ref, int end) ref->linesize[0], ref->linesize[1], ref->linesize[2], ref->linesize[3], ref->pts, ref->pkt_pos); - if (ref->width) { + switch(ref->type) { + case AVMEDIA_TYPE_VIDEO: ff_tlog(ctx, " a:%d/%d s:%dx%d i:%c iskey:%d type:%c", ref->sample_aspect_ratio.num, ref->sample_aspect_ratio.den, ref->width, ref->height, @@ -64,12 +65,13 @@ static void tlog_ref(void *ctx, AVFrame *ref, int end) ref->top_field_first ? 'T' : 'B', /* Top / Bottom */ ref->key_frame, av_get_picture_type_char(ref->pict_type)); - } - if (ref->nb_samples) { + break; + case AVMEDIA_TYPE_AUDIO: ff_tlog(ctx, " cl:%"PRId64"d n:%d r:%d", ref->channel_layout, ref->nb_samples, ref->sample_rate); + break; } ff_tlog(ctx, "]%s", end ? "\n" : ""); diff --git a/libavfilter/avfilter.h b/libavfilter/avfilter.h index b105dc3159..9f917deb41 100644 --- a/libavfilter/avfilter.h +++ b/libavfilter/avfilter.h @@ -45,6 +45,7 @@ #include "libavutil/log.h" #include "libavutil/samplefmt.h" #include "libavutil/pixfmt.h" +#include "libavutil/subfmt.h" #include "libavutil/rational.h" #include "libavfilter/version.h" @@ -343,6 +344,12 @@ typedef struct AVFilter { * and outputs use the same sample rate and channel count/layout. */ const enum AVSampleFormat *samples_list; + /** + * Analogous to pixels, but delimited by AV_SUBTITLE_FMT_NONE + * and restricted to filters that only have AVMEDIA_TYPE_SUBTITLE + * inputs and outputs. + */ + const enum AVSubtitleType *subs_list; /** * Equivalent to { pix_fmt, AV_PIX_FMT_NONE } as pixels_list. */ @@ -351,6 +358,10 @@ typedef struct AVFilter { * Equivalent to { sample_fmt, AV_SAMPLE_FMT_NONE } as samples_list. */ enum AVSampleFormat sample_fmt; + /** + * Equivalent to { sub_fmt, AV_SUBTITLE_FMT_NONE } as subs_list. + */ + enum AVSubtitleType sub_fmt; } formats; int priv_size; ///< size of private data to allocate for the filter diff --git a/libavfilter/avfiltergraph.c b/libavfilter/avfiltergraph.c index b8b432e98b..f4987654af 100644 --- a/libavfilter/avfiltergraph.c +++ b/libavfilter/avfiltergraph.c @@ -311,6 +311,8 @@ static int filter_link_check_formats(void *log, AVFilterLink *link, AVFilterForm return ret; break; + case AVMEDIA_TYPE_SUBTITLE: + return 0; default: av_assert0(!"reached"); } @@ -441,6 +443,9 @@ static int query_formats(AVFilterGraph *graph, void *log_ctx) if (!link) continue; + if (link->type == AVMEDIA_TYPE_SUBTITLE) + continue; + neg = ff_filter_get_negotiation(link); av_assert0(neg); for (neg_step = 1; neg_step < neg->nb_mergers; neg_step++) { diff --git a/libavfilter/formats.c b/libavfilter/formats.c index ba62f73248..5c972bb183 100644 --- a/libavfilter/formats.c +++ b/libavfilter/formats.c @@ -19,6 +19,7 @@ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ +#include "libavutil/subfmt.h" #include "libavutil/avassert.h" #include "libavutil/channel_layout.h" #include "libavutil/common.h" @@ -431,6 +432,12 @@ int ff_add_channel_layout(AVFilterChannelLayouts **l, uint64_t channel_layout) return 0; } +int ff_add_subtitle_type(AVFilterFormats **avff, int64_t fmt) +{ + ADD_FORMAT(avff, fmt, ff_formats_unref, int, formats, nb_formats); + return 0; +} + AVFilterFormats *ff_make_formats_list_singleton(int fmt) { int fmts[2] = { fmt, -1 }; @@ -450,6 +457,13 @@ AVFilterFormats *ff_all_formats(enum AVMediaType type) return NULL; fmt++; } + } else if (type == AVMEDIA_TYPE_SUBTITLE) { + if (ff_add_subtitle_type(&ret, AV_SUBTITLE_FMT_BITMAP) < 0) + return NULL; + if (ff_add_subtitle_type(&ret, AV_SUBTITLE_FMT_ASS) < 0) + return NULL; + if (ff_add_subtitle_type(&ret, AV_SUBTITLE_FMT_TEXT) < 0) + return NULL; } return ret; @@ -724,6 +738,10 @@ int ff_default_query_formats(AVFilterContext *ctx) type = AVMEDIA_TYPE_AUDIO; formats = ff_make_format_list(f->formats.samples_list); break; + case FF_FILTER_FORMATS_SUBFMTS_LIST: + type = AVMEDIA_TYPE_SUBTITLE; + formats = ff_make_format_list(f->formats.subs_list); + break; case FF_FILTER_FORMATS_SINGLE_PIXFMT: type = AVMEDIA_TYPE_VIDEO; formats = ff_make_formats_list_singleton(f->formats.pix_fmt); @@ -732,6 +750,10 @@ int ff_default_query_formats(AVFilterContext *ctx) type = AVMEDIA_TYPE_AUDIO; formats = ff_make_formats_list_singleton(f->formats.sample_fmt); break; + case FF_FILTER_FORMATS_SINGLE_SUBFMT: + type = AVMEDIA_TYPE_SUBTITLE; + formats = ff_make_formats_list_singleton(f->formats.sub_fmt); + break; default: av_assert2(!"Unreachable"); /* Intended fallthrough */ diff --git a/libavfilter/formats.h b/libavfilter/formats.h index a884d15213..94754ebd88 100644 --- a/libavfilter/formats.h +++ b/libavfilter/formats.h @@ -180,6 +180,9 @@ int ff_set_common_formats_from_list(AVFilterContext *ctx, const int *fmts); av_warn_unused_result int ff_add_channel_layout(AVFilterChannelLayouts **l, uint64_t channel_layout); +av_warn_unused_result +int ff_add_subtitle_type(AVFilterFormats **avff, int64_t fmt); + /** * Add *ref as a new reference to f. */ diff --git a/libavfilter/internal.h b/libavfilter/internal.h index fc09ef574c..192b0ae196 100644 --- a/libavfilter/internal.h +++ b/libavfilter/internal.h @@ -149,9 +149,11 @@ static av_always_inline int ff_filter_execute(AVFilterContext *ctx, avfilter_act enum FilterFormatsState { /** - * The default value meaning that this filter supports all formats - * and (for audio) sample rates and channel layouts/counts as long - * as these properties agree for all inputs and outputs. + * The default value meaning that this filter supports + * - For video: all formats + * - For audio: all sample rates and channel layouts/counts + * - For subtitles: all subtitle formats + * as long as these properties agree for all inputs and outputs. * This state is only allowed in case all inputs and outputs actually * have the same type. * The union is unused in this state. @@ -162,8 +164,10 @@ enum FilterFormatsState { FF_FILTER_FORMATS_QUERY_FUNC, ///< formats.query active. FF_FILTER_FORMATS_PIXFMT_LIST, ///< formats.pixels_list active. FF_FILTER_FORMATS_SAMPLEFMTS_LIST, ///< formats.samples_list active. + FF_FILTER_FORMATS_SUBFMTS_LIST, ///< formats.subs_list active. FF_FILTER_FORMATS_SINGLE_PIXFMT, ///< formats.pix_fmt active FF_FILTER_FORMATS_SINGLE_SAMPLEFMT, ///< formats.sample_fmt active. + FF_FILTER_FORMATS_SINGLE_SUBFMT, ///< formats.sub_fmt active. }; #define FILTER_QUERY_FUNC(func) \ @@ -175,16 +179,24 @@ enum FilterFormatsState { #define FILTER_SAMPLEFMTS_ARRAY(array) \ .formats.samples_list = array, \ .formats_state = FF_FILTER_FORMATS_SAMPLEFMTS_LIST +#define FILTER_SUBFMTS_ARRAY(array) \ + .formats.subs_list = array, \ + .formats_state = FF_FILTER_FORMATS_SUBFMTS_LIST #define FILTER_PIXFMTS(...) \ FILTER_PIXFMTS_ARRAY(((const enum AVPixelFormat []) { __VA_ARGS__, AV_PIX_FMT_NONE })) #define FILTER_SAMPLEFMTS(...) \ FILTER_SAMPLEFMTS_ARRAY(((const enum AVSampleFormat[]) { __VA_ARGS__, AV_SAMPLE_FMT_NONE })) +#define FILTER_SUBFMTS(...) \ + FILTER_SUBFMTS_ARRAY(((const enum AVSubtitleType[]) { __VA_ARGS__, AV_SUBTITLE_FMT_NONE })) #define FILTER_SINGLE_PIXFMT(pix_fmt_) \ .formats.pix_fmt = pix_fmt_, \ .formats_state = FF_FILTER_FORMATS_SINGLE_PIXFMT #define FILTER_SINGLE_SAMPLEFMT(sample_fmt_) \ .formats.sample_fmt = sample_fmt_, \ .formats_state = FF_FILTER_FORMATS_SINGLE_SAMPLEFMT +#define FILTER_SINGLE_SUBFMT(sub_fmt_) \ + .formats.sub_fmt = sub_fmt_, \ + .formats_state = FF_FILTER_FORMATS_SINGLE_SUBFMT #define FILTER_INOUTPADS(inout, array) \ .inout = array, \