From patchwork Wed May 22 08:57:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 49138 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:542:0:b0:460:55fa:d5ed with SMTP id 63csp214959vqf; Wed, 22 May 2024 01:58:12 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUm3R15y6aTfgHwpOAKtNtb4gkxiVmuw3M0tR9HBYp9Wwg5YuvKtPamg8Ppu0iq8lk6GJ2mxYvwIs24MuHjBlVz/0FoPwotSNsx4A== X-Google-Smtp-Source: AGHT+IHhqIZhHbw7iix3Tr9pW0qNm7jsWWXsl3sZf0RFO4YJLyHFv7rSjelydKhSN/mFUmPWyzZN X-Received: by 2002:a50:ab53:0:b0:56a:ae8a:acc0 with SMTP id 4fb4d7f45d1cf-57832a1e559mr899112a12.21.1716368292762; Wed, 22 May 2024 01:58:12 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 4fb4d7f45d1cf-57824f9894dsi1398461a12.420.2024.05.22.01.58.12; Wed, 22 May 2024 01:58:12 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=XygIKzhF; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B190D68D3E3; Wed, 22 May 2024 11:58:08 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03olkn2039.outbound.protection.outlook.com [40.92.59.39]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 432C868D16C for ; Wed, 22 May 2024 11:58:02 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EucgJURZU8ME7EPj7RydAcXmzGPGr3FPAGTGfFsrCXxcqc0G3kZR0T9GUXJMuciwbp8yHUb3MeNbzCKirXG6zrW/0ZbGe/GHPkCLb/r0x++l/ikvsWI/bXOSGS6y8+kzH/5VUNvbdopgPgjI6hPahUS68q9LztiaqT9KU5jb8oWf64DFoKNUQMYzXxkZennW2T2uIIImwP1TBSL/8PjMyavr6kwTuvKUtKu+0al0xPbJcz+Ddk6bq0a4vHoIXZ3gwJdMT9o+N6dAb3Xo7IShsInm8P8HgW36USWgCcRFXeWRsPx1eDHPmLdbHc/Fwr4HodB+aiUCKOiggL+ZHbo6Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2x1h0aUHjlglcgCXRtsIVGfgd78JCOmuxY1rJ1ScW30=; b=A/h1/7svD2DXU8dg84yYD6thnHL8VsedKUrJ1jECm7lC295nITkwWpR+DmpuHWSv376tN+0UnaYE073coUoTmfWdaOw4kUsZYBiShUC6esMHdyeHNr4cOzBR/Sy8CqnfCQo7X7Yw6V8AsNhCo5omR3tPy9iDBtxxs3HuFo3z7MdtGVN01tfkJVundT8HzPw6NMSf2bK7b6lJ1PgUFf3k3ZvvIbqzhlSdkIGAWLFaaZ4jfRhR5wXrKRpfozdiJkwmhTw6vLjihTn5VFx7tp409Znxb91NWlyveqqWzJfds/bZjPD7DJ2s7cSeiGqV5GLYOpI68esod5tUMVrj9TJuQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2x1h0aUHjlglcgCXRtsIVGfgd78JCOmuxY1rJ1ScW30=; b=XygIKzhFiocLQsCHPHx8QWh77SYiY3THkUNTuukWcur7HgXZR0+eK4TvK40ti/QR7uh8+L1N034EKFpDWSovXXZcstnVLU0A1wILug88csbN/8N5dNWW+uHY7oe5ZkEG+CqswzqHUryyNKsMN7PIuzQSp1CzHYf/uW7aYG0YfUX6WGpEYIQ/oWOJO28uL62mEZhDTk1S4AoRdmZk6HeC3hZAFklv3V/xjGKPlrVCD7kqivS5eO7QeYvgp2xalJzuxE0HHAN4ZUMkZeCcrwUUvJJEN730S3IvEEP1ZOWaJvfDzq/zh/LPmmImQ2tLOhchTxGERsrbOrrGTt7LtclV7w== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by DU2P250MB0191.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:277::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.36; Wed, 22 May 2024 08:58:00 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%3]) with mapi id 15.20.7587.030; Wed, 22 May 2024 08:58:00 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Wed, 22 May 2024 10:57:48 +0200 Message-ID: X-Mailer: git-send-email 2.40.1 X-TMN: [Zj064h5mWThY3GBBPuutj/7xigL880l0ZecMHCGrHH8=] X-ClientProxiedBy: FR0P281CA0253.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:af::8) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <20240522085752.3697753-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|DU2P250MB0191:EE_ X-MS-Office365-Filtering-Correlation-Id: 2c7ad0d9-1bba-43cc-5ce1-08dc7a3d47c0 X-Microsoft-Antispam: BCL:0; ARA:14566002|461199019|440099019|3412199016|1710799017; X-Microsoft-Antispam-Message-Info: thLrsfg7RUTbGXmlMk3E6o69MVxIDMyIh/uFXEAB8QuW2NSPZOAP/2++I6HMeqqksoIjDa86xRXFPxG4IRtJG+edtBkcS+1nEZ8txrABAy/0VgdmN1lf+tcqPq+MKy5SnuJ4NlqQPF3MqVGYMxSKMurDG0IJPoX+dMDtvbxIi1zyZAEPZQKkpFvUHalXaKzNyuIJ55sym8Eq4sZWOs1uFfnsYRqVwt79RESbjNe7hJCDEfCFrUHv2OSnCg5WpMEwSPtCsJURQtkXTjJdyihApx5PdaLehWhXLU+OVQpwUrXMBZyvkkqWZYBQrM76LQsqlWd/CJ3SqlUBsiWogdSeZDdr37n3DUk31wz1caA5SeI5T7vwOvelnpmzrC8WhsjEnqSCyjSpn436OzoegJpf7pmsikxICWLZp8DIFmSdO59goLzcU676svKd81Tvn3n3fFHl4OKHP0PWc6yE2JoNOtUZP24hlWuClOXG1JYjIGBkAmOYfpIOlLioU/bW2oYuy1flzQm/5edSS4EmBPkF9jh83bxJOjlr2sCb3d8xTma7TVkwaaNSGLwYB18lm/ZRJCBOMKJINDEw9EIQvyH0HWmnsDtJ56FBeCFjPtMN6fyqJ7AEvThMMTTxt/FDuv/U X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: hmCZh9kmP7mP9C6Mb3hXC1hCsPPOWwkJaoiYulDD2eoVofoo07Uoa+qjJclzxmnVyx1wCYhOliTUwoPsF2yC3+F6JKdgdW3DJ4O/80DhEx6hKyBIS+sIIP8j/Pc9S/wrIib4wGStJJkbsR2CITBdm1nEjup5FMJHJP+afeCr+pBSOj4uSZ+EAPtV0S+kpw1X291KHAnNdCbxm9A0crycgYuicl3st1/NAUv0AJPnpTOxO/tAFasfAgFTm1zl6mop42h+pX1WmqA+l7BL+CnIdJlmrNdlIEvszZd/v392pakf/QJ2SXzuxj++pL2l7xe1pVa/J+y0VJ9g+WJVNfuZiLyZL0nNZln9zgdr199DEtUnLf0h1361X1kTObPaYXFC9un94ELbTR57eVLgXTKIGUgr2bxE32CWnp+Da7Ys3lAixkyJk35bmzRs+n69/NWPQOfTPiwiRUzMn/9HZQUonQZ7+ZU8gWPTZK30efz2qf2jsJ0equ+uAS3BC3zGP4WO94ntffIJU+/0SzAr/WYmj144ct66ikMo4t3EtBAmUaoxeQZ82x95Nd4r9wFBtUl7LPQQ/Z4IaT5AJzvDTdWP+QuB+5FbGmZTVC/ufNBWWGlcAjn//L4LO7drsmJlF1thOh1sMMhtUv4ksFlhPaPF04g0Lc2eSucdAHpPVixZbxaUQvYK+6fQfPiZCq//tWOB+qwaozMUpGND7Ny029FxyWi1Ua4rkLvAOajbXOTKtJHJA98vujOblF44CHF9/WGGBYB5fbHRl1wPYNIYCD0jvQclIDW3+Zf/C/PCiwXXROpVsFmCTUizX0tWGeHtkmve9Ntv8PekCO6D+S8E1n7e8mfMXLjUyxYT3/FFE7nb5YFA97Q0c/O/llT9JwRzAKBeGPLf6tnpvDR2qi7F4iHOxuseDGL00Ip/kMB5shgiZ7V2a71LuIZFtg5p12slKuPSl+667I+IZ9GEdFDg/Zglf1FoFSEiB0wX6NG+7WwOM0PmGqIERo2Uu1zQn4h4xw9IRq5VuCvr7NbSQxvqYQAThmk2O158uBRBwJf+AdKKaBcA8XPnJgsINQknkWWt/ftNpXsyRsLqUJ7W8KbAEF6vvJGiR1sCIA/3XekEEIdqp2mCSVnMaRdulXgeFDHEZI9vXgFbrT9dVzpN0OvMtwGCgBACPLe6Dy8D6yaiwDG0uBl0CCU08gDvvUQZ22t8Czad7LZp3PgZZE52Vqa9LdWF8iaBWYpeFH+qnk1vZUeU1HqDls5x25v+A8efxHyibKvcRc8BNnh7tyYKXCGZR5IO3Q== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c7ad0d9-1bba-43cc-5ce1-08dc7a3d47c0 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2024 08:57:59.8020 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0191 Subject: [FFmpeg-devel] [PATCH 1/5] avfilter/af_atempo: Properly check av_tx_init() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: zC81Hwv9R+rP Fixes Coverity issue #1516804. Signed-off-by: Andreas Rheinhardt --- libavfilter/af_atempo.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/libavfilter/af_atempo.c b/libavfilter/af_atempo.c index 0c36eb4dd7..1aedb82060 100644 --- a/libavfilter/af_atempo.c +++ b/libavfilter/af_atempo.c @@ -269,6 +269,7 @@ static int yae_reset(ATempoContext *atempo, uint32_t nlevels = 0; float scale = 1.f, iscale = 1.f; uint32_t pot; + int ret; int i; atempo->format = format; @@ -300,16 +301,18 @@ static int yae_reset(ATempoContext *atempo, av_tx_uninit(&atempo->real_to_complex); av_tx_uninit(&atempo->complex_to_real); - av_tx_init(&atempo->real_to_complex, &atempo->r2c_fn, AV_TX_FLOAT_RDFT, 0, 1 << (nlevels + 1), &scale, 0); - if (!atempo->real_to_complex) { + ret = av_tx_init(&atempo->real_to_complex, &atempo->r2c_fn, + AV_TX_FLOAT_RDFT, 0, 1 << (nlevels + 1), &scale, 0); + if (ret < 0) { yae_release_buffers(atempo); - return AVERROR(ENOMEM); + return ret; } - av_tx_init(&atempo->complex_to_real, &atempo->c2r_fn, AV_TX_FLOAT_RDFT, 1, 1 << (nlevels + 1), &iscale, 0); - if (!atempo->complex_to_real) { + ret = av_tx_init(&atempo->complex_to_real, &atempo->c2r_fn, + AV_TX_FLOAT_RDFT, 1, 1 << (nlevels + 1), &iscale, 0); + if (ret < 0) { yae_release_buffers(atempo); - return AVERROR(ENOMEM); + return ret; } RE_MALLOC_OR_FAIL(atempo->correlation_in, (atempo->window + 1), sizeof(AVComplexFloat));