From patchwork Fri Sep 30 02:18:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 38473 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:3b1c:b0:96:9ee8:5cfd with SMTP id c28csp1399114pzh; Thu, 29 Sep 2022 19:19:06 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5AAZfVX19ETrFmzGU6hsXt+j4QReOpXlUOaREqjvMbAZRsM++TFWGK6Xkjyb5NuMDtlpIC X-Received: by 2002:a17:907:808:b0:730:54cc:b597 with SMTP id wv8-20020a170907080800b0073054ccb597mr4791029ejb.434.1664504345828; Thu, 29 Sep 2022 19:19:05 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id n16-20020a1709067b5000b00718d0604af4si661793ejo.604.2022.09.29.19.19.05; Thu, 29 Sep 2022 19:19:05 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=Sf15JENk; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CF8CC68BBA3; Fri, 30 Sep 2022 05:19:03 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-oln040092065070.outbound.protection.outlook.com [40.92.65.70]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A9AE468B3A2 for ; Fri, 30 Sep 2022 05:18:57 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lmPMFixu9XwXt0apsL9/4TsKj67BwKyREMyyxhsjJUF8O3/3WqW+8Z51pDE2tqeztbjhU0BUKpRv1EB0R2jX4BAJWhoZeN2QAzbPTYvfLnfopEJkjltODZWg+QVW8GFdLv/fxCu/hHTcNJqFRlbvmT6LtxLkakg/p0dZ33L0jnkkBhtKxL25nkRYA1lnbfwzxGOYcyVBAmW+7r+5NhSiLy0a0JBi64h7zG11d65onfjkXRErlCZF9G6zb/AAVh2hB/qPJb9QgWbxrIq1j6+LyC66UleN20AJyGHJg34/5kM83fJ8SAExoVhX9jkBon9nRIXW6LnwkvTzLQtCNfNHkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tAY/3mJsNenOJQbAcT175Wm2BlLV0jv5iSe7pRRet5E=; b=QkiYaTPDExShgOEBivc/k9JrgolAmCPSCat8aZvtEfNJl+11klehW7aV6LtT7GacbMmSLb39P9dJ3Z2XLzePw04L+m8mJkMGeGGCwDB+tPsI6yVTLgqeQN37h1p/Z0S+UQNkcdFN+t+iuACeJaH4sAyRb5yDUU5D0BLiSJLodhu8CG90jKFFdJMR2MSfRyrFAF5Wswi2Q615F++4mxuq0pHuXhOVHd0flGPfHbwovfi6auCH161gcqgk2XtsGJt2ZTo0iVK6XRuPAOswAQ0qFFIzqeQ9ZaS9GQCGsfV/x6HBJu0mcMGEPFIEJU8LJOelIYvUjVPMcSNGipPxd81ccw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tAY/3mJsNenOJQbAcT175Wm2BlLV0jv5iSe7pRRet5E=; b=Sf15JENkYL8rZfYVsZmcYxvTdX+KyIDiTV/JEYpykiuUp9pbYVbyBrR3NSt+c2vwQi2FM6V/ydQSfPUIAhA33upmpQ5UbdX4raKcd6SuAynm4Z2Te/ubSf3N237hazGaKfgKmEaduIi7ZNPvT8HjII1f4hwolLqCTzfDVieFWRE+9tLzV/fa1ZdCBl7FlcQUD4/q6hPP7D4yIul4X7wH80aaemtnW/CvIYSewp/rJ2M57deD2TL9pHoF/j6m6FQU/L1V4+aPbP3OQoB2X91hmA8w10n3TihP4ApRxMT7AIbWh5igFdK0UdtlHN9kUumr/EbkwcmsvY7oofPS4LiVdA== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by PAXP250MB0422.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:285::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 02:18:55 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::68bd:2fc7:ac52:38f8]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::68bd:2fc7:ac52:38f8%9]) with mapi id 15.20.5654.025; Fri, 30 Sep 2022 02:18:55 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Fri, 30 Sep 2022 04:18:51 +0200 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: X-TMN: [QOsxfpeEEZgVtb4uYtSAgQIiys5fKU+KihZar51xab0=] X-ClientProxiedBy: FR3P281CA0167.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::6) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <20220930021854.3048208-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|PAXP250MB0422:EE_ X-MS-Office365-Filtering-Correlation-Id: a3655352-0278-44bc-b0cb-08daa28a1fbf X-MS-Exchange-SLBlob-MailProps: AZnQBsB9XmougXX/gXRJ/glWGV8cWqURwk7b1teqcg2XEvsf7Ekgxxu69gJn63u1uGRCYFdVxcjGTyjdrADFflkhT7fcHKOV4RFkpeJi3tnnQsKH3RCXHv/ROzcrbdMj1WQz3JfyTLVaPWqOUpN1VnBkkY6lEG5TDAOhgBRlSATNg7ZAJ/qBbhRUNsoBHNjC8lDQv2BCtca27h7Flp0hVBt7Eo5MBldn4z66dyWkDqroz7F0+oA0BB1KxC2Ke3/MAsaErkP1vPk+YSmTgsOmPZrJ0Bzch9eR2VQ88FQuT5Wl7j/CoH2SLs7qWITpPly556DZOw88xXdy2C6WKcbykGDDAU8ZCP+J9aohUfcrJzjSgPdTcGdaLU8BkpaLgtM4UYK4dLAZIRH7ARiwHEA003anB05iTIAE+1tdfE1GGpgUW8J1LJIJUYIDDAyNJjULInY1LVPnR20bq/yjk5XxefsZpfnsZ7ibaDUgxRumHYshi90vOcMyraX4fESlrlZ7DI2jDGORpW4qDSzymtseHwaU01l/dHWapylGlrn4qVj47ntvHtGtgRizOdQP7LaWG542x8yKj8OFuF0oKqnalvAXOQN24ubdU6rdEGYOgYLJfvwKkvLm7k1MLReCYdjIWUtfFSTwltNeu5x36nbBnCMY76AjdA08itm/seCXoVWzE0hBguEcM4bzeXPosbI/qcHVvDtreK9oGRglB6UwRYhjx6ZqBtMNQC+C1PuSWqvyN5yVRSsdD0nLffy3SebP+TbfSLWib80= X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 42jotYcNQrHoYoJdLHc0ZM9AtFFtQV5UgcTI9rhfIGqYc0JoHH6pRy06cJFt39w9H2DOme7xGi+eZYdLLLpC/PE8UKqiva9kD9eFKY2i8oOefmSO8wywmM9pxvliOT5BWgscN/JG5bBg1Eu9hbByKhGp6VSHAPpsOYWcQAKSq9bKEYiUrlfPhajnU+Yop2iiK3j/Rh9QS3vBEud12aoJjBcVwc6Qud5JBfD412ZE355CbnY/6XdFYI2Lm6+sozywFR/2Z3qOkTnGrc0EZeG02jDPpLLbJu4sHxujtxFKyQJU1UJ4ievDl5554C5MBMmAy1aEzfDLok8MhWFSipCMiu7s8FSD5HQoKE0UB4d7Yf7zsEl+AqWyeX+JhXIZETm7VgWtFXDguALVApwq2bGle+G/VDeXVtZXL1hgmTVDaz87n8gKJENrQxF6Ir5C6YweHD5V1gSfS143CQTezb5oQlApUiyz503X8OMjMhk0k7jewskbDn3CKS7iywS4HAZB0+IbCReCCcXB03X7XEJqgpK2l+tUW6kZNrGu6bGJ3b2L14jqNs+y4deOmKUrV/CdTu6fgNRTXuB/rRjcyexgg+JlzF/Mln53KbNuT/RPkaQsBwCHCGgb5nBDZOGF9VU5qeRhDIAouBPx9NajHK1zQQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 0C9DpJVmBe2q+XbxWxl8TYQ4dQwg5P3D0VMc/pOD5ZekH/9TFrbPhH5eQxTZrWYmVIKdfTRa7/sSB9gnvQs+QGls1uDcQchCSjLP8uvcUWoI1myOoCrGjfjlJ4YtVogWAnunIZ70w7D0r+FYlEDea937xirfvsfnqenBEladwQF03mjtl/Tn+Rff4eFXArZNKP4txcVSbV6Z+6SeInSY1dc0eNUoYrRv85CoinTSW4MPYrxDm1Z1waSeGRxZou6WAOWNNF4L7TIfdWGpku6Zv7X6txevOPiQ4KsCVbJk6B9W5jlsqyLgzusdEqV7tX49E+EzWMHMJrbtPtCJDTL+pqI/kCQZDkdgoasH5nyfAoT77ulTOiE81EZ7Y834qkf7KVOGouy1VTcrFTnNPKtHQsYnYgsuD6BrQRrqp+VTXKTpKn8VGBKiEp0vVYYKOvYv3yFVuJC+dCf+QJAdgB0VEuvdqlZcwNP36kAcOBrOuvZCy/v+mAmkyIs4nEWw0ZW+AbwjmZWSxhAzcZQikzNH2Zu2hrNnMIRgBFeJo731ivaKgeK5osuVFw7VRA2yvPKD1YeRPjt4I+o0cqae9rJGx/G7KurIvVi4ut4ER4iArW2JzyYk5kQecXiZ3jTpgz+sqqTz3TF+1z8vkLIAd7YFL02eky4UzelIMwE2+zzegebcziVKV1kVGAJQQn5mIjy1gv0K65qcxxHyZpy1a1Dt4F+mupWrei+AF5KOJhzPgTv8d6IWlew638X5zYJbA6Ab0bzgRtgxXQ6J5ZREPH99AjegyTwI0ViJqTeGyhhQOifgU/G3tMDY9hZiBXWIAxHehD6TKTGDK9vO9YBUwZbSH7MrnPB7PyjW1mgmf1FbiSR5LfInYf2wNif0KnTcu916o/jz+gwF40N52sI3F7aXl3q12Ui0hOrIpRif8WjvaL00evQWnMgP3d9Lrt5b4JS3cESsWfO7rQgaduNKw8lk2n364myzD+u18uIRJPdlRC8OQkO7XHpfpx9R8mxtLaC6kdbcUnOVrm6ySDoEWPFME02QyAehX3sJ65ivBuXip1BDX9FK5/IkxsJ/EhJqWtqaKoMxnE/c+UnPZhLwtzNwqS/zpkwI6fXZ/A99O/zmjuKwpiuApMirpay8yLkXfFOFG8DRLAGwGzA56HZxViyAjSBu6Z2YPc5gmkfdEMmdPtRQmkdOq/8FPRme0H9gHW8rmFRE641l3ZsOdcNt7rrhZu+XqTKtLz9fQ8HlAMdaCkh073qgro+pBZB3RJr5/0IqQh51n2p09Z4QXQ/X3ym3++Z7hSHPJpr7fAZh80h+E3GifIrMVlizMZaWb9iI3CaA X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a3655352-0278-44bc-b0cb-08daa28a1fbf X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 02:18:55.0544 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXP250MB0422 Subject: [FFmpeg-devel] [PATCH 2/5] avcodec/mpeg12dec: Don't call ff_mpeg12_common_init() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: mEqMJq3FCzuX It only sets [yc]_dc_scale_table and these tables are only read in ff_set_qscale(); but the MPEG-1/2 decoders don't call ff_set_qscale() at all. (Furthermore, given that intra_dc_precision is always zero for a decoder at this point, ff_mpeg12_common_init() actually set these pointers to what ff_mpv_common_defaults() already set them.) Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12dec.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index 7133696f3c..dad1970f6c 100644 --- a/libavcodec/mpeg12dec.c +++ b/libavcodec/mpeg12dec.c @@ -1062,7 +1062,6 @@ static av_cold int mpeg_decode_init(AVCodecContext *avctx) /* we need some permutation to store matrices, * until the decoder sets the real permutation. */ ff_mpv_idct_init(s2); - ff_mpeg12_common_init(&s->mpeg_enc_ctx); ff_mpeg12_init_vlcs(); s2->chroma_format = 1; @@ -3075,7 +3074,6 @@ static av_cold int ipu_decode_init(AVCodecContext *avctx) ff_mpv_decode_init(m, avctx); ff_mpv_idct_init(m); - ff_mpeg12_common_init(m); ff_mpeg12_init_vlcs(); for (int i = 0; i < 64; i++) {