From patchwork Fri Mar 29 03:24:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 47638 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:9f96:b0:1a3:b6bb:3029 with SMTP id mm22csp1754925pzb; Thu, 28 Mar 2024 20:25:06 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWqd+yryUJ4usn15A24v92KvHo0FmXfJOjU/KIzi0KsmTClyyX5HvKuzXDOboY88E69NJEMDVvW6LDPUatdUcnldbJ+7clNX7/2Zg== X-Google-Smtp-Source: AGHT+IGZVERHaIneK2irdX0giLF+G20pabCw5CDaELySUtytDhalE4jutuRtN7GkDR0G0zksadeb X-Received: by 2002:a17:906:5fd5:b0:a47:3c66:b396 with SMTP id k21-20020a1709065fd500b00a473c66b396mr606278ejv.64.1711682706425; Thu, 28 Mar 2024 20:25:06 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id o23-20020a17090608d700b00a474a2e5393si1335111eje.123.2024.03.28.20.25.06; Thu, 28 Mar 2024 20:25:06 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=TTh0eudG; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 71A2068D751; Fri, 29 Mar 2024 05:24:57 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02olkn2037.outbound.protection.outlook.com [40.92.50.37]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B4AA868D747 for ; Fri, 29 Mar 2024 05:24:50 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bbB+jvtdnH5qF2dlGZmCyxjpaCIL48+AjUvQFVG3+ofGsD16oXG9PbGcXQee0vmQED5OrCrojTWVRtm5687GLuBd1ARCQTSGTmIhsmnBYZ9QdoCI/vkwKEWzcLor4m4h2UBhAlUrjQUCOGrbRwUPfdsc7whCwFu8hcKDR6VbcVmgUUX/6nibQunkif2vUx3Jxql9joSW5mY8Jc70Xnz29ERi9ih8T0bemkWLLD1uC6uSCiUl1VTxqzGl/1VzNO3aP7oXsfFW661VAgLZPwY0Vo9yfqGk3REp0p0ujY4kvS0/VgQQkD87gDsg5UdRmIC5A5RfFDxwDMOCAMlQV74+7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5QGxLO/+a2M+AlCCRtaREzkFg3rqQ5yEKDbjkyiU2CQ=; b=LUG58wE80A9yLXVIi94p93cM35tWhG6g2ikig9ABs09r2rLT40T3fM2eXwapfOu4HZq6ZpW19To20QIdaXbfJl4R6gga3knUixhnJDi2BWUcHpnsvqp4wSAxG29F+YVcmHXWemHJGsvL65L4T7OYOKXMiXUGHWEEViAEhBBU7ww7AGp0YgkSISTlcvOSDkkh01h8fIt7dI5dkZ399k43geeZq3KxaY91zH0q8w9RMCQhSaItpi02Yt9dn+qSy9DVFapLheQOdmiDUUmjVfrffCxuwxvDRb0skoenCn3MVmIJP+ecAlUcwyNb3yf/TOD3kazBj9YcvzqxBC5R5MlzYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5QGxLO/+a2M+AlCCRtaREzkFg3rqQ5yEKDbjkyiU2CQ=; b=TTh0eudGEcLdscp70BTjrFAuLflBWmC3iNbYoUMi/rV3sklwiJ+gM04LJuxluQTwg/2yO3LjjoHfs10AkpNziCMbsc8MrEZZ7dpXqze1fUNfVQAmliKMMDVEFFiZZhmN/zkN+bgPRe7CX5i5LF9w2t2X9v1MH2TMLoj6Eu92WDd9udieYmf0R0bDn7UKRpGUFuQVO3MgGbKQJCv0rIC47t82KmyTRee3w+s4/kweGkjpxQ4bSsLG+d/Xa3i6k1AkQmE9hYQ4CPZkj0w8ayxVkYdu9QvvD4savZ/hmZWq2TP/FTbNWrTWTmiXHg4qOeVqxFF/ICkMACww0sR9t6afiA== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by PR3P250MB0116.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:173::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.39; Fri, 29 Mar 2024 03:24:39 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d%4]) with mapi id 15.20.7409.039; Fri, 29 Mar 2024 03:24:39 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Fri, 29 Mar 2024 04:24:28 +0100 Message-ID: X-Mailer: git-send-email 2.40.1 In-Reply-To: References: X-TMN: [iwUGwYuJoYjeJnXRIXmG2nuydZ+CVNNgCjeY/c1rC94=] X-ClientProxiedBy: FR0P281CA0061.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::16) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <20240329032429.2305146-3-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|PR3P250MB0116:EE_ X-MS-Office365-Filtering-Correlation-Id: 4129a281-0cf6-44db-3f2d-08dc4f9fc4a2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sslOt7qXWG6Fy2mbVztAywoYTbPZfuDPmKIEIJiJHV2uUqCfXcSnNPzGtVqIAhGLnmJCT7GqnQtlUGo2nEiyLjwA8dENK5b08V92g5voZ7uw24fwXImX9Fhly4eJtDFW6gN/JnGjYAlTOMawuTL6C923T2a6D5oF7T3p22I1cP+CkZC/7jLIO3f7B2fR3p+W5PiEv1bR9o9DLzleMcUNQxPC4NffHTTVOjHKH8og0YMmO2cFgFOp4Ax50S2V57CkkDBcYonPqP2KawEG6AgZH2cf9/mWcy6mH4Il6FtCtRWdU/HTVuLkClz9EbmkstR9bqUvRqXr0K6ATNZ5kTzVsym2DL/8S6BcGjIcgSRmlSk2HHkR8E4ZQEtuOphZvzhBU2MrCbiIzOnV1ZMvyfEr0a1UgCa8HBeSCMSe64i9vYAdkAPOZkeoDHDtfvmkC+yrwuOp4lvAXH+kOkpI8U+A3sSl9W4h9Ur0b4CRHvlxqgL7O8cbnJi5h0/6L/B6OQAtkjuXL2LQCiG/yugcHFr7K+/Xbqbxh7ntDQSF7CDnwmEI3q8pZK6zM3oKdVgr7lAYfRDlWb6KR3PQq+TEPYHaEGyvyF4hg5mwR9KKDtpkPo1Ojq9tF/8ZaUiEzhm70WZ/ X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: s4JDakektDgIT7uU3f8ALAYq7vLwplp+mzM2uzc1g4ZjYorUwn66r8T5TSbc9Wf096khk+qYpOVyDpqwPJ5ATGvupi4vJes7Rf0Bs6nQ96XMLkuiD0TYUvmIiWB0Y3k9MUQsxC4+0YzQmYBpDroRLRx+7t+2QptJyP8la3Eguw84h/A1x/3rc8O+G4/RbdGTa+HiuSypJqh9eG7RMYlFedoYlfDlECl+iuS/n7sS9b/3dRL5WaUaAseOZYLHR0P1C6BWi3Gvnd6+30gXKNkFJtT+haa/8xOtAnAwadUzNLApGraaIVIiJkVMpA0UxQgk+jIh6ORez1QeGZz38HrEByoOtvKFFz0W+jjUvLZ/gHbH9Pri4ydodQCia6SevdKG45byyDXDrlg+qZqNeT6W6JolZbi0rYEh7bhWAQV4/5JZGuCHycQc4xqq+8+yuMLIdJQKNh+c5Ng3oROwmCUYUfGBlctV41u4WC7Z0fq1GqP0XXAdj1dK5TGPN2WoPpCNcBnF19+UFMRZQm0uHkpRmBLMmMuagXe1TWqNqioq8VdI7pgKV0/EjYdwxVvemBUNmdoT55UmljMLcQwL8cUJMTVLtS20iHxkypSZM89lQewjd3U6nPu+S1nYAZTnizB05z47DHzLJSgoDpxJJgjNCMIfGXqMgwmhs5rhDO4qU936k5Mw6+I+20KKNUQ5aXK+5bFAERj4UhQva3SufyaeDBLWInQEIgDh6PqBn2WGBJSJAv/1j8NYmjNSZZw8gzj4QKx42YePXYIv8zaWEpcQKNupK2IlRSyRdfc+K5ZaJXzl2ISDx27BCc38BVMMKNG8B9CF19Jy4iRyMHrcvMKEg2ioY4NIfZoTUoRTqvLNPEHRydGJhIxB1Nta8WFNsXHKQZqXk1Bsez/tSKJHRnCiWK4AsioKF93xsIYZN4RFAz8CeobibGGirYI7XeU5p03ovFpFhM61DeiR5wy1fgBCrqd6D54SSu0fiqVtV6WiA6F+Dg9ngJnClXIEAhUM1KanVMCj0DjajV+TOw9iod3o/hFADnEsWpoR/plpk5h+rFpEynVH0hMJ/+gHF98fx+v60hOHr1CMDtMyihKOrSKa/MyV7y2FC+ueUSwWqZc11kjL9ahitBXmeSglxQQcZHgDD4iQf9mwg1eO4OxWDbjIZAjVDxlchN/esVAXEf5lIrXc31u/oZOoBs6EvXc1G/kQc8KE3NSgiSqt/ChMp1zFprNAToPUlkCgiEcgR4On7LpGYFxbN3U1FHz3kGfgg/leuJBHKhC9aOoDCEEmseCOCA== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4129a281-0cf6-44db-3f2d-08dc4f9fc4a2 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2024 03:24:39.8974 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0116 Subject: [FFmpeg-devel] [PATCH 4/5] avfilter/vf_spp: Fix left-shift of negative value X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: kHDnK+6BcAM1 Affected the vf-spp FATE-test (on x86 only when MMX is disabled). Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_spp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_spp.c b/libavfilter/vf_spp.c index 5c6495612b..c8366ae319 100644 --- a/libavfilter/vf_spp.c +++ b/libavfilter/vf_spp.c @@ -171,7 +171,7 @@ static void store_slice_c(uint8_t *dst, const int16_t *src, int y, x; #define STORE(pos) do { \ - temp = ((src[x + y*src_linesize + pos] << log2_scale) + d[pos]) >> 6; \ + temp = (src[x + y*src_linesize + pos] * (1 << log2_scale) + d[pos]) >> 6;\ if (temp & 0x100) \ temp = ~(temp >> 31); \ dst[x + y*dst_linesize + pos] = temp; \ @@ -202,7 +202,7 @@ static void store_slice16_c(uint16_t *dst, const int16_t *src, unsigned int mask = -1<>1)) >> 5; \ + temp = (src[x + y*src_linesize + pos] * (1 << log2_scale) + (d[pos]>>1)) >> 5; \ if (temp & mask ) \ temp = ~(temp >> 31); \ dst[x + y*dst_linesize + pos] = temp; \