From patchwork Sat May 11 20:50:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 48746 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:1706:b0:1af:cdee:28c5 with SMTP id nv6csp298461pzb; Sat, 11 May 2024 13:54:26 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXQDSzjS+FCWz1/8BQ/5xMefJE9KEnedWqlXb4Ey7l3tQtkzX/DLFWpzKbcqImj1RxHqlEh7jejaagw6hJxPUg2LkicwMIzy1IvaQ== X-Google-Smtp-Source: AGHT+IGOW1aZNIz5NKAaITi5jk68XW64UNooQ8S8d3/q+kj7wxRRi0HIdyjvG0TnUzBEKk2CS0rq X-Received: by 2002:a17:906:a8f:b0:a58:ea69:3f5c with SMTP id a640c23a62f3a-a5a2d676767mr395224166b.75.1715460866214; Sat, 11 May 2024 13:54:26 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a640c23a62f3a-a5a1876dcc8si350041766b.226.2024.05.11.13.54.25; Sat, 11 May 2024 13:54:26 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=iF3rRpu0; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A692568D64A; Sat, 11 May 2024 23:52:57 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2104.outbound.protection.outlook.com [40.92.91.104]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2667E68D62F for ; Sat, 11 May 2024 23:52:54 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mm1AqmzMzF3lSBDpem9lnnHya14wSgjCVK+0FWBMvqDwZRGlfnkc67BXCYI8CLb2rpkLhw5j1Ay0CuBSMe8tbEn48RqdTL65X0RvSNKLy/grqZ+zOeLZpD3hgsyqnXcvFodUihID4NSLu4oS+kGS6ph+RomjIpm7+Pv7R67MbdnM6oYlsIOWvji5nXprS7QNMrqMnIv0lwKkO7YuMNyUDRHMN0L5kva0dk/Wx03NNcMe5j/xHLAjAxDV/igBXlpJ7O7BBVntaoiAMKmAgcaYrpVnJogePSD0a/nJD1ZuB3wQ+pjW8/LbCYKRdfkkFN6HhLuWjS+idLuadFDu9/+vjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EPHfvsmo1QWX1ay4MwmFi1w0uOqr9QNDQPEOsKul4Sk=; b=YqxrW95xI0MQwMZzgmlttP7gs5Fleya7lfwbw2JQpehHmq22iC2VOFSNPIgvaJ541e1wLbCpmBJFDBGllu6cvFc3vijKS6x7KI7qrEf8lKQHb0U/7EjLcEgJJMUxhciKM5JtPT1kLnPimwcPsz9lCRMsY35vyEUilCmXijUsymVM1BSE96ZXODsd6I9GsOyCmXO7BEtEMPSUYf5erXCXLEXbSRmdzTRUEQLyYzQRKWoZksO1X4Swu3JU1o8WOyqmJYu0bSukf+vFlxGoUwlVA/VNlv/Rh0LREptmbF+VlmRU0iOtgCzCg7gB1N+xjmA6Vzveg2UU/9HeKBYPBPSfbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EPHfvsmo1QWX1ay4MwmFi1w0uOqr9QNDQPEOsKul4Sk=; b=iF3rRpu0gZQmR8iokC83vCYTyAJN+7lrkxTZUEVK31mOYHoeQp6yfDv8csJMNy6oWqObZ9CCGlI1nzkalyu4ux4d+KXqZ52PGC8bFCHjMuUJXgQX4dGzPoNkdRkO5BMeTq82EEKpENuVSTfjXoMrokOSH58lK3rslALevOmi+dQySDfdhF8TEe3I+4Y7vmqFWvS2JyUR3kqhWX9ft3HB6Z3nP6lsWSyPNYd0J75AJB+w41+WHAXDbzPN5HqrNeM0LqyHNO7AF77YVIDk8oao6BuEKj1J0zJJr8G/O+3te4FiTliUo49+YFJ+3F43phAGdGOsipnQZ+Y4y6HTXTW7vg== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by PR3P250MB0370.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:17d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.55; Sat, 11 May 2024 20:52:51 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%7]) with mapi id 15.20.7544.052; Sat, 11 May 2024 20:52:51 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Sat, 11 May 2024 22:50:42 +0200 Message-ID: X-Mailer: git-send-email 2.40.1 In-Reply-To: References: X-TMN: [15/wdzxQElDuuURw4KrXYHhznpU6JQLBucKEXFgF1RI=] X-ClientProxiedBy: ZR0P278CA0172.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:45::6) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <20240511205135.2411886-17-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|PR3P250MB0370:EE_ X-MS-Office365-Filtering-Correlation-Id: a27de17d-50fa-44ca-a03d-08dc71fc52af X-Microsoft-Antispam: BCL:0; ARA:14566002|461199019|3412199016|440099019|1710799017; X-Microsoft-Antispam-Message-Info: 6IFi8oFagRb0xt54CjH+rtgk799jced5QE/FqhFf6jC5B0ZSQ21sLnORypMtLoKIOzTPTP8XbQVg1H0U+JpbTQIR0snvQSs2b6EQKhD6fnD8ZK8fN4VRE8UA3pWJmHWspNFqTBWWCldIS4X+tByh/5DzVly2AmZbWZUGlmXTFS5rACofHJ2NvLGYEoM+RS8Wrnz7GkcHKrrqehRyCwJvnrttqDzACdV+lSsItHC61PIwEaX2i+PATNzwNxPYegi0jWuJ3HuLVEdAbGb2MyffWtuVaWYxKuFBTvlCP3r2xlT+N1L9WqP+2Yqr90adDD6ppyYFx7bBW4yZINqrILGYJFa5simRt12E7w5sg5nP6ykSHlPAw2YvhaOXRKqtKsInfErrRpvBgqsp7IrjXaTNAmufLji5tsmqF+cWk5o6SvBToEojvVhyDcVIrtF4aCthmMWXftlrZ7j0lhY0WNnk3udYDY51BHbLJfUmp+M49Y8+rEhQ4OkDmk02pWopBOYgazbnc0xMvM5ILbtzHaRsR1d+Mu6r1EDckVwdpnl6T3XRkLNOJcelScC/28kRj4afWAPaSuMnp2JsOlmMciHop+XUyx2uiOVUQUfesWn7y68Q/KEsPZudUfFpp1FX3J2a X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Cgw+lW35oS5tFY+/NycP8sdyTfKGr/WfRK/q6gT9DK/apXSgkjXLcoZ9vWEmWkD7PFfYyUsO/CnwpMjrx9AIPLyUV0YnM/TWWkUsMPwstdVzbOuO1Alsuvtmj10aTiwE1OJXjqLDvsquiEvvcOOAntGyg4fokTdaOn+toFNEC9YeyiSwqxxqyWRhle14nn5NymV3khaLm9JSzRIpqmDPrRzWCOdDDCZVhokh7RYrWx4i0JAPKLKASrluENyMyGGniqEg3rAaCFBGbdvRR5dyonSZag8Pgnkf5j48poTyfRh83FWKcjpugy/4Tq28JXzQupdEDZV7GKcHVO2RKOeurXnZS0HSfocdLOPTDR/F71OLzEdRBzCBre1QTSfjwd5nWdcVeDcGCceZpp7+iultfIwN5lQAvLPgfBpa/NpYu2sHmsFuXHsQTbX7RlOCPkgHjs2OmQCU+SzjJxGBXjaATeE14gbnAzN0vH7qkrrVLzJuZgCe5J14EwAUlbl1yNmRBbT91CyeqNQnBV7Dqfsm/zip/TZkcumtFf8caQjigdCcnh37SOjA7i8Z4rQuqk3HyR7+Qk32IIuGt1LwyEmxztZ0kw2fGEolyiJxa6cr/SodLUsLUSTQcqR9rd96AkPu7A/4lnpg5u6YfQOSuyO4UoyyxGCV6tE0mSUZ3ad81InlHCo83SrG9S4WnqaPYzIfKR4TdTx0g6pZkGz39dJ9A4DJCyud5LOftv1deDvxzbtQbDKoEtPNS01xyowxGh+iPye4piDYLdgoDb2PPlxspPboYR2JmrS7gArDo32jaxX7CMS4NaM+1qV07/8Trayajr9PemVwIJFq/pqAaijEJbwLtP2O0Zl0dfdlPKduSCzV+OTDbdkcKUXOCfqHRbWQRGk99ujIaZAS75TxRY7uabdHvKMYrgzBxtr3H39B065UAlEO99ubvVV/3NI9VlJBPZsPiZgKHQl3uPG3U7aIcwUDWHq1M3agcreqp1Wc07//96eLCrnNpc07FFlYpPtrEu7OzXyYYlBkNdZ/nCdNMsowdHLO6sJL0qhSmd/U/dOmo+j+VdQKAQ+TXBTD5qbdTsjStJv8LH8v2Yxcyr3NAoSvxrOJF3mhFEYalnOeBp52NG9ZtexfnZkNDs3/Zk1GjJekAjoAMDdW5JfRbldwVW5R62KJrGM9X3iOcWilhZv29Mc1Rp1/GVP85pQR7jgIayWQPoVfPpGrw/Dzl3kgrSfDEk7SoiphVIOZ2c4Vd9ZqZL8vt2EixnqXM5PIjpoA2dWTcTmvYrqSrm+ya/XTiQ== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a27de17d-50fa-44ca-a03d-08dc71fc52af X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2024 20:52:51.5471 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0370 Subject: [FFmpeg-devel] [PATCH v2 18/71] avcodec/mpegvideo: Don't reset coded_block unnecessarily X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: nQrNbEX7yUOK coded_block is only used for I-frames, so it is unnecessary to reset it in ff_clean_intra_table_entries() (which cleans certain tables for a non-intra MB). Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index 74be22346d..ca6e637920 100644 --- a/libavcodec/mpegvideo.c +++ b/libavcodec/mpegvideo.c @@ -808,7 +808,7 @@ void ff_mpv_common_end(MpegEncContext *s) /** - * Clean dc, ac, coded_block for the current non-intra MB. + * Clean dc, ac for the current non-intra MB. */ void ff_clean_intra_table_entries(MpegEncContext *s) { @@ -822,12 +822,6 @@ void ff_clean_intra_table_entries(MpegEncContext *s) /* ac pred */ memset(s->ac_val[0][xy ], 0, 32 * sizeof(int16_t)); memset(s->ac_val[0][xy + wrap], 0, 32 * sizeof(int16_t)); - if (s->msmpeg4_version>=3) { - s->coded_block[xy ] = - s->coded_block[xy + 1 ] = - s->coded_block[xy + wrap] = - s->coded_block[xy + 1 + wrap] = 0; - } /* chroma */ wrap = s->mb_stride; xy = s->mb_x + s->mb_y * wrap;