From patchwork Sun Oct 30 23:56:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 39054 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:8e01:b0:a3:a294:714c with SMTP id y1csp607119pzj; Sun, 30 Oct 2022 16:56:38 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6cffL4mB3Pc5RBKPCHnwhxq8fsk8LMEYhCc843xx5D3dIAbfixBLQ3Mne9/NudZU9+Nq3U X-Received: by 2002:a17:906:9be5:b0:7ad:d0be:3467 with SMTP id de37-20020a1709069be500b007add0be3467mr2797106ejc.208.1667174198119; Sun, 30 Oct 2022 16:56:38 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id h20-20020a170906111400b0078dad5e8d65si4767951eja.68.2022.10.30.16.56.37; Sun, 30 Oct 2022 16:56:38 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b="d/hXvSf3"; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C595068BD72; Mon, 31 Oct 2022 01:56:34 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2043.outbound.protection.outlook.com [40.92.91.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B95ED68BBDD for ; Mon, 31 Oct 2022 01:56:28 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JPBTjrnlSmUJO0vcp69it9AOwGJugauT57QSwMR+TAjvu9NTYdbqzDqwl0BaYGx/qgFMpR2hLrM1PvWFK+CGQwCOWlx36xa1jByiKelLkhCYYJK/MaaECPIrrVM3UVN7Z3A8twtNwd9VScj8Unk7mjjmSPflXHiLBMQpFvL75k7pPq3wewPCmO1JDA+jDeeNorOEiwzsXoA+gxUeCJ2HyCjqvhnqq5sWVYUToaZe+fesQpoGj5geZJSRsJOwxQ+BstcnMLWZRPvbjlOYQt8irtB5ESYPy3Oo6lfySSh4IgEZdZ1Z2kvd6vv/eH5ayj2t3spFlkHhfGDamz6GmiODXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cQyj+ao6RvsWbzy2E4QIaDRfQniQ0hwBDh+UX2J21aE=; b=BytvBsJi7Zp0axZf1mFULaTZ3oPLYf7Ulcg6enAnsPRZUwrgN1jM7qTAaWdl1TPt0kIXxfczEMYDmOCXi2xxoS81OlOlsi76v9fAPLYyzlUzh8VJsdjB07Ybzgb2noV9m/nqxPybCP8Jvyx2FMl0EvDhIbY2+3rZ3WAaJNFU3ptEI/7Px+unaNVPbJSgwM7q1b3qfiorQCgliNgzU3BZagA5B42NjOS5l7v0Shm+UbmtRhq3ElioaraKY5UyaPbGoh4AfTaN2f6urRSQ/8YeyUrhQwSF6kLdjlaH6fMGMp4ITm6NWYqYC+3P0B8H0b5Tm0j3rH2xuPe5JGvm1blWdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cQyj+ao6RvsWbzy2E4QIaDRfQniQ0hwBDh+UX2J21aE=; b=d/hXvSf3fulDwpc3xIQVDdEqbZJYgQm6WS5LJmTkfpb2CMIsiNfv2PDF0s1iLqPcbHs5rJn2KcYg+f6KUqp9lyibMMciPDsacGETCWE1EyvMgVctNCvP+tGZWwIuSHbQw3KDa/z8jk/v6LSMcZPc9FerNzxJ7GeJTj435pXWBQrTIUjUR6BneNwZCB+AHgg6FrydMvZi6LKBlj6Eyt1GxwUtzoILXYJIs6lMcWtGoFN18WtlkLJGieWukTdYW0GF/8L8+NEANVYMlJaJ1LCfiWUgShPGZHQT9EY8ICz/MFlMwffSEh6Cpw9gvX6C+sWpsH6ktgrZ7EEITkFVotRkUw== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by GV1P250MB0857.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:97::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Sun, 30 Oct 2022 23:56:27 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::739a:8740:19c5:925c]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::739a:8740:19c5:925c%5]) with mapi id 15.20.5769.019; Sun, 30 Oct 2022 23:56:26 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Mon, 31 Oct 2022 00:56:14 +0100 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: X-TMN: [yQOFhAWbpnmMjHas64zVEMTJlLawHVVW+22bqvOUP+M=] X-ClientProxiedBy: FR0P281CA0146.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::20) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <20221030235631.11750-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|GV1P250MB0857:EE_ X-MS-Office365-Filtering-Correlation-Id: 4a81e046-381c-4831-1efd-08dabad25b73 X-MS-Exchange-SLBlob-MailProps: EgT5Wr3QDKxn/FJXV9AifVAmfFjhXa5ItNophVVmDMFunLjHnAOQ3NRNaOFeiqUiqRy1FBUqx6MQrq9WhlODlHqZ38ti90vO908MZDdS4CXGey1/xA/jsH/waPuNFj8FkvihZtX6qFrD6tKWQtCxxqG9vZ86jZJSsStcBb8EpDK5VnyL7DxBHIkIjlatOxmvfrH7iG2xh6YZNM+z/GLBtkaKpWsAk+YbLBcMGZa5v6oKix5y/H/A6/SL+gOMEk/IiPmYfl/RLu8LYvaADzFv8F5SfCgnQsgE9r4C3e9rKDZhmM57j8uR/cs0vMZ9ndN+aPmyl9ITjZWsR4J4YXm5O/5s/4hzSd6jqq0+1Ogbdn59NvGRvlAdQQeFofgdV82ngTf4gQfEDrXQIE7y3r9ojJM0JSDXWwDjAACPzoKb+/Ts0pjK2OZ0X9pC44+chd0eArL+ZnNDnwnFAg4NA/FMb76f/t4sgw0+AdA65uzAE+MK1YHOYSiNgBiSwhyRV9y10ac5YAwBqcfy38qq4Uggrrmnu2n2GcsABe8HklErY8Mc55wcmlLURnJym/vhOgDU96N8SAn0SuaVKifGtir2PqigbqgH2QuiehffSK268CsvKcM/SARyt7eau+DeiiiMyeZJKLdKesFCK17769A0vXnwbqQJUx0GzIGsrskrtj+YKKq7R0BX0YEDCZpXnTDBLV3qTlExuF+P8OASra/Obtgl/gZ7e8/joVzSFJ+mTLU= X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QaTHyJ5g86ia6PgP5l69oPV7eZMeBCzr0XJoAgJWgdMxQ0YpKVxlRKebV1eNE6Wbg1vMW9ixBaZIHUFJxtfbK8/i/IcUEK/2G+Vi9wZE89f7e45v7cx49dFsW9XGKEZkesxL5eVJLR0gy7OVdsPbiHoumeRFt7jGJNonYZomoxiBn4iF8VW14wEL2GPSN9FgcblsYCL7anUqylk/omt6oFCQKls0+zx7Ph2sdd749T69IMrhPCjKl9LWSckPW7blUAhfjsV9hhzmkwEspVbfCEMOoQG2SDjamTw2cbQlvddOCtCOPt1Uz8webZ/4PTphxs5U0zVjEOPFOvJN20hUqy7jxgqJbLZuezQXVaNmLLZf96tUam+M+tO0I/5qi3+pRIExD+jQ3yAEduazGQFFl5TZ8YF5nwbL+tTi7TiL/Aevx843qkwgZzRHmN4tsbUbkdiRxzn/iVnxnrD48/nkObWXGYpi9qD/32er61SgUyjzbaM7tGZGcOHbTVq34F2lKHiCH5V1RIGGPo8pH/PyVFIpCOPfWcuwFGzqnID8wqGDhufLpMhTlEj9EPxKGoNiWhVx9ASTih3RsmNtTDE/2MXPSXLgYIUnZ8PeVWffq9O8Tz9uw8Fhl1mRszHaL2kP0iSu9C24/4Uh+rq9lmNHSuca/4hC9QShbLGA7b+hAJ83vMWgETr9sI6Wh/Yt07/4 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: k9ivIZ0LD/J+AJwx0WTYVxhDx/whzHMuzv4I1UF8H4T6zQY0zy9lLYSVfZUanC0LK7U4rWda9x9KPDAosT4Q/GbWYYMrsH2lX+SKViWurInsy4Rv8KSp5APUjG/ibCL5LOjVpHN1seCZ8bHWTaQkJc1Vo4iZhfqNNaSLGvO/YEUBTGzJ9vQRAW7UTQZf/h6My208kPW9eRAvhg900Cejg60SwhBej5/ELqOHAC3rSC2/idg5EAFwfwyz+ylhH05D4uxXmW1G3mLgfxzrDvkJKQ8h+0kBl52Tj366ZG8xNo9QtYuZAPPf9DGXO3mrFZGyhetB0hZ0nW+UDdkGgWBIrE2U/WiP/5iASRlbTQ3iF+zIAkeJrPSB+tcs6cPvo6sfoRivqQ0gPmxncN9if0oYUPFtrc7QdoU1u6finqeLOwFWIkIVxXBtV7Nt9QYitLsHKMxqrosy8cvazgliMm25KQSuNcWgvD8sd7i0zZFj50GyK/FShjFyu2qNdR8pD5O/EoFddO4NNb2pOMS1sKDJiDpCh5hs6D3nLTMvAv4SerlkFASvnFr33/BggykF/f1OdnrOUpcZavLWAU0VNjeBhYHT+Gt4GZFe3T2hGWQEsvZpMDYRKsRlItSoxt1a4jJY6GvUMdaGhSjm+8GMfE3WpO7Lp4x3T5eXawGLtgvz0NrxphADVsBn8UGeVeut8jWYrZECU9LGJrfgqrUeq+k4FiTvBU1RJJL5MqrdppuUassCHlJoAUha3PiAdBz/Jr8n7AVeg4Bpa2PVcd8K+KjJ2RX5q0JtEawvNjjqfSdcJbVlshBb6jj2g2r23V7NbHVH9MUvDglURBqiOvxbSfnSIC23aV44gErZ4+pvRC4MuZRKfudqPRXE28BzO+qATgfUMa71Om53Bt93TBh9P1vBs6CpJajYTVGUEK4OngddJylrKbt737K0F+Nm2m2D0PWpeM2u/5UjTQKzf/ZeBhbiqv/Ka4PlUDStbCL/H8ydAK/CrPyBSTezhunBpft2XI1S0FS8KkzY3exmoBHvAfxae5fV5EnzChXhGRE12Y4Ak93t7fKbeUM+oyAgtVZ1ZvuqwP+cMQD+gmnBRc9bEeHentehG6zu6SCs0nhdl+CK0WbMNN1ZNOkq9GueCQBrha/p5n1XhONSOY/Xx04JSlCjWu/1zjlv/b3i8hHlEoHkN5KBxk1rMDNezwAv3L6Ir0lnMvX2zxvoyvDZqgZY8TjscjVTLmaQbtI3ncOaSrSr0+/GwB3S0q+CQr4t4IhQSl9+uCASeFmbl3FcBCAz74jJJWBaC/vINHhrUGd2NbDg0Pa2KuBOEXT75hynXKSDovfb X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a81e046-381c-4831-1efd-08dabad25b73 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2022 23:56:26.8547 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1P250MB0857 Subject: [FFmpeg-devel] [PATCH 02/19] avcodec/vc1: Remove always-false check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: PLcqm/WLMyAw Added in b50be4e38dc83389925dc14f24fa11e660d32197; this check was racy back then (as the VLC could be initialized concurrently) and it is redundant (always-false) since commit c742ab4e81bb9dcabfdab006d6b8b09a5808c4ce. Signed-off-by: Andreas Rheinhardt --- libavcodec/vc1.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/vc1.c b/libavcodec/vc1.c index f6de8b9e75..cacb66b15b 100644 --- a/libavcodec/vc1.c +++ b/libavcodec/vc1.c @@ -933,8 +933,6 @@ int ff_vc1_parse_frame_header_adv(VC1Context *v, GetBitContext* gb) v->rnd = get_bits1(gb); if (v->interlace) v->uvsamp = get_bits1(gb); - if(!ff_vc1_bfraction_vlc.table) - return 0; //parsing only, vlc tables havnt been allocated if (v->field_mode) { if (!v->refdist_flag) v->refdist = 0;