From patchwork Thu Apr 4 00:28:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 47781 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:24a8:b0:1a3:b6bb:3029 with SMTP id m40csp16693pzd; Wed, 3 Apr 2024 17:29:06 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVGTZx6LoX3Pzokwb15BK1MizsEBLnZr6o3cqh62kpPHhT9v39XZ6Xe/CVspMoAIc+KUkae25i8K/SN+5NNinyTxp4nmwRzsklJbA== X-Google-Smtp-Source: AGHT+IHKly6a+uxGP0v7hXIPYDRHbU09w5X3K+3umMTQtSIdcv725hXu2urFcCPToiTi2B8oUODN X-Received: by 2002:a19:914f:0:b0:513:c1b0:dcb2 with SMTP id y15-20020a19914f000000b00513c1b0dcb2mr653569lfj.3.1712190546096; Wed, 03 Apr 2024 17:29:06 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id o10-20020a170906288a00b00a4a399adff9si6696174ejd.805.2024.04.03.17.29.04; Wed, 03 Apr 2024 17:29:06 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=YGXsNR9A; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 650CC68BDE1; Thu, 4 Apr 2024 03:29:00 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01olkn2010.outbound.protection.outlook.com [40.92.66.10]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 89CB568CEE9 for ; Thu, 4 Apr 2024 03:28:53 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d3Q9QRRfVwpdbaY6v1gaCrnfvYr9MPxbf/gWVBUMTo0UFwfQkt4DaQTLlDEtnmfwJJduQXSHrwnQitwJNQQA3ZT2Wb5EmUtQMsiAq0XWcPcjpFLtdxEJadmU0M9BcP6j3Q3xvzmLY+39MZolX0LxhlnnQYQFejMsy4o9/SNla6/oA6ovdrzBfgDvbnJocQsRuknZYzS+0P/aG/MhGOBRZ60qNHU2PrwxT4q5Pu7dHlYVW8of+jnTmn1lQO7mCPl1R3RAgN1kCt96kkKpFh9Bg6o8EJ2lfBgHptcCzGMK6TbLxaF6IsqNqeKendJYGq2JgrigYVfAhdlRq8gakNameg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=27fq+p0OQPfpiKecEuVE5AqDOguGe4y7YShxBbqatZ8=; b=by6W+1yHlqgASrzlI+Q9uqM/PoZT0DitrO106x52avYWs2HqjSNMQ/ce3uhJxh8bRAmkwhnR2usNoGaFK+TDxnaKWF0T9iFRhUh0t2RJXNF/0uiFPfFr6t8cUJz+rszUZTZLjdIWUge5VFVQJRXVlM5Ykj46XrG4JbNfPn2HWlPdgOAd5FbxdBqCQwkxzvPf1HKggdJMiRLaSIX7UUvHe0mU8KGXPoeonDdpwlco+kv2KAWflySostV3PlThD+ShNtWJrTVv0D24c4BS/mcVQrXkht0/cgXsVQ8DP2seJYo2eTLVy6URrKJkigVnLJwy3bpRD+aFipd33y7crS8w/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=27fq+p0OQPfpiKecEuVE5AqDOguGe4y7YShxBbqatZ8=; b=YGXsNR9AI/CzGAGR8RINE9ge+xArgDbN1FNMB/aHuryVHWtqElci6PZpxKS5R24f+/Rg65K+b9wiyGr+h4r8koof6ov6EUuZvZfsxgHRoKc35m/B88xY4jB+T9OYuZW0jin2VnLRj7TOshpYe8LcTb7Yep6hMEbaVxtQLl4uAi5OXRNR4LS0jE1+fS5MQMd3QD2JoOweFfFV6v5lp+c9YI7reoAFoLXBbXszECxNFMnoLmbWPhiCQxxvgGPtOFB8UYRkRQ66/5hcCiKwovwQFOLTW01bqF7/O0V1GnVUEzh9U2+798pj546DnSqbd90jNN69+xfMBFiBNcKeQ3F5Cw== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AS8P250MB0362.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:37d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Thu, 4 Apr 2024 00:28:51 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d%4]) with mapi id 15.20.7409.042; Thu, 4 Apr 2024 00:28:51 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Thu, 4 Apr 2024 02:28:43 +0200 Message-ID: X-Mailer: git-send-email 2.40.1 X-TMN: [Azxd0kkfWCbOUGNxJOXcjkbP8y+GkDQQnhkF6g4V2s0=] X-ClientProxiedBy: ZR2P278CA0015.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:50::19) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <20240404002843.2925684-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AS8P250MB0362:EE_ X-MS-Office365-Filtering-Correlation-Id: 0dcc3385-486c-4f89-4dd7-08dc543e33ab X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 55L+AbUcawmXgIn1SiB+726DlF2fmdZgL+uDKVqyxegzZ97hpjX9pp/3hPB9cJkSZ3wx8EE6BF8yjCt67T1I/Y2H1YxeYIrQQA0eMvOmO8LWQc/IndRoV3XM/1bBzqfyliqKIRd7TsY5XOGwPxOvrL5F2ENl0AZXGK3VPSoujm+aRMG2Ne2O03PvweNO8aiNDFdchS9hlOS61vYY16KYlz8i7qPIqaFUHIe2N79Z0bTqV5rdrRMENHfvueKSYxvSWBIAlxs3Lxp1fr+vQOxcaAXPopAxERDbGrKmhiPzcZuWCI167jiTP6ri7qn/UXFrEgLVXNrPNJzW3DKM9rZ1IGzne0qxHJ0b21OxG4gP86S2PfmLlvbmdUg4JyHl4xkeTdwqH64KWSGfwnlwH0EioB5opk4HZQ2tB8R3Bnuii+lPwukNEcJbH8VAN4DlcQUcmTEvFCWuHz6ddxoL1vfWmQWCqgRflNIJcEZVBBUTYl3PwE546m37IbTfdFe1IwlCpH5SY1vhzD8S1Je/fU7ZNdWz9Z7iqLOYO5dOJ6ihvA5DtYgvGzKqffui52Fm2Sm6qM7L44Xo1SUVX6LuqhJQDnlOSTozPnYBW0dpbHI5xTX4x0zUq/6vV+/Fhc8M+ha4 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Kocl/WUgmF0VxM5sJLJ8vQpa57fjO8NL6hchiI9rvi4QWbbE1RLDEO/+1/p1HT4BA2HCfsnw5p5g0YFXuCL4PTu/K86qvAsFGWH0FR02HRYTKoRZa6UaITNdm+L7yV+1fbAaAb4mq+wHLWdGCEVmSYEOCVCjFKwzGu5iWj/VIHalrt+H8KDe+H6MTA1GhCsEdxWR65sSQXDYTdJlK5ipHXCStHoErKpTM1FUvFmIIHs0IGtJsaESqMvyIqk5HUrosUCgNvDMQjJvFqFcbO02nY9ScMYKxyi3bWGO0o49OJVUb6uHBaNg0gNv9KChe7aGQuFL0zrxvbj8/GeUmqRigV0fAmqp3VPvEze+EgFvoCwK/HXxse9ewJhZ6AURGeGrran6wvGWSDK46txER7fSjI9PoN06IA9VcOOJqj6GueCH9dHVY8a4FCGM4l4i7H621cVQ06sBkfoorG3Hyp1uug8QXc7HDE38PNBT8vN9LUBTkprHEUvW6EaOIJNrA+Tou+ksZNPtieqSnznGPK1e9OZpR9fLzqJAz6PvYVhxks3gcDyNq0b9pXjK3wa7kj/huFmiyMb3/3m8ChEyGgBTbEvHlk0DR9wGzEXaPjv8aH4FjB8KvI0PX8h235H4MmyFt+SZnz1Pxtvi2GGUoPQnVKLcynIFSyj3yr3D00ggwpKs8qx7atAYKLKk1iQPLo9mmpC+4V8jENJiEUTW/mNSJaRu4aBvuNpvjKGKtKGLNgRggQ5ATafe6kEV2EhC/XN5g69HpNmH4xPnYkB8KGOV0GNLkxklAxCwvgmpmiIQvApXREeR6JLSrEtg9aQf2SBeWrpwRqR5OJjKkdD9hd9eZCv8mF27BZn2NKkZ+m3heH7CbS6Chgv1ODWz7zUmNRJx75+r1tiJbJiiL7v+nkXBP8D7G0/Zl+s3v1UEzeZgjz61isPB2Jw7lQy2DjWRAa718CJX8rET1MwhF+guBfJaRO0RzXdNNiORfZNSKNyIr0GGZWEAhonTPqg5Xj6TF17+jSH8jRA3ccutDGmNMmMQyewbHDjSz3L0nizP4ykqnQxjrGwiDLD+ZMTL+bqnH5q9Snh/IIxVirtljSm/kta8MdM959Ekw1TY/NXnjOUsR7xG/h/LqZuElDayoXDrJ0rU4Xk7j6tIU62nF8G20RKIlmmwH6Z2j5aH1cjXIIAOa1KNjyHhC4D3G9lrJOwtCYJt7SZh+kYqJfrXhmsuWDDcML/nCP7JbaHOmKBz4YldWJpFUrOfJmwJ6OMjD4PN3gpMzj5WNK61s5v0L6ZqS08mZA== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0dcc3385-486c-4f89-4dd7-08dc543e33ab X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2024 00:28:51.4602 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0362 Subject: [FFmpeg-devel] [PATCH] avcodec/ppc/h264dsp: Fix left shifts of negative numbers X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: L8E/ny4JOxea PPC equivalent of c756b3fca240df75ffa28e75f2eb34834c10294d. Signed-off-by: Andreas Rheinhardt --- libavcodec/ppc/h264dsp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/ppc/h264dsp.c b/libavcodec/ppc/h264dsp.c index f50f2553a2..0650768d7b 100644 --- a/libavcodec/ppc/h264dsp.c +++ b/libavcodec/ppc/h264dsp.c @@ -663,7 +663,7 @@ void weight_h264_W_altivec(uint8_t *block, int stride, int height, DECLARE_ALIGNED(16, int32_t, temp)[4]; LOAD_ZERO; - offset <<= log2_denom; + offset *= 1 << log2_denom; if(log2_denom) offset += 1<<(log2_denom-1); temp[0] = log2_denom; temp[1] = weight; @@ -712,7 +712,7 @@ void biweight_h264_W_altivec(uint8_t *dst, uint8_t *src, int stride, int height, DECLARE_ALIGNED(16, int32_t, temp)[4]; LOAD_ZERO; - offset = ((offset + 1) | 1) << log2_denom; + offset = ((offset + 1) | 1) * (1 << log2_denom); temp[0] = log2_denom+1; temp[1] = weights; temp[2] = weightd;