From patchwork Mon Oct 17 01:33:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 38754 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:4a86:b0:9d:28a3:170e with SMTP id fn6csp1375530pzb; Sun, 16 Oct 2022 18:33:50 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6haR+iLWf3feQIwT+/y57pjT16L9hQ6vM9Pa6idX7L7qZ9dkawRYQi/57w2h3ZGOycvyMV X-Received: by 2002:aa7:d348:0:b0:45b:8ae3:ee3d with SMTP id m8-20020aa7d348000000b0045b8ae3ee3dmr8086340edr.428.1665970430127; Sun, 16 Oct 2022 18:33:50 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id eg47-20020a05640228af00b0045cc6aa0429si6781026edb.250.2022.10.16.18.33.49; Sun, 16 Oct 2022 18:33:50 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=oAjexvLQ; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E6C7768BC48; Mon, 17 Oct 2022 04:33:45 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02olkn2086.outbound.protection.outlook.com [40.92.49.86]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6A00268BBE7 for ; Mon, 17 Oct 2022 04:33:39 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Otxz/A/d1mDCIW1o0lt7kn09TCZhlmPkdavGutjqR7L3r6XTk64XVJJsN35MEnE0wAIXSCCoGwXt9ohh0ZjAv/SVixkOUpHu7PYoB/v6RX+w7N4UHuojhbNbOTcY08H+22LykSiaTGACbIMMC/XfywQInNwwrwgc2wnVQDhtew+kbSCyUg9yPd4kifBpRp084N89R1O3oblJ1lD26G8MOUH5wgqgvEeBACzUKFCRlY+horvmCXAiFkw7xSVrSX3HjGQjz8LDhXZrU4plGL0e3vKE8ITz/v5hXDWm9I40YzU/2Fzh04PrI60OXf+zyry6B9ci+0sfUb1VbZMsl41OGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=41Zr2X46pnpsmfia52I98FehyTCwWTyZ8xmIU8FvpsY=; b=JGk0//X8uqRBm3h9A3872G3lUeuoNkKQ2rJBSJulht20QqfLFQHnoH6I41NMxmf9gPWyxximE8qNhkV75oCguctQwQsQ5EKf0oac70I7m0qUBeiwy4tP94j8fGq+htjFjWR/cTqdNLFuPSewpI9daMkMT1xRj6Cazf/C+Cgf4Ap65jrUiTtpSwKzcAGMiwCrK13rtFATduIN+wfgHLsmbczSNnv+1+/8x5acj65JmOPe9ikfoPaj6/TOJ+18zwuIfp6Q2vrw5Hu/Q3EV44WFN4a0dABabYhUOFwf0rZhuYCfTEL+meR3+2Z4V3PFbabrzjBX5ZWS2xVRIWINSEsH8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=41Zr2X46pnpsmfia52I98FehyTCwWTyZ8xmIU8FvpsY=; b=oAjexvLQrqNC/9YwJAeRdpzdPExQ39Gt6O5EhhIf7Io9TV24QEmIMKFjsHkhvU9cjW1sqIVDcFMkhR3OcgbUbuqFlqhN+XoiqM8/AAnnJ/ykYoMqRYehYNJahCf748c4c2vZcwo4giXdYfXKP4C5aP6cRVvrBGBW4lC/38xYQf/mtAxvNl9XshF8L+nU/+Fmcpa3T9SAdG1tUDnNHBOriT7dk31dOiIboUhEJPpfsVNOgqQws17iboE5MUPB5lTaXl2vkv+/11vZezQ05AznNSBXUMh3HhxNliR8wn8udv7s9BEuxE84kfW7pOGzPBfmzKxgkT11FyzExf0CvQD9zw== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by DU0P250MB0916.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:3ec::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Mon, 17 Oct 2022 01:33:37 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::20c0:9c9e:87f:79f]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::20c0:9c9e:87f:79f%2]) with mapi id 15.20.5723.033; Mon, 17 Oct 2022 01:33:37 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Mon, 17 Oct 2022 03:33:35 +0200 Message-ID: X-Mailer: git-send-email 2.34.1 X-TMN: [loBSWquwMk3iXyNaD37z4jTA0J8vWfMXus6zMUJVyCQ=] X-ClientProxiedBy: FR3P281CA0040.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::8) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <20221017013340.944278-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|DU0P250MB0916:EE_ X-MS-Office365-Filtering-Correlation-Id: 81c5c125-abb7-487e-a48e-08daafdf9cf1 X-MS-Exchange-SLBlob-MailProps: AZnQBsB9XmriMkceEMr8g00cHUekKy/uzHPwHZ7ZKMxT4dnOEAyAX2zcfXh78+NhbCMUg2J04HCWwfOzEgvkecnRlqsvHmCD2Y30MzAC/Gj7sQ2T6WyotmIBvOylT3Nt3xd+QNuar0aAmt4sNj3HSTMbRI9HJMmGwPFuT0d2a2vErlbj14bu+Rb86VKyrEFuXC+9Pz7nxQtQxpLojHKrE0AHeLaC3AqppOO1qZd/zHYdT1x5EeCTBdBY5O3EPSYN7sO66uyHHdk8u27luSxeepUAKY6L8o5hskuNVg5QbImdyxxux6YhYuf7sGDnJJ2i0dmA1qRY297tJipVPz29kVh71eNiuPiIyZiJ4vpqUuIi3LDHD/OrB3UNoTRWJlzqjAUeqWKNZ4+4J/Di5sswoLZ2xKKMcJ7Ltp52mVLJjKwbD8VBRQIrfhKFjETvQ0snaZ1W0Xh/OK+idBT/RfEy+tTsrnx1tccFMEH42dbjt12xHK0VPFLkDnNTIWNGLT74E4Yj4v/G3OMQy+ahMkTgt2kZCXw9yatmyMr2x0axnbvKvxt9nkBXeM/P71FQbT+cUGAYiekdcdOWOSDf+A/fijgeXMxuuJZ+LSWJWMCny5Aig9dqTlR0TSCe+hHsCF1AzoshLhr5agyII/vIc4ZNYtqKqUdrBc6VxxFGVwOfcV6ewRWz9g5ZPp1oXJcyCyNI+U9C0ONrOL4pK0LhVavp5klhjKeT8TZG/5+XBiauH76K5M+AwYmciymL2aswvjpVlmCfGr4hxAI= X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QshOvEtPTN4WRn43gf+JpNdou/MNRtliae+QqaZP2zUqxwKNwwL+CJq2mQDsvJ8cdSFh7T1uLX9fHmnaUsnTRL58U8IGU0MqrS01zGnOiS2y5yKMXQm1Gtk3vMADDVFXd9zhZmSayUJoxWyrPEJXMQJkup+IfzU1BItN208LYkxBP4uqrwj1Qm8bgb9Vh/mm/SbvJnKrYsMdpvdBIxg75NxxT8hV4emK3y+q9YekH3zMTGv/wRNWSsL7brdg89sF5v65Buym+beUIzGAXBk2EVJGO8XytKUigrad4lfM+Db/Oxp5PW6ZnSONwCuaFRN4I/oxtxcuNpRARbCFUTEE44gHGxC16gJG5EnWf6lenhyRz7LMVLSOjsO7iXYjCtsiyI844I53qXLC5vH9ALC/m6P2jpcHvQomwbSM6L0PGc4bvhvrFXnV3yOx/GzyKYXKx/aYf+l0hzEt+12bEGBCsKqyBiv/i8QYXJrR/dSHvQa8oE2/waQsRJDHHGYYNazwPtwxEMzpAZ/hh4sryE2Ef9P9QKau65SStNx2PXT45Fs1elJyvUzzmcNLEc7DJLKztncfdviHgR3GJiMM5+FQPYwfyhuBHj4S688MbyD2w6pH6tYr0jvWLIhgoiObXEk+i3GkG0v8nNGcOi7Ghci9G4EY3GhdJp3SVgPTMhNM1kAoA+S6I6BJHzr6PsKKQpnY X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: OCoZx8taxB0vtVKJeWekHqBkpopyOrkUj1INFZ+QmbnWa4DsHyLd0f1awXGz1BC8xtyBP2KQItTPeigT/KAARx75pGwHPgOkTEIX3Jk82/QmRwZXdPJ3hoy/H5Vl8964wH409HO6JTplYQ0R3d755fpuKc7jOaD6XPW7/eDuXysecIkDblIjWYfK9MuXK+SEUOf2Maai8NZHM0wyzfKFzzn1dHzOqqOJieIgMxhzFTPAjQ/UZzCczqt1YEm0ZzJtU/tFZGyA1U0xz4aYwlGsJ3+yY3XlbQqDe1X6hpjcGegSvigZRunG3befmVRNvGVfrN0kPrPIUjCcCm0CbX/wZKhYJ6GzoYvhC+i3aP8wN3TkWLsVu1HtEK9+gRbNFQp1zURWanMeRwPl9WTEbDpdlUkwiyF6ki4DpifqEN1KTHHolMqXGJAO+q2ruXjBTnoirMNi9f+tLKIQIfIc40P6HAg7ZNaZw4oGsglKxJTE0PL2DR52gHMiq6JglUXE7cXw2rr5iOg9RQL9OFBvBuVL3JDlQIb2DRcpTocPnjmz08Q2OY6IYat3swkoavAxq/+5v4DfqopKuVueYq29fphlWnUVSoUlRrfbABdnFNDwpqdohdoCMDlQWF42Rfkuy//loaXZOwns7gCf1xLZW/Muw4qYEJ7XkbU8r5IDhLuVVEpJSgPuum981I6CskAAQ2JF9MQDpv2e3vBFJWHbddgV5ZqrmpQM6UQxs+5uanUBT/2fkhVZY3DhrlciZ6UBkq0n/0lk+8pZEaCZ6g5oVBN9NgNVBZoLhZl86kmjZkTcbjuFcu2M3XHDR1hPrfvPd31kgeLvsPQM2NGqRXkHfUyAsY9ysBcvPtIaG/sUP25g15Nx44NTW10dv4AWRw6Tk+Pc3EzHVZIl7SgsX3p9EQ0/6GZHTGE8wJjxD+9YmF8CfJyu8e8W8Gz5A2oy8Z1/DTGJw02icApY9ETtm8YbrygrEtfjANM1jMn97jSiP9Fud4O8ROMqdPO/1W3sXHpqe0wIot+LRMf76JfXjBlU31Oj29HOyHFf+lX+h3IGkVRCv2Rz5jVcgmeRPpwX2VMrnvlaaxjM6VZ1T0EFzk2HBBZCvtaUojzVMWiDIfSk5us1YhhR9nr7sS0SJ7YrNFur0OPxOimzxq8yV88rh5RBz0TLx7dynGzxgwFEM8b32ieXpVg9yDpIQlS7+XjKL1oCnH7IJVVb7hCsFxqy2LgafU31/S6/r/3o/D9LXU/RI5GLAqDXcL9WaUgJ8pFt8YR61xsCblrg/L25/FfFd2Q3YUFNcwtBoG8Sd/iIunvzhnDtNiWZ+Rp960t+gFnetPoQAbRv X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 81c5c125-abb7-487e-a48e-08daafdf9cf1 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 01:33:37.4339 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0P250MB0916 Subject: [FFmpeg-devel] [PATCH 1/6] avcodec/mpegvideo: Ignore skip_idct for encoders X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: X/ioWm6pHrvO It is documented to be unused for encoders. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index 5095149eaa..448b65bb96 100644 --- a/libavcodec/mpegvideo.c +++ b/libavcodec/mpegvideo.c @@ -1413,7 +1413,6 @@ void mpv_reconstruct_mb_internal(MpegEncContext *s, int16_t block[12][64], ff_mpv_motion(s, dest_y, dest_cb, dest_cr, 1, s->next_picture.f->data, op_pix, op_qpix); } } - } /* skip dequant / idct if we are really late ;) */ if(s->avctx->skip_idct){ @@ -1422,6 +1421,7 @@ void mpv_reconstruct_mb_internal(MpegEncContext *s, int16_t block[12][64], || s->avctx->skip_idct >= AVDISCARD_ALL) goto skip_idct; } + } /* add dct residue */ if (IS_ENCODER(s) || !(IS_MPEG12(s) || s->msmpeg4_version