From patchwork Tue Apr 2 01:37:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 47719 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:9f96:b0:1a3:b6bb:3029 with SMTP id mm22csp1084333pzb; Mon, 1 Apr 2024 18:38:02 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVOPSLCaLrwYz7JfIZMvcmkVMPY0PDxTRzKbP/KUioP6XG4HVOdm52BA1UPME9RGfpD46OjHCtO8gqbMW7dQj55Cfo+e5muAscI3w== X-Google-Smtp-Source: AGHT+IGlVauZeeHo/IFibi+ldiunDw1uF86u7rw+5NQaRjCo8IPEHY9tNwG74ng+BErIySia16Ef X-Received: by 2002:a50:baeb:0:b0:56b:900b:a2e with SMTP id x98-20020a50baeb000000b0056b900b0a2emr7879518ede.32.1712021882180; Mon, 01 Apr 2024 18:38:02 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id y94-20020a50bb67000000b0056c1a46a4afsi5082010ede.382.2024.04.01.18.38.01; Mon, 01 Apr 2024 18:38:02 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=TqZDRHuG; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4F8EF68D0A6; Tue, 2 Apr 2024 04:37:35 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04olkn2066.outbound.protection.outlook.com [40.92.75.66]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8034068D083 for ; Tue, 2 Apr 2024 04:37:33 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M2II2a7a+U5kUVtY36TPXPrTXnxpi8Ai9RW2t6c8TeEIL1EWFiijqoQHsgrW3jrEhfrJj2ZCi3zxgCRUDDkF+C9BGNaEP4aGZoS5dXLtj9esY2c3pSyozgAr24R+amVcmYhruUflSQaCgP3nEiWAQ5q811jPo+KIjq0WmhvnvTL0N4SWQkh+K2kHF7LZ46Ku6kjg55GGS+sjhjw4h94MEn67z4gb+eIHz9mUQ+Bqr2tR2JpwagOdRja4qrUkRP/s9uzap4T83YBPTlex1gAuzkOvOZgy82dtWFtzzIRAehCeuMN2FZ6nQA6jb1Njh5mjhTjKpuXb7B6cG1a2LyjHyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XkubpCHEi6U+ySTHw/movg4hbqqNgunj+55eEUprYrc=; b=Y6l7cxe2FZqal0XP+wdrk+m3yQRDa8Ch/0I6NfIZ6YrJNFS31S3DE2KqYdQTY0jsA3nXmlr4sT+zXmdRDVHwiiiitoczJ9G2KRJODPZkWRTqGoKx5R2UBYVMneOdPaWgfhzZuU9ZRn9pEjqq/P0vQSZrNHJZdRu21Z1jlqH2NNUP7/q/Ngc9HpF/4sK3q04zqwTsPf56KP2P/2iZmt2J+SKBfVETYPT9EZW7voNkEytdYhuUXUc+ZxLpB+7pUaZenIHJDT2qv8D8y3IByOevx2Q22lHHbcZeZax2NLBMhwE/EsTd9dV6yPp0Usbhl/kduTjYp2Te411l9DDuzvHQ1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XkubpCHEi6U+ySTHw/movg4hbqqNgunj+55eEUprYrc=; b=TqZDRHuGn4abNus9EvtEntRoI1V+cUd5NiLCmno4KuPxJYgnCH6NeEKzm97+WVe56ZxjA8olT3VHhOq0+kPMR+3qVG5K01bb+RBrwpt83C1uDlaZlB2rGADiKwakPyLbMHXQqLpgHij4R/djDw9EfOM3Asw89M3oluNLNePatzktHnGkIG8CAWmBVcxp5h9N3qCUmROxF7wpADCjFdGjvK5b/NDREONqyXEu/WPjmf8HrVWkXk7l1xueQ1K9dBSHnhOI/AdPf1j5ueUzYbBmnNUbJ8OnCggg2YMPDGF7P/ugCMYdBFI8bMv38qcxYzqGse3tMEM9AVzaAVckjxxz2g== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AS4P250MB0416.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:4c3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Tue, 2 Apr 2024 01:37:21 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::4a3b:cf76:cddc:c68d%4]) with mapi id 15.20.7409.042; Tue, 2 Apr 2024 01:37:21 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Tue, 2 Apr 2024 03:37:06 +0200 Message-ID: X-Mailer: git-send-email 2.40.1 In-Reply-To: References: X-TMN: [tH0x8nFsfgdSONojViDmySA4ruxEfwHwGP7svnEeo68=] X-ClientProxiedBy: FR0P281CA0191.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ab::14) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <20240402013708.1510327-4-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AS4P250MB0416:EE_ X-MS-Office365-Filtering-Correlation-Id: be90a6b3-7b21-4dce-567b-08dc52b57094 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X8UIo6gYatWWbzScMe2qEa2zPGvle7rCgX997YB9qDdcoIfGcX1X3bzSz6gaoAvr2VEPkO1UwgvfJh/TTOxv16BPeNYvivrqwcolM0BXIKicgA75yotn5A/Ek+/fDI38hqZeBHZTurG1+t6Naa3t6Hw0jOe0JI8n+01ZKTwWIv+eIOxlA6hQFbxFHWs2htcuEEoVG1DpZRAeKBmsZmJ/H3CkItAVdLVcQjwAxinqjIoyEs0ex9/fqwNTusW6LKNYRqi2p3AUzOwy58FuvP9kNUwtOPjapv79vXBOHCATQWL+unTbvQlynbaAOlGCRdnPRNUYdKnhdS5lkxAeQQ47FdyJ2eXHj88/4usgD4d0vBp9Bc/4tnLHZTo6fZn8siBPmdaOQTY8Rw64qEZzsmVV/q+lrRZafItpVgj/osgKEERcUN3L3F/TC7CpWwUs+wezLKJ6KXjVEw9t0x9kWQRptLAxUaznTstPPiPmX0oyYZVaxjNqu3YshDmsCFHP+jZ13wnM6UkOFod+FEN2cYwYGbbKll6W4KTAta6Qf2CsV6nZUzQZsCp4afIf1GnbJj3Kduvae+LSitINbE9pt/91jLV65HAzsoZBjebh1jsWR1D5zjxEiq3LyE4rd0Db6VDb X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: doWkFMWtZ4aNMqHpyPS636sILMNjmSpwkZgpS834/IIYfsGbFcPw5b+iOSex7zSZLJvhUAFTxx8m7U1kP5tflL3T6hgzGoLj2ImocfpdHsbNrnMjRkbJJSjkRpVMHF+e8tGq2GRo3DvcMK0c3L3OTZbXnQD8mG3kohhnrtfl0y+BAJccByw3v8jqjUsaH5a9PqMIrd9YZ8+Yld2tYtPW0XJ2nnWt1hJ/aFVbx+e6nR8ar+02804i7PJBJotXfovTrNapfxBiRm3wH+epC5uxoHMzJI+MU/PPSyUB4qg43WD9BOa/Ptg+05/bKkYw1Yfb+4oDBZihW4jnHsYOIN8rc+zPnFYxrxPtTCc0SJBn7WDvZ1M+X0v2CMt0YAQ2F2ToouWDKQPLsk1QCPrmiBRV97z9EzmJlcqSYAr3nnKvpYg8l6kupP5EwZzjkut/lW5ZbGZOYQxUXcltToCc8V0NkUv+jWKNNkm/lsDTnKY7uDvsjLqRMRQYG1T12e+tb7HwFz8PYg+MVcds1l/CZfv9nHPcuLnuDXX0O9EaXyaMLEU49DiGgnzjt1NmTcaztRcxYE4DWtI9HNyEnDzBp+BdxpUojpLbr1D2r7AggQ7n1XFKxlh2e7c1sSIaFEYMKcszKcyLZ01WJGoYE1AtfllUwX0Lo4wxdtfqy/vAIQAA6GT4XYb1CzMT7BfBahtwNJamsgtNLB80uEBJHkKmpMk1CHi8SGm0X1Xzr+uB8ln9ffXkaqHx4thOn1QjP5cDlHpwUli7ruhNK4zwpuf95aJw5LVG2QtcNsBz6ilDD76pbdRn+cCPrlzOAeGHmO36/OZ7zeiDuOcmuoBkCDwd4dSdMJZzzZbjvlDaK7405/p+wfzV/e80PsWIYmshP6hnbpvNwf4l0ZOpqetRKdJ3bWIPHAYmwPehRXJCbOqkfRqPHI87OJT0dsc1y91irjJRksG+5ZxjRTJeaGiTVhrwcTPsxVQB554SoG01+0zN2Hcu+us1p3+mTBZXfAHuJzYFYMFeiAJkYUtBgqf+GQFooTE9gwMSEas4yukKb5r59dOZ465O0+J8xRQ/QRa8aTvqL0hR0fyWNnWB6BB1NsQDt4e6AWNxWK2fyyrX19eKKyhIj5MIUus3zLSEbNMsKKQlbeGEee4/976aj9wWs2ZhXeNH26a/yM6wZbHR5ClmK0fwydNzrfdPNkgsFUekqDKQ54tYIYvRPiUrrD/scQfPcLWFj9v9Zz9P0QaRnzEanVw69HuNDXoFqOaf+PP/hDRat9W8Huwd6kntzHyXcsG+6tyDnQ== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: be90a6b3-7b21-4dce-567b-08dc52b57094 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2024 01:37:21.3036 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4P250MB0416 Subject: [FFmpeg-devel] [PATCH 5/7] avcodec/dsddec: Fix decoding LSBF samples X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 3JrIDs4YFuKY ff_dsd2pcm_translate() works internally by converting LSBF input to MSBF upon reading; its buffer is therefore always MSBF and should therefore be initialized with MSBF silence; but this is not true since e3d8963c3cb5b8cd31460dd9b3b9dba2a2343bf5 which this patch effectively reverts. Signed-off-by: Andreas Rheinhardt --- libavcodec/dsddec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/dsddec.c b/libavcodec/dsddec.c index 22009c70ef..2bb2e73b75 100644 --- a/libavcodec/dsddec.c +++ b/libavcodec/dsddec.c @@ -56,7 +56,7 @@ static av_cold int decode_init(AVCodecContext *avctx) if (!s) return AVERROR(ENOMEM); - silence = avctx->codec_id == AV_CODEC_ID_DSD_LSBF || avctx->codec_id == AV_CODEC_ID_DSD_LSBF_PLANAR ? DSD_SILENCE_REVERSED : DSD_SILENCE; + silence = DSD_SILENCE; for (i = 0; i < avctx->ch_layout.nb_channels; i++) { s[i].pos = 0; memset(s[i].buf, silence, sizeof(s[i].buf));