From patchwork Mon May 6 15:41:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 48590 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:e68f:b0:1af:836d:81b3 with SMTP id mz15csp1453648pzb; Mon, 6 May 2024 08:41:31 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCX8ymgdFiLYSXqd8eZkIHw/qaR6bgw4Mk1pDMuC5VUetwjVvNMz0fG18Kklgq9QgBuBJBm4h+fyNWak9aaPShoflscZOwmILrZNLQ== X-Google-Smtp-Source: AGHT+IHuUKgO+L/xpNUbdUvl8n8kFYgQ+v6z+yAVDbjwOzXJypsuEBBUhhjbwdP3Xozhsc8ZKsbO X-Received: by 2002:a17:906:6d05:b0:a59:9c20:215 with SMTP id m5-20020a1709066d0500b00a599c200215mr4566888ejr.6.1715010090731; Mon, 06 May 2024 08:41:30 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id hv14-20020a17090760ce00b00a51b7e1f165si5239331ejc.727.2024.05.06.08.41.29; Mon, 06 May 2024 08:41:30 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=OCMqu+z4; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AB2D368D656; Mon, 6 May 2024 18:41:26 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02olkn2071.outbound.protection.outlook.com [40.92.49.71]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C4E2468D645 for ; Mon, 6 May 2024 18:41:19 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nb+tswARZmiWhQ84YzlXZGDMAg5+nc12UXMhxqlstJeTSUqJWo0rxpyEWlel3h+gxG2AURXOj0piHV2LWreY2/LzBjS9Luuuw2hmktV7kUWM6jL7COArm+NBxkAvCzJVky8U1sd2oE1LVxJmTAxC0HySviVJUp8kyb4IqWnjsoas6xEIesu6FTAfm/c+b9V8tM47syhX2i7jOyG0sJZfoNTuORNNKSuF4jGOyxMdjRQdt1937tjm+hBHLErDC4ceG4g/Ba8Eu8QkGdcAGxBLCoDRSJwWxXwLQwkvFkdNWUT0yx1GKXTHY2etMVtZtcsxt1aAUFXSNCZj/iposaPYJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ezagKszp6Yk5/jKn1mcg+Pb92F1a0hrOroJGa2L8yws=; b=LrGZmaeuL+2qXeNCqaOGiu+RbexLQDYGMfWNRbdEASuCEgiZW9lcMQB4t9YqMW2csiRHPMw29O4UevWyjoA80qYW82HsYkmjyxEWX8Xv/f0nvgzCVjdTmc8egTzFUd7S+VJXx4eJzvW9tpluI0H0FM1xzdBur/ru72FW8WV4zhZl0htVqRzth4a3TQmp9rdpitji2/M1y19u+rca+lX+nzskixAQ6xS3rRsCKUiC69g2YDmcJkezEKM3y39xPlJDXOdeQ0iViTEp1ce5OHs6zuUodk353eztjiTP5ptNYEG3ITuH+N/9oEdOkbRMzXWWlAkGcDbCsdjywa/ZOThLqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ezagKszp6Yk5/jKn1mcg+Pb92F1a0hrOroJGa2L8yws=; b=OCMqu+z4VxgWde0LVZ6hKXxsHJQh8IsYldO7GcFTSF8+3eH9E5dBcWrNxGM7zDKSwk/qb6s7hmDuSRBnFKy9ve9d5k7H+usZ06VP+2a/bn2gVLQCkdUC/ijOExX9XFkfsKRArRbdDheNuMtf9p40RxfK3hbYUAcCHnFmGfPiSL/Nq1glglecxcR7aosL5c6NZIs46P12c9op8EqklOjA7ItZnyQfCWXOWJhAHpMHy3Sh+Z+z4kmuuIHMZKWyJL4TZZJLnClgw2h+eA5aUxezUpaUoCIpVT4UFbehx/g3Uv6YbA+d44yqlJVMUuU6jsabXMT4sdw5mMo7/A9giU/0XA== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AM8P250MB0090.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:36d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.41; Mon, 6 May 2024 15:41:18 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%7]) with mapi id 15.20.7544.029; Mon, 6 May 2024 15:41:18 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Mon, 6 May 2024 17:41:10 +0200 Message-ID: X-Mailer: git-send-email 2.40.1 X-TMN: [WJqQj59Q8VRy4G7gTBHAuJSfNuTt7Xnw] X-ClientProxiedBy: ZR0P278CA0119.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:20::16) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <20240506154110.545678-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AM8P250MB0090:EE_ X-MS-Office365-Filtering-Correlation-Id: 5b4b76f7-0447-4e6e-d197-08dc6de2f898 X-Microsoft-Antispam: BCL:0; ARA:14566002|461199019|3412199016|440099019|1710799017; X-Microsoft-Antispam-Message-Info: eyHTnnTEGLWvikdNuISBu3mAEb/x+QbL+TfwSSrqgix9aEOZzXhTL5eV5+3tkTS6n0Ww7zUkdHhbWuCmtZ2WKpQKK4xC3fqjr1NQ8zvsiVT4O+n6/lWtCwDYXXuvBdScMZirJYymHuXSvKl5MOhDcmdBw1O1kDJe0Vn1hPGLwZ1bIkvois638kOgVx6t07EQgcqmcJ1ttNAnWFW/LPEnZD+YW8y6gYdmRdvSzKHBWb2WfMeLr63VP9+Uxph97ZNMApHY1RLV/sYjcvDeV0UBze2xpOwdAjrFtUSPa3v/yuG/sv9f05nmXHOb24fHYI0N9OS3Upv/6YMHhF/yfNH66FzuRLM7lt9MMfdESW597H1HAw12f+DLV7nyUpYKHHLnDQytVPlbvR5xAsZvc5niD+tElceS5JIJJGFZ9XsKQSa+7ZGbqCGw6jn0gwJypr2sPgpOBZwpRFiLw6p1ra0RGe2845qJLV4bavlMqfXAmUDf7DnabNWAkJW9NRn4E+Te+/tIwHpeVKwFG73uYY1+T7epEJcFx+BYmv0XwMM3xv/Jp14cavXy0gyyVFF9qNQsr0uvj/lqmRZRnkZPbRkStzDYtr/GXEIXk33egv3IQcO+ZpvWqA6R5Ama2UYUEMlJ X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: DB6Ar9Q4KDmpJ1CVAHwvg/0jkVCxJpspbfKbeeE8ovq81kNY9IvFmiKFx7oYYq/uVBUfu3fOAdrlbrMuHaldhZIBPPDNCLyQ4KhDaOCyhruKpviX8rQFecymZBWjj8c0mv+m/ko8ZQOa/ImNvp0Ph54NoLM5bBHuES5ySyjj+DG4I30oSkKEoMSI9/2PhYik/braoWqVQreQMkg6fZpzGV13syqEDCYijhV3VikVnGAGIH7NpZQq2ZbHU53ydh5tkjL1O1gr3nFslCchZDU06gqTY/gByw39jk3KSFECB+GZ2wCGg5KWW+NLoCXBP7iX0KhJxaz7tCX/TFEOZ8k54YCkcDt7CCcbp7KyXgO7fHfjGPiCzFATXBf85DhmdTD3sGYSlxZp1cOdSdNoAC5iRQ4s6QSe2tZSZvPlNCVsyxn4hdFQBjSbdr9kb41l3zuwHq36CSPSlGpaxPhGhK52ipQbC7jxhfXsX4nb6zj6E7mRkLVmAbL62pLSSpzkDagZ1LOYH9H6sakCbRQ9jAmCmsTq5faeK5y7uNqgT2u5a8/wfz5zgRaSooT6rjZ8HX9lxqWVk1gYtnvgGSt/Yc6mw31qM5OmfZSmsveIcv3qQQEuJZSG561l1og5T7Uq5Z+l0MJfM8M0Ux/FUXS8yOesurSZgVlwSD9GX1+C18OtFGGUBQCQapzWP6V3O1maBzeFRhzzxpta6Jxb/3/G6rWfSy2ldQiJg0FoWkxNxtnCB7b5PhJVjHO4/20Pu7wTu38IRI9/X9cQhNefJYr+n0IR1iDXkYVwVaxDdwlbKE90yRyPxW6yu+OaCqExuO6nsLQ0StyRqUm6HPiEwxh68EiU5rYnsYw5fYGJ3qAh0hUiA8X9chfsPIfakDwNkLdHs4eeXDIa/XFmHsFkVMKyEXVC4Y1x6IiPt3xOwWIactiAg8Ndf9OcaipztNoEJO2JmVq6u3ScalzOHDOXqMMk7B9UgjhyevMmsRz7hjrE5tM/DG33dNxBoUmJ85mfkkRt0BYIbuZzzOBSGO6qaKSGh1nRtNccjjsfJMyiF9spCkJZYKvQYq8gPVJw5u8PXMcp1km+Vd0+006j8Indij7px8j5P5Pats+JDc4aiGfWDG3bxmEnIBgoJaPGp66glPeLSnLlnC/9wXaXAfgCiQSicHjxjG2d7B9Ehk3mvn7N7YchdkAp9dvJvfnBfNwAKeA7Hemc7511xZa0GnWPfnkhfIkXTLquOSNdu/zqgLF+59nNWwMnBUyZbi4oeQkYPnwxdDrAKo6Mj86lwT+PNffLoQUBwg== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b4b76f7-0447-4e6e-d197-08dc6de2f898 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 15:41:18.2925 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0090 Subject: [FFmpeg-devel] [PATCH] tests/checkasm/svq1enc: Use proper range for input X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: sjV8JuzjyRxE ssd_int8_vs_int16 is only called from encode_block() in svq1enc.c; it calls it in stages: At stage 0, the int16_t array contains the difference of two uint16_t. At each of the following stages, the int16_t array is filled by subtracting an int8_t from the current stage's int16_t array. The maximum stage is five, so the int16_t are in the range (-255 + 5 * 127)..(255 + 5 * 128). This commit modifies the checkasm test to only use values from this range, fixing (undefined) integer overflow in the test. Signed-off-by: Andreas Rheinhardt --- tests/checkasm/svq1enc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/checkasm/svq1enc.c b/tests/checkasm/svq1enc.c index 1a6f531141..f9abdcbff8 100644 --- a/tests/checkasm/svq1enc.c +++ b/tests/checkasm/svq1enc.c @@ -18,7 +18,6 @@ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ -#include "libavutil/mem.h" #include "libavutil/mem_internal.h" #include "libavcodec/svq1encdsp.h" @@ -26,11 +25,13 @@ #include "checkasm.h" #define BUF_SIZE 1024 +#define MIN_VAL (-255 - 5 * 127) +#define MAX_VAL ( 255 + 5 * 128) #define randomize(buf, len) \ do { \ for (int i = 0; i < len; i++) \ - buf[i] = ((rnd() % 65281) - 32641); \ + buf[i] = ((rnd() % (MAX_VAL - MIN_VAL + 1)) + MIN_VAL); \ } while (0) static void test_ssd_int8_vs_int16(SVQ1EncDSPContext *s) {