From patchwork Mon Aug 15 11:52:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 37283 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:3d0d:b0:8d:a68e:8a0e with SMTP id y13csp1225362pzi; Mon, 15 Aug 2022 04:52:30 -0700 (PDT) X-Google-Smtp-Source: AA6agR5mhODCB1DxMC3uVz3AsflKh7fHjE3YaZ7fTdHGlMM4zRyPJkstKrGOZFnf4PgS1Wt/Vauo X-Received: by 2002:a17:907:781a:b0:730:ccea:7c29 with SMTP id la26-20020a170907781a00b00730ccea7c29mr10310218ejc.85.1660564349803; Mon, 15 Aug 2022 04:52:29 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id mt19-20020a170907619300b00730968191c5si6306583ejc.456.2022.08.15.04.52.29; Mon, 15 Aug 2022 04:52:29 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=MI521EQ7; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 04E7168B934; Mon, 15 Aug 2022 14:52:27 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-oln040092068060.outbound.protection.outlook.com [40.92.68.60]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F0F5D68B5E4 for ; Mon, 15 Aug 2022 14:52:19 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B/pDqdfXs9etmy4i195MC8X8GBwZCcrVCeekS0I0eRD+DW9WkfMHLCcX3juh/GAcGAKBJPQV4AZGgCuPbpZ1wLE3ysl8whK2W0YUg6fvulupNxkSv5xlBimllxXiOmksqmTyykkyIyoS0JmYPImH5GPsIHRPosT0BhY9mj5OejshEUFSopwIDXPbYcCXMylHWsLbt8uH7q2E76nk6TUA2iewjoJbROjNKOVNWRXxQNrE8+RWIkbCZbNrnRkbMcDShwW2vpH5+fc6UjVtJASLAhY+1ZEwHty861rBGdeUEQE1Mlje2RJaIo4DvSXC0pVbH+lnl6tQ41TwY3k+a8eRKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8UeXEtc1w8S5daf9xerPybH37GKOWJEVw++JZcqKSaU=; b=BVTgpnouHFyDPPTZH3Pg5fg9TiBoc20bC3evF88fG1i80W0lF3EtamjD7EEBQv2yUZBYo6qYE1fecS9D/JdqvpeRIVFZmkekyNFU1468Pc3HtrQnZjUP6erPZqhadW5HOrtLsMX3lB67lpdl1VNp8wq+9gMM98hB/bUmG7yNsHEMLLtk+qsZCPrJvHwAQG1tU4q6uVfMg364Mw63hpQAolxHGWhYpIlrqJUWrOl9+gPWI9CFrk5EntxqBjHOAXQ6+Z1vXhVKq9HgUcU99zPYKyZdNvSeWKu2OGSXctCvJFBGv+sszJR/UgpI37peLeGof0SubC5Y9L66N9VfJ5gSlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8UeXEtc1w8S5daf9xerPybH37GKOWJEVw++JZcqKSaU=; b=MI521EQ73UOnLnGmbeNIZVeS1o1x4o033OBGFhkU/c2jmftTFl1z5WdcTSff7CHjj4L94mNdWv+JBvlYac/a8h+n9g5ZRMAppz4LHsZmXM73bKHfJl4dkjvfx/vhCPmkRIRIcb8EvCTLs46oDGLHypsZq95Vt+hMLv+SsMCyVTtGiU9O+zOQGjSnN3+0q0wFlhrY360FEtytuqzDcFXVJeJSEm2/J86ymvvgk4IhfoD9XHtRMdcTkw6wfcRbU2Tv/vVlOXDS484FcRDOCpiXqM3K4wgKcUgR2RP7SP9DjcANEEmQoOHQbC19UAP+QDS7G6lNLeDFnnX9ma6z+rCtTg== Received: from HE1PR0101MB2219.eurprd01.prod.exchangelabs.com (2603:10a6:3:2b::25) by PR3PR01MB7937.eurprd01.prod.exchangelabs.com (2603:10a6:102:170::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.10; Mon, 15 Aug 2022 11:52:18 +0000 Received: from HE1PR0101MB2219.eurprd01.prod.exchangelabs.com ([fe80::a552:4834:4a95:2c5e]) by HE1PR0101MB2219.eurprd01.prod.exchangelabs.com ([fe80::a552:4834:4a95:2c5e%6]) with mapi id 15.20.5504.028; Mon, 15 Aug 2022 11:52:18 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Mon, 15 Aug 2022 13:52:06 +0200 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: X-TMN: [LXJdoXhW6PiuEl6R6fTrjU5Qc12JyQe1] X-ClientProxiedBy: ZR0P278CA0194.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:44::21) To HE1PR0101MB2219.eurprd01.prod.exchangelabs.com (2603:10a6:3:2b::25) X-Microsoft-Original-Message-ID: <20220815115211.2237279-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a874953f-3439-4525-8dfa-08da7eb49ae1 X-MS-Exchange-SLBlob-MailProps: S/btQ8cKWiTPBnr/PBTQGLC8wm2swa7NsoKHIkYH0cEqfmYrR9M6yhIpEUn/wf6siZa5CEjmFWOkFUESduIcwPV2vU4eqqYCWq2xYvbn8glG+hIQuQLMY9S9/+eHINZw00sN/z5+m9Xm/Aq+OSMTT79y5F0idgr8M/AAU7AO0cYL62rqdbuMKaSwfwsdc56BLqvp4aRzcawLibAokqgYx8wnTdMXwsnSobIVJJDA+G514N5KjGKI0WgVSk//GDbN6M6hQTaDNPi5od6hZFxUIViwvIuRrMCcJVyooLgUEN7IfMEpCOU6klb9OVcmZc629Wu+DMHK0EXyZilhJvK1AIWuk8Kcmcz/8ijD+K/uAnCR+g5f4clm2b8LTSdAub+tqqm+2jug8QXIzP2o5r5o4gcxXRwSA3Fn/ZBF7cL7Gy0ZaT90QaHHx5haDualoBDWa8jjmyU6bnImjidpZX+AGF3NU6winduUmJ389+Zgq3Np4IuTBMSO/Zj2uac5qoatYZhm6VcWMLR1EYCIP20VBw38k+xp04YxCBl/kXggP4trxOpM+cXv7NKVN1mJKYBDyXDgwTtkrsAmmohlJ+I8rmcZhrgfxqs7LgLdh7xCwkoXAZYNVEvVHbAvSVgmQDcIZ7QPalxO/9hMrzbMAkfpg3qAw2f6i7yW9433ONPN2JIzfT2zf6gIXil+RgGGtgHAjMFzQ2oG1sH93QuF5sKKQZhKEtcPjX0KdniKm2krNcthiRzatZQGta+dRPpWSK62WeYhfkWCTRs= X-MS-TrafficTypeDiagnostic: PR3PR01MB7937:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +hFkUJ20RmonU8UhG8U3cnymtycwNZE/lLEtTc8nt6PSWFNEJ5q4fEiQg8aWe9l4xUrdF35UPKGxa0+Y4HdKzOX9zXthlHAGyDUQ1n7q7uy55nar5APGJBHQV4kQjk7XwZWHWKgtgrMaSl9T121tqFOLIa5as+X+ipviImLCOHJNV5r+JtT/fJLjC7Jbo38642q/l+Xa3Yb+t7haR28YSZIOktTq2BH3hDjEWC0OvaVS/lYzzKTkUyHKjLiF4CBGjKseaRY+o2yJdNAa2yMC0ija2zrlkI9L0atKqEYjtdBsaEA6mrCDTtrPdVPAEgCaOxby3BLPgGKKg11dnXGKnsFQm0MJmZuF5XeXglPSEIc0zDE1tFMIkG2chuVgZmyZ/4+TlTFSdoLUHcD4XBPXm52KGf3xiUsPDX1Z5vnpa302OgZ1C2MAT61zgasws4Yc42PXJSJtAwfvByL4qhYGLQRoBhyIIM2aR5dqdiOw6U26TUbyt8yUy+oBFRWRhfOt6dJgLzInaxiB5uD4YwUqge5fg0qOv4eUidv13R+LbiTopZ6KvvaP6zAIpgweS6lX4wFXRywAVjMPbLFtbcklsvTTwhtJUe6e+/0O2FEY8twEJZwWIkCP52lmPyGJzepyeI2vk7MPyguNLhTyLW1hBw== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: x5rrDtRDTqhHWHH5doXGlzzx4+dRvUI02wis60mzjw1eQvXlrKICaQKUAdbO/7QjBsWnDY8S6lr0r6GBITXz8Q5Un1YJ5SoPa02S2sLIeztsGRth4sNseoliEVF/g9eKp3KqNir2XRMoAI7lRAeJ7Qqnuzy8xFOSUUcw8fGkdO1fyGTfmmioN86g8+sr7TR3Q8NBr2XFPh4vAnjbiW/KHBgN/eeE7o7o7i3HzWaMpfXJOoHz2XUSppwQdoWkBnek/N+W2ytSh1WpN8+TcHbcUppk4/35ffvCoiXBaLLPvCGVSVeNrnjqeDEjxEb2YRblMiyU+jxnqYtEyZbsMqaGpJwsb+h0A+Zxcl1/fLTBweZdv4h8Wwd5/2rcrPK9dMpzhrhuKs8tvJGsoTAcEkyJEJnaUI8BIsRE2H7/plWTFlcVwLGDbSJr2CY+b0Bnn9EWpuHQOeUmuwrU6vw+FTY/4GD6DERpP3ctALR1IJvL8k4SxzliUNNM8va+0IgHUHRa9HOVK4DZtZkooQMuFA+RfCQEtYGDDXLs+JaJ16CE4CmINk/4XIQHfBumsAIr4YmO/GkgZTGDL75Hb4sYq9jfbeWGWqnyRsM6NJkVRqzvP8IPxzBTLGKgETGxznK+UKt0vtFM8Wwb3+4iqkW8SPKdPYylyK4aAL11bwyUQ6I4JSe3dIgbL6Y4tIzqDt0SKoJp9GL/XizjhdhC3/xDADvac4Ne3KUxTzvx7qiJsfyEa1zzZQysUfF1h1KC/KOr11MF23FJUgt99DFK7kxOEcq0ufec9qUPDJP3xaodt9El8j1cqKURPnR4KEmy+kCTD09T2oNozxkrqTBKaS3tNCBIzGw8mIlsnN1niQhCKhzDfUUQ3DlZePdPuIS/iWel59PbHtTbeU2OtnV7fiyFSAyZ73M6jIKA3QR07akAgBTr544wxuRwBqjPu6/b0WZ7EqQlkTq7suZlAgve0/3cxRB3OGVfU/I5LfxeLFBAeLwPyFu73wtRGQkbgQb3amdcjMwQSLg9ciBvzudp90GkeQ/szIeC14FoCGSXlYtxAWtYMWT0pGWOPcGlsA/z/AzLzoJ68RGMRoNfTWezkQwqaFnr5VPhM9QweyLWdotx/1NZzDnYB91Fuhuqw8YLbEJ4alvHsU/Q9F9zbCwZPkb20j5xm5xRIftoKfI3krp+vCXiSe0gl3AKBHQYmtugTENnN5NQStTTn3L53CUAAZB/+Em6HBdrw0tmrsNlit6SQCouIMlSKVmy2mWDIXw1Bj721vfBGXYG7LpHK8CBx7aAFjw3QwURCrfW8uy4kBcbg8JQ1ZM= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a874953f-3439-4525-8dfa-08da7eb49ae1 X-MS-Exchange-CrossTenant-AuthSource: HE1PR0101MB2219.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Aug 2022 11:52:18.7157 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR01MB7937 Subject: [FFmpeg-devel] [PATCH 2/7] avcodec/h263dec: Don't set frame parameters redundantly X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: /ZJQcgosbU/B This frame will be reset later in ff_mpv_frame_start() anyway. Signed-off-by: Andreas Rheinhardt --- libavcodec/h263dec.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/libavcodec/h263dec.c b/libavcodec/h263dec.c index a65f16caea..a14d7811f5 100644 --- a/libavcodec/h263dec.c +++ b/libavcodec/h263dec.c @@ -583,10 +583,6 @@ retry: s->codec_id == AV_CODEC_ID_H263I) s->gob_index = H263_GOB_HEIGHT(s->height); - // for skipping the frame - s->current_picture.f->pict_type = s->pict_type; - s->current_picture.f->key_frame = s->pict_type == AV_PICTURE_TYPE_I; - /* skip B-frames if we don't have reference frames */ if (!s->last_picture_ptr && (s->pict_type == AV_PICTURE_TYPE_B || s->droppable))