From patchwork Fri May 21 09:17:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 27886 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:b214:0:0:0:0:0 with SMTP id b20csp340409iof; Fri, 21 May 2021 02:19:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyrJiMFzB6Ds190SKTlyaXUVsVWjVxxBEtvFvy1XxbQBItcomlwERe8pLD3p2riw27botLM X-Received: by 2002:a17:906:5d0a:: with SMTP id g10mr9161076ejt.349.1621588761252; Fri, 21 May 2021 02:19:21 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id df25si5185708edb.200.2021.05.21.02.19.20; Fri, 21 May 2021 02:19:21 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=lFWHodRu; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B27EE689AFD; Fri, 21 May 2021 12:18:16 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-oln040092064073.outbound.protection.outlook.com [40.92.64.73]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 483FF68993B for ; Fri, 21 May 2021 12:18:13 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vy1u1HJ27cyeif32jjYdHfDbMllTRpfoqYKPW+fFfIWIKIM4ph1CV02ObHrmf18NX0CJhhqnibgQXzvdYJSU/HjVfVHLuBAiaTfYNcwxF2ciO6wt3O9oJVMS0Jg57kOPdFhHWVCo47l3e8GUwgIXGteJoFbPtC9ioT7hzTV1LCKzXoZmXVn/qYXNz61w2nwgYiEafklINsHN9YuH8FfbpGIr6J2kLNkeh9UO3fLofXN6r+eTuouAHhPAsWJJDiIl5fcJktYF2w2gEQumPUylTS07ZKT+aPhybUXICLTftq4ODkwo8Fpk+XkYMTuhwrV/DC5L8efFDkD8etRLE2NBnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mbJqWjCLo3Te7rQdGePnn7WWYZezlWl40089nlYStsI=; b=AWNKGKqbaFTpHuwxkUbN1xdMvB8yH/1mfO62WqTdTv+aI08huSZqWQNKXkNL/dcBmzKmT/k5+kvTizzz1Q2M91cp8f6ywZMCB5pHbHuULx2KMNO3IuGlpx9+OXBffmRyd+/k6Q6rRtHRwSQ1GRyMHQWG48Vktt3M2VEdPJDBoawvnWsDnhtyJUzv4cJA+PqDVLdGI8dt2CqdBpeHifFg1BScSDo1ISPck0OJlUWa/RqOfkh9HtYPHR6Wocx4y5Omh2ekNCoHHzV/UDpHOebHNVjwC9L4Ia4r6oOhmviVfd3RZQYcBRzOqV8aH9T6kdaOwenvhwI2y9d1PEb2F/sSvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mbJqWjCLo3Te7rQdGePnn7WWYZezlWl40089nlYStsI=; b=lFWHodRuJJxmOA/zrgZEzmoQf4q4DJMK7AWl0fis2X9FnBI8nP2BcuMTyNOLzMgld4BM8ZnNbYWjO5WxEaMLz4gXMzJkXtjmK2izwoEjRw0sDgWS6UIJYHVfyaS0Zf0vVovIXX3OwUKABZxUfe1nG/G3XH973MGmcCyJg5RehO0kKEymTyfpkH4I9+SxkbYKuw26STRR7j1bm7wVRlZwW5HWo12rDCy6DAI53o6VZPYiUHHB9AFqwwCPGFZUoStHQ6qlfrb4tDfbt6aRRe/1moo4EjU8v0qSMXTb9r5Xp+De/DvyLHqNXUy3aVKHELwUfPB0YV52yWQvQSNeHx9F3Q== Received: from VE1EUR01FT010.eop-EUR01.prod.protection.outlook.com (2a01:111:e400:7e19::41) by VE1EUR01HT073.eop-EUR01.prod.protection.outlook.com (2a01:111:e400:7e19::297) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25; Fri, 21 May 2021 09:18:11 +0000 Received: from HE1PR0301MB2154.eurprd03.prod.outlook.com (2a01:111:e400:7e19::41) by VE1EUR01FT010.mail.protection.outlook.com (2a01:111:e400:7e19::83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25 via Frontend Transport; Fri, 21 May 2021 09:18:11 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:966F40A6AA332F2258D2AA4DD1468F7550838EEFCFF2A699A7256881241A59FB; UpperCasedChecksum:F8B3E260ECDF12471729DA5DD021E74A8228456E59E00A6549A7EAAD0BA5A53C; SizeAsReceived:7595; Count:48 Received: from HE1PR0301MB2154.eurprd03.prod.outlook.com ([fe80::f4cc:63fc:9cef:37fb]) by HE1PR0301MB2154.eurprd03.prod.outlook.com ([fe80::f4cc:63fc:9cef:37fb%6]) with mapi id 15.20.4150.025; Fri, 21 May 2021 09:18:11 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Fri, 21 May 2021 11:17:13 +0200 Message-ID: X-Mailer: git-send-email 2.27.0 In-Reply-To: References: X-TMN: [hSdynToKhJXBZ1UJg9t398KNYZtgzIvK] X-ClientProxiedBy: PR0P264CA0070.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1d::34) To HE1PR0301MB2154.eurprd03.prod.outlook.com (2603:10a6:3:2a::22) X-Microsoft-Original-Message-ID: <20210521091742.184902-9-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sblaptop.fritz.box (188.192.95.27) by PR0P264CA0070.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1d::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.23 via Frontend Transport; Fri, 21 May 2021 09:18:10 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 48 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 0ddf57c1-cac6-4424-eecd-08d91c395ab5 X-MS-Exchange-SLBlob-MailProps: gjx25WM8ZNU/M7M4vrgvBd+IenKLBfau5nb8qoyArkTpid85orbTVt7EV7hFOz3hhHyw5pNtKP/+IZqKK72ZChuSnyLTroUhVAbY+OXAdx1sw61Lw3L5uCVhU64E3Rr3P5z62QgrK+Dy9XKZ+YKiO6AN3MsgIO7kjVn6i8wwcMQ/uHlSH0A1pFwl+L/786Pir8gzixNBfu+uNzPpAfeGqDaNXSDj8zL1KIIFwK7dTQTtBvhmaeNfj69cw2pNfLGPJUBVU/J89rjahGT0vEeHcaksem5XGmVzxZxaVs6yb8VaUl3h/dtJUH2FBXnaqXozduV360MPGSdBv4DWRib6HUxtsUXm/KXnpsJH3FclHmG2rO0wdhIvtLKcstBe/i0spdk2S87x5wdIArRO9/z4IUjsqh2mnJlgQK41MiApul/Y4kauUMCxFwNONqPzZS3IfKSo4b+7KPP5LjphkqPJwejBrWmUDQ21RMRovFWCSgvZA0wnfgCrMerqiA07/lfr0VYMYdI+EbKqGgd2HZl1A+xJpSRyayfrZB2i1ewHBzMmKBP9qybTijruuMBgppJ5eDjZTGC4vcKLsWB/ZqcCop+T3b6NwL+47gWFPMrRk5PkZDOpL/0v8MgOC1YClgMWZnJapHh48qq3D3NbjR0NpaWAkoLshbC5MEszw1kO6iVw5rBSFlaMaSMQ80x55rAZoHPbgH2SgghmwrZdbzTQAULXTCRPG7PeHnUZEnoSPIM= X-MS-TrafficTypeDiagnostic: VE1EUR01HT073: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Jdk4ASr3eCo+Pn5aVK8vvf/RW4cDpLcwqKmTaBy3dkZF04jiayTrb1tUY6kBqLk5I3A9gwAMJg4h4Yk6PoAPLBnvsxG9GvLxgqpgT59Tj0zAje6/beF4I/opvfFjyq/2Exb9RxTG9WOg5aNqPT+A7yvSLfl1BVWKynFxI8xERdo+pFA/K3Txc5wI/ZA0J0/iHP6VXXUCEGUF2s92FKuk3T/XNHkcbuzANjinVjvQ5xWAh1S4cBnBgkLNwLnHGyHY+1wB2CIRFHO6EnZ/sIMng40EC0Pvpb/Ob8qroyabkCwIo0sOZxPFHYMRSyXNEIP6e4/UXrRFgR+qtVb8pBIjx2UP3+rj9WSi0+TFwf6Dwz13JNjd9d1SLlRitGgcP6n+H1thBlRhxjMa8RHkR1YYIA== X-MS-Exchange-AntiSpam-MessageData: qoYJXSUi5jWl9Fxm0WAP/3XmSQSljtIMDNw98QVehXteZQC7xkzmD4TOlbo7riL2zCq0G/qt6N1MZsFgPP1KNhfS1PgLn3NDFJmTZxA7wgJjlGERuxUVkSYDQxOGZGzjIXUFzCpCocpqxuzfHGpI+A== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0ddf57c1-cac6-4424-eecd-08d91c395ab5 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2021 09:18:11.2800 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: VE1EUR01FT010.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1EUR01HT073 Subject: [FFmpeg-devel] [PATCH 10/39] avcodec/libvorbisenc: Avoid copying data, allow user-supplied buffers X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: tFK028WW9C3j Here the packet size is known before allocating the packet because the encoder provides said information (and works with internal buffers itself), so one can use this information to avoid the implicit use of another intermediate buffer for the packet data; and by switching to ff_get_encode_buffer() one can also allow user-supplied buffers. Signed-off-by: Andreas Rheinhardt --- libavcodec/libvorbisenc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/libvorbisenc.c b/libavcodec/libvorbisenc.c index d0f4c65aac..ec674695d4 100644 --- a/libavcodec/libvorbisenc.c +++ b/libavcodec/libvorbisenc.c @@ -25,6 +25,7 @@ #include "libavutil/opt.h" #include "avcodec.h" #include "audio_frame_queue.h" +#include "encode.h" #include "internal.h" #include "vorbis.h" #include "vorbis_parser.h" @@ -348,7 +349,7 @@ static int libvorbis_encode_frame(AVCodecContext *avctx, AVPacket *avpkt, av_fifo_generic_read(s->pkt_fifo, &op, sizeof(ogg_packet), NULL); - if ((ret = ff_alloc_packet2(avctx, avpkt, op.bytes, 0)) < 0) + if ((ret = ff_get_encode_buffer(avctx, avpkt, op.bytes, 0)) < 0) return ret; av_fifo_generic_read(s->pkt_fifo, avpkt->data, op.bytes, NULL); @@ -378,11 +379,12 @@ const AVCodec ff_libvorbis_encoder = { .long_name = NULL_IF_CONFIG_SMALL("libvorbis"), .type = AVMEDIA_TYPE_AUDIO, .id = AV_CODEC_ID_VORBIS, + .capabilities = AV_CODEC_CAP_DR1 | AV_CODEC_CAP_DELAY | + AV_CODEC_CAP_SMALL_LAST_FRAME, .priv_data_size = sizeof(LibvorbisEncContext), .init = libvorbis_encode_init, .encode2 = libvorbis_encode_frame, .close = libvorbis_encode_close, - .capabilities = AV_CODEC_CAP_DELAY | AV_CODEC_CAP_SMALL_LAST_FRAME, .sample_fmts = (const enum AVSampleFormat[]) { AV_SAMPLE_FMT_FLTP, AV_SAMPLE_FMT_NONE }, .priv_class = &vorbis_class,