From patchwork Tue May 11 01:52:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 27712 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:b214:0:0:0:0:0 with SMTP id b20csp3534942iof; Mon, 10 May 2021 18:52:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzlkrTzvBFM6X7iO4cPFOp8TK41TLN33jGtFr/AVUfsJsblrPACn7BvtU3wbJtaSvPzItjJ X-Received: by 2002:aa7:d950:: with SMTP id l16mr32780415eds.374.1620697955069; Mon, 10 May 2021 18:52:35 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id h25si15719759eds.368.2021.05.10.18.52.34; Mon, 10 May 2021 18:52:35 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=rW6MdH5y; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BD4A9680C04; Tue, 11 May 2021 04:52:31 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05olkn2028.outbound.protection.outlook.com [40.92.90.28]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 51AB8680BBE for ; Tue, 11 May 2021 04:52:25 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CctByOkaeWYwsm15OIcUMQ5g+6Q2XdEhhw9WX8+VyhwmJBJMh4wSDhPweWbwHk64+zw/2Qr45zxu4LzdYzTuIEAnsr/JEul/fODcSo2gPS5eaMYx8KiTHIG4FDyxegOVFXe0ehfAJBJQJrz2ogbaVwm/c+PlZdNHHJJWfroWRNr15JOq2yYUNR/QdbgU+Oggqr5NrL8TGYecY83aShVkBXkBjUrdBiIzI57NBwq0BFkiiBntY/Mb58Qyc/1gBG5wPPlUFkpXKPRrGzRnqP0/ofVYTqqydhDwuYSRu+RbRYmr2k+aDfoI+/S8jgiE28V5jM61OQRwBp4Zf6foCzeajw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WOnTqcloDaslDA12Iy8rhyGB/2+ehEZ39k+jWGgNlZI=; b=hf4+Cu+YR/XYL5Nz7jSliujFB3U/dtMRsF3sNoJvgfaJOGvJjMk3KUCf0gUtw+20IsvaYia6h0dU9sESAUpLSBTgjbNrn1T3xSD3hs7dk2GK7hGntcSD5nTTloYi8ajtmashPZfqNwdJUbqPRQ2ScQIkxP2gyLI+x9NzZPnuiWKmaoU8HIaPveEhX/KJHGGZAQdATOqarbrjOvB00QtznnOduS3Uu45pXmR1K6ljPnJ+2+I6huijGmBTQZtHZ/ldU+Jsx8e90mOfuXqhY9pQFcQNl9WXejfeCALyFl0wLtFio2/8oe68AQ6UqrCaR779hbHnWaj6Urqm5OZkmz9vVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WOnTqcloDaslDA12Iy8rhyGB/2+ehEZ39k+jWGgNlZI=; b=rW6MdH5ytjubOeUfuXdB9tdOtS1jqnygDIvhVjkFnUsQnmSmBBpac+/svWbkco19xemhUqptvHseRtqaiT7WxaSehXqTYJQg+dD2Oyq8d+50g9HHzpl3CIxelKLj8GfOV0jMDHLMQYDALuDkTBQFeaR+ynUSauu4Y331tkGX4aCTKIxA1hapbPXX0MdB6mtXc6F7KnsRVF8OzFzW9FPzL+lr43WIcV+5opQAca/XRr/Lt5l5FCkY3LDrFHo+VQINZfVLkIdBw50O0nw/UJN/Ye7knp83PcAwPSJ4+G9ebreMoxqv06pcemw4zvUi81lJfbDPrgY1982IIG3p9dy9Vw== Received: from DB8EUR05FT057.eop-eur05.prod.protection.outlook.com (2a01:111:e400:fc0f::53) by DB8EUR05HT257.eop-eur05.prod.protection.outlook.com (2a01:111:e400:fc0f::172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25; Tue, 11 May 2021 01:52:24 +0000 Received: from HE1PR0301MB2154.eurprd03.prod.outlook.com (2a01:111:e400:fc0f::4a) by DB8EUR05FT057.mail.protection.outlook.com (2a01:111:e400:fc0f::403) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Tue, 11 May 2021 01:52:24 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:D4B25264A3DA3119A3D0DE08CD61AF9C6B2E0122FB41DCCDD7358590145C0B26; UpperCasedChecksum:72E38CFB2A28790DBD5A17990526BBB2A427A598205B867B6EFB5DC6D170DEA8; SizeAsReceived:7395; Count:46 Received: from HE1PR0301MB2154.eurprd03.prod.outlook.com ([fe80::45bb:c44f:2b75:23b7]) by HE1PR0301MB2154.eurprd03.prod.outlook.com ([fe80::45bb:c44f:2b75:23b7%5]) with mapi id 15.20.4108.032; Tue, 11 May 2021 01:52:23 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Tue, 11 May 2021 03:52:14 +0200 Message-ID: X-Mailer: git-send-email 2.27.0 X-TMN: [k8t03eCcYA8woUMc2NdFLmLKMZ+clcYCHbqlThp3zmU=] X-ClientProxiedBy: PR0P264CA0173.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1c::17) To HE1PR0301MB2154.eurprd03.prod.outlook.com (2603:10a6:3:2a::22) X-Microsoft-Original-Message-ID: <20210511015214.180299-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sblaptop.fritz.box (188.193.170.150) by PR0P264CA0173.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Tue, 11 May 2021 01:52:22 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 46 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 4aa4da98-a3ff-4951-92b7-08d9141f6b8f X-MS-Exchange-SLBlob-MailProps: q+fD6XS3/UKy2u/d+r3W+uRJNKnW6EYf6wr5rMm/ibj3qjgzD+pqb+ojAXvl9ILV9i50QYMheCwQqRXbiD+pqVXfdiI9a5MawlcIcNTyrTOrondhNnth0oRDvfCRvPcNv1+V2pC0jQfQk6JB0+iPr+OIRFXLFpROtvF5L//hgmdKAgQTu+S+brGbarpPN6YTg+1LzfIKNoidOYRaoBE3l8cK8qHO/b9cEUpu0Mx3nmQnWKwNQQyZ7XS6RuAlHUbUolD8wbmvlXEjfz0ud3PHm0c18/+5z88J8Ddeu6nhDMZqb80BgaH//ZZN/6wHucAdH9p3B/okg1q22wCZRvGdgUdFlxPW1P2KApX/jT7a683N1lqiASBxEyew20MAw9nPjSQVSxvoK9zLfWLLUaO9+3TMtfLLazdRwmSC3/InKnLOyukArTCckRimtKU/JYk4U2uukXPv7ULbnKGqpEg0ckeve6SK5VzI11tGdsQzZMkC3COrEINmSBV61JI618IBG9gefH9Vs4FR9Ppzgd02+RWiUk5whidX3IDOP4kClfG+hloNHIzyjU5k43pw44gFLIUs4e/cczB5kg83T7mwKKhhC5+JxT8BjVX3F4AFXHXfORr1KDfyxL2CvzyjZLsO9pJoLmLQzkoprYrjJ7KAl5StNZBIWrIGs+WnIhAq4bQS+9PUTVyw8mN6wtv2wRMiX5OdO46kiVjmDkG4n7Fkpw== X-MS-TrafficTypeDiagnostic: DB8EUR05HT257: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /3eWh7gu25u/ibrxYJ6Wmxgoxk4MXk11fnxkxov/DB+hi9rVG7nfeNjG3pBJp9VsJ9U3T8NGFkaajfrkFSMBqf342EqFyKPvxDrw6rV7YBNjhMU0aIxKp8FqseRLfNxtFacDgLtygxePuk9g5xztLi9ssLXMs7zMYT5DqaQ8HLsTg8pSV8aowXdZP5eertq6eSb29PVbM0CWBO8292HeXLhUhvV8F96f4n46iU9RC8PKtLeQ65W9eYj2pCK+kqdKMZ86SUpeYrdj3vOL5NkmXOPZg9R/6zCp305/7jhinLvgCZQRNTKLPHD0VeFZlO1tN3G2f3u5THZD71XpPqjIL6iSFk8aAAv/y7jSZEv6xuvXZxf8LTmRae/fv5Crse+7vZkq/6iZaEyi8dpZrnB91g== X-MS-Exchange-AntiSpam-MessageData: jwOgC7gyRgvKYP3q2fMwGYulD/VCm/2015E/A/zdgMgWtD9m5M/+galFqHQIG3rG0vP/ZVxvbeU+4ZMl9DpOCNjHXhXtGP9/XmJgyksolOiruNnlxarjan7Ql1Rat1+Cg+bcUrTkU9uFnHTblA2CKg== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4aa4da98-a3ff-4951-92b7-08d9141f6b8f X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2021 01:52:23.3607 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: DB8EUR05FT057.eop-eur05.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8EUR05HT257 Subject: [FFmpeg-devel] [PATCH] avcodec/libxavs: Always use in-band headers X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: vZlz2bkYgQj/ The code to create global headers is broken and deactivated, so one must not deactivate in-band headers even if the AV_CODEC_FLAG_GLOBAL_HEADER is set; doing otherwise creates unplayable files when this flag is set. Signed-off-by: Andreas Rheinhardt --- libavcodec/libxavs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libxavs.c b/libavcodec/libxavs.c index 253f4bde6a..01ee8b4187 100644 --- a/libavcodec/libxavs.c +++ b/libavcodec/libxavs.c @@ -335,7 +335,7 @@ static av_cold int XAVS_init(AVCodecContext *avctx) x4->params.i_threads = avctx->thread_count; x4->params.b_interlaced = avctx->flags & AV_CODEC_FLAG_INTERLACED_DCT; - if (avctx->flags & AV_CODEC_FLAG_GLOBAL_HEADER) + if (avctx->flags & AV_CODEC_FLAG_GLOBAL_HEADER && 0) x4->params.b_repeat_headers = 0; x4->enc = xavs_encoder_open(&x4->params);