From patchwork Sun Apr 25 22:34:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 27379 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:5014:0:0:0:0:0 with SMTP id e20csp3459815iob; Sun, 25 Apr 2021 15:39:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwdH6vvXNjmcW3j8Q+2zIgJDjbKDNeF3mK2nPNLhZRGpDOSyJEfbjjkiPJ25tcCzLQ68y0q X-Received: by 2002:a17:906:28cd:: with SMTP id p13mr1888031ejd.336.1619390380209; Sun, 25 Apr 2021 15:39:40 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id l6si11428935edr.9.2021.04.25.15.39.39; Sun, 25 Apr 2021 15:39:40 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=GQJe8PO8; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 76A56689E94; Mon, 26 Apr 2021 01:36:21 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-oln040092064108.outbound.protection.outlook.com [40.92.64.108]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 387EE689E94 for ; Mon, 26 Apr 2021 01:36:19 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k6/8xGUfAn9UNn9IriHddTTTy0eMuP/4HVk/qMyVXySScfXbzT4tazFYUjumTh0stS7e8SSWVMX7dZ4OEuY/7/dbTq6mo64FfsINp/HuiHlVVyPkdeZMoQDy/cBRZ9LWNw4Nya4B57+rWOPx07x2brLk7wxxDJ66tJI3x1o1mLkQUwuWEx/2ZVJmHYN6oVY/Wy6o1AoRY9e3nCw5AMIjbERzEHZQu/Q0VIqteG/Ou6AtTqsosRbxt1i1Cu/SMSWaFdvl3UDgS2nTiKOjjZ4o+5G3fa8aWNwOr4qJuT62kI7K/YR7nQImag2F78WzDlYXycvk580OeQvJpjNIfwbMQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q9Wi053B+ZktUjrb2y15+LzeXXKgSdNDJa0nfroWNKs=; b=Xq0HuLmBMsjS8VW4FZzmLtak8ttsE8/jkZiT2Fody9uUdT0ld8NZWpqGF3nLvopdfYOy91cqbzYRULvSmToBAJvSZKxwpeaIr8hrotWXFBab1FEZgWzmAwC75BkrF2PgOrJeYIlsX8e9k3Df40RIf++wAOUbUsfjf80NQWkIm11BYMH5AGAsrZsQHlDpmVwoiWANqiwGAxNjGUxKXMLUK3uWyDbetIKwFXyLzwATVvqEA5iM7mAb5xwPErcvo1+vApX/LeowAyNYCsHbjhM7xGF6TV3l5B4x7yuyyqkU/tZ14Qp0HXRVFax3s6ADXml+ouaU9Zw2eyYY5LXAgacRPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q9Wi053B+ZktUjrb2y15+LzeXXKgSdNDJa0nfroWNKs=; b=GQJe8PO8u9PdyJIv91wTknE3BS2qnb4GQ8S4+yzz4w5yqfbDSTY0MEHgvZvWgqvDmxwiYPKWT/O0Lcuda0Z51WsArDXOI0aH0oLATfsDyRpzJjac9dp6aNccVXS2SSKaomZNTPTe7JEGnXHru0SRwSX8EmqMtedJkp1Q9T1p68B/jrci1Xz9VPCQbFy4AfVM5IJgYpzNEaJQ5Y2MIMJmdEwwxLeJrcDlmiqDKEJCJFW5Gz2MCbPvR5gmrXi0jZqN9bYBKlsR4PLHE2wPbyC2F+tPe34JwgcMMYtXKborcNhWehMRmUW+xWaJnVaow5aLZGBjt27qs2dhD9fdUSTJig== Received: from HE1EUR01FT054.eop-EUR01.prod.protection.outlook.com (2a01:111:e400:7e18::46) by HE1EUR01HT232.eop-EUR01.prod.protection.outlook.com (2a01:111:e400:7e18::100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.21; Sun, 25 Apr 2021 22:36:18 +0000 Received: from HE1PR0301MB2154.eurprd03.prod.outlook.com (2a01:111:e400:7e18::4b) by HE1EUR01FT054.mail.protection.outlook.com (2a01:111:e400:7e18::317) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.21 via Frontend Transport; Sun, 25 Apr 2021 22:36:18 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:9E9791347362C262A484C3B742224816B5C91C786BA93A029BA4AE4B1A88FF48; UpperCasedChecksum:20309A091C9C1660F9C9C6691019323A0F1F65E3F15CAE4580BE89A759F67D8D; SizeAsReceived:7575; Count:48 Received: from HE1PR0301MB2154.eurprd03.prod.outlook.com ([fe80::45bb:c44f:2b75:23b7]) by HE1PR0301MB2154.eurprd03.prod.outlook.com ([fe80::45bb:c44f:2b75:23b7%5]) with mapi id 15.20.4065.026; Sun, 25 Apr 2021 22:36:18 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Mon, 26 Apr 2021 00:34:45 +0200 Message-ID: X-Mailer: git-send-email 2.27.0 In-Reply-To: References: X-TMN: [axqCJh7kNuCNDFmsYxSf6ilGG2gq7/PL] X-ClientProxiedBy: ZR0P278CA0100.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:23::15) To HE1PR0301MB2154.eurprd03.prod.outlook.com (2603:10a6:3:2a::22) X-Microsoft-Original-Message-ID: <20210425223448.130684-30-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sblaptop.fritz.box (188.193.248.86) by ZR0P278CA0100.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:23::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.22 via Frontend Transport; Sun, 25 Apr 2021 22:36:17 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 48 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 4a68dcf2-4dc8-40b3-a359-08d9083a8b06 X-MS-Exchange-SLBlob-MailProps: q+fD6XS3/UKBTepCewFwVSkfoADfkQpyLSgPZ3++pmPQkBV3P2RHOyBG8UBAuw4RcKPmsSnO+sprUsTx44cw5jCLqFlh8JHBBJXAONGjyz1Dt0vsECcp3QFW4yPAeCmSzqmLb39pzdtJulcQqZQRgtwM8YMfJ3jB3Fcuotx3FSySJ9HeoNu92nnNNS+nnbLlarwaeuVilzGqP+/ow8icru3K3aIg4fOWOPIU/53G1BebtXKZhXeDqQnmAzVENgU623Xsgk8Kf/92/4eG2jOPD4b9Ybjq1GdouR93R/I8aldUOtY+UGWeAqxLSHrnjl8ZY3epNcwR6pptUXZ21OSykaj4+Om7KVjAH69R/bZArEkIFPzsiybqpF59wxcWhPB/sp6ZFO4C1HxggKORARhk1XLGU3TsRik/DkSE8lGCIEi6h866HAVbqsoQWEGXTeLm3EljK0+XS6IpxbvsVpPID5POmCcro+bN3Xsl38JyAzyU9nrlwWGX1ZHPiq+RdiMEyoKb7iwvli01husiNDmMxUXhKa2TtATN6JGj29/zkgGtwoYAbNhw5ifV+6FkQNGSAu2QFizMGQsuzkth2jY0LJ9mrRXFSqtXg85jIRWxRZhFjwrvmqlSfvBSoZnVoRC4wTgNfQeoubYMaNJYZg47M9jxD9ll34vE94IwDR2ryE3vnLgmAKlCwqyxo6H9aKjRnyYBckx+IC7MuZP5dHvfqA== X-MS-TrafficTypeDiagnostic: HE1EUR01HT232: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zjNSpmPvsrQX4ohqzWFYlCUVa4SdqKNSMTnD6y3cENtZg44joDsHvnMnBl/wm+c2B/afIRxLs5Hvz6q8aDBXJxfI2qxj9Ib9vS6OYZ5p8F2BCc76HcpHaiw90CXjwdrvEuw2JQWEepfnPxG6wt6Gsw78oA1PBnujORllIuc64Z6usUrDyvHTIbUg8B4O5sm4L66QOvInH01X09ytS+TkcS6EbmU0Opjw4KFf1Ads27DMP6CqkxOBATvTUp2OhIOW9WjF/Lzt1vNpEQEF9hAnS5Gv/9h9jtC5Fo3xp7HCO/fm9Iv9vZXPH2AtQusLlZSmQV0ZUqJJ4fhGHJD8vRr0rRr8YEmm6t9SGxl+PJEhjQ+1HJclsby7XCFGqZhWhsZ2UY8cFgJb5zlMv3kftv7Tmg== X-MS-Exchange-AntiSpam-MessageData: jQgel5HtP/7VLPMjsW/ZWkNngkB5BI1TuZK9gLEeznVKznAXGILpl3SFpcnWZaBIDoTOsZMOPolATkqAjEHCzZVHWpybponWi2i/xWwmjsqBAlxJTBYePJezsJWPDuZvxNVBsrkgS13wjqY6AzZtoQ== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a68dcf2-4dc8-40b3-a359-08d9083a8b06 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2021 22:36:18.5308 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: HE1EUR01FT054.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1EUR01HT232 Subject: [FFmpeg-devel] [PATCH 31/34] avcodec/libgsmenc: Avoid copying packet data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 67+uFfx1DNNp When the packet size is known in advance like here, one can avoid an intermediate buffer for the packet data. Signed-off-by: Andreas Rheinhardt --- These encoders have the most unorthodox way of using their private data that I have ever seen. Will fix it later. libavcodec/libgsmenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/libgsmenc.c b/libavcodec/libgsmenc.c index fdb11c705e..eeaa5b2a10 100644 --- a/libavcodec/libgsmenc.c +++ b/libavcodec/libgsmenc.c @@ -98,7 +98,8 @@ static int libgsm_encode_frame(AVCodecContext *avctx, AVPacket *avpkt, gsm_signal *samples = (gsm_signal *)frame->data[0]; struct gsm_state *state = avctx->priv_data; - if ((ret = ff_alloc_packet2(avctx, avpkt, avctx->block_align, 0)) < 0) + if ((ret = ff_alloc_packet2(avctx, avpkt, avctx->block_align, + avctx->block_align)) < 0) return ret; switch(avctx->codec_id) {