From patchwork Sun Apr 25 22:34:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 27407 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:5014:0:0:0:0:0 with SMTP id e20csp3459670iob; Sun, 25 Apr 2021 15:39:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwxcQBSa9QZ1aqrRcJNTE5+VEOIosxCs71i4XsFLdC0DSuTZt6VP1na0tIzXXjAp9yWyPf6 X-Received: by 2002:a05:6402:cbb:: with SMTP id cn27mr18075027edb.222.1619390361407; Sun, 25 Apr 2021 15:39:21 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id dc16si11334908edb.147.2021.04.25.15.39.21; Sun, 25 Apr 2021 15:39:21 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=hfubpfmI; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 86DA4689EE7; Mon, 26 Apr 2021 01:36:17 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-oln040092064050.outbound.protection.outlook.com [40.92.64.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2435A689E94 for ; Mon, 26 Apr 2021 01:36:15 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h2dno2dthMdrSahFjVD231AQ0/z/DC4O2q8F3024h/3D9PJjCp4ezgpGhUR9DAhr5s//A2goU1/GdKQyvwID7Dr5W6aG38E+QWxBrP/7vilvRkWaSYWVjYR1PMIjAQykCTfL8p+OHDBO36bCKGnbUROLskFgXmz4MspzmTUN233vTHcXLT6jlmHuh0bOsPOYnlFXNDz9Sxv5BGvFBtN9+ZTJ8+AF+TsZoLG2MrD1TYhoFiAa3eXCYGrOC5aQ9eOrS+sYb8++CjXRQuYF+Sq93OX6zrLnS/RVEML8yFITHUaAzlFs2v4l0LDb+vH3L7aJs1DR9+bNHU8ASRiWxwL0Og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u8sEe61SFU81im+z/1OE2R19qw1hCVMPtTzQLqORaAc=; b=YlLokSKhFuzaOuVEbMFdAFukxioHsPbDG8Txmfp3Bz/ciYF36QNhWp9N4/DVqq6nIcK4r+tYQ+m/w2Qe5V8oEIsTelmO5y3ctoHsTvgE+Vh2LfybxMD44lDu+FoVO72E+W+1no9WDq1UfpQrl/QFdDpvMSvGqcMOhHZ2Zt673AmGrWoGDPXjCYWO1lpCDhPgVIvtGes3w1wFCIQyUM4WfOt+PDGewc2uam46KgaKcXFMNrP1MKHlxTTymRZDxhIh9OdIAtCSvCMK7pcHm+rOEjkFzm/R58EA4f8Rg7iw0u4r7NZLlthN9tKoUEji0E66ziSL8Zx5Ch4jHgI9DVzmGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u8sEe61SFU81im+z/1OE2R19qw1hCVMPtTzQLqORaAc=; b=hfubpfmIGNxWF9M4ANgJUGWO+Hbm0BklpOdbeA8+ApIDjcK7MpdBRfHWY2KFl+kizI6PZ7H0gOaOmeoz1VqhVbFnEBUSiZJVPF2f0+/Tc/RZaIhXGA7XEUYutSvOthoulZIZemv645p7OoszgwZ0ZiAnO4RY9o+aChjenb5wnESqS637gdmQvzYwxS+EgSXd3qJhf2Yvn0kXjPjoRYdTuERK0VWAiMa/IfSiO7ZXhsWFfJXYMvasuIPtWUPS3ltX0GPXTs+SQcuYnRY3kBdJc1q8GuW2cOJ2Z6BmDzmvOFeFi1kn6Qu20dTyEZPKfaunjsgaVfn0bggc2qisA7R9Xw== Received: from HE1EUR01FT054.eop-EUR01.prod.protection.outlook.com (2a01:111:e400:7e18::41) by HE1EUR01HT237.eop-EUR01.prod.protection.outlook.com (2a01:111:e400:7e18::397) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.21; Sun, 25 Apr 2021 22:36:14 +0000 Received: from HE1PR0301MB2154.eurprd03.prod.outlook.com (2a01:111:e400:7e18::4b) by HE1EUR01FT054.mail.protection.outlook.com (2a01:111:e400:7e18::317) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.21 via Frontend Transport; Sun, 25 Apr 2021 22:36:14 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:29586F8AAEC4D1A7636FA101CE7AB1DBAFC0878916DDF57F1C3B4237E1A23BE2; UpperCasedChecksum:122F38BDC52EB4AD81327A75FF50BAD76274AC92B8215E6DF7985E8AFF96AAA1; SizeAsReceived:7587; Count:48 Received: from HE1PR0301MB2154.eurprd03.prod.outlook.com ([fe80::45bb:c44f:2b75:23b7]) by HE1PR0301MB2154.eurprd03.prod.outlook.com ([fe80::45bb:c44f:2b75:23b7%5]) with mapi id 15.20.4065.026; Sun, 25 Apr 2021 22:36:14 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Mon, 26 Apr 2021 00:34:43 +0200 Message-ID: X-Mailer: git-send-email 2.27.0 In-Reply-To: References: X-TMN: [Mod449bxMaACeGyyRCR9N4+1cnpi65VY] X-ClientProxiedBy: ZR0P278CA0100.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:23::15) To HE1PR0301MB2154.eurprd03.prod.outlook.com (2603:10a6:3:2a::22) X-Microsoft-Original-Message-ID: <20210425223448.130684-28-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sblaptop.fritz.box (188.193.248.86) by ZR0P278CA0100.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:23::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.22 via Frontend Transport; Sun, 25 Apr 2021 22:36:13 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 48 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 785e7518-9aca-4462-7609-08d9083a887a X-MS-Exchange-SLBlob-MailProps: q+fD6XS3/UKBTepCewFwVSkfoADfkQpyLSgPZ3++pmNRScJOCDEqrV4ygaz0VPNEOIVX5u4ZFzuIzJFs0JJ6Ur1jpj73AXLMD9qC+N6Gf+elzW6redbFH8K/HtqT+AlAn8BNu+noQFEiewpND3AEKeCVBSLj6IOaulgE2sEAml3ZHq7Ax/5GaqF/iKyMnJoYml4jUHAdiTEKXyjoEYxqoQR1m45BGuNYuygguoXpj1BioldrZwlf4SuRvnm4E/GD8YXucENR7jOSHyqWa0+FehHElttGa1VfLrQVLrjp6NBWWvJcuC+GXHmXaOt2U0iNpmQvRnxLSKvBLLnLnd6EPQMYsvMOT1g38YBCyyyw1B3TxF0AYD5RT9Lt4WqHLbGEgCB4DPX6LrIVPlbUeh0MxSDxAugMZ9C9h+GMOVVk5TmJa4w5mb52L/+g+Wj6tHcQE/1Y1iB2/uG9ScdF3EcXdWprg2AMEtia/vW+cdjLeXP3oU6sPRb9RU35J7RqQS3fTXft3cPjXiE5Nr4LD4m5ZVpQpLcWrTkRUpci097ZWVuE9/uYGHbIxMT2H0M99gxpYEreE3AOVsEIu46Ai+qpLLMtS85fZhrnBXkPrfQ5nDLMZbNCrMf4hQrRfSvMzBGCRUAHo7g55IDQuMgtMz5n1eHlsK91mYD+tSsG+9bCTXGU9cPA/IPK4r6FG+H+QpMpAQo6Fj3EBP558r4Ty2Ivwg== X-MS-TrafficTypeDiagnostic: HE1EUR01HT237: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /LTsT97HaCMHqMdfaGoSsUc+RGYbmlDKlzsMwYtWequKkXQg3Fp4W5EB1dlkEa2nPhkBwPqVYo1L8M+Z28Jzs1e+Qh+9dJuC1Bz7XLZ4eHILy3jzWExzbSrrJzB5/FCDI234OjUDDyvl7Zqw/c8g4qWRfoAQYQNMSkmz5sNMo3w4kVjDDkMy5FfDeNtfIwnKYdOVJiMLIrcaJkAtt42cZvGuT6Np7A8l0Vhu8B93gd8mSCCl3nGlrOOsxwc/u14v74ULk2nr/Lv0rsmqEKgeUgInbhdSyy0aUg/ma8MQDwSVP1P4/Ozj7QfR7gsy6z9j9TG+dLpFum+xkid1zMB+6MdBSukHQJEtd55qUmKEjRyPOszHRxGmeaYKGCg2O9HUB4V1SDHJFNDHJ+u3zltGAw== X-MS-Exchange-AntiSpam-MessageData: 097GLwtmYkwHTuH7ARF0j8KxByym6mQuqHgNdf2bhnCPGmT955XcdJsM1q+NJbd3t8W9l9RmN//cW8IbTGwrbgvqAjpASumGA202VRW+rQPbjMaQ+k+V21f9v7HZLLSuv3UdwhMyU15Sm2Crwdpwuw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 785e7518-9aca-4462-7609-08d9083a887a X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2021 22:36:14.2637 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: HE1EUR01FT054.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1EUR01HT237 Subject: [FFmpeg-devel] [PATCH 29/34] avcodec/libvorbisenc: Avoid copying packet data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: mcqb0fWLmJvq Here the packet size is known before allocating the packet because the encoder provides said information (and works with internal buffers itself), so one can pass this information to ff_alloc_packet2() to avoid the implicit use of another intermediate buffer for the packet data. Signed-off-by: Andreas Rheinhardt --- libavcodec/libvorbisenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libvorbisenc.c b/libavcodec/libvorbisenc.c index bf94764954..16b32631c2 100644 --- a/libavcodec/libvorbisenc.c +++ b/libavcodec/libvorbisenc.c @@ -349,7 +349,7 @@ static int libvorbis_encode_frame(AVCodecContext *avctx, AVPacket *avpkt, av_fifo_generic_read(s->pkt_fifo, &op, sizeof(ogg_packet), NULL); - if ((ret = ff_alloc_packet2(avctx, avpkt, op.bytes, 0)) < 0) + if ((ret = ff_alloc_packet2(avctx, avpkt, op.bytes, op.bytes)) < 0) return ret; av_fifo_generic_read(s->pkt_fifo, avpkt->data, op.bytes, NULL);